Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-10 Thread Hans Verkuil
On 03/10/2014 01:12 PM, Archit Taneja wrote: Hi Hans, On Friday 07 March 2014 07:17 PM, Archit Taneja wrote: On Friday 07 March 2014 07:02 PM, Hans Verkuil wrote: On 03/07/2014 02:22 PM, Archit Taneja wrote: Disregard what I said, it's OK to upstream it. But if you could just spend

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-07 Thread Archit Taneja
Hi Hans, On Tuesday 04 March 2014 05:05 PM, Hans Verkuil wrote: On 03/04/14 12:25, Archit Taneja wrote: I had a minor question about the selection API: Are the V4L2_SET_TGT_CROP/COMPOSE_DEFAULT and the corresponding 'BOUNDS' targets supposed to be used with VIDIOC_S_SELECTION? If so, what's

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-07 Thread Hans Verkuil
On 03/07/2014 12:50 PM, Archit Taneja wrote: Hi Hans, On Tuesday 04 March 2014 05:05 PM, Hans Verkuil wrote: On 03/04/14 12:25, Archit Taneja wrote: I had a minor question about the selection API: Are the V4L2_SET_TGT_CROP/COMPOSE_DEFAULT and the corresponding 'BOUNDS' targets supposed to

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-07 Thread Archit Taneja
Hi, On Friday 07 March 2014 06:29 PM, Hans Verkuil wrote: Do you think I can go ahead with posting the v3 patch set for 3.15, and work on fixing the compliance issue for the -rc fixes? It's fine to upstream this in staging, but while not all compliance errors are fixed it can't go to

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-07 Thread Hans Verkuil
On 03/07/2014 02:22 PM, Archit Taneja wrote: Hi, On Friday 07 March 2014 06:29 PM, Hans Verkuil wrote: Do you think I can go ahead with posting the v3 patch set for 3.15, and work on fixing the compliance issue for the -rc fixes? It's fine to upstream this in staging, but while not all

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-07 Thread Archit Taneja
On Friday 07 March 2014 07:02 PM, Hans Verkuil wrote: On 03/07/2014 02:22 PM, Archit Taneja wrote: Hi, On Friday 07 March 2014 06:29 PM, Hans Verkuil wrote: Do you think I can go ahead with posting the v3 patch set for 3.15, and work on fixing the compliance issue for the -rc fixes? It's

[PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-04 Thread Archit Taneja
Add selection ioctl ops. For VPE, cropping makes sense only for the input to VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense only for the output of VPE(or V4L2_BUF_TYPE_VIDEO_CAPTURE/MPLANE buffers). For the CAPTURE type, V4L2_SEL_TGT_COMPOSE results in VPE writing the

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-04 Thread Hans Verkuil
Hi Archit, On 03/04/14 09:49, Archit Taneja wrote: Add selection ioctl ops. For VPE, cropping makes sense only for the input to VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense only for the output of VPE(or V4L2_BUF_TYPE_VIDEO_CAPTURE/MPLANE buffers). For the

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-04 Thread Archit Taneja
Hi, On Tuesday 04 March 2014 03:10 PM, Hans Verkuil wrote: Hi Archit, On 03/04/14 09:49, Archit Taneja wrote: Add selection ioctl ops. For VPE, cropping makes sense only for the input to VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense only for the output of VPE(or

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-04 Thread Hans Verkuil
On 03/04/14 12:25, Archit Taneja wrote: I had a minor question about the selection API: Are the V4L2_SET_TGT_CROP/COMPOSE_DEFAULT and the corresponding 'BOUNDS' targets supposed to be used with VIDIOC_S_SELECTION? If so, what's the expect behaviour? No, those are read only in practice. So

RE: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-04 Thread Kamil Debski
Hi Archit, From: Archit Taneja [mailto:arc...@ti.com] Sent: Tuesday, March 04, 2014 12:25 PM Hi, On Tuesday 04 March 2014 03:10 PM, Hans Verkuil wrote: Hi Archit, On 03/04/14 09:49, Archit Taneja wrote: Add selection ioctl ops. For VPE, cropping makes sense only for the input to