Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-15 Thread Steve Longerbeam
On 8/14/19 12:16 AM, Sakari Ailus wrote: Hi Steve, On Tue, Aug 13, 2019 at 04:27:06PM -0700, Steve Longerbeam wrote: Hi Sakari, On 8/13/19 1:28 AM, Sakari Ailus wrote: Hi Steve, On Thu, Aug 08, 2019 at 11:02:29AM -0700, Steve Longerbeam wrote: On 8/8/19 1:53 AM, Philipp Zabel wrote: Hi

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-14 Thread Sakari Ailus
Hi Steve, On Tue, Aug 13, 2019 at 04:27:06PM -0700, Steve Longerbeam wrote: > Hi Sakari, > > On 8/13/19 1:28 AM, Sakari Ailus wrote: > > Hi Steve, > > > > On Thu, Aug 08, 2019 at 11:02:29AM -0700, Steve Longerbeam wrote: > > > > > > On 8/8/19 1:53 AM, Philipp Zabel wrote: > > > > Hi Sakari, > >

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-13 Thread Steve Longerbeam
Hi Sakari, On 8/13/19 1:28 AM, Sakari Ailus wrote: Hi Steve, On Thu, Aug 08, 2019 at 11:02:29AM -0700, Steve Longerbeam wrote: On 8/8/19 1:53 AM, Philipp Zabel wrote: Hi Sakari, On Thu, 2019-08-08 at 11:26 +0300, Sakari Ailus wrote: [...] Have you checked how it works if you simply leave o

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-13 Thread Sakari Ailus
Hi Steve, On Thu, Aug 08, 2019 at 11:02:29AM -0700, Steve Longerbeam wrote: > > > On 8/8/19 1:53 AM, Philipp Zabel wrote: > > Hi Sakari, > > > > On Thu, 2019-08-08 at 11:26 +0300, Sakari Ailus wrote: > > [...] > > > > > Have you checked how it works if you simply leave out this test? > > Whethe

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-10 Thread Steve Longerbeam
On 8/8/19 11:02 AM, Steve Longerbeam wrote: On 8/8/19 1:53 AM, Philipp Zabel wrote: Hi Sakari, On Thu, 2019-08-08 at 11:26 +0300, Sakari Ailus wrote: [...] Have you checked how it works if you simply leave out this test? Whether this works or not depends on the sensor used, and for some

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-08 Thread Steve Longerbeam
On 8/8/19 1:53 AM, Philipp Zabel wrote: Hi Sakari, On Thu, 2019-08-08 at 11:26 +0300, Sakari Ailus wrote: [...] Have you checked how it works if you simply leave out this test? Whether this works or not depends on the sensor used, and for some sensor/drivers may depend on timing (or random

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-08 Thread Sakari Ailus
Hi Philipp, On Thu, Aug 08, 2019 at 10:53:25AM +0200, Philipp Zabel wrote: > Hi Sakari, > > On Thu, 2019-08-08 at 11:26 +0300, Sakari Ailus wrote: > [...] > > > > Have you checked how it works if you simply leave out this test? > > Whether this works or not depends on the sensor used, and for so

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-08 Thread Philipp Zabel
Hi Sakari, On Thu, 2019-08-08 at 11:26 +0300, Sakari Ailus wrote: [...] > > > Have you checked how it works if you simply leave out this test? Whether this works or not depends on the sensor used, and for some sensor/drivers may depend on timing (or random factors influencing it). See below. [..

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-08 Thread Sakari Ailus
Hi Ezequiel, On Wed, Aug 07, 2019 at 10:59:22AM -0300, Ezequiel Garcia wrote: > Hi Sakari, > > Thanks for reviewing the patch. > > On Wed, 2019-08-07 at 15:06 +0300, Sakari Ailus wrote: > > On Tue, Jul 30, 2019 at 05:14:24AM -0300, Ezequiel Garcia wrote: > > > Hey Hans, > > > > > > On Mon, 2019

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-07 Thread Ezequiel Garcia
Hi Sakari, Thanks for reviewing the patch. On Wed, 2019-08-07 at 15:06 +0300, Sakari Ailus wrote: > On Tue, Jul 30, 2019 at 05:14:24AM -0300, Ezequiel Garcia wrote: > > Hey Hans, > > > > On Mon, 2019-07-01 at 08:48 +0200, Philipp Zabel wrote: > > > On Thu, 2019-06-27 at 19:29 -0300, Fabio Esteva

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-07 Thread Sakari Ailus
On Tue, Jul 30, 2019 at 05:14:24AM -0300, Ezequiel Garcia wrote: > Hey Hans, > > On Mon, 2019-07-01 at 08:48 +0200, Philipp Zabel wrote: > > On Thu, 2019-06-27 at 19:29 -0300, Fabio Estevam wrote: > > > From: Ezequiel Garcia > > > > > > Not all sensors will be able to guarantee a proper initial

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-07-30 Thread Ezequiel Garcia
Hey Hans, On Mon, 2019-07-01 at 08:48 +0200, Philipp Zabel wrote: > On Thu, 2019-06-27 at 19:29 -0300, Fabio Estevam wrote: > > From: Ezequiel Garcia > > > > Not all sensors will be able to guarantee a proper initial state. > > This may be either because the driver is not properly written, > > o

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-06-30 Thread Philipp Zabel
On Thu, 2019-06-27 at 19:29 -0300, Fabio Estevam wrote: > From: Ezequiel Garcia > > Not all sensors will be able to guarantee a proper initial state. > This may be either because the driver is not properly written, > or (probably unlikely) because the hardware won't support it. > > While the rig

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-06-27 Thread Steve Longerbeam
Thanks Fabio, Reviewed-by: Steve Longerbeam On 6/27/19 3:29 PM, Fabio Estevam wrote: From: Ezequiel Garcia Not all sensors will be able to guarantee a proper initial state. This may be either because the driver is not properly written, or (probably unlikely) because the hardware won't suppor

[PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-06-27 Thread Fabio Estevam
From: Ezequiel Garcia Not all sensors will be able to guarantee a proper initial state. This may be either because the driver is not properly written, or (probably unlikely) because the hardware won't support it. While the right solution in the former case is to fix the sensor driver, the real w