Re: [RFC PATCH V3 1/3] dt-bindings: mt8183: Added FD dt-bindings

2019-09-17 Thread Rob Herring
On Fri, 6 Sep 2019 18:11:23 +0800, Jerry-ch Chen wrote:
> From: Jerry-ch Chen 
> 
> This patch adds DT binding documentation for the Face Detection (FD)
> unit of the Mediatek's mt8183 SoC.
> 
> Signed-off-by: Jerry-ch Chen 
> ---
>  .../bindings/media/mediatek,mt8183-fd.txt | 34 +++
>  1 file changed, 34 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt
> 

Reviewed-by: Rob Herring 


[RFC PATCH V3 1/3] dt-bindings: mt8183: Added FD dt-bindings

2019-09-06 Thread Jerry-ch Chen
From: Jerry-ch Chen 

This patch adds DT binding documentation for the Face Detection (FD)
unit of the Mediatek's mt8183 SoC.

Signed-off-by: Jerry-ch Chen 
---
 .../bindings/media/mediatek,mt8183-fd.txt | 34 +++
 1 file changed, 34 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt

diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt 
b/Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt
new file mode 100644
index ..46464175b95a
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt
@@ -0,0 +1,34 @@
+* Mediatek Face Detection Unit (FD)
+
+Face Detection (FD) unit is a typical memory-to-memory HW device.
+It provides hardware accelerated face detection function, and it
+is able to detect different poses of faces. FD will writre result
+of detected face into memory as output.
+
+Required properties:
+- compatible: "mediatek,mt8183-fd"
+- mediatek,scp : the node of system control processor (SCP), see
+  Documentation/devicetree/bindings/remoteproc/mtk,scp.txt for details.
+- iommus: should point to the 3 entries:  M4U_PORT_CAM_FDVT_RP,
+  M4U_PORT_CAM_FDVT_WR and M4U_PORT_CAM_FDVT_RB.  (Please see
+  Documentation/devicetree/bindings/iommu/mediatek,iommu.txt for details.)
+- reg: Physical base address and length of the register space.
+- interrupts: interrupt number to the cpu.
+- clocks : must contain the FDVT clock, see
+  Documentation/devicetree/bindings/clock/clock-bindings.txt for details.
+- clock-names: must be "fd".
+- power-domain: must be "MT8183_POWER_DOMAIN_ISP".
+
+Example:
+   fd: fd@1502b000 {
+   compatible = "mediatek,mt8183-fd";
+   mediatek,scp = <&scp>;
+   iommus = <&iommu M4U_PORT_CAM_FDVT_RP>,
+<&iommu M4U_PORT_CAM_FDVT_WR>,
+<&iommu M4U_PORT_CAM_FDVT_RB>;
+   reg = <0 0x1502b000 0 0x1000>;
+   interrupts = ;
+   clocks = <&imgsys CLK_IMG_FDVT>;
+   clock-names = "fd";
+   power-domains = <&scpsys MT8183_POWER_DOMAIN_ISP>;
+   };
-- 
2.18.0