RE: [RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver

;alanx.chi...@intel.com> Subject: Re: [RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver HI Andy, thanks for addressing my comments on v6. Some more questions below. On Tue, Apr 10, 2018 at 11:48:44PM +0800, Andy Yeh wrote: > From: Alan Chiang <alanx.chi...@intel.com> >

Re: [RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver

On Mon, Apr 16, 2018 at 04:30:46AM +, Tomasz Figa wrote: > On Thu, Apr 12, 2018 at 6:57 PM Sakari Ailus > wrote: > > > Hi Jacopo, > > > On Thu, Apr 12, 2018 at 10:57:01AM +0200, jacopo mondi wrote: > > ... > > > > + if (MAX_RETRY == ++retry) { > > > >

Re: [RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver

On Thu, Apr 12, 2018 at 6:57 PM Sakari Ailus wrote: > Hi Jacopo, > On Thu, Apr 12, 2018 at 10:57:01AM +0200, jacopo mondi wrote: > ... > > > + if (MAX_RETRY == ++retry) { > > > + dev_err(>dev, > > > + "Cannot do

Re: [RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver

Hi Jacopo, On Thu, Apr 12, 2018 at 10:57:01AM +0200, jacopo mondi wrote: ... > > + if (MAX_RETRY == ++retry) { > > + dev_err(>dev, > > + "Cannot do the write operation because VCM is > > busy\n"); > > Nit: this is over 80 cols, it's fine,

Re: [RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver

HI Andy, thanks for addressing my comments on v6. Some more questions below. On Tue, Apr 10, 2018 at 11:48:44PM +0800, Andy Yeh wrote: > From: Alan Chiang > > DW9807 is a 10 bit DAC from Dongwoon, designed for linear > control of voice coil motor. > > This driver

Re: [RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver

On Wed, Apr 11, 2018 at 1:38 PM Tomasz Figa wrote: [snip] > > +static int dw9807_set_dac(struct i2c_client *client, u16 data) > > +{ > > + const char tx_data[3] = { > > + DW9807_MSB_ADDR, ((data >> 8) & 0x03), (data & 0xff) > > + }; > > + int

Re: [RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver

Hi Andy, Alan, On Wed, Apr 11, 2018 at 12:41 AM Andy Yeh wrote: > From: Alan Chiang > DW9807 is a 10 bit DAC from Dongwoon, designed for linear > control of voice coil motor. > This driver creates a V4L2 subdevice and > provides control to set the