Re: [2.6.33.4 PATCH] V4L/uvcvideo: Add support for Suyin Corp. Lenovo Webcam

2010-06-26 Thread Nils Radtke
  Hi Laurent,

On ven 2010-06-25 @ 09-29-28 +0200, Laurent Pinchart wrote: 
# Hi Nils,
# 
# On Thursday 24 June 2010 20:19:41 Nils Radtke wrote:
#  On Wed 2010-06-23 @ 02-45-53PM +0200, Laurent Pinchart wrote:
#  # On Wednesday 23 June 2010 11:23:16 Nils Radtke wrote:
#  #  From: Nils Radtke l...@think-future.de
#  # 
#  #  This patch adds support for the Suyin Corp. Lenovo Webcam.
#  #  lsusb: ID 064e:a102 Suyin Corp. Lenovo Webcam
#  # 
#  #  It is available as built-in webcam i.e. in ACER timeline 1810t
#  #  notebooks.
#  # 
#  #  The note in uvc_driver.c about Logitech cameras applies the same
#  #  to the Suyin web cam: it doesn't announce itself as UVC devices
#  #  but is compliant.
#  # 
#  #  Signed-off-by: Nils Radtke l...@think-future.de
#  #
#  # Thanks for the patch. Could you please send me the output of lsusb -v for
#  your
#  
#  Bus 002 Device 002: ID 064e:a102 Suyin Corp. Lenovo Webcam
# 
# [snip]
# 
#  Interface Descriptor:
#bLength 9
#bDescriptorType 4
#bInterfaceNumber0
#bAlternateSetting   0
#bNumEndpoints   1
#bInterfaceClass14 Video
#bInterfaceSubClass  1 Video Control
#bInterfaceProtocol  0
#iInterface  5 Webcam
# 
# This looks like a pretty standard UVC device. Are you sure your patch is 
# needed ?
Indeed. Hm, about whether the patch is needed.. What happened here was: the 
module
didn't get loaded w/o the patch. But then maybe something else made the change? 
After subsequent reboot the module did get loaded. Hm..

Isn't the vendor/product ID a point of reference that tells the kernel which 
module
to load when supported hw is found? That was the idea behind adding the ID and
submitting the patch. 

Thanks for clarification.

Cheers, 

  Nils

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [2.6.33.4 PATCH] V4L/uvcvideo: Add support for Suyin Corp. Lenovo Webcam

2010-06-26 Thread Greg KH
On Sat, Jun 26, 2010 at 12:36:15PM +0200, Nils Radtke wrote:
 Isn't the vendor/product ID a point of reference that tells the kernel which 
 module
 to load when supported hw is found? That was the idea behind adding the ID and
 submitting the patch. 

No, it also triggers off of the class information of the device, which
your device says it supports.  If we had to add every single unique
device id for usb keyboards, that would be a mess :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [2.6.33.4 PATCH] V4L/uvcvideo: Add support for Suyin Corp. Lenovo Webcam

2010-06-25 Thread Laurent Pinchart
Hi Nils,

On Thursday 24 June 2010 20:19:41 Nils Radtke wrote:
 On Wed 2010-06-23 @ 02-45-53PM +0200, Laurent Pinchart wrote:
 # On Wednesday 23 June 2010 11:23:16 Nils Radtke wrote:
 #  From: Nils Radtke l...@think-future.de
 # 
 #  This patch adds support for the Suyin Corp. Lenovo Webcam.
 #  lsusb: ID 064e:a102 Suyin Corp. Lenovo Webcam
 # 
 #  It is available as built-in webcam i.e. in ACER timeline 1810t
 #  notebooks.
 # 
 #  The note in uvc_driver.c about Logitech cameras applies the same
 #  to the Suyin web cam: it doesn't announce itself as UVC devices
 #  but is compliant.
 # 
 #  Signed-off-by: Nils Radtke l...@think-future.de
 #
 # Thanks for the patch. Could you please send me the output of lsusb -v for
 your
 
 Bus 002 Device 002: ID 064e:a102 Suyin Corp. Lenovo Webcam

[snip]

 Interface Descriptor:
   bLength 9
   bDescriptorType 4
   bInterfaceNumber0
   bAlternateSetting   0
   bNumEndpoints   1
   bInterfaceClass14 Video
   bInterfaceSubClass  1 Video Control
   bInterfaceProtocol  0
   iInterface  5 Webcam

This looks like a pretty standard UVC device. Are you sure your patch is 
needed ?

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [2.6.33.4 PATCH] V4L/uvcvideo: Add support for Suyin Corp. Lenovo Webcam

2010-06-24 Thread Nils Radtke
  Hi Laurent,

On Wed 2010-06-23 @ 02-45-53PM +0200, Laurent Pinchart wrote: 
# Hi Nils,
# 
# On Wednesday 23 June 2010 11:23:16 Nils Radtke wrote:
#  From: Nils Radtke l...@think-future.de
#  
#  This patch adds support for the Suyin Corp. Lenovo Webcam.
#  lsusb: ID 064e:a102 Suyin Corp. Lenovo Webcam
#  
#  It is available as built-in webcam i.e. in ACER timeline 1810t
#  notebooks.
#  
#  The note in uvc_driver.c about Logitech cameras applies the same
#  to the Suyin web cam: it doesn't announce itself as UVC devices
#  but is compliant.
#  
#  Signed-off-by: Nils Radtke l...@think-future.de
# 
# Thanks for the patch. Could you please send me the output of lsusb -v for 
your 

Bus 002 Device 002: ID 064e:a102 Suyin Corp. Lenovo Webcam
Device Descriptor:
  bLength18
  bDescriptorType 1
  bcdUSB   2.00
  bDeviceClass  239 Miscellaneous Device
  bDeviceSubClass 2 ?
  bDeviceProtocol 1 Interface Association
  bMaxPacketSize064
  idVendor   0x064e Suyin Corp.
  idProduct  0xa102 Lenovo Webcam
  bcdDevice2.22
  iManufacturer   2 SuYin
  iProduct1 WebCam
  iSerial 3 CN0316-S30C-OV061-VA-R02.02.02
  bNumConfigurations  1
  Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength  569
bNumInterfaces  2
bConfigurationValue 1
iConfiguration  0 
bmAttributes 0x80
  (Bus Powered)
MaxPower   98mA
Interface Association:
  bLength 8
  bDescriptorType11
  bFirstInterface 0
  bInterfaceCount 2
  bFunctionClass 14 Video
  bFunctionSubClass   3 Video Interface Collection
  bFunctionProtocol   0 
  iFunction   5 Webcam
Interface Descriptor:
  bLength 9
  bDescriptorType 4
  bInterfaceNumber0
  bAlternateSetting   0
  bNumEndpoints   1
  bInterfaceClass14 Video
  bInterfaceSubClass  1 Video Control
  bInterfaceProtocol  0 
  iInterface  5 Webcam
  VideoControl Interface Descriptor:
bLength13
bDescriptorType36
bDescriptorSubtype  1 (HEADER)
bcdUVC   1.00
wTotalLength  103
dwClockFrequency   15.00MHz
bInCollection   1
baInterfaceNr( 0)   1
  VideoControl Interface Descriptor:
bLength 9
bDescriptorType36
bDescriptorSubtype  3 (OUTPUT_TERMINAL)
bTerminalID 2
wTerminalType  0x0101 USB Streaming
bAssocTerminal  0
bSourceID   5
iTerminal   0 
  VideoControl Interface Descriptor:
bLength26
bDescriptorType36
bDescriptorSubtype  6 (EXTENSION_UNIT)
bUnitID 4
guidExtensionCode {7033f028-1163-2e4a-ba2c-6890eb334016}
bNumControl 8
bNrPins 1
baSourceID( 0)  3
bControlSize1
bmControls( 0)   0x0f
iExtension  0 
  VideoControl Interface Descriptor:
bLength26
bDescriptorType36
bDescriptorSubtype  6 (EXTENSION_UNIT)
bUnitID 5
guidExtensionCode {3fae1228-d7bc-114e-a357-6f1edef7d61d}
bNumControl 8
bNrPins 1
baSourceID( 0)  4
bControlSize1
bmControls( 0)   0xff
iExtension  0 
  VideoControl Interface Descriptor:
bLength18
bDescriptorType36
bDescriptorSubtype  2 (INPUT_TERMINAL)
bTerminalID 1
wTerminalType  0x0201 Camera Sensor
bAssocTerminal  0
iTerminal   0 
wObjectiveFocalLengthMin  0
wObjectiveFocalLengthMax  0
wOcularFocalLength0
bControlSize  3
bmControls   0x
  VideoControl Interface Descriptor:
bLength11
bDescriptorType36
bDescriptorSubtype  5 (PROCESSING_UNIT)
  Warning: Descriptor too short
bUnitID 3
bSourceID   1
wMaxMultiplier  0
bControlSize2
bmControls 0x173f
  Brightness
  Contrast
  Hue
  Saturation
  Sharpness
  Gamma
  Backlight Compensation
  Gain
  Power Line Frequency
  White Balance Temperature, Auto
iProcessing 0 

Re: [2.6.33.4 PATCH] V4L/uvcvideo: Add support for Suyin Corp. Lenovo Webcam

2010-06-23 Thread Laurent Pinchart
Hi Nils,

On Wednesday 23 June 2010 11:23:16 Nils Radtke wrote:
 From: Nils Radtke l...@think-future.de
 
 This patch adds support for the Suyin Corp. Lenovo Webcam.
 lsusb: ID 064e:a102 Suyin Corp. Lenovo Webcam
 
 It is available as built-in webcam i.e. in ACER timeline 1810t
 notebooks.
 
 The note in uvc_driver.c about Logitech cameras applies the same
 to the Suyin web cam: it doesn't announce itself as UVC devices
 but is compliant.
 
 Signed-off-by: Nils Radtke l...@think-future.de

Thanks for the patch. Could you please send me the output of lsusb -v for your 
camera, as well as the raw binary descriptors ? You can retrieve the later 
with

cat /proc/bus/usb/xxx/yyy

Replace xxx with the device bus number, and yyy with the device number. Both 
can be retrieved from /proc/bus/usb/devices.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html