Re: [ANN] Media sessions in Lyon in October: codecs
Le lundi 07 octobre 2019 à 13:44 +0200, Ricardo Ribalda Delgado a écrit : > HI Tomasz > > On Mon, Oct 7, 2019 at 11:43 AM Tomasz Figa wrote: > > Hi Ricardo, > > > > On Mon, Oct 7, 2019 at 6:22 PM Ricardo Ribalda Delgado > > wrote: > > > HI Nicolas > > > > > > Sorry to hijack the thread. Do you know if anyone at AMD is working on > > > making a v4l driver for the encoder? Or they want to continue with > > > their mesa approach? > > > > > > Converting a mesa-vappi to v4l is something doable by the mortals? > > > Just changing the API or is a complete rewrite of the code? > > > > Do you know what kind of hardware that is? > > AMD VCE > > https://en.wikipedia.org/wiki/Video_Coding_Engine > > > > Is it a fully integrated smart encoder that manages everything > > internally or a "simplified" one like Rockchip or Intel, which need a > > lot of assistance from the software, like bitrate control and > > bitstream assembly? > > For what I can read from the documentation it looks more like the > intel, with plenty of knobs to play around, and support for custom > motion estimation and all the other fancy stuff. > > > Also, is the encoder an integral part of the GPU or a distinct block > > that can operate independently of the GPU driver? While it should be > > possible to chain a V4L2 driver of the AMDGPU DRM driver, the VAAPI > > model is kind of established for encoders that are closely tied with > > the GPU. > > My concern about vaapi is the complexity of the stack, to "simply" > encode a video you need mesa and llvm. It would be nicer with a v4l2 > m2m driver and gstreamer But i can see that it can get complicated > if the vce shares resources with the other parts of the gpu. Best is to grab someone working on this in Mesa or at AMD. The GPU based accelerators often uses shaders to complete the work. And shaders need to be compiled, hence the you need LLVM or ACO. regards, Nicolas > > > Thanks! > > > > Best regards, > > Tomasz > > > > > Best regards! > > > > > > On Mon, Oct 7, 2019 at 2:05 AM Nicolas Dufresne > > > wrote: > > > > Le jeudi 26 septembre 2019 à 19:21 +0900, Tomasz Figa a écrit : > > > > > On Mon, Sep 23, 2019 at 11:13 PM Hans Verkuil > > > > > wrote: > > > > > > Hi all, > > > > > > > > > > > > Since we have three separate half-day sessions for different topics > > > > > > I decided > > > > > > to split the announcement for this in three emails as well, so > > > > > > these things > > > > > > can be discussed in separate threads. > > > > > > > > > > > > All sessions are in room Terreaux VIP Lounge - Level 0. > > > > > > There is a maximum of 15 people. > > > > > > > > > > > > The first session deals with the codec API and is on Tuesday > > > > > > morning from > > > > > > 8:30 (tentative, might change) to 12:00 (we have to vacate the room > > > > > > at that > > > > > > time). > > > > > > > > > > > > Confirmed attendees for this session: > > > > > > > > > > > > Boris Brezillon > > > > > > Alexandre Courbot > > > > > > Nicolas Dufresne > > > > > > Tomasz Figa > > > > > > Ezequiel Garcia > > > > > > Daniel Gomez > > > > > > Dafna Hirschfeld > > > > > > Eugen Hristev > > > > > > Paul Kocialkowski > > > > > > Helen Koike > > > > > > Michael Tretter > > > > > > Hans Verkuil > > > > > > > > > > > > Tentative: > > > > > > > > > > > > Laurent Pinchart > > > > > > Jacopo Mondi > > > > > > > > > > > > Jacopo, please confirm if you want to attend this session. I didn't > > > > > > find > > > > > > an email with explicit confirmation, so it was probably done via > > > > > > irc. But since > > > > > > this session is getting close to capacity I would prefer to keep > > > > > > attendance to > > > > > > those are actually working with codecs (or will work with it in the > > > > > > near future). > > > > > > > > > > > > If I missed someone, or you are on the list but won't attend after > > > > > > all, then > > > > > > please let me know. > > > > > > > > > > > > > > > > > > > > > > > > Agenda: > > > > > > > > > > > > - Status of any pending patches related to codec support. > > > > > > > > > > > > - Requirements of moving codec drivers out of staging. > > > > > > > > > > > > - Finalize the stateful encoder API. There are two pieces that need > > > > > > to be defined: > > > > > > > > > > > > 1) Setting the frame rate so bitrate control can make sense, since > > > > > >they need to know this information. This is also relevant for the > > > > > >stateless codec (and this may have to change on a per-frame basis > > > > > >for stateless codecs!). > > > > > > > > > > > >This can either be implemented via ENUM_FRAMEINTERVALS for the > > > > > > coded > > > > > >pixelformats and S_PARM support, or we just add a new control > > > > > > for this. > > > > > >E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). > > > > > > If we > > > > > >go for a control, then we need to consider the unit. We can use a > > >
Re: [ANN] Media sessions in Lyon in October: codecs
HI Tomasz On Mon, Oct 7, 2019 at 11:43 AM Tomasz Figa wrote: > > Hi Ricardo, > > On Mon, Oct 7, 2019 at 6:22 PM Ricardo Ribalda Delgado > wrote: > > > > HI Nicolas > > > > Sorry to hijack the thread. Do you know if anyone at AMD is working on > > making a v4l driver for the encoder? Or they want to continue with > > their mesa approach? > > > > Converting a mesa-vappi to v4l is something doable by the mortals? > > Just changing the API or is a complete rewrite of the code? > > Do you know what kind of hardware that is? AMD VCE https://en.wikipedia.org/wiki/Video_Coding_Engine > > Is it a fully integrated smart encoder that manages everything > internally or a "simplified" one like Rockchip or Intel, which need a > lot of assistance from the software, like bitrate control and > bitstream assembly? For what I can read from the documentation it looks more like the intel, with plenty of knobs to play around, and support for custom motion estimation and all the other fancy stuff. > > Also, is the encoder an integral part of the GPU or a distinct block > that can operate independently of the GPU driver? While it should be > possible to chain a V4L2 driver of the AMDGPU DRM driver, the VAAPI > model is kind of established for encoders that are closely tied with > the GPU. My concern about vaapi is the complexity of the stack, to "simply" encode a video you need mesa and llvm. It would be nicer with a v4l2 m2m driver and gstreamer But i can see that it can get complicated if the vce shares resources with the other parts of the gpu. Thanks! > > Best regards, > Tomasz > > > > > Best regards! > > > > On Mon, Oct 7, 2019 at 2:05 AM Nicolas Dufresne > > wrote: > > > > > > Le jeudi 26 septembre 2019 à 19:21 +0900, Tomasz Figa a écrit : > > > > On Mon, Sep 23, 2019 at 11:13 PM Hans Verkuil > > > > wrote: > > > > > Hi all, > > > > > > > > > > Since we have three separate half-day sessions for different topics I > > > > > decided > > > > > to split the announcement for this in three emails as well, so these > > > > > things > > > > > can be discussed in separate threads. > > > > > > > > > > All sessions are in room Terreaux VIP Lounge - Level 0. > > > > > There is a maximum of 15 people. > > > > > > > > > > The first session deals with the codec API and is on Tuesday morning > > > > > from > > > > > 8:30 (tentative, might change) to 12:00 (we have to vacate the room > > > > > at that > > > > > time). > > > > > > > > > > Confirmed attendees for this session: > > > > > > > > > > Boris Brezillon > > > > > Alexandre Courbot > > > > > Nicolas Dufresne > > > > > Tomasz Figa > > > > > Ezequiel Garcia > > > > > Daniel Gomez > > > > > Dafna Hirschfeld > > > > > Eugen Hristev > > > > > Paul Kocialkowski > > > > > Helen Koike > > > > > Michael Tretter > > > > > Hans Verkuil > > > > > > > > > > Tentative: > > > > > > > > > > Laurent Pinchart > > > > > Jacopo Mondi > > > > > > > > > > Jacopo, please confirm if you want to attend this session. I didn't > > > > > find > > > > > an email with explicit confirmation, so it was probably done via irc. > > > > > But since > > > > > this session is getting close to capacity I would prefer to keep > > > > > attendance to > > > > > those are actually working with codecs (or will work with it in the > > > > > near future). > > > > > > > > > > If I missed someone, or you are on the list but won't attend after > > > > > all, then > > > > > please let me know. > > > > > > > > > > > > > > > > > > > > Agenda: > > > > > > > > > > - Status of any pending patches related to codec support. > > > > > > > > > > - Requirements of moving codec drivers out of staging. > > > > > > > > > > - Finalize the stateful encoder API. There are two pieces that need > > > > > to be defined: > > > > > > > > > > 1) Setting the frame rate so bitrate control can make sense, since > > > > >they need to know this information. This is also relevant for the > > > > >stateless codec (and this may have to change on a per-frame basis > > > > >for stateless codecs!). > > > > > > > > > >This can either be implemented via ENUM_FRAMEINTERVALS for the > > > > > coded > > > > >pixelformats and S_PARM support, or we just add a new control for > > > > > this. > > > > >E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). > > > > > If we > > > > >go for a control, then we need to consider the unit. We can use a > > > > >fraction as well. See this series that puts in the foundation for > > > > > that: > > > > >https://patchwork.linuxtv.org/cover/58857/ > > > > > > > > > >I am inclined to go with a control, since the semantics don't > > > > > really > > > > >match ENUM_FRAMEINTERVALS/S_PARM. These ioctls still need to be > > > > > supported > > > > >for legacy drivers. Open question: some drivers (mediatek, hva, > > > > > coda) > > > > >require S_PARM(OUTPUT), some (venus) allow both S_PARM(CAPTURE) and > > > > >S_PARM(OUTP
Re: [ANN] Media sessions in Lyon in October: codecs
Hi Ricardo, On Mon, Oct 7, 2019 at 6:22 PM Ricardo Ribalda Delgado wrote: > > HI Nicolas > > Sorry to hijack the thread. Do you know if anyone at AMD is working on > making a v4l driver for the encoder? Or they want to continue with > their mesa approach? > > Converting a mesa-vappi to v4l is something doable by the mortals? > Just changing the API or is a complete rewrite of the code? Do you know what kind of hardware that is? Is it a fully integrated smart encoder that manages everything internally or a "simplified" one like Rockchip or Intel, which need a lot of assistance from the software, like bitrate control and bitstream assembly? Also, is the encoder an integral part of the GPU or a distinct block that can operate independently of the GPU driver? While it should be possible to chain a V4L2 driver of the AMDGPU DRM driver, the VAAPI model is kind of established for encoders that are closely tied with the GPU. Best regards, Tomasz > > Best regards! > > On Mon, Oct 7, 2019 at 2:05 AM Nicolas Dufresne wrote: > > > > Le jeudi 26 septembre 2019 à 19:21 +0900, Tomasz Figa a écrit : > > > On Mon, Sep 23, 2019 at 11:13 PM Hans Verkuil wrote: > > > > Hi all, > > > > > > > > Since we have three separate half-day sessions for different topics I > > > > decided > > > > to split the announcement for this in three emails as well, so these > > > > things > > > > can be discussed in separate threads. > > > > > > > > All sessions are in room Terreaux VIP Lounge - Level 0. > > > > There is a maximum of 15 people. > > > > > > > > The first session deals with the codec API and is on Tuesday morning > > > > from > > > > 8:30 (tentative, might change) to 12:00 (we have to vacate the room at > > > > that > > > > time). > > > > > > > > Confirmed attendees for this session: > > > > > > > > Boris Brezillon > > > > Alexandre Courbot > > > > Nicolas Dufresne > > > > Tomasz Figa > > > > Ezequiel Garcia > > > > Daniel Gomez > > > > Dafna Hirschfeld > > > > Eugen Hristev > > > > Paul Kocialkowski > > > > Helen Koike > > > > Michael Tretter > > > > Hans Verkuil > > > > > > > > Tentative: > > > > > > > > Laurent Pinchart > > > > Jacopo Mondi > > > > > > > > Jacopo, please confirm if you want to attend this session. I didn't find > > > > an email with explicit confirmation, so it was probably done via irc. > > > > But since > > > > this session is getting close to capacity I would prefer to keep > > > > attendance to > > > > those are actually working with codecs (or will work with it in the > > > > near future). > > > > > > > > If I missed someone, or you are on the list but won't attend after all, > > > > then > > > > please let me know. > > > > > > > > > > > > > > > > Agenda: > > > > > > > > - Status of any pending patches related to codec support. > > > > > > > > - Requirements of moving codec drivers out of staging. > > > > > > > > - Finalize the stateful encoder API. There are two pieces that need > > > > to be defined: > > > > > > > > 1) Setting the frame rate so bitrate control can make sense, since > > > >they need to know this information. This is also relevant for the > > > >stateless codec (and this may have to change on a per-frame basis > > > >for stateless codecs!). > > > > > > > >This can either be implemented via ENUM_FRAMEINTERVALS for the coded > > > >pixelformats and S_PARM support, or we just add a new control for > > > > this. > > > >E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). If > > > > we > > > >go for a control, then we need to consider the unit. We can use a > > > >fraction as well. See this series that puts in the foundation for > > > > that: > > > >https://patchwork.linuxtv.org/cover/58857/ > > > > > > > >I am inclined to go with a control, since the semantics don't really > > > >match ENUM_FRAMEINTERVALS/S_PARM. These ioctls still need to be > > > > supported > > > >for legacy drivers. Open question: some drivers (mediatek, hva, coda) > > > >require S_PARM(OUTPUT), some (venus) allow both S_PARM(CAPTURE) and > > > >S_PARM(OUTPUT). I am inclined to allow both since this is not a > > > > CAPTURE > > > >vs OUTPUT thing, it is global to both queues. > > > > > > > > 2) Interactions between OUTPUT and CAPTURE formats. > > > > > > > >The main problem is what to do if the capture sizeimage is too small > > > >for the OUTPUT resolution when streaming starts. > > > > > > > >Proposal: width and height of S_FMT(OUTPUT) are used to > > > >calculate a minimum sizeimage (app may request more). This is > > > >driver-specific. (Is it? Or is this codec-specific?) > > > > > > > >V4L2_FMT_FLAG_FIXED_RESOLUTION is always set for codec formats > > > >for the encoder (i.e. we don't support mid-stream resolution > > > >changes for now) and V4L2_EVENT_SOURCE_CHANGE is not > > > >supported. See https://patchwork.linuxtv.org/patch/56478/ for > > > >the patch adding this fla
Re: [ANN] Media sessions in Lyon in October: codecs
HI Nicolas Sorry to hijack the thread. Do you know if anyone at AMD is working on making a v4l driver for the encoder? Or they want to continue with their mesa approach? Converting a mesa-vappi to v4l is something doable by the mortals? Just changing the API or is a complete rewrite of the code? Best regards! On Mon, Oct 7, 2019 at 2:05 AM Nicolas Dufresne wrote: > > Le jeudi 26 septembre 2019 à 19:21 +0900, Tomasz Figa a écrit : > > On Mon, Sep 23, 2019 at 11:13 PM Hans Verkuil wrote: > > > Hi all, > > > > > > Since we have three separate half-day sessions for different topics I > > > decided > > > to split the announcement for this in three emails as well, so these > > > things > > > can be discussed in separate threads. > > > > > > All sessions are in room Terreaux VIP Lounge - Level 0. > > > There is a maximum of 15 people. > > > > > > The first session deals with the codec API and is on Tuesday morning from > > > 8:30 (tentative, might change) to 12:00 (we have to vacate the room at > > > that > > > time). > > > > > > Confirmed attendees for this session: > > > > > > Boris Brezillon > > > Alexandre Courbot > > > Nicolas Dufresne > > > Tomasz Figa > > > Ezequiel Garcia > > > Daniel Gomez > > > Dafna Hirschfeld > > > Eugen Hristev > > > Paul Kocialkowski > > > Helen Koike > > > Michael Tretter > > > Hans Verkuil > > > > > > Tentative: > > > > > > Laurent Pinchart > > > Jacopo Mondi > > > > > > Jacopo, please confirm if you want to attend this session. I didn't find > > > an email with explicit confirmation, so it was probably done via irc. But > > > since > > > this session is getting close to capacity I would prefer to keep > > > attendance to > > > those are actually working with codecs (or will work with it in the near > > > future). > > > > > > If I missed someone, or you are on the list but won't attend after all, > > > then > > > please let me know. > > > > > > > > > > > > Agenda: > > > > > > - Status of any pending patches related to codec support. > > > > > > - Requirements of moving codec drivers out of staging. > > > > > > - Finalize the stateful encoder API. There are two pieces that need > > > to be defined: > > > > > > 1) Setting the frame rate so bitrate control can make sense, since > > >they need to know this information. This is also relevant for the > > >stateless codec (and this may have to change on a per-frame basis > > >for stateless codecs!). > > > > > >This can either be implemented via ENUM_FRAMEINTERVALS for the coded > > >pixelformats and S_PARM support, or we just add a new control for this. > > >E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). If we > > >go for a control, then we need to consider the unit. We can use a > > >fraction as well. See this series that puts in the foundation for that: > > >https://patchwork.linuxtv.org/cover/58857/ > > > > > >I am inclined to go with a control, since the semantics don't really > > >match ENUM_FRAMEINTERVALS/S_PARM. These ioctls still need to be > > > supported > > >for legacy drivers. Open question: some drivers (mediatek, hva, coda) > > >require S_PARM(OUTPUT), some (venus) allow both S_PARM(CAPTURE) and > > >S_PARM(OUTPUT). I am inclined to allow both since this is not a CAPTURE > > >vs OUTPUT thing, it is global to both queues. > > > > > > 2) Interactions between OUTPUT and CAPTURE formats. > > > > > >The main problem is what to do if the capture sizeimage is too small > > >for the OUTPUT resolution when streaming starts. > > > > > >Proposal: width and height of S_FMT(OUTPUT) are used to > > >calculate a minimum sizeimage (app may request more). This is > > >driver-specific. (Is it? Or is this codec-specific?) > > > > > >V4L2_FMT_FLAG_FIXED_RESOLUTION is always set for codec formats > > >for the encoder (i.e. we don't support mid-stream resolution > > >changes for now) and V4L2_EVENT_SOURCE_CHANGE is not > > >supported. See https://patchwork.linuxtv.org/patch/56478/ for > > >the patch adding this flag. > > > > > >Of course, if we start to support mid-stream resolution > > >changes (or other changes that require a source change event), > > >then this flag should be dropped by the encoder driver and > > >documentation on how to handle the source change event should > > >be documented in the encoder spec. I prefer to postpone this > > >until we have an encoder than can actually do mid-stream > > >resolution changes. > > > > > >If sizeimage of the OUTPUT is too small for the CAPTURE > > >resolution and V4L2_EVENT_SOURCE_CHANGE is not supported, > > >then the second STREAMON (either CAPTURE or OUTPUT) will > > >return -ENOMEM since there is not enough memory to do the > > >encode. > > > > > >If V4L2_FMT_FLAG_FIXED_RESOLUTION is set (i.e. that should > > >be the case for all current encoders), then any bitrate controls > > >will be
Re: [ANN] Media sessions in Lyon in October: codecs
On Mon, Oct 7, 2019 at 9:03 AM Nicolas Dufresne wrote: > > Le jeudi 26 septembre 2019 à 19:21 +0900, Tomasz Figa a écrit : > > On Mon, Sep 23, 2019 at 11:13 PM Hans Verkuil wrote: > > > Hi all, > > > > > > Since we have three separate half-day sessions for different topics I > > > decided > > > to split the announcement for this in three emails as well, so these > > > things > > > can be discussed in separate threads. > > > > > > All sessions are in room Terreaux VIP Lounge - Level 0. > > > There is a maximum of 15 people. > > > > > > The first session deals with the codec API and is on Tuesday morning from > > > 8:30 (tentative, might change) to 12:00 (we have to vacate the room at > > > that > > > time). > > > > > > Confirmed attendees for this session: > > > > > > Boris Brezillon > > > Alexandre Courbot > > > Nicolas Dufresne > > > Tomasz Figa > > > Ezequiel Garcia > > > Daniel Gomez > > > Dafna Hirschfeld > > > Eugen Hristev > > > Paul Kocialkowski > > > Helen Koike > > > Michael Tretter > > > Hans Verkuil > > > > > > Tentative: > > > > > > Laurent Pinchart > > > Jacopo Mondi > > > > > > Jacopo, please confirm if you want to attend this session. I didn't find > > > an email with explicit confirmation, so it was probably done via irc. But > > > since > > > this session is getting close to capacity I would prefer to keep > > > attendance to > > > those are actually working with codecs (or will work with it in the near > > > future). > > > > > > If I missed someone, or you are on the list but won't attend after all, > > > then > > > please let me know. > > > > > > > > > > > > Agenda: > > > > > > - Status of any pending patches related to codec support. > > > > > > - Requirements of moving codec drivers out of staging. > > > > > > - Finalize the stateful encoder API. There are two pieces that need > > > to be defined: > > > > > > 1) Setting the frame rate so bitrate control can make sense, since > > >they need to know this information. This is also relevant for the > > >stateless codec (and this may have to change on a per-frame basis > > >for stateless codecs!). > > > > > >This can either be implemented via ENUM_FRAMEINTERVALS for the coded > > >pixelformats and S_PARM support, or we just add a new control for this. > > >E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). If we > > >go for a control, then we need to consider the unit. We can use a > > >fraction as well. See this series that puts in the foundation for that: > > >https://patchwork.linuxtv.org/cover/58857/ > > > > > >I am inclined to go with a control, since the semantics don't really > > >match ENUM_FRAMEINTERVALS/S_PARM. These ioctls still need to be > > > supported > > >for legacy drivers. Open question: some drivers (mediatek, hva, coda) > > >require S_PARM(OUTPUT), some (venus) allow both S_PARM(CAPTURE) and > > >S_PARM(OUTPUT). I am inclined to allow both since this is not a CAPTURE > > >vs OUTPUT thing, it is global to both queues. > > > > > > 2) Interactions between OUTPUT and CAPTURE formats. > > > > > >The main problem is what to do if the capture sizeimage is too small > > >for the OUTPUT resolution when streaming starts. > > > > > >Proposal: width and height of S_FMT(OUTPUT) are used to > > >calculate a minimum sizeimage (app may request more). This is > > >driver-specific. (Is it? Or is this codec-specific?) > > > > > >V4L2_FMT_FLAG_FIXED_RESOLUTION is always set for codec formats > > >for the encoder (i.e. we don't support mid-stream resolution > > >changes for now) and V4L2_EVENT_SOURCE_CHANGE is not > > >supported. See https://patchwork.linuxtv.org/patch/56478/ for > > >the patch adding this flag. > > > > > >Of course, if we start to support mid-stream resolution > > >changes (or other changes that require a source change event), > > >then this flag should be dropped by the encoder driver and > > >documentation on how to handle the source change event should > > >be documented in the encoder spec. I prefer to postpone this > > >until we have an encoder than can actually do mid-stream > > >resolution changes. > > > > > >If sizeimage of the OUTPUT is too small for the CAPTURE > > >resolution and V4L2_EVENT_SOURCE_CHANGE is not supported, > > >then the second STREAMON (either CAPTURE or OUTPUT) will > > >return -ENOMEM since there is not enough memory to do the > > >encode. > > > > > >If V4L2_FMT_FLAG_FIXED_RESOLUTION is set (i.e. that should > > >be the case for all current encoders), then any bitrate controls > > >will be limited in range to what the current state (CAPTURE and > > >OUTPUT formats and frame rate) supports. > > > > > > - Stateless encoders? > > > > This could indeed be a good topic. The hantro driver currently only > > supports JPEG encoding, but the hardware also supports H.264 and VP8 > > at least. It, however,
Re: [ANN] Media sessions in Lyon in October: codecs
Le jeudi 26 septembre 2019 à 19:21 +0900, Tomasz Figa a écrit : > On Mon, Sep 23, 2019 at 11:13 PM Hans Verkuil wrote: > > Hi all, > > > > Since we have three separate half-day sessions for different topics I > > decided > > to split the announcement for this in three emails as well, so these things > > can be discussed in separate threads. > > > > All sessions are in room Terreaux VIP Lounge - Level 0. > > There is a maximum of 15 people. > > > > The first session deals with the codec API and is on Tuesday morning from > > 8:30 (tentative, might change) to 12:00 (we have to vacate the room at that > > time). > > > > Confirmed attendees for this session: > > > > Boris Brezillon > > Alexandre Courbot > > Nicolas Dufresne > > Tomasz Figa > > Ezequiel Garcia > > Daniel Gomez > > Dafna Hirschfeld > > Eugen Hristev > > Paul Kocialkowski > > Helen Koike > > Michael Tretter > > Hans Verkuil > > > > Tentative: > > > > Laurent Pinchart > > Jacopo Mondi > > > > Jacopo, please confirm if you want to attend this session. I didn't find > > an email with explicit confirmation, so it was probably done via irc. But > > since > > this session is getting close to capacity I would prefer to keep attendance > > to > > those are actually working with codecs (or will work with it in the near > > future). > > > > If I missed someone, or you are on the list but won't attend after all, then > > please let me know. > > > > > > > > Agenda: > > > > - Status of any pending patches related to codec support. > > > > - Requirements of moving codec drivers out of staging. > > > > - Finalize the stateful encoder API. There are two pieces that need > > to be defined: > > > > 1) Setting the frame rate so bitrate control can make sense, since > >they need to know this information. This is also relevant for the > >stateless codec (and this may have to change on a per-frame basis > >for stateless codecs!). > > > >This can either be implemented via ENUM_FRAMEINTERVALS for the coded > >pixelformats and S_PARM support, or we just add a new control for this. > >E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). If we > >go for a control, then we need to consider the unit. We can use a > >fraction as well. See this series that puts in the foundation for that: > >https://patchwork.linuxtv.org/cover/58857/ > > > >I am inclined to go with a control, since the semantics don't really > >match ENUM_FRAMEINTERVALS/S_PARM. These ioctls still need to be supported > >for legacy drivers. Open question: some drivers (mediatek, hva, coda) > >require S_PARM(OUTPUT), some (venus) allow both S_PARM(CAPTURE) and > >S_PARM(OUTPUT). I am inclined to allow both since this is not a CAPTURE > >vs OUTPUT thing, it is global to both queues. > > > > 2) Interactions between OUTPUT and CAPTURE formats. > > > >The main problem is what to do if the capture sizeimage is too small > >for the OUTPUT resolution when streaming starts. > > > >Proposal: width and height of S_FMT(OUTPUT) are used to > >calculate a minimum sizeimage (app may request more). This is > >driver-specific. (Is it? Or is this codec-specific?) > > > >V4L2_FMT_FLAG_FIXED_RESOLUTION is always set for codec formats > >for the encoder (i.e. we don't support mid-stream resolution > >changes for now) and V4L2_EVENT_SOURCE_CHANGE is not > >supported. See https://patchwork.linuxtv.org/patch/56478/ for > >the patch adding this flag. > > > >Of course, if we start to support mid-stream resolution > >changes (or other changes that require a source change event), > >then this flag should be dropped by the encoder driver and > >documentation on how to handle the source change event should > >be documented in the encoder spec. I prefer to postpone this > >until we have an encoder than can actually do mid-stream > >resolution changes. > > > >If sizeimage of the OUTPUT is too small for the CAPTURE > >resolution and V4L2_EVENT_SOURCE_CHANGE is not supported, > >then the second STREAMON (either CAPTURE or OUTPUT) will > >return -ENOMEM since there is not enough memory to do the > >encode. > > > >If V4L2_FMT_FLAG_FIXED_RESOLUTION is set (i.e. that should > >be the case for all current encoders), then any bitrate controls > >will be limited in range to what the current state (CAPTURE and > >OUTPUT formats and frame rate) supports. > > > > - Stateless encoders? > > This could indeed be a good topic. The hantro driver currently only > supports JPEG encoding, but the hardware also supports H.264 and VP8 > at least. It, however, handles only the core parts of the encoding, > i.e. generating the actual encoded frames (slices) without headers. It > also doesn't do any bitrate control or scene change detection on its > own and expects quality parameters (QP) or keyframe requests to come > from the software. > > I'm
Re: [ANN] Media sessions in Lyon in October: codecs
On Fri, Sep 27, 2019 at 12:28 AM Nicolas Dufresne wrote: > > Le jeudi 26 septembre 2019 à 19:21 +0900, Tomasz Figa a écrit : > > On Mon, Sep 23, 2019 at 11:13 PM Hans Verkuil wrote: > > > Hi all, > > > > > > Since we have three separate half-day sessions for different topics I > > > decided > > > to split the announcement for this in three emails as well, so these > > > things > > > can be discussed in separate threads. > > > > > > All sessions are in room Terreaux VIP Lounge - Level 0. > > > There is a maximum of 15 people. > > > > > > The first session deals with the codec API and is on Tuesday morning from > > > 8:30 (tentative, might change) to 12:00 (we have to vacate the room at > > > that > > > time). > > > > > > Confirmed attendees for this session: > > > > > > Boris Brezillon > > > Alexandre Courbot > > > Nicolas Dufresne > > > Tomasz Figa > > > Ezequiel Garcia > > > Daniel Gomez > > > Dafna Hirschfeld > > > Eugen Hristev > > > Paul Kocialkowski > > > Helen Koike > > > Michael Tretter > > > Hans Verkuil > > > > > > Tentative: > > > > > > Laurent Pinchart > > > Jacopo Mondi > > > > > > Jacopo, please confirm if you want to attend this session. I didn't find > > > an email with explicit confirmation, so it was probably done via irc. But > > > since > > > this session is getting close to capacity I would prefer to keep > > > attendance to > > > those are actually working with codecs (or will work with it in the near > > > future). > > > > > > If I missed someone, or you are on the list but won't attend after all, > > > then > > > please let me know. > > > > > > > > > > > > Agenda: > > > > > > - Status of any pending patches related to codec support. > > > > > > - Requirements of moving codec drivers out of staging. > > > > > > - Finalize the stateful encoder API. There are two pieces that need > > > to be defined: > > > > > > 1) Setting the frame rate so bitrate control can make sense, since > > >they need to know this information. This is also relevant for the > > >stateless codec (and this may have to change on a per-frame basis > > >for stateless codecs!). > > > > > >This can either be implemented via ENUM_FRAMEINTERVALS for the coded > > >pixelformats and S_PARM support, or we just add a new control for this. > > >E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). If we > > >go for a control, then we need to consider the unit. We can use a > > >fraction as well. See this series that puts in the foundation for that: > > >https://patchwork.linuxtv.org/cover/58857/ > > > > > >I am inclined to go with a control, since the semantics don't really > > >match ENUM_FRAMEINTERVALS/S_PARM. These ioctls still need to be > > > supported > > >for legacy drivers. Open question: some drivers (mediatek, hva, coda) > > >require S_PARM(OUTPUT), some (venus) allow both S_PARM(CAPTURE) and > > >S_PARM(OUTPUT). I am inclined to allow both since this is not a CAPTURE > > >vs OUTPUT thing, it is global to both queues. > > > > > > 2) Interactions between OUTPUT and CAPTURE formats. > > > > > >The main problem is what to do if the capture sizeimage is too small > > >for the OUTPUT resolution when streaming starts. > > > > > >Proposal: width and height of S_FMT(OUTPUT) are used to > > >calculate a minimum sizeimage (app may request more). This is > > >driver-specific. (Is it? Or is this codec-specific?) > > > > > >V4L2_FMT_FLAG_FIXED_RESOLUTION is always set for codec formats > > >for the encoder (i.e. we don't support mid-stream resolution > > >changes for now) and V4L2_EVENT_SOURCE_CHANGE is not > > >supported. See https://patchwork.linuxtv.org/patch/56478/ for > > >the patch adding this flag. > > > > > >Of course, if we start to support mid-stream resolution > > >changes (or other changes that require a source change event), > > >then this flag should be dropped by the encoder driver and > > >documentation on how to handle the source change event should > > >be documented in the encoder spec. I prefer to postpone this > > >until we have an encoder than can actually do mid-stream > > >resolution changes. > > > > > >If sizeimage of the OUTPUT is too small for the CAPTURE > > >resolution and V4L2_EVENT_SOURCE_CHANGE is not supported, > > >then the second STREAMON (either CAPTURE or OUTPUT) will > > >return -ENOMEM since there is not enough memory to do the > > >encode. > > > > > >If V4L2_FMT_FLAG_FIXED_RESOLUTION is set (i.e. that should > > >be the case for all current encoders), then any bitrate controls > > >will be limited in range to what the current state (CAPTURE and > > >OUTPUT formats and frame rate) supports. > > > > > > - Stateless encoders? > > > > This could indeed be a good topic. The hantro driver currently only > > supports JPEG encoding, but the hardware also supports H.264 and VP8 > > at least. It, howeve
Re: [ANN] Media sessions in Lyon in October: codecs
Hi, On Mon, Sep 23, 2019 at 07:19:34PM +0300, Laurent Pinchart wrote: > On Mon, Sep 23, 2019 at 05:02:13PM +0200, Jacopo Mondi wrote: > > On Mon, Sep 23, 2019 at 04:12:55PM +0200, Hans Verkuil wrote: > > > Hi all, > > > > > > Since we have three separate half-day sessions for different topics I > > > decided > > > to split the announcement for this in three emails as well, so these > > > things > > > can be discussed in separate threads. > > > > > > All sessions are in room Terreaux VIP Lounge - Level 0. > > > There is a maximum of 15 people. > > > > > > The first session deals with the codec API and is on Tuesday morning from > > > 8:30 (tentative, might change) to 12:00 (we have to vacate the room at > > > that > > > time). > > > > > > Confirmed attendees for this session: > > > > > > Boris Brezillon > > > Alexandre Courbot > > > Nicolas Dufresne > > > Tomasz Figa > > > Ezequiel Garcia > > > Daniel Gomez > > > Dafna Hirschfeld > > > Eugen Hristev > > > Paul Kocialkowski > > > Helen Koike > > > Michael Tretter > > > Hans Verkuil > > > > > > Tentative: > > > > > > Laurent Pinchart > > > Jacopo Mondi > > > > > > Jacopo, please confirm if you want to attend this session. I didn't find > > > an email with explicit confirmation, so it was probably done via irc. But > > > since > > > this session is getting close to capacity I would prefer to keep > > > attendance to > > > those are actually working with codecs (or will work with it in the near > > > future). > > > > I'm not really working on codecs, so if you're running almost at full > > capacity please feel free to re-assign my seat. > > Same here. I think that Maxime Ripard, who isn't in the above list, > would be able to contribute more than I could. I wasn't sure I would be able to make it, but I can, so if it's still an option count me in :) Maxime signature.asc Description: PGP signature
Re: [ANN] Media sessions in Lyon in October: codecs
On 23.09.2019 17:12, Hans Verkuil wrote: > Hi all, > > Since we have three separate half-day sessions for different topics I decided > to split the announcement for this in three emails as well, so these things > can be discussed in separate threads. > > All sessions are in room Terreaux VIP Lounge - Level 0. > There is a maximum of 15 people. > > The first session deals with the codec API and is on Tuesday morning from > 8:30 (tentative, might change) to 12:00 (we have to vacate the room at that > time). > > Confirmed attendees for this session: > > Boris Brezillon > Alexandre Courbot > Nicolas Dufresne > Tomasz Figa > Ezequiel Garcia > Daniel Gomez > Dafna Hirschfeld > Eugen Hristev > Paul Kocialkowski > Helen Koike > Michael Tretter > Hans Verkuil > > Tentative: > > Laurent Pinchart > Jacopo Mondi > > Jacopo, please confirm if you want to attend this session. I didn't find > an email with explicit confirmation, so it was probably done via irc. But > since > this session is getting close to capacity I would prefer to keep attendance to > those are actually working with codecs (or will work with it in the near > future). > Hi Hans, I am on 'just interested'. If someone is directly involved , they can take my place on this topic. I will see at conference time if there are still open seats if I will join or not. Eugen > If I missed someone, or you are on the list but won't attend after all, then > please let me know. > > > > Agenda: > > - Status of any pending patches related to codec support. > > - Requirements of moving codec drivers out of staging. > > - Finalize the stateful encoder API. There are two pieces that need >to be defined: > > 1) Setting the frame rate so bitrate control can make sense, since > they need to know this information. This is also relevant for the > stateless codec (and this may have to change on a per-frame basis > for stateless codecs!). > > This can either be implemented via ENUM_FRAMEINTERVALS for the coded > pixelformats and S_PARM support, or we just add a new control for this. > E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). If we > go for a control, then we need to consider the unit. We can use a > fraction as well. See this series that puts in the foundation for that: > https://patchwork.linuxtv.org/cover/58857/ > > I am inclined to go with a control, since the semantics don't really > match ENUM_FRAMEINTERVALS/S_PARM. These ioctls still need to be supported > for legacy drivers. Open question: some drivers (mediatek, hva, coda) > require S_PARM(OUTPUT), some (venus) allow both S_PARM(CAPTURE) and > S_PARM(OUTPUT). I am inclined to allow both since this is not a CAPTURE > vs OUTPUT thing, it is global to both queues. > > 2) Interactions between OUTPUT and CAPTURE formats. > > The main problem is what to do if the capture sizeimage is too small > for the OUTPUT resolution when streaming starts. > > Proposal: width and height of S_FMT(OUTPUT) are used to > calculate a minimum sizeimage (app may request more). This is > driver-specific. (Is it? Or is this codec-specific?) > > V4L2_FMT_FLAG_FIXED_RESOLUTION is always set for codec formats > for the encoder (i.e. we don't support mid-stream resolution > changes for now) and V4L2_EVENT_SOURCE_CHANGE is not > supported. See https://patchwork.linuxtv.org/patch/56478/ for > the patch adding this flag. > > Of course, if we start to support mid-stream resolution > changes (or other changes that require a source change event), > then this flag should be dropped by the encoder driver and > documentation on how to handle the source change event should > be documented in the encoder spec. I prefer to postpone this > until we have an encoder than can actually do mid-stream > resolution changes. > > If sizeimage of the OUTPUT is too small for the CAPTURE > resolution and V4L2_EVENT_SOURCE_CHANGE is not supported, > then the second STREAMON (either CAPTURE or OUTPUT) will > return -ENOMEM since there is not enough memory to do the > encode. > > If V4L2_FMT_FLAG_FIXED_RESOLUTION is set (i.e. that should > be the case for all current encoders), then any bitrate controls > will be limited in range to what the current state (CAPTURE and > OUTPUT formats and frame rate) supports. > > - Stateless encoders? > > - Anything else? (I have a feeling I missed a codec-related topic, but >I can't find it in my mailbox) > > Regards, > > Hans >
Re: [ANN] Media sessions in Lyon in October: codecs
Hi Hans, On 9/23/19 7:12 AM, Hans Verkuil wrote: > Hi all, > > Since we have three separate half-day sessions for different topics I decided > to split the announcement for this in three emails as well, so these things > can be discussed in separate threads. > > All sessions are in room Terreaux VIP Lounge - Level 0. > There is a maximum of 15 people. > > The first session deals with the codec API and is on Tuesday morning from > 8:30 (tentative, might change) to 12:00 (we have to vacate the room at that > time). > > Confirmed attendees for this session: > > Boris Brezillon > Alexandre Courbot > Nicolas Dufresne > Tomasz Figa > Ezequiel Garcia > Daniel Gomez > Dafna Hirschfeld > Eugen Hristev > Paul Kocialkowski > Helen Koike > Michael Tretter > Hans Verkuil > > Tentative: > > Laurent Pinchart > Jacopo Mondi I'd like to attend the codec session too if there is vacant seat. > > Jacopo, please confirm if you want to attend this session. I didn't find > an email with explicit confirmation, so it was probably done via irc. But > since > this session is getting close to capacity I would prefer to keep attendance to > those are actually working with codecs (or will work with it in the near > future). > > If I missed someone, or you are on the list but won't attend after all, then > please let me know. > > > > Agenda: > > - Status of any pending patches related to codec support. > > - Requirements of moving codec drivers out of staging. > > - Finalize the stateful encoder API. There are two pieces that need > to be defined: > > 1) Setting the frame rate so bitrate control can make sense, since >they need to know this information. This is also relevant for the >stateless codec (and this may have to change on a per-frame basis >for stateless codecs!). > >This can either be implemented via ENUM_FRAMEINTERVALS for the coded >pixelformats and S_PARM support, or we just add a new control for this. >E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). If we >go for a control, then we need to consider the unit. We can use a >fraction as well. See this series that puts in the foundation for that: >https://patchwork.linuxtv.org/cover/58857/ > >I am inclined to go with a control, since the semantics don't really >match ENUM_FRAMEINTERVALS/S_PARM. These ioctls still need to be supported >for legacy drivers. Open question: some drivers (mediatek, hva, coda) >require S_PARM(OUTPUT), some (venus) allow both S_PARM(CAPTURE) and >S_PARM(OUTPUT). I am inclined to allow both since this is not a CAPTURE >vs OUTPUT thing, it is global to both queues. > > 2) Interactions between OUTPUT and CAPTURE formats. > >The main problem is what to do if the capture sizeimage is too small >for the OUTPUT resolution when streaming starts. > >Proposal: width and height of S_FMT(OUTPUT) are used to >calculate a minimum sizeimage (app may request more). This is >driver-specific. (Is it? Or is this codec-specific?) > >V4L2_FMT_FLAG_FIXED_RESOLUTION is always set for codec formats >for the encoder (i.e. we don't support mid-stream resolution >changes for now) and V4L2_EVENT_SOURCE_CHANGE is not >supported. See https://patchwork.linuxtv.org/patch/56478/ for >the patch adding this flag. > >Of course, if we start to support mid-stream resolution >changes (or other changes that require a source change event), >then this flag should be dropped by the encoder driver and >documentation on how to handle the source change event should >be documented in the encoder spec. I prefer to postpone this >until we have an encoder than can actually do mid-stream >resolution changes. > >If sizeimage of the OUTPUT is too small for the CAPTURE >resolution and V4L2_EVENT_SOURCE_CHANGE is not supported, >then the second STREAMON (either CAPTURE or OUTPUT) will >return -ENOMEM since there is not enough memory to do the >encode. > >If V4L2_FMT_FLAG_FIXED_RESOLUTION is set (i.e. that should >be the case for all current encoders), then any bitrate controls >will be limited in range to what the current state (CAPTURE and >OUTPUT formats and frame rate) supports. > > - Stateless encoders? > > - Anything else? (I have a feeling I missed a codec-related topic, but > I can't find it in my mailbox) > > Regards, > > Hans > -- regards, Stan
Re: [ANN] Media sessions in Lyon in October: codecs
Le jeudi 26 septembre 2019 à 19:21 +0900, Tomasz Figa a écrit : > On Mon, Sep 23, 2019 at 11:13 PM Hans Verkuil wrote: > > Hi all, > > > > Since we have three separate half-day sessions for different topics I > > decided > > to split the announcement for this in three emails as well, so these things > > can be discussed in separate threads. > > > > All sessions are in room Terreaux VIP Lounge - Level 0. > > There is a maximum of 15 people. > > > > The first session deals with the codec API and is on Tuesday morning from > > 8:30 (tentative, might change) to 12:00 (we have to vacate the room at that > > time). > > > > Confirmed attendees for this session: > > > > Boris Brezillon > > Alexandre Courbot > > Nicolas Dufresne > > Tomasz Figa > > Ezequiel Garcia > > Daniel Gomez > > Dafna Hirschfeld > > Eugen Hristev > > Paul Kocialkowski > > Helen Koike > > Michael Tretter > > Hans Verkuil > > > > Tentative: > > > > Laurent Pinchart > > Jacopo Mondi > > > > Jacopo, please confirm if you want to attend this session. I didn't find > > an email with explicit confirmation, so it was probably done via irc. But > > since > > this session is getting close to capacity I would prefer to keep attendance > > to > > those are actually working with codecs (or will work with it in the near > > future). > > > > If I missed someone, or you are on the list but won't attend after all, then > > please let me know. > > > > > > > > Agenda: > > > > - Status of any pending patches related to codec support. > > > > - Requirements of moving codec drivers out of staging. > > > > - Finalize the stateful encoder API. There are two pieces that need > > to be defined: > > > > 1) Setting the frame rate so bitrate control can make sense, since > >they need to know this information. This is also relevant for the > >stateless codec (and this may have to change on a per-frame basis > >for stateless codecs!). > > > >This can either be implemented via ENUM_FRAMEINTERVALS for the coded > >pixelformats and S_PARM support, or we just add a new control for this. > >E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). If we > >go for a control, then we need to consider the unit. We can use a > >fraction as well. See this series that puts in the foundation for that: > >https://patchwork.linuxtv.org/cover/58857/ > > > >I am inclined to go with a control, since the semantics don't really > >match ENUM_FRAMEINTERVALS/S_PARM. These ioctls still need to be supported > >for legacy drivers. Open question: some drivers (mediatek, hva, coda) > >require S_PARM(OUTPUT), some (venus) allow both S_PARM(CAPTURE) and > >S_PARM(OUTPUT). I am inclined to allow both since this is not a CAPTURE > >vs OUTPUT thing, it is global to both queues. > > > > 2) Interactions between OUTPUT and CAPTURE formats. > > > >The main problem is what to do if the capture sizeimage is too small > >for the OUTPUT resolution when streaming starts. > > > >Proposal: width and height of S_FMT(OUTPUT) are used to > >calculate a minimum sizeimage (app may request more). This is > >driver-specific. (Is it? Or is this codec-specific?) > > > >V4L2_FMT_FLAG_FIXED_RESOLUTION is always set for codec formats > >for the encoder (i.e. we don't support mid-stream resolution > >changes for now) and V4L2_EVENT_SOURCE_CHANGE is not > >supported. See https://patchwork.linuxtv.org/patch/56478/ for > >the patch adding this flag. > > > >Of course, if we start to support mid-stream resolution > >changes (or other changes that require a source change event), > >then this flag should be dropped by the encoder driver and > >documentation on how to handle the source change event should > >be documented in the encoder spec. I prefer to postpone this > >until we have an encoder than can actually do mid-stream > >resolution changes. > > > >If sizeimage of the OUTPUT is too small for the CAPTURE > >resolution and V4L2_EVENT_SOURCE_CHANGE is not supported, > >then the second STREAMON (either CAPTURE or OUTPUT) will > >return -ENOMEM since there is not enough memory to do the > >encode. > > > >If V4L2_FMT_FLAG_FIXED_RESOLUTION is set (i.e. that should > >be the case for all current encoders), then any bitrate controls > >will be limited in range to what the current state (CAPTURE and > >OUTPUT formats and frame rate) supports. > > > > - Stateless encoders? > > This could indeed be a good topic. The hantro driver currently only > supports JPEG encoding, but the hardware also supports H.264 and VP8 > at least. It, however, handles only the core parts of the encoding, > i.e. generating the actual encoded frames (slices) without headers. It > also doesn't do any bitrate control or scene change detection on its > own and expects quality parameters (QP) or keyframe requests to come > from the software. > > I'm
Re: [ANN] Media sessions in Lyon in October: codecs
On Mon, Sep 23, 2019 at 11:13 PM Hans Verkuil wrote: > > Hi all, > > Since we have three separate half-day sessions for different topics I decided > to split the announcement for this in three emails as well, so these things > can be discussed in separate threads. > > All sessions are in room Terreaux VIP Lounge - Level 0. > There is a maximum of 15 people. > > The first session deals with the codec API and is on Tuesday morning from > 8:30 (tentative, might change) to 12:00 (we have to vacate the room at that > time). > > Confirmed attendees for this session: > > Boris Brezillon > Alexandre Courbot > Nicolas Dufresne > Tomasz Figa > Ezequiel Garcia > Daniel Gomez > Dafna Hirschfeld > Eugen Hristev > Paul Kocialkowski > Helen Koike > Michael Tretter > Hans Verkuil > > Tentative: > > Laurent Pinchart > Jacopo Mondi > > Jacopo, please confirm if you want to attend this session. I didn't find > an email with explicit confirmation, so it was probably done via irc. But > since > this session is getting close to capacity I would prefer to keep attendance to > those are actually working with codecs (or will work with it in the near > future). > > If I missed someone, or you are on the list but won't attend after all, then > please let me know. > > > > Agenda: > > - Status of any pending patches related to codec support. > > - Requirements of moving codec drivers out of staging. > > - Finalize the stateful encoder API. There are two pieces that need > to be defined: > > 1) Setting the frame rate so bitrate control can make sense, since >they need to know this information. This is also relevant for the >stateless codec (and this may have to change on a per-frame basis >for stateless codecs!). > >This can either be implemented via ENUM_FRAMEINTERVALS for the coded >pixelformats and S_PARM support, or we just add a new control for this. >E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). If we >go for a control, then we need to consider the unit. We can use a >fraction as well. See this series that puts in the foundation for that: >https://patchwork.linuxtv.org/cover/58857/ > >I am inclined to go with a control, since the semantics don't really >match ENUM_FRAMEINTERVALS/S_PARM. These ioctls still need to be supported >for legacy drivers. Open question: some drivers (mediatek, hva, coda) >require S_PARM(OUTPUT), some (venus) allow both S_PARM(CAPTURE) and >S_PARM(OUTPUT). I am inclined to allow both since this is not a CAPTURE >vs OUTPUT thing, it is global to both queues. > > 2) Interactions between OUTPUT and CAPTURE formats. > >The main problem is what to do if the capture sizeimage is too small >for the OUTPUT resolution when streaming starts. > >Proposal: width and height of S_FMT(OUTPUT) are used to >calculate a minimum sizeimage (app may request more). This is >driver-specific. (Is it? Or is this codec-specific?) > >V4L2_FMT_FLAG_FIXED_RESOLUTION is always set for codec formats >for the encoder (i.e. we don't support mid-stream resolution >changes for now) and V4L2_EVENT_SOURCE_CHANGE is not >supported. See https://patchwork.linuxtv.org/patch/56478/ for >the patch adding this flag. > >Of course, if we start to support mid-stream resolution >changes (or other changes that require a source change event), >then this flag should be dropped by the encoder driver and >documentation on how to handle the source change event should >be documented in the encoder spec. I prefer to postpone this >until we have an encoder than can actually do mid-stream >resolution changes. > >If sizeimage of the OUTPUT is too small for the CAPTURE >resolution and V4L2_EVENT_SOURCE_CHANGE is not supported, >then the second STREAMON (either CAPTURE or OUTPUT) will >return -ENOMEM since there is not enough memory to do the >encode. > >If V4L2_FMT_FLAG_FIXED_RESOLUTION is set (i.e. that should >be the case for all current encoders), then any bitrate controls >will be limited in range to what the current state (CAPTURE and >OUTPUT formats and frame rate) supports. > > - Stateless encoders? This could indeed be a good topic. The hantro driver currently only supports JPEG encoding, but the hardware also supports H.264 and VP8 at least. It, however, handles only the core parts of the encoding, i.e. generating the actual encoded frames (slices) without headers. It also doesn't do any bitrate control or scene change detection on its own and expects quality parameters (QP) or keyframe requests to come from the software. I'm not sure if there is any other hardware with similar constraints that could use V4L2, but I believe the Intel video encoder supported by VAAPI has a similar design. Best regards, Tomasz > > - Anything else? (I have a feeling I missed a codec-related topic, but > I can't find it in my mailbox) > > Regards, > > Hans
Re: [ANN] Media sessions in Lyon in October: codecs
On 9/23/19 12:02 PM, Jacopo Mondi wrote: > Hi Hans, > > On Mon, Sep 23, 2019 at 04:12:55PM +0200, Hans Verkuil wrote: >> Hi all, >> >> Since we have three separate half-day sessions for different topics I decided >> to split the announcement for this in three emails as well, so these things >> can be discussed in separate threads. >> >> All sessions are in room Terreaux VIP Lounge - Level 0. >> There is a maximum of 15 people. >> >> The first session deals with the codec API and is on Tuesday morning from >> 8:30 (tentative, might change) to 12:00 (we have to vacate the room at that >> time). >> >> Confirmed attendees for this session: >> >> Boris Brezillon >> Alexandre Courbot >> Nicolas Dufresne >> Tomasz Figa >> Ezequiel Garcia >> Daniel Gomez >> Dafna Hirschfeld >> Eugen Hristev >> Paul Kocialkowski >> Helen Koike >> Michael Tretter >> Hans Verkuil >> >> Tentative: >> >> Laurent Pinchart >> Jacopo Mondi >> >> Jacopo, please confirm if you want to attend this session. I didn't find >> an email with explicit confirmation, so it was probably done via irc. But >> since >> this session is getting close to capacity I would prefer to keep attendance >> to >> those are actually working with codecs (or will work with it in the near >> future). > > I'm not really working on codecs, so if you're running almost at full > capacity please feel free to re-assign my seat. Same here, feel free to re-assign my seat. Thanks, Helen > > If there are free seats I might flock in, but without contributing too > much to the discussions :) > > Thanks >j > >> >> If I missed someone, or you are on the list but won't attend after all, then >> please let me know. >> >> >> >> Agenda: >> >> - Status of any pending patches related to codec support. >> >> - Requirements of moving codec drivers out of staging. >> >> - Finalize the stateful encoder API. There are two pieces that need >> to be defined: >> >> 1) Setting the frame rate so bitrate control can make sense, since >>they need to know this information. This is also relevant for the >>stateless codec (and this may have to change on a per-frame basis >>for stateless codecs!). >> >>This can either be implemented via ENUM_FRAMEINTERVALS for the coded >>pixelformats and S_PARM support, or we just add a new control for this. >>E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). If we >>go for a control, then we need to consider the unit. We can use a >>fraction as well. See this series that puts in the foundation for that: >>https://patchwork.linuxtv.org/cover/58857/ >> >>I am inclined to go with a control, since the semantics don't really >>match ENUM_FRAMEINTERVALS/S_PARM. These ioctls still need to be supported >>for legacy drivers. Open question: some drivers (mediatek, hva, coda) >>require S_PARM(OUTPUT), some (venus) allow both S_PARM(CAPTURE) and >>S_PARM(OUTPUT). I am inclined to allow both since this is not a CAPTURE >>vs OUTPUT thing, it is global to both queues. >> >> 2) Interactions between OUTPUT and CAPTURE formats. >> >>The main problem is what to do if the capture sizeimage is too small >>for the OUTPUT resolution when streaming starts. >> >>Proposal: width and height of S_FMT(OUTPUT) are used to >>calculate a minimum sizeimage (app may request more). This is >>driver-specific. (Is it? Or is this codec-specific?) >> >>V4L2_FMT_FLAG_FIXED_RESOLUTION is always set for codec formats >>for the encoder (i.e. we don't support mid-stream resolution >>changes for now) and V4L2_EVENT_SOURCE_CHANGE is not >>supported. See https://patchwork.linuxtv.org/patch/56478/ for >>the patch adding this flag. >> >>Of course, if we start to support mid-stream resolution >>changes (or other changes that require a source change event), >>then this flag should be dropped by the encoder driver and >>documentation on how to handle the source change event should >>be documented in the encoder spec. I prefer to postpone this >>until we have an encoder than can actually do mid-stream >>resolution changes. >> >>If sizeimage of the OUTPUT is too small for the CAPTURE >>resolution and V4L2_EVENT_SOURCE_CHANGE is not supported, >>then the second STREAMON (either CAPTURE or OUTPUT) will >>return -ENOMEM since there is not enough memory to do the >>encode. >> >>If V4L2_FMT_FLAG_FIXED_RESOLUTION is set (i.e. that should >>be the case for all current encoders), then any bitrate controls >>will be limited in range to what the current state (CAPTURE and >>OUTPUT formats and frame rate) supports. >> >> - Stateless encoders? >> >> - Anything else? (I have a feeling I missed a codec-related topic, but >> I can't find it in my mailbox) >> >> Regards, >> >> Hans
Re: [ANN] Media sessions in Lyon in October: codecs
Hi Laurent, Hans On Mon, 23 Sep 2019 at 18:19, Laurent Pinchart wrote: > > Hello, > > (CC'ing Maxime) > > On Mon, Sep 23, 2019 at 05:02:13PM +0200, Jacopo Mondi wrote: > > On Mon, Sep 23, 2019 at 04:12:55PM +0200, Hans Verkuil wrote: > > > Hi all, > > > > > > Since we have three separate half-day sessions for different topics I > > > decided > > > to split the announcement for this in three emails as well, so these > > > things > > > can be discussed in separate threads. > > > > > > All sessions are in room Terreaux VIP Lounge - Level 0. > > > There is a maximum of 15 people. > > > > > > The first session deals with the codec API and is on Tuesday morning from > > > 8:30 (tentative, might change) to 12:00 (we have to vacate the room at > > > that > > > time). > > > > > > Confirmed attendees for this session: > > > > > > Boris Brezillon > > > Alexandre Courbot > > > Nicolas Dufresne > > > Tomasz Figa > > > Ezequiel Garcia > > > Daniel Gomez > > > Dafna Hirschfeld > > > Eugen Hristev > > > Paul Kocialkowski > > > Helen Koike > > > Michael Tretter > > > Hans Verkuil > > > > > > Tentative: > > > > > > Laurent Pinchart > > > Jacopo Mondi > > > > > > Jacopo, please confirm if you want to attend this session. I didn't find > > > an email with explicit confirmation, so it was probably done via irc. But > > > since > > > this session is getting close to capacity I would prefer to keep > > > attendance to > > > those are actually working with codecs (or will work with it in the near > > > future). > > > > I'm not really working on codecs, so if you're running almost at full > > capacity please feel free to re-assign my seat. > > Same here. I think that Maxime Ripard, who isn't in the above list, > would be able to contribute more than I could. > Same with codecs. Not a problem to give my seat if necessary. > > If there are free seats I might flock in, but without contributing too > > much to the discussions :) > > > > > If I missed someone, or you are on the list but won't attend after all, > > > then > > > please let me know. > > > > > > > > > > > > Agenda: > > > > > > - Status of any pending patches related to codec support. > > > > > > - Requirements of moving codec drivers out of staging. > > > > > > - Finalize the stateful encoder API. There are two pieces that need > > > to be defined: > > > > > > 1) Setting the frame rate so bitrate control can make sense, since > > >they need to know this information. This is also relevant for the > > >stateless codec (and this may have to change on a per-frame basis > > >for stateless codecs!). > > > > > >This can either be implemented via ENUM_FRAMEINTERVALS for the coded > > >pixelformats and S_PARM support, or we just add a new control for this. > > >E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). If we > > >go for a control, then we need to consider the unit. We can use a > > >fraction as well. See this series that puts in the foundation for that: > > >https://patchwork.linuxtv.org/cover/58857/ > > > > > >I am inclined to go with a control, since the semantics don't really > > >match ENUM_FRAMEINTERVALS/S_PARM. These ioctls still need to be > > > supported > > >for legacy drivers. Open question: some drivers (mediatek, hva, coda) > > >require S_PARM(OUTPUT), some (venus) allow both S_PARM(CAPTURE) and > > >S_PARM(OUTPUT). I am inclined to allow both since this is not a CAPTURE > > >vs OUTPUT thing, it is global to both queues. > > > > > > 2) Interactions between OUTPUT and CAPTURE formats. > > > > > >The main problem is what to do if the capture sizeimage is too small > > >for the OUTPUT resolution when streaming starts. > > > > > >Proposal: width and height of S_FMT(OUTPUT) are used to > > >calculate a minimum sizeimage (app may request more). This is > > >driver-specific. (Is it? Or is this codec-specific?) > > > > > >V4L2_FMT_FLAG_FIXED_RESOLUTION is always set for codec formats > > >for the encoder (i.e. we don't support mid-stream resolution > > >changes for now) and V4L2_EVENT_SOURCE_CHANGE is not > > >supported. See https://patchwork.linuxtv.org/patch/56478/ for > > >the patch adding this flag. > > > > > >Of course, if we start to support mid-stream resolution > > >changes (or other changes that require a source change event), > > >then this flag should be dropped by the encoder driver and > > >documentation on how to handle the source change event should > > >be documented in the encoder spec. I prefer to postpone this > > >until we have an encoder than can actually do mid-stream > > >resolution changes. > > > > > >If sizeimage of the OUTPUT is too small for the CAPTURE > > >resolution and V4L2_EVENT_SOURCE_CHANGE is not supported, > > >then the second STREAMON (either CAPTURE or OUTPUT) will > > >return -ENOMEM since there is not enough memory to do the > > >encode. > > > >
Re: [ANN] Media sessions in Lyon in October: codecs
Hello, (CC'ing Maxime) On Mon, Sep 23, 2019 at 05:02:13PM +0200, Jacopo Mondi wrote: > On Mon, Sep 23, 2019 at 04:12:55PM +0200, Hans Verkuil wrote: > > Hi all, > > > > Since we have three separate half-day sessions for different topics I > > decided > > to split the announcement for this in three emails as well, so these things > > can be discussed in separate threads. > > > > All sessions are in room Terreaux VIP Lounge - Level 0. > > There is a maximum of 15 people. > > > > The first session deals with the codec API and is on Tuesday morning from > > 8:30 (tentative, might change) to 12:00 (we have to vacate the room at that > > time). > > > > Confirmed attendees for this session: > > > > Boris Brezillon > > Alexandre Courbot > > Nicolas Dufresne > > Tomasz Figa > > Ezequiel Garcia > > Daniel Gomez > > Dafna Hirschfeld > > Eugen Hristev > > Paul Kocialkowski > > Helen Koike > > Michael Tretter > > Hans Verkuil > > > > Tentative: > > > > Laurent Pinchart > > Jacopo Mondi > > > > Jacopo, please confirm if you want to attend this session. I didn't find > > an email with explicit confirmation, so it was probably done via irc. But > > since > > this session is getting close to capacity I would prefer to keep attendance > > to > > those are actually working with codecs (or will work with it in the near > > future). > > I'm not really working on codecs, so if you're running almost at full > capacity please feel free to re-assign my seat. Same here. I think that Maxime Ripard, who isn't in the above list, would be able to contribute more than I could. > If there are free seats I might flock in, but without contributing too > much to the discussions :) > > > If I missed someone, or you are on the list but won't attend after all, then > > please let me know. > > > > > > > > Agenda: > > > > - Status of any pending patches related to codec support. > > > > - Requirements of moving codec drivers out of staging. > > > > - Finalize the stateful encoder API. There are two pieces that need > > to be defined: > > > > 1) Setting the frame rate so bitrate control can make sense, since > >they need to know this information. This is also relevant for the > >stateless codec (and this may have to change on a per-frame basis > >for stateless codecs!). > > > >This can either be implemented via ENUM_FRAMEINTERVALS for the coded > >pixelformats and S_PARM support, or we just add a new control for this. > >E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). If we > >go for a control, then we need to consider the unit. We can use a > >fraction as well. See this series that puts in the foundation for that: > >https://patchwork.linuxtv.org/cover/58857/ > > > >I am inclined to go with a control, since the semantics don't really > >match ENUM_FRAMEINTERVALS/S_PARM. These ioctls still need to be supported > >for legacy drivers. Open question: some drivers (mediatek, hva, coda) > >require S_PARM(OUTPUT), some (venus) allow both S_PARM(CAPTURE) and > >S_PARM(OUTPUT). I am inclined to allow both since this is not a CAPTURE > >vs OUTPUT thing, it is global to both queues. > > > > 2) Interactions between OUTPUT and CAPTURE formats. > > > >The main problem is what to do if the capture sizeimage is too small > >for the OUTPUT resolution when streaming starts. > > > >Proposal: width and height of S_FMT(OUTPUT) are used to > >calculate a minimum sizeimage (app may request more). This is > >driver-specific. (Is it? Or is this codec-specific?) > > > >V4L2_FMT_FLAG_FIXED_RESOLUTION is always set for codec formats > >for the encoder (i.e. we don't support mid-stream resolution > >changes for now) and V4L2_EVENT_SOURCE_CHANGE is not > >supported. See https://patchwork.linuxtv.org/patch/56478/ for > >the patch adding this flag. > > > >Of course, if we start to support mid-stream resolution > >changes (or other changes that require a source change event), > >then this flag should be dropped by the encoder driver and > >documentation on how to handle the source change event should > >be documented in the encoder spec. I prefer to postpone this > >until we have an encoder than can actually do mid-stream > >resolution changes. > > > >If sizeimage of the OUTPUT is too small for the CAPTURE > >resolution and V4L2_EVENT_SOURCE_CHANGE is not supported, > >then the second STREAMON (either CAPTURE or OUTPUT) will > >return -ENOMEM since there is not enough memory to do the > >encode. > > > >If V4L2_FMT_FLAG_FIXED_RESOLUTION is set (i.e. that should > >be the case for all current encoders), then any bitrate controls > >will be limited in range to what the current state (CAPTURE and > >OUTPUT formats and frame rate) supports. > > > > - Stateless encoders? > > > > - Anything else? (I have a feeling I missed a codec-related topic, but > > I can't find it in my mail
Re: [ANN] Media sessions in Lyon in October: codecs
Hi Hans, On Mon, Sep 23, 2019 at 04:12:55PM +0200, Hans Verkuil wrote: > Hi all, > > Since we have three separate half-day sessions for different topics I decided > to split the announcement for this in three emails as well, so these things > can be discussed in separate threads. > > All sessions are in room Terreaux VIP Lounge - Level 0. > There is a maximum of 15 people. > > The first session deals with the codec API and is on Tuesday morning from > 8:30 (tentative, might change) to 12:00 (we have to vacate the room at that > time). > > Confirmed attendees for this session: > > Boris Brezillon > Alexandre Courbot > Nicolas Dufresne > Tomasz Figa > Ezequiel Garcia > Daniel Gomez > Dafna Hirschfeld > Eugen Hristev > Paul Kocialkowski > Helen Koike > Michael Tretter > Hans Verkuil > > Tentative: > > Laurent Pinchart > Jacopo Mondi > > Jacopo, please confirm if you want to attend this session. I didn't find > an email with explicit confirmation, so it was probably done via irc. But > since > this session is getting close to capacity I would prefer to keep attendance to > those are actually working with codecs (or will work with it in the near > future). I'm not really working on codecs, so if you're running almost at full capacity please feel free to re-assign my seat. If there are free seats I might flock in, but without contributing too much to the discussions :) Thanks j > > If I missed someone, or you are on the list but won't attend after all, then > please let me know. > > > > Agenda: > > - Status of any pending patches related to codec support. > > - Requirements of moving codec drivers out of staging. > > - Finalize the stateful encoder API. There are two pieces that need > to be defined: > > 1) Setting the frame rate so bitrate control can make sense, since >they need to know this information. This is also relevant for the >stateless codec (and this may have to change on a per-frame basis >for stateless codecs!). > >This can either be implemented via ENUM_FRAMEINTERVALS for the coded >pixelformats and S_PARM support, or we just add a new control for this. >E.g. V4L2_CID_MPEG_VIDEO_FRAME_INTERVAL (or perhaps FRAME_RATE). If we >go for a control, then we need to consider the unit. We can use a >fraction as well. See this series that puts in the foundation for that: >https://patchwork.linuxtv.org/cover/58857/ > >I am inclined to go with a control, since the semantics don't really >match ENUM_FRAMEINTERVALS/S_PARM. These ioctls still need to be supported >for legacy drivers. Open question: some drivers (mediatek, hva, coda) >require S_PARM(OUTPUT), some (venus) allow both S_PARM(CAPTURE) and >S_PARM(OUTPUT). I am inclined to allow both since this is not a CAPTURE >vs OUTPUT thing, it is global to both queues. > > 2) Interactions between OUTPUT and CAPTURE formats. > >The main problem is what to do if the capture sizeimage is too small >for the OUTPUT resolution when streaming starts. > >Proposal: width and height of S_FMT(OUTPUT) are used to >calculate a minimum sizeimage (app may request more). This is >driver-specific. (Is it? Or is this codec-specific?) > >V4L2_FMT_FLAG_FIXED_RESOLUTION is always set for codec formats >for the encoder (i.e. we don't support mid-stream resolution >changes for now) and V4L2_EVENT_SOURCE_CHANGE is not >supported. See https://patchwork.linuxtv.org/patch/56478/ for >the patch adding this flag. > >Of course, if we start to support mid-stream resolution >changes (or other changes that require a source change event), >then this flag should be dropped by the encoder driver and >documentation on how to handle the source change event should >be documented in the encoder spec. I prefer to postpone this >until we have an encoder than can actually do mid-stream >resolution changes. > >If sizeimage of the OUTPUT is too small for the CAPTURE >resolution and V4L2_EVENT_SOURCE_CHANGE is not supported, >then the second STREAMON (either CAPTURE or OUTPUT) will >return -ENOMEM since there is not enough memory to do the >encode. > >If V4L2_FMT_FLAG_FIXED_RESOLUTION is set (i.e. that should >be the case for all current encoders), then any bitrate controls >will be limited in range to what the current state (CAPTURE and >OUTPUT formats and frame rate) supports. > > - Stateless encoders? > > - Anything else? (I have a feeling I missed a codec-related topic, but > I can't find it in my mailbox) > > Regards, > > Hans signature.asc Description: PGP signature
