Re: [PATCH] media: stm32-dcmi: add power saving support

2018-06-11 Thread kbuild test robot
Hi Hugues,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.17 next-20180608]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Hugues-Fruchet/media-stm32-dcmi-add-power-saving-support/20180611-174016
base:   git://linuxtv.org/media_tree.git master
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=sparc64 

All errors (new ones prefixed by >>):

   drivers/media//platform/stm32/stm32-dcmi.c: In function 'dcmi_suspend':
   drivers/media//platform/stm32/stm32-dcmi.c:1886:2: error: implicit 
declaration of function 'pinctrl_pm_select_sleep_state' 
[-Werror=implicit-function-declaration]
 pinctrl_pm_select_sleep_state(dev);
 ^
   drivers/media//platform/stm32/stm32-dcmi.c: In function 'dcmi_resume':
>> drivers/media//platform/stm32/stm32-dcmi.c:1894:2: error: implicit 
>> declaration of function 'pinctrl_pm_select_default_state'; did you mean 
>> 'irq_set_default_host'? [-Werror=implicit-function-declaration]
 pinctrl_pm_select_default_state(dev);
 ^~~
 irq_set_default_host
   cc1: some warnings being treated as errors

vim +1894 drivers/media//platform/stm32/stm32-dcmi.c

  1879  
  1880  static __maybe_unused int dcmi_suspend(struct device *dev)
  1881  {
  1882  /* disable clock */
  1883  pm_runtime_force_suspend(dev);
  1884  
  1885  /* change pinctrl state */
> 1886  pinctrl_pm_select_sleep_state(dev);
  1887  
  1888  return 0;
  1889  }
  1890  
  1891  static __maybe_unused int dcmi_resume(struct device *dev)
  1892  {
  1893  /* restore pinctl default state */
> 1894  pinctrl_pm_select_default_state(dev);
  1895  
  1896  /* clock enable */
  1897  pm_runtime_force_resume(dev);
  1898  
  1899  return 0;
  1900  }
  1901  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip


Re: [PATCH] media: stm32-dcmi: add power saving support

2018-06-11 Thread kbuild test robot
Hi Hugues,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.17 next-20180608]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Hugues-Fruchet/media-stm32-dcmi-add-power-saving-support/20180611-174016
base:   git://linuxtv.org/media_tree.git master
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/media/platform/stm32/stm32-dcmi.c: In function 'dcmi_suspend':
>> drivers/media/platform/stm32/stm32-dcmi.c:1886:2: error: implicit 
>> declaration of function 'pinctrl_pm_select_sleep_state' 
>> [-Werror=implicit-function-declaration]
 pinctrl_pm_select_sleep_state(dev);
 ^
   drivers/media/platform/stm32/stm32-dcmi.c: In function 'dcmi_resume':
>> drivers/media/platform/stm32/stm32-dcmi.c:1894:2: error: implicit 
>> declaration of function 'pinctrl_pm_select_default_state' 
>> [-Werror=implicit-function-declaration]
 pinctrl_pm_select_default_state(dev);
 ^~~
   cc1: some warnings being treated as errors

vim +/pinctrl_pm_select_sleep_state +1886 
drivers/media/platform/stm32/stm32-dcmi.c

  1879  
  1880  static __maybe_unused int dcmi_suspend(struct device *dev)
  1881  {
  1882  /* disable clock */
  1883  pm_runtime_force_suspend(dev);
  1884  
  1885  /* change pinctrl state */
> 1886  pinctrl_pm_select_sleep_state(dev);
  1887  
  1888  return 0;
  1889  }
  1890  
  1891  static __maybe_unused int dcmi_resume(struct device *dev)
  1892  {
  1893  /* restore pinctl default state */
> 1894  pinctrl_pm_select_default_state(dev);
  1895  
  1896  /* clock enable */
  1897  pm_runtime_force_resume(dev);
  1898  
  1899  return 0;
  1900  }
  1901  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip