Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2018-03-13 Thread Nicolas Dufresne
Le mardi 13 mars 2018 à 21:09 -0400, Nicolas Dufresne a écrit : > > I've looked into this again. I have hit the same issue but with CPU > > to > > DRM, using DMABuf allocated from DRM Dumb buffers. In that case, > > using > > DMA_BUF_IOCTL_SYNC fixes the issues. > > > > This raises a lot of

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2018-03-13 Thread Nicolas Dufresne
Le mardi 13 mars 2018 à 20:44 -0400, Nicolas Dufresne a écrit : > Le mercredi 18 octobre 2017 à 11:34 +0300, Stanimir Varbanov a écrit > : > > > > On 10/17/2017 05:19 PM, Nicolas Dufresne wrote: > > > Le mardi 17 octobre 2017 à 13:14 +0300, Sakari Ailus a écrit : > > > > On Sun, Oct 15, 2017 at

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2018-03-13 Thread Nicolas Dufresne
Le mercredi 18 octobre 2017 à 11:34 +0300, Stanimir Varbanov a écrit : > > On 10/17/2017 05:19 PM, Nicolas Dufresne wrote: > > Le mardi 17 octobre 2017 à 13:14 +0300, Sakari Ailus a écrit : > > > On Sun, Oct 15, 2017 at 07:09:24PM -0400, Nicolas Dufresne wrote: > > > > Le dimanche 15 octobre 2017

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-18 Thread Stanimir Varbanov
On 10/17/2017 05:19 PM, Nicolas Dufresne wrote: > Le mardi 17 octobre 2017 à 13:14 +0300, Sakari Ailus a écrit : >> On Sun, Oct 15, 2017 at 07:09:24PM -0400, Nicolas Dufresne wrote: >>> Le dimanche 15 octobre 2017 à 23:40 +0300, Sakari Ailus a écrit : Hi Nicolas, On Tue, Oct 10,

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-17 Thread Nicolas Dufresne
Le mardi 17 octobre 2017 à 13:14 +0300, Sakari Ailus a écrit : > On Sun, Oct 15, 2017 at 07:09:24PM -0400, Nicolas Dufresne wrote: > > Le dimanche 15 octobre 2017 à 23:40 +0300, Sakari Ailus a écrit : > > > Hi Nicolas, > > > > > > On Tue, Oct 10, 2017 at 11:40:10AM -0400, Nicolas Dufresne wrote:

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-17 Thread Sakari Ailus
On Sun, Oct 15, 2017 at 07:09:24PM -0400, Nicolas Dufresne wrote: > Le dimanche 15 octobre 2017 à 23:40 +0300, Sakari Ailus a écrit : > > Hi Nicolas, > > > > On Tue, Oct 10, 2017 at 11:40:10AM -0400, Nicolas Dufresne wrote: > > > Le mardi 29 août 2017 à 14:26 +0300, Stanimir Varbanov a écrit : >

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-16 Thread Sakari Ailus
On Sun, Oct 15, 2017 at 07:09:24PM -0400, Nicolas Dufresne wrote: > Le dimanche 15 octobre 2017 à 23:40 +0300, Sakari Ailus a écrit : > > Hi Nicolas, > > > > On Tue, Oct 10, 2017 at 11:40:10AM -0400, Nicolas Dufresne wrote: > > > Le mardi 29 août 2017 à 14:26 +0300, Stanimir Varbanov a écrit : >

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-15 Thread Nicolas Dufresne
Le dimanche 15 octobre 2017 à 23:40 +0300, Sakari Ailus a écrit : > Hi Nicolas, > > On Tue, Oct 10, 2017 at 11:40:10AM -0400, Nicolas Dufresne wrote: > > Le mardi 29 août 2017 à 14:26 +0300, Stanimir Varbanov a écrit : > > > Currently videobuf2-dma-sg checks for dma direction for > > > every

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-15 Thread Sakari Ailus
Hi Nicolas, On Tue, Oct 10, 2017 at 11:40:10AM -0400, Nicolas Dufresne wrote: > Le mardi 29 août 2017 à 14:26 +0300, Stanimir Varbanov a écrit : > > Currently videobuf2-dma-sg checks for dma direction for > > every single page and videobuf2-dc lacks any dma direction > > checks and calls

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-10 Thread Nicolas Dufresne
Le mardi 29 août 2017 à 14:26 +0300, Stanimir Varbanov a écrit : > Currently videobuf2-dma-sg checks for dma direction for > every single page and videobuf2-dc lacks any dma direction > checks and calls set_page_dirty_lock unconditionally. > > Thus unify and align the invocations of

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-10 Thread Sakari Ailus
On Tue, Oct 10, 2017 at 10:01:36AM +0200, Marek Szyprowski wrote: > Hi Stanimir, > > On 2017-10-10 09:42, Stanimir Varbanov wrote: > > Marek, > > > > Any comments? > > Oh, I thought that this one has been already merged. If not (yet), > here is my ack. > > > On 08/29/2017 02:26 PM, Stanimir

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-10 Thread Marek Szyprowski
Hi Stanimir, On 2017-10-10 09:42, Stanimir Varbanov wrote: Marek, Any comments? Oh, I thought that this one has been already merged. If not (yet), here is my ack. On 08/29/2017 02:26 PM, Stanimir Varbanov wrote: Currently videobuf2-dma-sg checks for dma direction for every single page and

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-10 Thread Stanimir Varbanov
Marek, Any comments? On 08/29/2017 02:26 PM, Stanimir Varbanov wrote: > Currently videobuf2-dma-sg checks for dma direction for > every single page and videobuf2-dc lacks any dma direction > checks and calls set_page_dirty_lock unconditionally. > > Thus unify and align the invocations of