On Mon, 2016-09-19 at 10:00 +0200, Hans Verkuil wrote:
> Fix smatch error:
>
> media-git/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c:100
> mtk_mdp_vpu_send_msg() error: double unlock 'mutex:&ctx->mdp_dev->vpulock'
>
> Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
Reviewed-by: Minghsiu Tsai <minghsiu.t...@mediatek.com>
> ---
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c
> b/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c
> index 39188e5..4893825 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c
> @@ -92,11 +92,9 @@ static int mtk_mdp_vpu_send_msg(void *msg, int len, struct
> mtk_mdp_vpu *vpu,
>
> mutex_lock(&ctx->mdp_dev->vpulock);
> err = vpu_ipi_send(vpu->pdev, (enum ipi_id)id, msg, len);
> - if (err) {
> - mutex_unlock(&ctx->mdp_dev->vpulock);
> + if (err)
> dev_err(&ctx->mdp_dev->pdev->dev,
> "vpu_ipi_send fail status %d\n", err);
> - }
> mutex_unlock(&ctx->mdp_dev->vpulock);
>
> return err;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
