Re: [PATCH] pxa_camera: merge soc_mediabus.c into pxa_camera.c

2016-09-23 Thread Robert Jarzmik
Hans Verkuil writes: >> Hi Hans, >> >> I wonder why you chose to copy-paste this code instead of adding in the >> Kconfig >> a "depends on !SOC_CAMERA". Any specific reason ? As this will have to be >> dealt >> with later anyway as you pointed out earlier, this format

Re: [PATCH] pxa_camera: merge soc_mediabus.c into pxa_camera.c

2016-09-21 Thread Hans Verkuil
On 09/21/2016 08:37 AM, Robert Jarzmik wrote: > Hans Verkuil writes: > >> Linking soc_mediabus into this driver causes multiple definition linker >> warnings >> if soc_camera is also enabled: >> >> >>

Re: [PATCH] pxa_camera: merge soc_mediabus.c into pxa_camera.c

2016-09-21 Thread Robert Jarzmik
Hans Verkuil writes: > Linking soc_mediabus into this driver causes multiple definition linker > warnings > if soc_camera is also enabled: > > > drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_image_size+0x0): > multiple definition of