Re: [PATCH] sound/usb: Relax urb data alignment restriciton for HVR-950Q only

2009-12-10 Thread John S Gruber
After reviewing the patch as well as the spec, your change looks pretty reasonable (aside from the fact that you need the other USB IDs).  It seems pretty clear that the au0828 violates the spec, but the spec does indicate how to handle that case, which is what your code addresses. I think

Re: [PATCH] sound/usb: Relax urb data alignment restriciton for HVR-950Q only

2009-12-10 Thread Devin Heitmueller
Hello John, On Thu, Dec 10, 2009 at 8:38 PM, John S Gruber johnsgru...@gmail.com wrote: I think you found something in the specification I haven't found. What did you see that indicated how to deal with equipment misbehaving in this way? I'm referring to section 2.3.2.3 of Universal Serial Bus

Re: [PATCH] sound/usb: Relax urb data alignment restriciton for HVR-950Q only

2009-12-10 Thread John S Gruber
On Thu, Dec 10, 2009 at 8:49 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: Hello John, On Thu, Dec 10, 2009 at 8:38 PM, John S Gruber johnsgru...@gmail.com wrote: I think you found something in the specification I haven't found. What did you see that indicated how to deal with

Re: [PATCH] sound/usb: Relax urb data alignment restriciton for HVR-950Q only

2009-12-07 Thread Devin Heitmueller
On Fri, Dec 4, 2009 at 6:26 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: On Fri, Dec 4, 2009 at 5:15 PM, John S Gruber johnsgru...@gmail.com wrote: Addressing audio quality problem. In sound/usb/usbaudio.c, for the Hauppage HVR-950Q only, change retire_capture_urb to copy the

Re: [PATCH] sound/usb: Relax urb data alignment restriciton for HVR-950Q only

2009-12-04 Thread Devin Heitmueller
On Fri, Dec 4, 2009 at 5:15 PM, John S Gruber johnsgru...@gmail.com wrote: Addressing audio quality problem. In sound/usb/usbaudio.c, for the Hauppage HVR-950Q only, change retire_capture_urb to copy the entire byte stream while still counting entire audio frames. urbs unaligned on channel