Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

2018-03-02 Thread Philipp Zabel
Hi Fabio, On Thu, 2018-03-01 at 13:43 -0300, Fabio Estevam wrote: > On Thu, Mar 1, 2018 at 1:27 PM, Philipp Zabel wrote: > > > Oh, this only works for csi ports that have pinctrl in their csi port > > node, like: > > > > _csi0 { > > pinctrl-names = "default"; >

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

2018-03-01 Thread Fabio Estevam
On Thu, Mar 1, 2018 at 1:27 PM, Philipp Zabel wrote: > Oh, this only works for csi ports that have pinctrl in their csi port > node, like: > > _csi0 { > pinctrl-names = "default"; > pinctrl-0 = <_ipu1_csi0>; > }; This is the case for imx6qdl-sabresd.dtsi

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

2018-03-01 Thread Fabio Estevam
Steve, Phiipp, On Thu, Mar 1, 2018 at 1:02 PM, Fabio Estevam wrote: > So imx_csi_probe() does not succeed anymore since > devm_pinctrl_get_select_default() always fails. > > Not sure I understand the comments that explain the need for pinctrl > handling inside the driver. >

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

2018-03-01 Thread Philipp Zabel
On Thu, 2018-03-01 at 13:02 -0300, Fabio Estevam wrote: > On Thu, Mar 1, 2018 at 1:09 AM, Gustavo A. R. Silva > wrote: > > Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. > > The proper pointer to be passed as argument is pinctrl > > instead of priv->vdev. > > > >

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

2018-03-01 Thread Fabio Estevam
On Thu, Mar 1, 2018 at 1:09 AM, Gustavo A. R. Silva wrote: > Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. > The proper pointer to be passed as argument is pinctrl > instead of priv->vdev. > > This issue was detected with the help of Coccinelle. > > Fixes:

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

2018-03-01 Thread Philipp Zabel
On Wed, 2018-02-28 at 22:09 -0600, Gustavo A. R. Silva wrote: > Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. > The proper pointer to be passed as argument is pinctrl > instead of priv->vdev. > > This issue was detected with the help of Coccinelle. > > Fixes: 52e17089d185 ("media: imx: