Re: [PATCH 1/6] v4l: ti-vpe: Create a vpdma helper library

2013-08-21 Thread Archit Taneja
Hi, On Tuesday 20 August 2013 07:26 PM, Laurent Pinchart wrote: Hi Archit, On Tuesday 20 August 2013 18:46:38 Archit Taneja wrote: On Tuesday 20 August 2013 05:09 PM, Laurent Pinchart wrote: snip +static int vpdma_load_firmware(struct vpdma_data *vpdma) +{ + int r; + struct

Re: [PATCH 1/6] v4l: ti-vpe: Create a vpdma helper library

2013-08-20 Thread Laurent Pinchart
Hi Archit, On Wednesday 14 August 2013 16:27:57 Archit Taneja wrote: On Friday 09 August 2013 03:34 AM, Laurent Pinchart wrote: On Friday 02 August 2013 19:33:38 Archit Taneja wrote: The primary function of VPDMA is to move data between external memory and internal processing modules(in

Re: [PATCH 1/6] v4l: ti-vpe: Create a vpdma helper library

2013-08-20 Thread Archit Taneja
On Tuesday 20 August 2013 05:09 PM, Laurent Pinchart wrote: Hi Archit, On Wednesday 14 August 2013 16:27:57 Archit Taneja wrote: On Friday 09 August 2013 03:34 AM, Laurent Pinchart wrote: On Friday 02 August 2013 19:33:38 Archit Taneja wrote: The primary function of VPDMA is to move data

Re: [PATCH 1/6] v4l: ti-vpe: Create a vpdma helper library

2013-08-20 Thread Archit Taneja
Hi Laurent, On Tuesday 20 August 2013 05:09 PM, Laurent Pinchart wrote: snip +static int vpdma_load_firmware(struct vpdma_data *vpdma) +{ + int r; + struct device *dev = vpdma-pdev-dev; + + r = request_firmware_nowait(THIS_MODULE, 1, + (const char *)

Re: [PATCH 1/6] v4l: ti-vpe: Create a vpdma helper library

2013-08-20 Thread Laurent Pinchart
Hi Archit, On Tuesday 20 August 2013 18:46:38 Archit Taneja wrote: On Tuesday 20 August 2013 05:09 PM, Laurent Pinchart wrote: snip +static int vpdma_load_firmware(struct vpdma_data *vpdma) +{ +int r; +struct device *dev = vpdma-pdev-dev; + +r =

Re: [PATCH 1/6] v4l: ti-vpe: Create a vpdma helper library

2013-08-14 Thread Archit Taneja
On Friday 09 August 2013 03:05 AM, Laurent Pinchart wrote: Hi Archit, On Monday 05 August 2013 16:56:46 Archit Taneja wrote: On Monday 05 August 2013 01:43 PM, Tomi Valkeinen wrote: On 02/08/13 17:03, Archit Taneja wrote: +struct vpdma_data_format vpdma_yuv_fmts[] = { +

Re: [PATCH 1/6] v4l: ti-vpe: Create a vpdma helper library

2013-08-14 Thread Archit Taneja
On Friday 09 August 2013 03:34 AM, Laurent Pinchart wrote: Hi Archit, Thank you for the patch. On Friday 02 August 2013 19:33:38 Archit Taneja wrote: The primary function of VPDMA is to move data between external memory and internal processing modules(in our case, VPE) that source or sink

Re: [PATCH 1/6] v4l: ti-vpe: Create a vpdma helper library

2013-08-08 Thread Laurent Pinchart
Hi Archit, On Monday 05 August 2013 16:56:46 Archit Taneja wrote: On Monday 05 August 2013 01:43 PM, Tomi Valkeinen wrote: On 02/08/13 17:03, Archit Taneja wrote: +struct vpdma_data_format vpdma_yuv_fmts[] = { + [VPDMA_DATA_FMT_Y444] = { + .data_type = DATA_TYPE_Y444, +

Re: [PATCH 1/6] v4l: ti-vpe: Create a vpdma helper library

2013-08-08 Thread Laurent Pinchart
Hi Archit, Thank you for the patch. On Friday 02 August 2013 19:33:38 Archit Taneja wrote: The primary function of VPDMA is to move data between external memory and internal processing modules(in our case, VPE) that source or sink data. VPDMA is capable of buffering this data and then

Re: [PATCH 1/6] v4l: ti-vpe: Create a vpdma helper library

2013-08-05 Thread Tomi Valkeinen
Hi, On 02/08/13 17:03, Archit Taneja wrote: +struct vpdma_data_format vpdma_yuv_fmts[] = { + [VPDMA_DATA_FMT_Y444] = { + .data_type = DATA_TYPE_Y444, + .depth = 8, + }, This, and all the other tables, should probably be consts? +static void

Re: [PATCH 1/6] v4l: ti-vpe: Create a vpdma helper library

2013-08-05 Thread Archit Taneja
On Monday 05 August 2013 01:43 PM, Tomi Valkeinen wrote: Hi, On 02/08/13 17:03, Archit Taneja wrote: +struct vpdma_data_format vpdma_yuv_fmts[] = { + [VPDMA_DATA_FMT_Y444] = { + .data_type = DATA_TYPE_Y444, + .depth = 8, + }, This, and

Re: [PATCH 1/6] v4l: ti-vpe: Create a vpdma helper library

2013-08-05 Thread Tomi Valkeinen
On 05/08/13 14:26, Archit Taneja wrote: On Monday 05 August 2013 01:43 PM, Tomi Valkeinen wrote: +/* + * submit a list of DMA descriptors to the VPE VPDMA, do not wait for completion + */ +int vpdma_submit_descs(struct vpdma_data *vpdma, struct vpdma_desc_list *list) +{ +/* we always