Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-09-07 Thread Antti Palosaari
On 08/01/2011 05:24 AM, Mauro Carvalho Chehab wrote: Em 31-07-2011 22:22, Antti Palosaari escreveu: On 08/01/2011 03:46 AM, Mauro Carvalho Chehab wrote: One bad thing I noticed with the API is that it calls adap-props.frontend_attach(adap) several times, instead of just one, without even

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-09-07 Thread Michael Krufky
On Wed, Sep 7, 2011 at 12:51 PM, Antti Palosaari cr...@iki.fi wrote: On 08/01/2011 05:24 AM, Mauro Carvalho Chehab wrote: Em 31-07-2011 22:22, Antti Palosaari escreveu: On 08/01/2011 03:46 AM, Mauro Carvalho Chehab wrote: One bad thing I noticed with the API is that it calls

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-09-07 Thread Michael Krufky
On Wed, Sep 7, 2011 at 1:41 PM, Michael Krufky mkru...@kernellabs.com wrote: On Wed, Sep 7, 2011 at 12:51 PM, Antti Palosaari cr...@iki.fi wrote: On 08/01/2011 05:24 AM, Mauro Carvalho Chehab wrote: Em 31-07-2011 22:22, Antti Palosaari escreveu: On 08/01/2011 03:46 AM, Mauro Carvalho Chehab

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-09-07 Thread Michael Krufky
On Wed, Sep 7, 2011 at 12:51 PM, Antti Palosaari cr...@iki.fi wrote: Also .num_frontends can be removed after that, since DVB USB will just loop through 0 to MAX FEs and register all FEs found (fe pointer !NULL). We need to keep .num_frontends and .num_adapters both, because my next change to

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-09-07 Thread Antti Palosaari
On 09/07/2011 08:45 PM, Michael Krufky wrote: On Wed, Sep 7, 2011 at 1:41 PM, Michael Krufkymkru...@kernellabs.com wrote: On Wed, Sep 7, 2011 at 12:51 PM, Antti Palosaaricr...@iki.fi wrote: On 08/01/2011 05:24 AM, Mauro Carvalho Chehab wrote: Em 31-07-2011 22:22, Antti Palosaari escreveu:

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-09-07 Thread Michael Krufky
On Wed, Sep 7, 2011 at 2:20 PM, Antti Palosaari cr...@iki.fi wrote: On 09/07/2011 08:45 PM, Michael Krufky wrote: On Wed, Sep 7, 2011 at 1:41 PM, Michael Krufkymkru...@kernellabs.com  wrote: On Wed, Sep 7, 2011 at 12:51 PM, Antti Palosaaricr...@iki.fi  wrote: On 08/01/2011 05:24 AM, Mauro

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-09-07 Thread Antti Palosaari
On 09/07/2011 09:36 PM, Michael Krufky wrote: On Wed, Sep 7, 2011 at 2:20 PM, Antti Palosaaricr...@iki.fi wrote: Yes, I now saw when looked latest anysee driver that you moved .streaming_ctrl(), .frontend_attach() and .tuner_attach() to frontend property. OK, it is not then relevant anymore

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-31 Thread Patrick Boettcher
On Thursday 28 July 2011 00:23:06 Antti Palosaari wrote: On 07/28/2011 01:07 AM, Malcolm Priestley wrote: On Wed, 2011-07-27 at 16:06 -0300, Mauro Carvalho Chehab wrote: Em 25-07-2011 21:17, Antti Palosaari escreveu: Signed-off-by: Antti Palosaaricr...@iki.fi +adap-fe[i] =

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-31 Thread Mauro Carvalho Chehab
Em 27-07-2011 16:49, Antti Palosaari escreveu: On 07/27/2011 10:06 PM, Mauro Carvalho Chehab wrote: +for (i = 0; i= x; i++) { +ret = adap-props.frontend_attach(adap); +if (ret || adap-fe[i] == NULL) { +/* only print error when there is no FE at all */ +

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-31 Thread Antti Palosaari
On 08/01/2011 03:46 AM, Mauro Carvalho Chehab wrote: Em 27-07-2011 16:49, Antti Palosaari escreveu: On 07/27/2011 10:06 PM, Mauro Carvalho Chehab wrote: +for (i = 0; i= x; i++) { +ret = adap-props.frontend_attach(adap); +if (ret || adap-fe[i] == NULL) { +/*

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-31 Thread Antti Palosaari
On 07/31/2011 09:28 PM, Patrick Boettcher wrote: On Thursday 28 July 2011 00:23:06 Antti Palosaari wrote: * We should have priv at the very first. No priv for FW DL example. * Remote keytable should be property of certain device model not adapter * There should be way to set count of adapter

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-31 Thread Mauro Carvalho Chehab
Em 31-07-2011 22:22, Antti Palosaari escreveu: On 08/01/2011 03:46 AM, Mauro Carvalho Chehab wrote: Em 27-07-2011 16:49, Antti Palosaari escreveu: On 07/27/2011 10:06 PM, Mauro Carvalho Chehab wrote: +for (i = 0; i= x; i++) { +ret = adap-props.frontend_attach(adap); +if

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-27 Thread Mauro Carvalho Chehab
Em 25-07-2011 21:17, Antti Palosaari escreveu: Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb/dvb-usb/dvb-usb-dvb.c | 85 +++--- drivers/media/dvb/dvb-usb/dvb-usb-init.c |4 ++ drivers/media/dvb/dvb-usb/dvb-usb.h | 11 +++- 3 files

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-27 Thread Antti Palosaari
On 07/27/2011 10:06 PM, Mauro Carvalho Chehab wrote: +for (i = 0; i= x; i++) { +ret = adap-props.frontend_attach(adap); +if (ret || adap-fe[i] == NULL) { +/* only print error when there is no FE at all */ +if (i == 0) +err(no frontend

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-27 Thread Mauro Carvalho Chehab
Em 27-07-2011 16:49, Antti Palosaari escreveu: On 07/27/2011 10:06 PM, Mauro Carvalho Chehab wrote: +for (i = 0; i= x; i++) { +ret = adap-props.frontend_attach(adap); +if (ret || adap-fe[i] == NULL) { +/* only print error when there is no FE at all */ +

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-27 Thread Antti Palosaari
On 07/27/2011 11:06 PM, Mauro Carvalho Chehab wrote: Em 27-07-2011 16:49, Antti Palosaari escreveu: On 07/27/2011 10:06 PM, Mauro Carvalho Chehab wrote: +for (i = 0; i= x; i++) { +ret = adap-props.frontend_attach(adap); +if (ret || adap-fe[i] == NULL) { +/*

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-27 Thread Malcolm Priestley
On Wed, 2011-07-27 at 16:06 -0300, Mauro Carvalho Chehab wrote: Em 25-07-2011 21:17, Antti Palosaari escreveu: Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb/dvb-usb/dvb-usb-dvb.c | 85 +++--- drivers/media/dvb/dvb-usb/dvb-usb-init.c |

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-27 Thread Antti Palosaari
On 07/28/2011 01:07 AM, Malcolm Priestley wrote: On Wed, 2011-07-27 at 16:06 -0300, Mauro Carvalho Chehab wrote: Em 25-07-2011 21:17, Antti Palosaari escreveu: Signed-off-by: Antti Palosaaricr...@iki.fi +adap-fe[i] = NULL; +/* In error case, do not try register more