Re: [PATCH 3/6] [media] s5p-mfc: Core support for MFC v7

2013-06-18 Thread Sachin Kamat
Hi Arun, On 18 June 2013 11:25, Arun Kumar K arunkk.sams...@gmail.com wrote: Hi Sachin, On Tue, Jun 18, 2013 at 10:56 AM, Sachin Kamat sachin.ka...@linaro.org wrote: On 18 June 2013 10:21, Arun Kumar K arunkk.sams...@gmail.com wrote: Hi Kamil, Thank you for the review. #define

Re: [PATCH 3/6] [media] s5p-mfc: Core support for MFC v7

2013-06-18 Thread Arun Kumar K
Hi Sachin, On Tue, Jun 18, 2013 at 11:42 AM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Arun, On 18 June 2013 11:25, Arun Kumar K arunkk.sams...@gmail.com wrote: Hi Sachin, On Tue, Jun 18, 2013 at 10:56 AM, Sachin Kamat sachin.ka...@linaro.org wrote: On 18 June 2013 10:21, Arun

RE: [PATCH 3/6] [media] s5p-mfc: Core support for MFC v7

2013-06-18 Thread Kamil Debski
Hi Arun, Sachin, -Original Message- From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: Tuesday, June 18, 2013 7:27 AM To: Arun Kumar K Cc: Kamil Debski; Arun Kumar K; LMML; jtp.p...@samsung.com; Sylwester Nawrocki; avnd.ki...@samsung.com Subject: Re: [PATCH 3/6] [media] s5p

RE: [PATCH 3/6] [media] s5p-mfc: Core support for MFC v7

2013-06-17 Thread Kamil Debski
Hi Arun, I have read your patches. They seem alright, I back comments made by Hans and Sylwester. I have one question, which follows inline. Best wishes, -- Kamil Debski Linux Kernel Developer Samsung RD Institute Poland -Original Message- From: Arun Kumar K

Re: [PATCH 3/6] [media] s5p-mfc: Core support for MFC v7

2013-06-17 Thread Arun Kumar K
Hi Kamil, Thank you for the review. #define IS_MFCV6(dev)(dev-variant-version = 0x60 ? 1 : 0) +#define IS_MFCV7(dev)(dev-variant-version = 0x70 ? 1 : 0) According to this, MFC v7 is also detected as MFC v6. Was this intended? Yes this was intentional as

Re: [PATCH 3/6] [media] s5p-mfc: Core support for MFC v7

2013-06-17 Thread Sachin Kamat
On 18 June 2013 10:21, Arun Kumar K arunkk.sams...@gmail.com wrote: Hi Kamil, Thank you for the review. #define IS_MFCV6(dev)(dev-variant-version = 0x60 ? 1 : 0) +#define IS_MFCV7(dev)(dev-variant-version = 0x70 ? 1 : 0) According to this, MFC v7 is also

Re: [PATCH 3/6] [media] s5p-mfc: Core support for MFC v7

2013-06-17 Thread Arun Kumar K
Hi Sachin, On Tue, Jun 18, 2013 at 10:56 AM, Sachin Kamat sachin.ka...@linaro.org wrote: On 18 June 2013 10:21, Arun Kumar K arunkk.sams...@gmail.com wrote: Hi Kamil, Thank you for the review. #define IS_MFCV6(dev)(dev-variant-version = 0x60 ? 1 : 0) +#define