Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-04-29 Thread Laurent Pinchart
Hi Scott, Sorry for the (very) late reply. On Sunday 07 April 2013 18:35:54 Scott Jiang wrote: Hi Laurent, +struct mt9m114_reg { + u16 reg; + u32 val; + int width; +}; + +enum { + MT9M114_QVGA, + MT9M114_VGA, + MT9M114_WVGA,

Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-04-07 Thread Scott Jiang
Hi Laurent, +struct mt9m114_reg { + u16 reg; + u32 val; + int width; +}; + +enum { + MT9M114_QVGA, + MT9M114_VGA, + MT9M114_WVGA, + MT9M114_720P, +}; This is the part I don't like. Instead of hardcoding 4 different

Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-04-04 Thread Laurent Pinchart
Hi Scott, On Monday 01 April 2013 17:33:02 Scott Jiang wrote: Hi Laurent, +struct mt9m114_reg { + u16 reg; + u32 val; + int width; +}; + +enum { + MT9M114_QVGA, + MT9M114_VGA, + MT9M114_WVGA, + MT9M114_720P, +}; This is the

Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-04-01 Thread Scott Jiang
Hi Laurent, +struct mt9m114_reg { + u16 reg; + u32 val; + int width; +}; + +enum { + MT9M114_QVGA, + MT9M114_VGA, + MT9M114_WVGA, + MT9M114_720P, +}; This is the part I don't like. Instead of hardcoding 4 different resolutions and using

Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-03-28 Thread Scott Jiang
This driver support parallel data output mode and QVGA/VGA/WVGA/720P resolution. You can select YCbCr and RGB565 output format. What host bridge do you use this driver with ? I only tested with blackfin. + */ [snip] +struct mt9m114_reg { + u16 reg; + u32 val; + int

Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-03-28 Thread Laurent Pinchart
Hi Scott, On Thursday 28 March 2013 16:29:30 Scott Jiang wrote: This driver support parallel data output mode and QVGA/VGA/WVGA/720P resolution. You can select YCbCr and RGB565 output format. What host bridge do you use this driver with ? I only tested with blackfin. + */

Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-03-26 Thread Laurent Pinchart
Hi Scott, Thank you for the patch. On Friday 18 January 2013 17:00:44 Scott Jiang wrote: This driver support parallel data output mode and QVGA/VGA/WVGA/720P resolution. You can select YCbCr and RGB565 output format. What host bridge do you use this driver with ? Signed-off-by: Scott Jiang

Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-03-18 Thread Mauro Carvalho Chehab
Hi Scott, Em Fri, 18 Jan 2013 17:00:44 -0500 Scott Jiang scott.jiang.li...@gmail.com escreveu: This driver support parallel data output mode and QVGA/VGA/WVGA/720P resolution. You can select YCbCr and RGB565 output format. There are a few checkpatch warnings, due to recent API changes at