Re: [PATCH for v3.6] VIDIOC_ENUM_FREQ_BANDS fix

2012-08-02 Thread Hans Verkuil
On Wed August 1 2012 22:41:16 Rémi Denis-Courmont wrote:
 Le mercredi 1 août 2012 22:52:46 Hans Verkuil, vous avez écrit :
  When VIDIOC_ENUM_FREQ_BANDS is called for a driver that doesn't supply an
  enum_freq_bands op, then it will fall back to reporting a single freq band
  based on information from g_tuner or g_modulator.
 
 By the way...
 
 Isn't V4L2_TUNER_CAP_FREQ_BANDS expected to tell whether the driver can 
 enumerate bands?

Yes. And it is set as well in this fallback case.

 Why is there a need for fallback implementation?

The main reason is that struct v4l2_frequency_band also returns the modulation
of the frequency band. For all existing drivers (except radio-cadet, which
now implements enum_freq_bands) this can be deduced by the type of device node
that's used (/dev/radioX means FM, /dev/videoX or vbiX means VSB). While the
application could do the same we decided it was more consistent if the V4L2
core does that for the application. It was trivial to implement.

So apps will benefit, and only drivers that actually have more than one
frequency band need to go to the trouble of implementing enum_freq_bands.

Regards,

Hans
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH for v3.6] VIDIOC_ENUM_FREQ_BANDS fix

2012-08-01 Thread Rémi Denis-Courmont
Le mercredi 1 août 2012 22:52:46 Hans Verkuil, vous avez écrit :
 When VIDIOC_ENUM_FREQ_BANDS is called for a driver that doesn't supply an
 enum_freq_bands op, then it will fall back to reporting a single freq band
 based on information from g_tuner or g_modulator.

By the way...

Isn't V4L2_TUNER_CAP_FREQ_BANDS expected to tell whether the driver can 
enumerate bands? Why is there a need for fallback implementation?

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html