Re: [PATCH v11 00/21] V4L2 clock and asynchronous probing
On Fri 14 June 2013 21:08:10 Guennadi Liakhovetski wrote:
v11 of the V4L2 clock helper and asynchronous probing patch set.
Functionally identical to v10, only differences are a couple of comment
lines and one renamed struct field - as requested by respectable
reviewers :)
Only patches #15, 16 and 18 changed.
Thanks for posting the patch adding documentation! Much appreciated.
As a result I give my ack for this patch series:
Acked-by: Hans Verkuil hans.verk...@cisco.com
Regards,
Hans
Guennadi Liakhovetski (21):
soc-camera: move common code to soc_camera.c
soc-camera: add host clock callbacks to start and stop the master
clock
pxa-camera: move interface activation and deactivation to clock
callbacks
omap1-camera: move interface activation and deactivation to clock
callbacks
atmel-isi: move interface activation and deactivation to clock
callbacks
mx3-camera: move interface activation and deactivation to clock
callbacks
mx2-camera: move interface activation and deactivation to clock
callbacks
mx1-camera: move interface activation and deactivation to clock
callbacks
sh-mobile-ceu-camera: move interface activation and deactivation to
clock callbacks
soc-camera: make .clock_{start,stop} compulsory, .add / .remove
optional
soc-camera: don't attach the client to the host during probing
sh-mobile-ceu-camera: add primitive OF support
sh-mobile-ceu-driver: support max width and height in DT
V4L2: add temporary clock helpers
V4L2: add a device pointer to struct v4l2_subdev
V4L2: support asynchronous subdevice registration
soc-camera: switch I2C subdevice drivers to use v4l2-clk
soc-camera: add V4L2-async support
sh_mobile_ceu_camera: add asynchronous subdevice probing support
imx074: support asynchronous probing
ARM: shmobile: convert ap4evb to asynchronously register camera
subdevices
.../devicetree/bindings/media/sh_mobile_ceu.txt| 18 +
arch/arm/mach-shmobile/board-ap4evb.c | 103 ++--
arch/arm/mach-shmobile/clock-sh7372.c |1 +
drivers/media/i2c/soc_camera/imx074.c | 32 +-
drivers/media/i2c/soc_camera/mt9m001.c | 17 +-
drivers/media/i2c/soc_camera/mt9m111.c | 20 +-
drivers/media/i2c/soc_camera/mt9t031.c | 19 +-
drivers/media/i2c/soc_camera/mt9t112.c | 25 +-
drivers/media/i2c/soc_camera/mt9v022.c | 17 +-
drivers/media/i2c/soc_camera/ov2640.c | 19 +-
drivers/media/i2c/soc_camera/ov5642.c | 20 +-
drivers/media/i2c/soc_camera/ov6650.c | 17 +-
drivers/media/i2c/soc_camera/ov772x.c | 15 +-
drivers/media/i2c/soc_camera/ov9640.c | 17 +-
drivers/media/i2c/soc_camera/ov9640.h |1 +
drivers/media/i2c/soc_camera/ov9740.c | 18 +-
drivers/media/i2c/soc_camera/rj54n1cb0c.c | 17 +-
drivers/media/i2c/soc_camera/tw9910.c | 24 +-
drivers/media/platform/soc_camera/atmel-isi.c | 38 +-
drivers/media/platform/soc_camera/mx1_camera.c | 48 +-
drivers/media/platform/soc_camera/mx2_camera.c | 41 +-
drivers/media/platform/soc_camera/mx3_camera.c | 44 +-
drivers/media/platform/soc_camera/omap1_camera.c | 41 +-
drivers/media/platform/soc_camera/pxa_camera.c | 46 +-
.../platform/soc_camera/sh_mobile_ceu_camera.c | 243 +--
drivers/media/platform/soc_camera/sh_mobile_csi2.c | 153 +++--
drivers/media/platform/soc_camera/soc_camera.c | 707
+---
.../platform/soc_camera/soc_camera_platform.c |2 +-
drivers/media/v4l2-core/Makefile |3 +-
drivers/media/v4l2-core/v4l2-async.c | 280
drivers/media/v4l2-core/v4l2-clk.c | 242 +++
drivers/media/v4l2-core/v4l2-common.c |2 +
include/media/sh_mobile_ceu.h |2 +
include/media/sh_mobile_csi2.h |2 +-
include/media/soc_camera.h | 39 +-
include/media/v4l2-async.h | 105 +++
include/media/v4l2-clk.h | 54 ++
include/media/v4l2-subdev.h| 10 +
38 files changed, 2035 insertions(+), 467 deletions(-)
create mode 100644 Documentation/devicetree/bindings/media/sh_mobile_ceu.txt
create mode 100644 drivers/media/v4l2-core/v4l2-async.c
create mode 100644 drivers/media/v4l2-core/v4l2-clk.c
create mode 100644 include/media/v4l2-async.h
create mode 100644 include/media/v4l2-clk.h
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v11 00/21] V4L2 clock and asynchronous probing
On Fri June 14 2013 22:45:15 Guennadi Liakhovetski wrote: Hi Laurent On Fri, 14 Jun 2013, Laurent Pinchart wrote: Hi Guennadi, Thank you for the patches. On Friday 14 June 2013 21:08:10 Guennadi Liakhovetski wrote: v11 of the V4L2 clock helper and asynchronous probing patch set. Functionally identical to v10, only differences are a couple of comment lines and one renamed struct field - as requested by respectable reviewers :) Only patches #15, 16 and 18 changed. [snip] .../devicetree/bindings/media/sh_mobile_ceu.txt| 18 + Documentation/video4linux/v4l2-framework.txt is missing :-) I know. I will add it as soon as these patches are in. Can you please post a first version earlier? I am hesitant to Ack the series without knowing that there is at least a first version of the documentation posted. We have had bad experiences in the past with code being committed and no documentation. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v11 00/21] V4L2 clock and asynchronous probing
Hi Guennadi, Thank you for the patches. On Friday 14 June 2013 21:08:10 Guennadi Liakhovetski wrote: v11 of the V4L2 clock helper and asynchronous probing patch set. Functionally identical to v10, only differences are a couple of comment lines and one renamed struct field - as requested by respectable reviewers :) Only patches #15, 16 and 18 changed. [snip] .../devicetree/bindings/media/sh_mobile_ceu.txt| 18 + Documentation/video4linux/v4l2-framework.txt is missing :-) arch/arm/mach-shmobile/board-ap4evb.c | 103 ++-- arch/arm/mach-shmobile/clock-sh7372.c |1 + drivers/media/i2c/soc_camera/imx074.c | 32 +- drivers/media/i2c/soc_camera/mt9m001.c | 17 +- drivers/media/i2c/soc_camera/mt9m111.c | 20 +- drivers/media/i2c/soc_camera/mt9t031.c | 19 +- drivers/media/i2c/soc_camera/mt9t112.c | 25 +- drivers/media/i2c/soc_camera/mt9v022.c | 17 +- drivers/media/i2c/soc_camera/ov2640.c | 19 +- drivers/media/i2c/soc_camera/ov5642.c | 20 +- drivers/media/i2c/soc_camera/ov6650.c | 17 +- drivers/media/i2c/soc_camera/ov772x.c | 15 +- drivers/media/i2c/soc_camera/ov9640.c | 17 +- drivers/media/i2c/soc_camera/ov9640.h |1 + drivers/media/i2c/soc_camera/ov9740.c | 18 +- drivers/media/i2c/soc_camera/rj54n1cb0c.c | 17 +- drivers/media/i2c/soc_camera/tw9910.c | 24 +- drivers/media/platform/soc_camera/atmel-isi.c | 38 +- drivers/media/platform/soc_camera/mx1_camera.c | 48 +- drivers/media/platform/soc_camera/mx2_camera.c | 41 +- drivers/media/platform/soc_camera/mx3_camera.c | 44 +- drivers/media/platform/soc_camera/omap1_camera.c | 41 +- drivers/media/platform/soc_camera/pxa_camera.c | 46 +- .../platform/soc_camera/sh_mobile_ceu_camera.c | 243 +-- drivers/media/platform/soc_camera/sh_mobile_csi2.c | 153 +++-- drivers/media/platform/soc_camera/soc_camera.c | 707 ++--- .../platform/soc_camera/soc_camera_platform.c |2 +- drivers/media/v4l2-core/Makefile |3 +- drivers/media/v4l2-core/v4l2-async.c | 280 drivers/media/v4l2-core/v4l2-clk.c | 242 +++ drivers/media/v4l2-core/v4l2-common.c |2 + include/media/sh_mobile_ceu.h |2 + include/media/sh_mobile_csi2.h |2 +- include/media/soc_camera.h | 39 +- include/media/v4l2-async.h | 105 +++ include/media/v4l2-clk.h | 54 ++ include/media/v4l2-subdev.h| 10 + 38 files changed, 2035 insertions(+), 467 deletions(-) create mode 100644 Documentation/devicetree/bindings/media/sh_mobile_ceu.txt create mode 100644 drivers/media/v4l2-core/v4l2-async.c create mode 100644 drivers/media/v4l2-core/v4l2-clk.c create mode 100644 include/media/v4l2-async.h create mode 100644 include/media/v4l2-clk.h -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v11 00/21] V4L2 clock and asynchronous probing
Hi Laurent On Fri, 14 Jun 2013, Laurent Pinchart wrote: Hi Guennadi, Thank you for the patches. On Friday 14 June 2013 21:08:10 Guennadi Liakhovetski wrote: v11 of the V4L2 clock helper and asynchronous probing patch set. Functionally identical to v10, only differences are a couple of comment lines and one renamed struct field - as requested by respectable reviewers :) Only patches #15, 16 and 18 changed. [snip] .../devicetree/bindings/media/sh_mobile_ceu.txt| 18 + Documentation/video4linux/v4l2-framework.txt is missing :-) I know. I will add it as soon as these patches are in. Thanks Guennadi arch/arm/mach-shmobile/board-ap4evb.c | 103 ++-- arch/arm/mach-shmobile/clock-sh7372.c |1 + drivers/media/i2c/soc_camera/imx074.c | 32 +- drivers/media/i2c/soc_camera/mt9m001.c | 17 +- drivers/media/i2c/soc_camera/mt9m111.c | 20 +- drivers/media/i2c/soc_camera/mt9t031.c | 19 +- drivers/media/i2c/soc_camera/mt9t112.c | 25 +- drivers/media/i2c/soc_camera/mt9v022.c | 17 +- drivers/media/i2c/soc_camera/ov2640.c | 19 +- drivers/media/i2c/soc_camera/ov5642.c | 20 +- drivers/media/i2c/soc_camera/ov6650.c | 17 +- drivers/media/i2c/soc_camera/ov772x.c | 15 +- drivers/media/i2c/soc_camera/ov9640.c | 17 +- drivers/media/i2c/soc_camera/ov9640.h |1 + drivers/media/i2c/soc_camera/ov9740.c | 18 +- drivers/media/i2c/soc_camera/rj54n1cb0c.c | 17 +- drivers/media/i2c/soc_camera/tw9910.c | 24 +- drivers/media/platform/soc_camera/atmel-isi.c | 38 +- drivers/media/platform/soc_camera/mx1_camera.c | 48 +- drivers/media/platform/soc_camera/mx2_camera.c | 41 +- drivers/media/platform/soc_camera/mx3_camera.c | 44 +- drivers/media/platform/soc_camera/omap1_camera.c | 41 +- drivers/media/platform/soc_camera/pxa_camera.c | 46 +- .../platform/soc_camera/sh_mobile_ceu_camera.c | 243 +-- drivers/media/platform/soc_camera/sh_mobile_csi2.c | 153 +++-- drivers/media/platform/soc_camera/soc_camera.c | 707 ++--- .../platform/soc_camera/soc_camera_platform.c |2 +- drivers/media/v4l2-core/Makefile |3 +- drivers/media/v4l2-core/v4l2-async.c | 280 drivers/media/v4l2-core/v4l2-clk.c | 242 +++ drivers/media/v4l2-core/v4l2-common.c |2 + include/media/sh_mobile_ceu.h |2 + include/media/sh_mobile_csi2.h |2 +- include/media/soc_camera.h | 39 +- include/media/v4l2-async.h | 105 +++ include/media/v4l2-clk.h | 54 ++ include/media/v4l2-subdev.h| 10 + 38 files changed, 2035 insertions(+), 467 deletions(-) create mode 100644 Documentation/devicetree/bindings/media/sh_mobile_ceu.txt create mode 100644 drivers/media/v4l2-core/v4l2-async.c create mode 100644 drivers/media/v4l2-core/v4l2-clk.c create mode 100644 include/media/v4l2-async.h create mode 100644 include/media/v4l2-clk.h -- Regards, Laurent Pinchart --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v11 00/21] V4L2 clock and asynchronous probing
Hi Guennadi, On 06/14/2013 10:45 PM, Guennadi Liakhovetski wrote: On Fri, 14 Jun 2013, Laurent Pinchart wrote: On Friday 14 June 2013 21:08:10 Guennadi Liakhovetski wrote: v11 of the V4L2 clock helper and asynchronous probing patch set. Functionally identical to v10, only differences are a couple of comment lines and one renamed struct field - as requested by respectable reviewers:) Only patches #15, 16 and 18 changed. [snip] .../devicetree/bindings/media/sh_mobile_ceu.txt| 18 + Documentation/video4linux/v4l2-framework.txt is missing:-) I know. I will add it as soon as these patches are in. Actually it would be nice to see some documentation, before this patch set is merged. I don't think the whole concept is going to be changed or rejected by Mauro at this point :) And we always have been pushing back on merging any code without some corresponding documentation. The v4l2 API seems relatively well documented, and I would prefer to keep it that way. :-) Regards, Sylwester -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
