Re: [PATCH v2 3/7] [media] rc-core: add support for IR raw transmitters
Hi Andi, [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.8-rc4 next-20160825] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Andi-Shyti/Add-support-for-IR-transmitters/20160902-060825 base: git://linuxtv.org/media_tree.git master reproduce: make htmldocs All warnings (new ones prefixed by >>): make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. drivers/gpu/drm/i915/i915_vgpu.c:105: warning: No description found for parameter 'dev_priv' drivers/gpu/drm/i915/i915_vgpu.c:184: warning: No description found for parameter 'dev_priv' drivers/gpu/drm/i915/i915_vgpu.c:184: warning: Excess function parameter 'dev' description in 'intel_vgt_balloon' drivers/gpu/drm/i915/i915_vgpu.c:106: warning: No description found for parameter 'dev_priv' drivers/gpu/drm/i915/i915_vgpu.c:185: warning: No description found for parameter 'dev_priv' drivers/gpu/drm/i915/i915_vgpu.c:185: warning: Excess function parameter 'dev' description in 'intel_vgt_balloon' drivers/gpu/drm/i915/i915_gem.c:929: warning: No description found for parameter 'i915' drivers/gpu/drm/i915/i915_gem.c:929: warning: Excess function parameter 'dev' description in 'i915_gem_gtt_pwrite_fast' drivers/gpu/drm/i915/intel_hotplug.c:543: warning: Excess function parameter 'enabled' description in 'intel_hpd_poll_init' drivers/gpu/drm/i915/intel_hotplug.c:544: warning: Excess function parameter 'enabled' description in 'intel_hpd_poll_init' drivers/gpu/drm/i915/intel_fbc.c:1087: warning: No description found for parameter 'crtc_state' drivers/gpu/drm/i915/intel_fbc.c:1087: warning: No description found for parameter 'plane_state' drivers/gpu/drm/i915/intel_fbc.c:1088: warning: No description found for parameter 'crtc_state' drivers/gpu/drm/i915/intel_fbc.c:1088: warning: No description found for parameter 'plane_state' >> include/media/rc-core.h:39: warning: bad line:driver >> requires pulce/spce data sequence. drivers/gpu/drm/drm_crtc.c:1272: WARNING: Inline literal start-string without end-string. drivers/gpu/drm/drm_crtc.c:1387: WARNING: Inline literal start-string without end-string. include/drm/drm_crtc.h:1200: WARNING: Inline literal start-string without end-string. include/drm/drm_crtc.h:1253: WARNING: Inline literal start-string without end-string. include/drm/drm_crtc.h:1266: WARNING: Inline literal start-string without end-string. include/drm/drm_crtc.h:1270: WARNING: Inline literal start-string without end-string. drivers/gpu/drm/drm_irq.c:718: WARNING: Option list ends without a blank line; unexpected unindent. drivers/gpu/drm/drm_fb_helper.c:2196: WARNING: Inline emphasis start-string without end-string. drivers/gpu/drm/drm_simple_kms_helper.c:156: WARNING: Inline literal start-string without end-string. include/drm/drm_gem.h:212: WARNING: Inline emphasis start-string without end-string. drivers/gpu/drm/i915/intel_uncore.c:1622: ERROR: Unexpected indentation. drivers/gpu/drm/i915/intel_uncore.c:1623: WARNING: Block quote ends without a blank line; unexpected unindent. drivers/gpu/drm/i915/intel_uncore.c:1656: ERROR: Unexpected indentation. drivers/gpu/drm/i915/intel_uncore.c:1657: WARNING: Block quote ends without a blank line; unexpected unindent. drivers/gpu/drm/i915/i915_vgpu.c:178: WARNING: Literal block ends without a blank line; unexpected unindent. drivers/gpu/drm/i915/intel_audio.c:54: WARNING: Inline emphasis start-string without end-string. drivers/gpu/drm/i915/intel_audio.c:54: WARNING: Inline emphasis start-string without end-string. drivers/gpu/drm/i915/intel_lrc.c:1166: ERROR: Unexpected indentation. drivers/gpu/drm/i915/intel_lrc.c:1167: WARNING: Block quote ends without a blank line; unexpected unindent. drivers/gpu/drm/i915/intel_guc_fwif.h:159: WARNING: Block quote ends without a blank line; unexpected unindent. drivers/gpu/drm/i915/intel_guc_fwif.h:178: WARNING: Enumerated list ends without a blank line; unexpected unindent. WARNING: dvipng command 'dvipng' cannot be run (needed for math display), check the imgmath_dvipng setting vim +39 include/media/rc-core.h 23 #include 24 25 extern int rc_core_debug; 26 #define IR_dprintk(level, fmt, ...) \ 27 do {\ 28 if (rc_core_debug >= level) \ 29 printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__); \ 30 } while (0) 31 32 /** 33 * enum
Re: [PATCH v2 3/7] [media] rc-core: add support for IR raw transmitters
On Fri, Sep 02, 2016 at 02:16:25AM +0900, Andi Shyti wrote: > IR raw transmitter driver type is specified in the enum > rc_driver_type as RC_DRIVER_IR_RAW_TX which includes all those > devices that transmit raw stream of bit to a receiver. > > The data are provided by userspace applications, therefore they > don't need any input device allocation, but still they need to be > registered as raw devices. > > Suggested-by: Sean Young> Signed-off-by: Andi Shyti > --- > drivers/media/rc/rc-main.c | 39 +++ > include/media/rc-core.h| 9 ++--- > 2 files changed, 29 insertions(+), 19 deletions(-) > > diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c > index 7961083..c3c1f68 100644 > --- a/drivers/media/rc/rc-main.c > +++ b/drivers/media/rc/rc-main.c > @@ -1361,20 +1361,24 @@ struct rc_dev *rc_allocate_device(enum rc_driver_type > type) > if (!dev) > return NULL; > > - dev->input_dev = input_allocate_device(); > - if (!dev->input_dev) { > - kfree(dev); > - return NULL; > - } > + if (type != RC_DRIVER_IR_RAW_TX) { > + dev->input_dev = input_allocate_device(); > + if (!dev->input_dev) { > + kfree(dev); > + return NULL; > + } > + > + dev->input_dev->getkeycode = ir_getkeycode; > + dev->input_dev->setkeycode = ir_setkeycode; > + input_set_drvdata(dev->input_dev, dev); > > - dev->input_dev->getkeycode = ir_getkeycode; > - dev->input_dev->setkeycode = ir_setkeycode; > - input_set_drvdata(dev->input_dev, dev); > + setup_timer(>timer_keyup, ir_timer_keyup, > + (unsigned long)dev); > > - spin_lock_init(>rc_map.lock); > - spin_lock_init(>keylock); > + spin_lock_init(>rc_map.lock); > + spin_lock_init(>keylock); > + } > mutex_init(>lock); > - setup_timer(>timer_keyup, ir_timer_keyup, (unsigned long)dev); > > dev->dev.type = _dev_type; > dev->dev.class = _class; > @@ -1474,7 +1478,7 @@ out_table: > > static void rc_free_rx_device(struct rc_dev *dev) > { > - if (!dev) > + if (!dev || dev->driver_type == RC_DRIVER_IR_RAW_TX) > return; > > ir_free_table(>rc_map); > @@ -1522,11 +1526,14 @@ int rc_register_device(struct rc_dev *dev) An tx-only device shouldn't have the sysfs attribute protocol, that should be handled here too. > dev->input_name ?: "Unspecified device", path ?: "N/A"); > kfree(path); > > - rc = rc_setup_rx_device(dev); > - if (rc) > - goto out_dev; > + if (dev->driver_type != RC_DRIVER_IR_RAW_TX) { > + rc = rc_setup_rx_device(dev); > + if (rc) > + goto out_dev; > + } > > - if (dev->driver_type == RC_DRIVER_IR_RAW) { > + if (dev->driver_type == RC_DRIVER_IR_RAW || > + dev->driver_type == RC_DRIVER_IR_RAW_TX) { > if (!raw_init) { > request_module_nowait("ir-lirc-codec"); > raw_init = true; > diff --git a/include/media/rc-core.h b/include/media/rc-core.h > index 4fc60dd..56e33c1 100644 > --- a/include/media/rc-core.h > +++ b/include/media/rc-core.h > @@ -32,13 +32,16 @@ do { > \ > /** > * enum rc_driver_type - type of the RC output > * > - * @RC_DRIVER_SCANCODE: Driver or hardware generates a scancode > - * @RC_DRIVER_IR_RAW:Driver or hardware generates pulse/space > sequences. > - * It needs a Infra-Red pulse/space decoder > + * @RC_DRIVER_SCANCODE: Driver or hardware generates a scancode > + * @RC_DRIVER_IR_RAW: Driver or hardware generates pulse/space > sequences. > + *It needs a Infra-Red pulse/space decoder > + * @RC_DRIVER_IR_RAW_TX: Device transmitter only, > + driver requires pulce/spce data sequence. > */ > enum rc_driver_type { > RC_DRIVER_SCANCODE = 0, > RC_DRIVER_IR_RAW, > + RC_DRIVER_IR_RAW_TX, > }; > > /** > -- > 2.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html