Re: [PATCH v3 06/15] dt: binding: add binding for ImgTec IR block
On 28/02/14 01:28, Rob Herring wrote: On Thu, Feb 27, 2014 at 4:52 PM, James Hogan james.ho...@imgtec.com wrote: v3: - Rename compatible string to img,ir-rev1 (Rob Herring). - Specify ordering of clocks explicitly (Rob Herring). I'd appreciate if somebody could give this another glance after the two changes listed above and Ack it (I'll probably be posting a v4 patchset tomorrow). Looks fine. Acked-by: Rob Herring r...@kernel.org Thanks Rob! Cheers James -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 06/15] dt: binding: add binding for ImgTec IR block
Hi Rob, Mark + DT maintainers,
On Friday 07 February 2014 15:49:15 James Hogan wrote:
Add device tree binding for ImgTec Consumer Infrared block, specifically
major revision 1 of the hardware.
Signed-off-by: James Hogan james.ho...@imgtec.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: linux-media@vger.kernel.org
Cc: Rob Herring robh...@kernel.org
Cc: Pawel Moll pawel.m...@arm.com
Cc: Mark Rutland mark.rutl...@arm.com
Cc: Ian Campbell ijc+devicet...@hellion.org.uk
Cc: Kumar Gala ga...@codeaurora.org
Cc: devicet...@vger.kernel.org
Cc: Rob Landley r...@landley.net
Cc: linux-...@vger.kernel.org
Cc: Tomasz Figa tomasz.f...@gmail.com
---
v3:
- Rename compatible string to img,ir-rev1 (Rob Herring).
- Specify ordering of clocks explicitly (Rob Herring).
I'd appreciate if somebody could give this another glance after the two
changes listed above and Ack it (I'll probably be posting a v4 patchset
tomorrow).
Thanks
James
v2:
- Future proof compatible string from img,ir to img,ir1, where the 1
corresponds to the major revision number of the hardware (Tomasz
Figa).
- Added clock-names property and three specific clock names described in
the manual, only one of which is used by the current driver (Tomasz
Figa).
---
.../devicetree/bindings/media/img-ir-rev1.txt | 34
++ 1 file changed, 34 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/img-ir-rev1.txt
diff --git a/Documentation/devicetree/bindings/media/img-ir-rev1.txt
b/Documentation/devicetree/bindings/media/img-ir-rev1.txt new file mode
100644
index ..5434ce61b925
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/img-ir-rev1.txt
@@ -0,0 +1,34 @@
+* ImgTec Infrared (IR) decoder version 1
+
+This binding is for Imagination Technologies' Infrared decoder block,
+specifically major revision 1.
+
+Required properties:
+- compatible:Should be img,ir-rev1
+- reg: Physical base address of the controller and
length of
+ memory mapped region.
+- interrupts:The interrupt specifier to the cpu.
+
+Optional properties:
+- clocks:List of clock specifiers as described in standard
+ clock bindings.
+ Up to 3 clocks may be specified in the following order:
+ 1st:Core clock (defaults to 32.768KHz if omitted).
+ 2nd:System side (fast) clock.
+ 3rd:Power modulation clock.
+- clock-names: List of clock names corresponding to the clocks
+ specified in the clocks property.
+ Accepted clock names are:
+ core: Core clock.
+ sys: System clock.
+ mod: Power modulation clock.
+
+Example:
+
+ ir@02006200 {
+ compatible = img,ir-rev1;
+ reg = 0x02006200 0x100;
+ interrupts = 29 4;
+ clocks = clk_32khz;
+ clock-names = core;
+ };
signature.asc
Description: This is a digitally signed message part.
Re: [PATCH v3 06/15] dt: binding: add binding for ImgTec IR block
On Thu, Feb 27, 2014 at 4:52 PM, James Hogan james.ho...@imgtec.com wrote:
Hi Rob, Mark + DT maintainers,
On Friday 07 February 2014 15:49:15 James Hogan wrote:
Add device tree binding for ImgTec Consumer Infrared block, specifically
major revision 1 of the hardware.
Signed-off-by: James Hogan james.ho...@imgtec.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: linux-media@vger.kernel.org
Cc: Rob Herring robh...@kernel.org
Cc: Pawel Moll pawel.m...@arm.com
Cc: Mark Rutland mark.rutl...@arm.com
Cc: Ian Campbell ijc+devicet...@hellion.org.uk
Cc: Kumar Gala ga...@codeaurora.org
Cc: devicet...@vger.kernel.org
Cc: Rob Landley r...@landley.net
Cc: linux-...@vger.kernel.org
Cc: Tomasz Figa tomasz.f...@gmail.com
---
v3:
- Rename compatible string to img,ir-rev1 (Rob Herring).
- Specify ordering of clocks explicitly (Rob Herring).
I'd appreciate if somebody could give this another glance after the two
changes listed above and Ack it (I'll probably be posting a v4 patchset
tomorrow).
Looks fine.
Acked-by: Rob Herring r...@kernel.org
v2:
- Future proof compatible string from img,ir to img,ir1, where the 1
corresponds to the major revision number of the hardware (Tomasz
Figa).
- Added clock-names property and three specific clock names described in
the manual, only one of which is used by the current driver (Tomasz
Figa).
---
.../devicetree/bindings/media/img-ir-rev1.txt | 34
++ 1 file changed, 34 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/img-ir-rev1.txt
diff --git a/Documentation/devicetree/bindings/media/img-ir-rev1.txt
b/Documentation/devicetree/bindings/media/img-ir-rev1.txt new file mode
100644
index ..5434ce61b925
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/img-ir-rev1.txt
@@ -0,0 +1,34 @@
+* ImgTec Infrared (IR) decoder version 1
+
+This binding is for Imagination Technologies' Infrared decoder block,
+specifically major revision 1.
+
+Required properties:
+- compatible:Should be img,ir-rev1
+- reg: Physical base address of the controller and
length of
+ memory mapped region.
+- interrupts:The interrupt specifier to the cpu.
+
+Optional properties:
+- clocks:List of clock specifiers as described in standard
+ clock bindings.
+ Up to 3 clocks may be specified in the following order:
+ 1st:Core clock (defaults to 32.768KHz if omitted).
+ 2nd:System side (fast) clock.
+ 3rd:Power modulation clock.
+- clock-names: List of clock names corresponding to the clocks
+ specified in the clocks property.
+ Accepted clock names are:
+ core: Core clock.
+ sys: System clock.
+ mod: Power modulation clock.
+
+Example:
+
+ ir@02006200 {
+ compatible = img,ir-rev1;
+ reg = 0x02006200 0x100;
+ interrupts = 29 4;
+ clocks = clk_32khz;
+ clock-names = core;
+ };
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
