Re: [PATCH v3 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-14 Thread jacopo mondi
Hello Loic, On Thu, Sep 06, 2018 at 10:13:53AM +0200, Loic Poulain wrote: > On 6 September 2018 at 09:48, jacopo mondi wrote: > > Hello Loic, > >thanks for looking into this > > > > On Tue, Sep 04, 2018 at 07:22:50PM +0200, Loic Poulain wrote: > >> Hi Jacopo, > >> > >> > - ret =

Re: [PATCH v3 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-07 Thread Loic Poulain
On 6 September 2018 at 10:48, jacopo mondi wrote: > Hello Loic, > > On Thu, Sep 06, 2018 at 10:13:53AM +0200, Loic Poulain wrote: >> On 6 September 2018 at 09:48, jacopo mondi wrote: >> > Hello Loic, >> >thanks for looking into this >> > >> > On Tue, Sep 04, 2018 at 07:22:50PM +0200, Loic

Re: [PATCH v3 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-06 Thread jacopo mondi
Hello Loic, On Thu, Sep 06, 2018 at 10:13:53AM +0200, Loic Poulain wrote: > On 6 September 2018 at 09:48, jacopo mondi wrote: > > Hello Loic, > >thanks for looking into this > > > > On Tue, Sep 04, 2018 at 07:22:50PM +0200, Loic Poulain wrote: > >> Hi Jacopo, > >> > >> > - ret =

Re: [PATCH v3 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-06 Thread Loic Poulain
On 6 September 2018 at 09:48, jacopo mondi wrote: > Hello Loic, >thanks for looking into this > > On Tue, Sep 04, 2018 at 07:22:50PM +0200, Loic Poulain wrote: >> Hi Jacopo, >> >> > - ret = ov5640_mod_reg(sensor, OV5640_REG_MIPI_CTRL00, BIT(5), >> > -on ? 0 :

Re: [PATCH v3 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-06 Thread jacopo mondi
Hello Loic, thanks for looking into this On Tue, Sep 04, 2018 at 07:22:50PM +0200, Loic Poulain wrote: > Hi Jacopo, > > > - ret = ov5640_mod_reg(sensor, OV5640_REG_MIPI_CTRL00, BIT(5), > > -on ? 0 : BIT(5)); > > - if (ret) > > - return ret;

Re: [PATCH v3 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-04 Thread Loic Poulain
Hi Jacopo, > - ret = ov5640_mod_reg(sensor, OV5640_REG_MIPI_CTRL00, BIT(5), > -on ? 0 : BIT(5)); > - if (ret) > - return ret; > - ret = ov5640_write_reg(sensor, OV5640_REG_PAD_OUTPUT00, > - on ? 0x00 : 0x70);