Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

Hi! > > > Nevertheless, V4L2_CID_FOCUS_ABSOLUTE > > > is documented as follows (emphasis mine): > > > > > > This control sets the *focal point* of the camera to the specified > > > position. The unit is undefined. Positive values set the focus > > > closer to the camera, negative values

Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

Hi Mauro, On Wed, Apr 19, 2017 at 10:51:18AM -0300, Mauro Carvalho Chehab wrote: > Em Sun, 16 Apr 2017 12:12:10 +0300 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Fri, Apr 14, 2017 at 11:23:32PM -0300, Mauro Carvalho Chehab wrote: > > > Hi Sakari, > > > > > > Em

Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

Em Sat, 29 Apr 2017 00:00:05 +0200 Pavel Machek escreveu: > Hi! > > > Hmm... if the idea is to have a control that doesn't do ringing > > compensation, then it should be clear at the control's descriptions > > that: > > > > - V4L2_CID_FOCUS_ABSOLUTE should be used if the VCM has

Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

Hi! > Hmm... if the idea is to have a control that doesn't do ringing > compensation, then it should be clear at the control's descriptions > that: > > - V4L2_CID_FOCUS_ABSOLUTE should be used if the VCM has ringing > compensation; > - V4L2_CID_VOICE_COIL_CURRENT and

Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

Em Sun, 16 Apr 2017 12:12:10 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Fri, Apr 14, 2017 at 11:23:32PM -0300, Mauro Carvalho Chehab wrote: > > Hi Sakari, > > > > Em Tue, 14 Feb 2017 14:20:22 +0200 > > Sakari Ailus escreveu: > > > > >

Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

Hi Mauro, On Fri, Apr 14, 2017 at 11:23:32PM -0300, Mauro Carvalho Chehab wrote: > Hi Sakari, > > Em Tue, 14 Feb 2017 14:20:22 +0200 > Sakari Ailus escreveu: > > > Add a V4L2 control class for voice coil lens driver devices. These are > > simple devices that are

Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

Hi! > Worse than that, patch 2/2 gives the false sensation that both > controls are equal. > > Ok, I understand that they need to be identical on the existing > driver, in order to keep backward compatibility, but I'm afraid > that, without a clear distinction between them at the documentation,

Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

Hi Sakari, Em Tue, 14 Feb 2017 14:20:22 +0200 Sakari Ailus escreveu: > Add a V4L2 control class for voice coil lens driver devices. These are > simple devices that are used to move a camera lens from its resting > position. >From some past threads with this patch,

Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

Hi! > > > > I wonder... should we somehow expose the range of diopters to > > > > userspace? I believe userland camera application will need that > > > > information. > > > > > > It'd certainly be useful to be able to provide more information. > > > > > > The question is: where to store it, and

Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

Hi Pavel, On Wed, Feb 15, 2017 at 09:09:09AM +0100, Pavel Machek wrote: > Hi! > > > On 02/15/17 00:47, Pavel Machek wrote: > > > On Tue 2017-02-14 14:20:22, Sakari Ailus wrote: > > >> Add a V4L2 control class for voice coil lens driver devices. These are > > >> simple devices that are used to

Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

Hi! > On 02/15/17 00:47, Pavel Machek wrote: > > On Tue 2017-02-14 14:20:22, Sakari Ailus wrote: > >> Add a V4L2 control class for voice coil lens driver devices. These are > >> simple devices that are used to move a camera lens from its resting > >> position. > >> > >> Signed-off-by: Sakari

Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

Hi Pavel, On 02/15/17 00:47, Pavel Machek wrote: > On Tue 2017-02-14 14:20:22, Sakari Ailus wrote: >> Add a V4L2 control class for voice coil lens driver devices. These are >> simple devices that are used to move a camera lens from its resting >> position. >> >> Signed-off-by: Sakari Ailus

Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

On Tue 2017-02-14 14:20:22, Sakari Ailus wrote: > Add a V4L2 control class for voice coil lens driver devices. These are > simple devices that are used to move a camera lens from its resting > position. > > Signed-off-by: Sakari Ailus Looks good to me. I wonder...