Re: [PATCH v4] media: Add stk1160 new driver

2012-07-12 Thread Ezequiel Garcia
Hans, On Tue, Jul 10, 2012 at 3:39 AM, Hans Verkuil hverk...@xs4all.nl wrote: Take a look at the latest videobuf2-core.h: I've added helper functions that check the owner. You can probably simplify the driver code quite a bit by using those helpers. Indeed, using latest vb2_xxx_fop and

Re: [PATCH v4] media: Add stk1160 new driver

2012-07-10 Thread Hans Verkuil
On Tue July 10 2012 05:17:41 Ezequiel Garcia wrote: Hey Mauro, On Fri, Jul 6, 2012 at 11:41 AM, Ezequiel Garcia elezegar...@gmail.com wrote: On Thu, Jul 5, 2012 at 9:01 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 05-07-2012 19:36, Sylwester Nawrocki escreveu: On 07/06/2012

Re: [PATCH v4] media: Add stk1160 new driver

2012-07-10 Thread Ezequiel Garcia
Hi Hans, On Tue, Jul 10, 2012 at 3:39 AM, Hans Verkuil hverk...@xs4all.nl wrote: On Tue July 10 2012 05:17:41 Ezequiel Garcia wrote: Hey Mauro, On Fri, Jul 6, 2012 at 11:41 AM, Ezequiel Garcia elezegar...@gmail.com wrote: On Thu, Jul 5, 2012 at 9:01 PM, Mauro Carvalho Chehab

Re: [PATCH v4] media: Add stk1160 new driver

2012-07-10 Thread Hans Verkuil
On Tue 10 July 2012 14:26:11 Ezequiel Garcia wrote: Hi Hans, On Tue, Jul 10, 2012 at 3:39 AM, Hans Verkuil hverk...@xs4all.nl wrote: On Tue July 10 2012 05:17:41 Ezequiel Garcia wrote: Hey Mauro, On Fri, Jul 6, 2012 at 11:41 AM, Ezequiel Garcia elezegar...@gmail.com wrote: On

Re: [PATCH v4] media: Add stk1160 new driver

2012-07-09 Thread Ezequiel Garcia
Hey Mauro, On Fri, Jul 6, 2012 at 11:41 AM, Ezequiel Garcia elezegar...@gmail.com wrote: On Thu, Jul 5, 2012 at 9:01 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 05-07-2012 19:36, Sylwester Nawrocki escreveu: On 07/06/2012 12:11 AM, Mauro Carvalho Chehab wrote: +static int

Re: [PATCH v4] media: Add stk1160 new driver

2012-07-06 Thread Ezequiel Garcia
On Thu, Jul 5, 2012 at 9:01 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 05-07-2012 19:36, Sylwester Nawrocki escreveu: On 07/06/2012 12:11 AM, Mauro Carvalho Chehab wrote: +static int vidioc_dqbuf(struct file *file, void *priv, struct v4l2_buffer *p) +{ + struct stk1160 *dev =

Re: [PATCH v4] media: Add stk1160 new driver

2012-07-06 Thread Ezequiel Garcia
Hi Mauro, On Thu, Jul 5, 2012 at 7:11 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig index 99937c9..8d94d56 100644 --- a/drivers/media/video/Kconfig +++ b/drivers/media/video/Kconfig @@ -661,6 +661,8 @@ source

Re: [PATCH v4] media: Add stk1160 new driver

2012-07-05 Thread Sylwester Nawrocki
On 07/06/2012 12:11 AM, Mauro Carvalho Chehab wrote: +static int vidioc_dqbuf(struct file *file, void *priv, struct v4l2_buffer *p) +{ +struct stk1160 *dev = video_drvdata(file); + +if (!stk1160_is_owner(dev, file)) +return -EBUSY; + +return vb2_dqbuf(dev-vb_vidq,

Re: [PATCH v4] media: Add stk1160 new driver

2012-07-05 Thread Mauro Carvalho Chehab
Em 05-07-2012 19:36, Sylwester Nawrocki escreveu: On 07/06/2012 12:11 AM, Mauro Carvalho Chehab wrote: +static int vidioc_dqbuf(struct file *file, void *priv, struct v4l2_buffer *p) +{ + struct stk1160 *dev = video_drvdata(file); + + if (!stk1160_is_owner(dev, file)) +