Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver

2017-02-16 Thread Russell King - ARM Linux
On Thu, Feb 16, 2017 at 10:44:16AM -0800, Steve Longerbeam wrote: > On 02/16/2017 04:40 AM, Russell King - ARM Linux wrote: > >[8.012191] imx_media_common: module is from the staging directory, the > >quality is unknown, you have been warned. > >[8.018175] imx_media: module is from the

Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver

2017-02-16 Thread Steve Longerbeam
On 02/16/2017 06:20 AM, Russell King - ARM Linux wrote: On Thu, Feb 16, 2017 at 01:09:35PM +, Russell King - ARM Linux wrote: More crap. If the "complete" method fails (or, in fact, anything in v4l2_async_test_notify() fails) then all hell breaks loose, because of the total lack of

Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver

2017-02-16 Thread Steve Longerbeam
On 02/16/2017 04:40 AM, Russell King - ARM Linux wrote: On Thu, Feb 16, 2017 at 11:52:06AM +, Russell King - ARM Linux wrote: On Wed, Feb 15, 2017 at 06:19:22PM -0800, Steve Longerbeam wrote: +static const struct platform_device_id imx_csi_ids[] = { + { .name = "imx-ipuv3-csi" }, +

Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver

2017-02-16 Thread Russell King - ARM Linux
On Thu, Feb 16, 2017 at 01:09:35PM +, Russell King - ARM Linux wrote: > On Thu, Feb 16, 2017 at 12:40:27PM +, Russell King - ARM Linux wrote: > > However, the following is primerily directed at Laurent as the one who > > introduced the BUG_ON() in question... > > > > NEVER EVER USE

Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver

2017-02-16 Thread Russell King - ARM Linux
On Thu, Feb 16, 2017 at 12:40:27PM +, Russell King - ARM Linux wrote: > However, the following is primerily directed at Laurent as the one who > introduced the BUG_ON() in question... > > NEVER EVER USE BUG_ON() IN A PATH THAT CAN RETURN AN ERROR. > > It's possible to find Linus rants about

Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver

2017-02-16 Thread Russell King - ARM Linux
On Thu, Feb 16, 2017 at 11:52:06AM +, Russell King - ARM Linux wrote: > On Wed, Feb 15, 2017 at 06:19:22PM -0800, Steve Longerbeam wrote: > > +static const struct platform_device_id imx_csi_ids[] = { > > + { .name = "imx-ipuv3-csi" }, > > + { }, > > +}; > > +MODULE_DEVICE_TABLE(platform,

Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver

2017-02-16 Thread Russell King - ARM Linux
On Wed, Feb 15, 2017 at 06:19:22PM -0800, Steve Longerbeam wrote: > +static const struct platform_device_id imx_csi_ids[] = { > + { .name = "imx-ipuv3-csi" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(platform, imx_csi_ids); > + > +static struct platform_driver imx_csi_driver = { > +