On 09/21/2018 03:41 PM, Sakari Ailus wrote:
> Hi Bingbu,
>
> On Fri, Sep 21, 2018 at 03:20:19PM +0800, Bing Bu Cao wrote:
> ...
+ try_fmt->field = V4L2_FIELD_NONE;
+
+ mutex_unlock(>mutex);
+
+ return 0;
+}
+
+static int
On Fri, Sep 21, 2018 at 11:28 AM Bing Bu Cao wrote:
>
>
> On 09/18/2018 05:49 PM, Tomasz Figa wrote:
> > Hi Bingbu,
> >
> > On Mon, Sep 17, 2018 at 2:53 PM wrote:
> >> From: Bingbu Cao
> >>
> >> Add a v4l2 sub-device driver for the Sony imx319 image sensor.
> >> This is a camera sensor using
Hi Bingbu,
On Fri, Sep 21, 2018 at 03:20:19PM +0800, Bing Bu Cao wrote:
...
> >> + try_fmt->field = V4L2_FIELD_NONE;
> >> +
> >> + mutex_unlock(>mutex);
> >> +
> >> + return 0;
> >> +}
> >> +
> >> +static int imx319_update_digital_gain(struct imx319 *imx319, u32 d_gain)
> >> +{
> >> + int
On 09/17/2018 07:34 PM, Sakari Ailus wrote:
> Hi Bingbu,
>
> Thanks for the update! A few more small comments, I think we're done after
> these.
>
> On Mon, Sep 17, 2018 at 01:57:52PM +0800, bingbu@intel.com wrote:
>> From: Bingbu Cao
>>
>> Add a v4l2 sub-device driver for the Sony imx319
Ack, I will add more explanation into the code.
On 09/19/2018 12:11 PM, Tomasz Figa wrote:
> Hi Bingbu,
>
> On Mon, Sep 17, 2018 at 2:53 PM wrote:
> [snip]
>> +static int imx319_update_digital_gain(struct imx319 *imx319, u32 d_gain)
>> +{
>> + int ret;
>> +
>> + ret =
On 09/18/2018 05:49 PM, Tomasz Figa wrote:
> Hi Bingbu,
>
> On Mon, Sep 17, 2018 at 2:53 PM wrote:
>> From: Bingbu Cao
>>
>> Add a v4l2 sub-device driver for the Sony imx319 image sensor.
>> This is a camera sensor using the i2c bus for control and the
>> csi-2 bus for data.
> Please see my
Ack.
On 09/17/2018 07:34 PM, Sakari Ailus wrote:
> Hi Bingbu,
>
> Thanks for the update! A few more small comments, I think we're done after
> these.
>
> On Mon, Sep 17, 2018 at 01:57:52PM +0800, bingbu@intel.com wrote:
>> From: Bingbu Cao
>>
>> Add a v4l2 sub-device driver for the Sony
Hi Bingbu,
On Mon, Sep 17, 2018 at 2:53 PM wrote:
[snip]
> +static int imx319_update_digital_gain(struct imx319 *imx319, u32 d_gain)
> +{
> + int ret;
> +
> + ret = imx319_write_reg(imx319, IMX319_REG_DPGA_USE_GLOBAL_GAIN, 1, 1);
> + if (ret)
> + return ret;
> +
>
Hi Bingbu,
On Mon, Sep 17, 2018 at 2:53 PM wrote:
>
> From: Bingbu Cao
>
> Add a v4l2 sub-device driver for the Sony imx319 image sensor.
> This is a camera sensor using the i2c bus for control and the
> csi-2 bus for data.
Please see my comments inline. Also, I'd appreciate being CCed on
Hi Bingbu,
Thanks for the update! A few more small comments, I think we're done after
these.
On Mon, Sep 17, 2018 at 01:57:52PM +0800, bingbu@intel.com wrote:
> From: Bingbu Cao
>
> Add a v4l2 sub-device driver for the Sony imx319 image sensor.
> This is a camera sensor using the i2c bus
Hi Bingbu,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.19-rc4 next-20180913]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
11 matches
Mail list logo