Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-16 Thread Sakari Ailus
Hi Steve, On Tue, Mar 14, 2017 at 09:43:09AM -0700, Steve Longerbeam wrote: > > > On 03/14/2017 09:21 AM, Nicolas Dufresne wrote: > >Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit : > >>On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: > >>>On 03/11/2017 07:14

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-14 Thread Pavel Machek
On Mon 2017-03-13 10:45:38, Russell King - ARM Linux wrote: > On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: > > On 03/11/2017 07:14 PM, Steve Longerbeam wrote: > > > The event must be user visible, otherwise the user has no indication > > > the error, and can't correct it by stream

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-14 Thread Steve Longerbeam
On 03/14/2017 09:47 AM, Russell King - ARM Linux wrote: On Tue, Mar 14, 2017 at 12:21:31PM -0400, Nicolas Dufresne wrote: My main concern here based on what I'm reading, is that this driver is not even able to notice immediately that a produced frame was corrupted (because it's out of sync).

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-14 Thread Russell King - ARM Linux
On Tue, Mar 14, 2017 at 12:21:31PM -0400, Nicolas Dufresne wrote: > My main concern here based on what I'm reading, is that this driver is > not even able to notice immediately that a produced frame was corrupted > (because it's out of sync). From usability perspective, this is really > bad. Can't

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-14 Thread Steve Longerbeam
On 03/14/2017 09:21 AM, Nicolas Dufresne wrote: Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit : On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: On 03/11/2017 07:14 PM, Steve Longerbeam wrote: The event must be user visible, otherwise the user has no

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-14 Thread Nicolas Dufresne
Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit : > On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: > > On 03/11/2017 07:14 PM, Steve Longerbeam wrote: > > > The event must be user visible, otherwise the user has no indication > > > the error, and can't correct

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-13 Thread Steve Longerbeam
On 03/13/2017 10:10 AM, Hans Verkuil wrote: On 03/13/2017 06:06 PM, Steve Longerbeam wrote: On 03/13/2017 03:53 AM, Hans Verkuil wrote: On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: On 03/11/2017 07:14 PM, Steve

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-13 Thread Hans Verkuil
On 03/13/2017 06:06 PM, Steve Longerbeam wrote: > > > On 03/13/2017 03:53 AM, Hans Verkuil wrote: >> On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote: >>> On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: On 03/11/2017 07:14 PM, Steve Longerbeam wrote: > The event must

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-13 Thread Steve Longerbeam
On 03/13/2017 03:53 AM, Hans Verkuil wrote: On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: On 03/11/2017 07:14 PM, Steve Longerbeam wrote: The event must be user visible, otherwise the user has no indication the error,

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-13 Thread Hans Verkuil
On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote: > On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: >> On 03/11/2017 07:14 PM, Steve Longerbeam wrote: >>> The event must be user visible, otherwise the user has no indication >>> the error, and can't correct it by stream restart.

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-13 Thread Russell King - ARM Linux
On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: > On 03/11/2017 07:14 PM, Steve Longerbeam wrote: > > The event must be user visible, otherwise the user has no indication > > the error, and can't correct it by stream restart. > > In that case the driver can detect this and call

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-13 Thread Hans Verkuil
On 03/11/2017 07:14 PM, Steve Longerbeam wrote: > > > On 03/11/2017 03:39 AM, Hans Verkuil wrote: >> On 10/03/17 19:37, Steve Longerbeam wrote: >>> Hi Hans, >>> >>> On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: > Add a new FRAME_INTERVAL_ERROR

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 10:51 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote: On 03/11/2017 03:39 AM, Hans Verkuil wrote: It's fine to use an internal event as long as the end-user doesn't see it. But if you lose vsyncs, then you never capture

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 10:51 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote: On 03/11/2017 03:39 AM, Hans Verkuil wrote: It's fine to use an internal event as long as the end-user doesn't see it. But if you lose vsyncs, then you never capture

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-11 Thread Russell King - ARM Linux
On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote: > On 03/11/2017 03:39 AM, Hans Verkuil wrote: > >It's fine to use an internal event as long as the end-user doesn't > >see it. But if you lose vsyncs, then you never capture another frame, > >right? > > No, that's not correct. By

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 03:39 AM, Hans Verkuil wrote: On 10/03/17 19:37, Steve Longerbeam wrote: Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured an

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-11 Thread Hans Verkuil
On 10/03/17 19:37, Steve Longerbeam wrote: > Hi Hans, > > On 03/10/2017 04:03 AM, Hans Verkuil wrote: >> On 10/03/17 05:52, Steve Longerbeam wrote: >>> Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or >>> output device has measured an interval between the reception or

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-10 Thread Steve Longerbeam
On 03/10/2017 03:30 PM, Pavel Machek wrote: On Fri 2017-03-10 10:37:21, Steve Longerbeam wrote: Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-10 Thread Pavel Machek
On Fri 2017-03-10 10:37:21, Steve Longerbeam wrote: > Hi Hans, > > On 03/10/2017 04:03 AM, Hans Verkuil wrote: > >On 10/03/17 05:52, Steve Longerbeam wrote: > >>Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or > >>output device has measured an interval between the reception

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-10 Thread Steve Longerbeam
Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured an interval between the reception or transmit completion of two consecutive frames of video that is

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-10 Thread Hans Verkuil
On 10/03/17 05:52, Steve Longerbeam wrote: > Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or > output device has measured an interval between the reception or transmit > completion of two consecutive frames of video that is outside the nominal > frame interval by some