Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi! > That self-referencing mux-controls property looks a bit superfluous: > > mux: video-multiplexer { > mux-controls = <>; > }; > > Other than that, I'm completely fine with splitting the compatible into > something like video-mux-gpio and video-mux-mmio and reusing

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi Pavel, On Fri, 2017-04-14 at 22:32 +0200, Pavel Machek wrote: > Hi! > > > > The MUX framework is already in linux-next. Could you use that instead of > > > adding new driver + bindings that are not compliant with the MUX > > > framework? > > > I don't think it'd be much of a change in terms

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi! > > The MUX framework is already in linux-next. Could you use that instead of > > adding new driver + bindings that are not compliant with the MUX framework? > > I don't think it'd be much of a change in terms of code, using the MUX > > framework appears quite simple. > > It is not quite

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi Sakari, thank you for the review. On Tue, 2017-04-04 at 15:47 +0300, Sakari Ailus wrote: > Hi Steve, Philipp and Pavel, > > On Mon, Mar 27, 2017 at 05:40:34PM -0700, Steve Longerbeam wrote: > > From: Philipp Zabel > > > > This driver can handle SoC internal and

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi Steve, On Tue, Apr 11, 2017 at 05:50:58PM -0700, Steve Longerbeam wrote: > > > On 04/04/2017 05:47 AM, Sakari Ailus wrote: > >Hi Steve, Philipp and Pavel, > > > >On Mon, Mar 27, 2017 at 05:40:34PM -0700, Steve Longerbeam wrote: > >>From: Philipp Zabel > >> > >>This

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

On 04/04/2017 05:47 AM, Sakari Ailus wrote: Hi Steve, Philipp and Pavel, On Mon, Mar 27, 2017 at 05:40:34PM -0700, Steve Longerbeam wrote: From: Philipp Zabel This driver can handle SoC internal and external video bus multiplexers, controlled either by register bit

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

On Wed 2017-04-05 13:58:39, Lucas Stach wrote: > Am Mittwoch, den 05.04.2017, 13:18 +0200 schrieb Pavel Machek: > > Hi! > > > > > + * video stream multiplexer controlled via gpio or syscon > > > + * > > > + * Copyright (C) 2013 Pengutronix, Sascha Hauer > > > + * Copyright

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Am Mittwoch, den 05.04.2017, 13:18 +0200 schrieb Pavel Machek: > Hi! > > > + * video stream multiplexer controlled via gpio or syscon > > + * > > + * Copyright (C) 2013 Pengutronix, Sascha Hauer > > + * Copyright (C) 2016 Pengutronix, Philipp Zabel

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi! > + * video stream multiplexer controlled via gpio or syscon > + * > + * Copyright (C) 2013 Pengutronix, Sascha Hauer > + * Copyright (C) 2016 Pengutronix, Philipp Zabel This is actually quite interesting. Same email address for two people...

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi Steve, Philipp and Pavel, On Mon, Mar 27, 2017 at 05:40:34PM -0700, Steve Longerbeam wrote: > From: Philipp Zabel > > This driver can handle SoC internal and external video bus multiplexers, > controlled either by register bit fields or by a GPIO. The subdevice >

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi Steve, On 03/28/2017 03:40 AM, Steve Longerbeam wrote: > From: Philipp Zabel > > This driver can handle SoC internal and external video bus multiplexers, > controlled either by register bit fields or by a GPIO. The subdevice > passes through frame interval and mbus