Re: [PATCH v6 2/2] media: video-i2c: add video-i2c driver

2018-04-05 Thread Matt Ranostay
On Thu, Apr 5, 2018 at 12:39 AM, Sakari Ailus wrote: > Hi Matt, > > Thanks for the patch. It's a very nicely written, small driver. :-) > > Please see more comments below. > > On Sat, Mar 31, 2018 at 05:59:26PM -0700, Matt Ranostay wrote: >> There are several thermal sensors that only have a low-s

Re: [PATCH v6 2/2] media: video-i2c: add video-i2c driver

2018-04-05 Thread Sakari Ailus
Hi Hans, On Thu, Apr 05, 2018 at 10:04:57AM +0200, Hans Verkuil wrote: ... > >> +static int start_streaming(struct vb2_queue *vq, unsigned int count) > >> +{ > >> + struct video_i2c_data *data = vb2_get_drv_priv(vq); > >> + struct video_i2c_buffer *buf, *tmp; > >> + > >> + if (data->kthread_vid

Re: [PATCH v6 2/2] media: video-i2c: add video-i2c driver

2018-04-05 Thread Hans Verkuil
On 05/04/18 09:39, Sakari Ailus wrote: > Hi Matt, > > Thanks for the patch. It's a very nicely written, small driver. :-) > > Please see more comments below. > > On Sat, Mar 31, 2018 at 05:59:26PM -0700, Matt Ranostay wrote: >> There are several thermal sensors that only have a low-speed bus >>

Re: [PATCH v6 2/2] media: video-i2c: add video-i2c driver

2018-04-05 Thread Sakari Ailus
Hi Matt, Thanks for the patch. It's a very nicely written, small driver. :-) Please see more comments below. On Sat, Mar 31, 2018 at 05:59:26PM -0700, Matt Ranostay wrote: > There are several thermal sensors that only have a low-speed bus > interface but output valid video data. This patchset en

Re: [PATCH v6 2/2] media: video-i2c: add video-i2c driver

2018-03-31 Thread Matt Ranostay
On Sat, Mar 31, 2018 at 5:59 PM, Matt Ranostay wrote: > There are several thermal sensors that only have a low-speed bus > interface but output valid video data. This patchset enables support > for the AMG88xx "Grid-Eye" sensor family. > > Signed-off-by: Matt Ranostay > --- v4l2-compliance SHA