Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

Hi Jason, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc5 next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

lanX <alanx.chi...@intel.com>; Lai, Jim <jim....@intel.com> Subject: Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver Hi Jason, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc5 next-20180316] [if

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

Hi Jason, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc5 next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

>; Chiang, AlanX <alanx.chi...@intel.com>; Lai, Jim <jim@intel.com> Subject: Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver Hi Andy, Thanks for the update. Two minor comments below. On Thu, Mar 15, 2018 at 12:24:19AM +0800, Andy Yeh wrote: ... > +static

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

Hi Andy, On Wed, Mar 14, 2018 at 04:29:52PM +, Yeh, Andy wrote: > Still wrong line break... > Please check the list instead. Thanks. > https://patchwork.linuxtv.org/patch/47936/ The patch you sent using git send-email seems fine; I bet it's your e-mail client that does the rewrapping. --

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

hiang, AlanX <alanx.chi...@intel.com>; Lai, Jim <jim@intel.com> Subject: Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver Hi Andy, Thanks for the update. Two minor comments below. On Thu, Mar 15, 2018 at 12:24:19AM +0800, Andy Yeh wrote: ... > +static int imx25

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

Hi Andy, Thanks for the update. Two minor comments below. On Thu, Mar 15, 2018 at 12:24:19AM +0800, Andy Yeh wrote: ... > +static int imx258_set_ctrl(struct v4l2_ctrl *ctrl) > +{ > + struct imx258 *imx258 = > + container_of(ctrl->handler, struct imx258, ctrl_handler); > +

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

Still wrong line break... Please check the list instead. Thanks. https://patchwork.linuxtv.org/patch/47936/ Regards, Andy -Original Message- From: Yeh, Andy Sent: Thursday, March 15, 2018 12:24 AM To: linux-media@vger.kernel.org; tf...@chromium.org Cc: sakari.ai...@linux.intel.com; Yeh,

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

>; Chen, JasonX Z <jasonx.z.c...@intel.com>; Chiang, AlanX <alanx.chi...@intel.com>; Lai, Jim <jim....@intel.com> Subject: Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver On Fri, Mar 9, 2018 at 7:46 PM, Yeh, Andy <andy@intel.com> wrote: > Hi Tomasz,

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

; Sent: Friday, March 9, 2018 6:20 PM > To: Sakari Ailus <sakari.ai...@linux.intel.com> > Cc: Yeh, Andy <andy@intel.com>; Linux Media Mailing List > <linux-media@vger.kernel.org>; Chen, JasonX Z <jasonx.z.c...@intel.com>; > Chiang, AlanX <alanx.chi...@intel.com> &g

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

<sakari.ai...@linux.intel.com> Cc: Yeh, Andy <andy@intel.com>; Linux Media Mailing List <linux-media@vger.kernel.org>; Chen, JasonX Z <jasonx.z.c...@intel.com>; Chiang, AlanX <alanx.chi...@intel.com> Subject: Re: [PATCH v8] media: imx258: Add imx258 camera sensor dr

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

Hi Andy, Sakari, On Fri, Mar 9, 2018 at 5:54 PM, Sakari Ailus wrote: > Hi Andy, > > Thanks for the update. Please see my comments below. > > On Fri, Mar 09, 2018 at 12:15:54AM +0800, Andy Yeh wrote: >> Add a V4L2 sub-device driver for the Sony IMX258 image sensor.

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

Hi Andy, Thanks for the update. Please see my comments below. On Fri, Mar 09, 2018 at 12:15:54AM +0800, Andy Yeh wrote: > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Jason