Re: [PATCHv4] Add Freescale MC44S803 tuner driver

2009-01-19 Thread Jochen Friedrich 
Hi Antti,

 +buf[0] = (val  0xFF)  16;
 
 I am not sure where it comes I have seen comments sometimes that we 
 should use lower case hex numbers.

OK, will fix.

 +return -EREMOTEIO;
 [...]
 +u8 ret, id;
 
 Error status (-EREMOTEIO) is stored to the u8, which leads ~254. This 
 seems not to be problem currently because mc44s803_readreg() is used 
 only in mc44s803_attach() that returns NULL in error case. Anyhow, I 
 think it would be better to use int for clarity.

This is definitely a BUG. I'll also fix this. Do you want me to post an
update to the tuner or an incremental patch against your repository?

Thanks,
Jochen
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv4] Add Freescale MC44S803 tuner driver

2009-01-19 Thread Antti Palosaari 

Jochen Friedrich wrote:

This is definitely a BUG. I'll also fix this. Do you want me to post an
update to the tuner or an incremental patch against your repository?


Post new patch. I hope Mauro will pick up your patch and add it to the 
master when no more comments are given. Anyhow, I don't know what's 
correct procedure.


regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv4] Add Freescale MC44S803 tuner driver

2009-01-17 Thread Detlef Rohde 


Hi All,
I have to apologize being a stupid newbie not able to put Antti's latest 
source (mc44s803-71b0ef33303a) into my kernel (2.6.27-11-generic).
Have performed successfully a make, but running install failed 
because of missed option settings for this operation. I am uncertain if 
I must set a path directory. Is'nt there a symbolic link to the right 
directory? make compiled lots of not needed stuff here, but my system 
needs only a firmware file:

(Copied from /var/log/messages)
Jan 17 23:22:21 detlef-laptop kernel: [  155.512517] dvb-usb: found a 
'TerraTec Cinergy T USB XE' in cold state, will try to load a firmware
Jan 17 23:22:21 detlef-laptop kernel: [  155.512530] firmware: 
requesting dvb-usb-af9015.fw
Jan 17 23:22:21 detlef-laptop kernel: [  155.526289] dvb_usb_af9015: 
probe of 4-3.3:1.0 failed with error -2


Maybe Antti can post me one which I simply can paste into /lib/firmware? 
Hopefully one of you can give an advice..

regards,
Detlef

Antti Palosaari schrieb: 2.6.27-11-generic

Hello Jochen,
I just reviewed this patch and here is my comments;

Jochen Friedrich wrote:

+buf[0] = (val  0xFF)  16;


I am not sure where it comes I have seen comments sometimes that we 
should use lower case hex numbers.



+return -EREMOTEIO;

[...]

+u8 ret, id;


Error status (-EREMOTEIO) is stored to the u8, which leads ~254. This 
seems not to be problem currently because mc44s803_readreg() is used 
only in mc44s803_attach() that returns NULL in error case. Anyhow, I 
think it would be better to use int for clarity.


regards,
Antti



--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html