Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2010-01-15 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: On Wed, Jan 13, 2010 at 9:00 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: Michael Krufky wrote: The same tree is also available using http instead of https: http://www.kernellabs.com/hg/~dheitmueller/em28xx-pal-vbi-2 This should work for you without

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2010-01-15 Thread Devin Heitmueller
On Fri, Jan 15, 2010 at 3:00 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: I've tried to tactfully point this out in the past, but PLEASE STOP USING THE TRUNK AS YOUR PERSONAL DEVELOPMENT SANDBOX.  These changes should have gone into a branch, and you should have solicited testers for

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2010-01-15 Thread hermann pitton
Am Freitag, den 15.01.2010, 17:22 -0500 schrieb Devin Heitmueller: On Fri, Jan 15, 2010 at 3:00 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: I've tried to tactfully point this out in the past, but PLEASE STOP USING THE TRUNK AS YOUR PERSONAL DEVELOPMENT SANDBOX. These changes

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2010-01-15 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: Rather than making any announcement, I would strongly encourage you to consider actually soliciting the feedback on your proposed approach from all of the developers who are actually contributing the code to the project. The point here is as simple as I don't have

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2010-01-13 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: You didn't forget about the em28xx PAL VBI tree, right? I'm just mentioning it because the PULL has been pending for several weeks and came long before the PULL for the HVR-1600 ALSA changes. I tried to, but the hgimport script doesn't like https trees: $ ./hgimport

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2010-01-13 Thread Michael Krufky
On Wed, Jan 13, 2010 at 8:44 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: Devin Heitmueller wrote: You didn't forget about the em28xx PAL VBI tree, right?  I'm just mentioning it because the PULL has been pending for several weeks and came long before the PULL for the HVR-1600 ALSA

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2010-01-13 Thread Mauro Carvalho Chehab
Michael Krufky wrote: The same tree is also available using http instead of https: http://www.kernellabs.com/hg/~dheitmueller/em28xx-pal-vbi-2 This should work for you without issue. Ok. Applied, thanks! Mauro. -- To unsubscribe from this list: send the line unsubscribe linux-media in

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2010-01-13 Thread Devin Heitmueller
On Wed, Jan 13, 2010 at 9:00 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: Michael Krufky wrote: The same tree is also available using http instead of https: http://www.kernellabs.com/hg/~dheitmueller/em28xx-pal-vbi-2 This should work for you without issue. Ok. Applied, thanks!

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2010-01-10 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: Mauro, Please PULL from http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2 for the following: cx18-alsa: Fix the rates definition and move some buffer freeing code. cx18: address possible passing of NULL to snd_card_free cx18-alsa: codingstyle cleanup

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2010-01-10 Thread Devin Heitmueller
On Sun, Jan 10, 2010 at 7:33 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: Hi Devin, Unfortunately, I got some merge conflicts with cx18 code from Andy, due to the buffer handling changes. Could you please rebase your tree against tip, solving those conflicts? Sure, I'll try to do

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2010-01-08 Thread Andy Walls
On Wed, 2010-01-06 at 23:00 -0500, Devin Heitmueller wrote: Mauro, Please PULL from http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2 for the following: In case it's needed: Acked-by: Andy Walls awa...@radix.net Regards, Andy cx18-alsa: Fix the rates definition and move some

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-22 Thread Mauro Carvalho Chehab
Em 22-12-2009 01:50, Devin Heitmueller escreveu: On Mon, Dec 21, 2009 at 10:24 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: In the case of this patch series, the complains are not related to 80 cols: snip In this case, there was a mix of 80-column issues, as well as some other

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-22 Thread Takashi Iwai
At Mon, 21 Dec 2009 12:30:48 -0500, Devin Heitmueller wrote: On Mon, Dec 21, 2009 at 12:21 PM, Takashi Iwai ti...@suse.de wrote: Just a very quick look through the files, here are some comments: - snd_card_free() can't be called with NULL, but the error path in  snd_cx18_init() may

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-22 Thread Devin Heitmueller
On Tue, Dec 22, 2009 at 5:34 AM, Mauro Carvalho Chehab Provided that you've fixed the points that Takashi rised about the alsa part, I'm fine. Please send a separate pull request c/c him , in order to allow him to send his ack. Ok. With the holidays upon us and my being out of town, I will

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-21 Thread Takashi Iwai
At Sun, 13 Dec 2009 10:22:44 -0500, Devin Heitmueller wrote: On Sat, Dec 12, 2009 at 5:34 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: Hi Devin, It is better to submit the RFC patches to alsa ML for they to take a look. Cheers, Mauro Is there something specific you

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-21 Thread Devin Heitmueller
On Mon, Dec 21, 2009 at 12:21 PM, Takashi Iwai ti...@suse.de wrote: Just a very quick look through the files, here are some comments: - snd_card_free() can't be called with NULL, but the error path in  snd_cx18_init() may reach that (when snd_card_create() returns an  error). - Specifying

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-21 Thread hermann pitton
Hi, Am Sonntag, den 20.12.2009, 22:44 -0500 schrieb Andy Walls: On Sun, 2009-12-20 at 22:33 -0500, Devin Heitmueller wrote: On Sun, Dec 20, 2009 at 10:28 PM, Andy Walls awa...@radix.net wrote: Hmmm on the current v4l-dvb tree, the command $ v4l/scripts/checkpatch.pl --no-tree --strict

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-21 Thread Mauro Carvalho Chehab
Em 21-12-2009 01:44, Andy Walls escreveu: On Sun, 2009-12-20 at 22:33 -0500, Devin Heitmueller wrote: On Sun, Dec 20, 2009 at 10:28 PM, Andy Walls awa...@radix.net wrote: Hmmm on the current v4l-dvb tree, the command $ v4l/scripts/checkpatch.pl --no-tree --strict \ -f

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-21 Thread Devin Heitmueller
On Mon, Dec 21, 2009 at 10:24 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: In the case of this patch series, the complains are not related to 80 cols: snip In this case, there was a mix of 80-column issues, as well as some other issues. I did fix the issues other than the 80-column

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-20 Thread Devin Heitmueller
On Mon, Dec 14, 2009 at 11:19 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: Em Mon, 14 Dec 2009 11:10:50 -0500 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: On Mon, Dec 14, 2009 at 11:09 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: I can't pull. Your site is not

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-20 Thread Andy Walls
On Sun, 2009-12-20 at 22:02 -0500, Devin Heitmueller wrote: On Mon, Dec 14, 2009 at 11:19 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: Em Mon, 14 Dec 2009 11:10:50 -0500 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: On Mon, Dec 14, 2009 at 11:09 AM, Mauro Carvalho

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-20 Thread Devin Heitmueller
On Sun, Dec 20, 2009 at 10:28 PM, Andy Walls awa...@radix.net wrote: Hmmm on the current v4l-dvb tree, the command $ v4l/scripts/checkpatch.pl --no-tree --strict  \        -f linux/drivers/media/video/cx18/cx18-driver.c yields warnings about pre-existing 80 column lines and

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-20 Thread Andy Walls
On Sun, 2009-12-20 at 22:33 -0500, Devin Heitmueller wrote: On Sun, Dec 20, 2009 at 10:28 PM, Andy Walls awa...@radix.net wrote: Hmmm on the current v4l-dvb tree, the command $ v4l/scripts/checkpatch.pl --no-tree --strict \ -f linux/drivers/media/video/cx18/cx18-driver.c

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-14 Thread Mauro Carvalho Chehab
Em Sat, 12 Dec 2009 16:00:27 -0500 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: Hello Mauro, Please pull from http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2 for the following: cx18-alsa: fix memory leak in error condition cx18-alsa: remove a couple of warnings

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-14 Thread Mauro Carvalho Chehab
Em Mon, 14 Dec 2009 14:07:42 -0200 Mauro Carvalho Chehab mche...@infradead.org escreveu: Em Sat, 12 Dec 2009 16:00:27 -0500 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: Hello Mauro, Please pull from http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2 for the

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-14 Thread Devin Heitmueller
On Mon, Dec 14, 2009 at 11:09 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: I can't pull. Your site is not responding. Hmm... it seems a temporary failure. It is working now. That is strange (works fine from here). You reported a similar issue trying to pull one of Michael Krufky's

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-14 Thread Mauro Carvalho Chehab
Em Mon, 14 Dec 2009 11:10:50 -0500 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: On Mon, Dec 14, 2009 at 11:09 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: I can't pull. Your site is not responding. Hmm... it seems a temporary failure. It is working now. That is

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-14 Thread Devin Heitmueller
On Mon, Dec 14, 2009 at 11:19 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: Em Mon, 14 Dec 2009 11:10:50 -0500 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: On Mon, Dec 14, 2009 at 11:09 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: I can't pull. Your site is not

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-13 Thread Devin Heitmueller
On Sat, Dec 12, 2009 at 5:34 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: Hi Devin, It is better to submit the RFC patches to alsa ML for they to take a look. Cheers, Mauro Is there something specific you want the ALSA people to review? There are no changes to the ALSA core and

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-12 Thread Mauro Carvalho Chehab
Hi Devin, It is better to submit the RFC patches to alsa ML for they to take a look. Cheers, Mauro Devin Heitmueller wrote: Hello Mauro, Please pull from http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2 for the following: cx18-alsa: fix memory leak in error condition