Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-03-13 Thread Andy Walls
On Fri, 2010-03-12 at 21:34 +1100, Vincent McIntyre wrote: On 2/20/10, Mauro Carvalho Chehab mche...@redhat.com wrote: Robert Lowery wrote: Mauro, I had to make 2 changes to get the patch to work for me Ok. Please test this (hopefully) final revision. -- commit

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-02-19 Thread Robert Lowery
Mauro, I had to make 2 changes to get the patch to work for me see below HTH -Rob Robert Lowery wrote: Mauro's new code does the 50 offset unconditionally for DTV7 by setting offset = 225, not just when the ZARLINK456 or DIBCOM52 tables were explicitly selected. This change is

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-02-19 Thread Mauro Carvalho Chehab
Robert Lowery wrote: Mauro, I had to make 2 changes to get the patch to work for me see below HTH -Rob +if (priv-firm_version = 0x0302) { +if (priv-cur_fw.type DTV7) +offset -= 30; +else if

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-02-19 Thread Mauro Carvalho Chehab
Robert Lowery wrote: Mauro, I had to make 2 changes to get the patch to work for me Ok. Please test this (hopefully) final revision. -- commit bd8bb8798bb96136b6898186d505c9e154334b5d Author: Mauro Carvalho Chehab mche...@redhat.com Date: Fri Feb 19 02:45:00 2010 -0200 V4L/DVB:

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-02-19 Thread Robert Lowery
Robert Lowery wrote: Mauro, I had to make 2 changes to get the patch to work for me Ok. Please test this (hopefully) final revision. This version works for me -- commit bd8bb8798bb96136b6898186d505c9e154334b5d Author: Mauro Carvalho Chehab mche...@redhat.com Date: Fri Feb 19

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-02-18 Thread Mauro Carvalho Chehab
Robert Lowery wrote: Mauro's new code does the 50 offset unconditionally for DTV7 by setting offset = 225, not just when the ZARLINK456 or DIBCOM52 tables were explicitly selected. This change is what appears to cause issues for me. I've reviewed all information and troubles we have

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-02-18 Thread Robert Lowery
Robert Lowery wrote: Mauro's new code does the 50 offset unconditionally for DTV7 by setting offset = 225, not just when the ZARLINK456 or DIBCOM52 tables were explicitly selected. This change is what appears to cause issues for me. I've reviewed all information and troubles we

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-01-07 Thread Terry Wu
Hi, The 6MHz patch is for Taiwan only. It should not change anything for 7MHz and 8MHz. Terry 2010/1/7 Robert Lowery rglow...@exemail.com.au: On Wed, 2010-01-06 at 14:20 +1100, Robert Lowery wrote: On Mon, 2010-01-04 at 21:27 -0500, Andy Walls wrote: On Mon, 2010-01-04 at 15:27

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-01-07 Thread Terry Wu
Hi, And the 6MHz patch you mentioned is a wrong patch. http://linuxtv.org/hg/v4l-dvb/rev/e6a8672631a0 + if (priv-cur_fw.type DTV6) + offset = 175; + if (priv-cur_fw.type DTV7) + offset = 225; + else

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-01-07 Thread Terry Wu
Hi, The following codes in the 6MHz patch are not for 6MHz. Please read the mchehab's comments. 1.28/* 1.29 - * We must adjust the offset by 500kHz in two cases in order 1.30 - * to correctly center the IF output: 1.31 -

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-01-07 Thread Terry Wu
Hi, You can check the dmesg output to verify which XCEIVE firmware/SCODE is using. For examples, (1). DVB-T 7MHz bandwidth, frequency=177.5MHz and BASE F8MHZ/DTV7 firmware is using, SCODE SCODE DTV7 ZARLINK456/HAS_IF_5260 [ 266.008596] xc2028 0-0061: Loading firmware for type=BASE

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-01-07 Thread Robert Lowery
Hi Terry, Thanks for your comments, my responses are inline below. Hi, You can check the dmesg output to verify which XCEIVE firmware/SCODE is using. For examples, (1). DVB-T 7MHz bandwidth, frequency=177.5MHz and BASE F8MHZ/DTV7 firmware is using, SCODE SCODE DTV7

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-01-06 Thread Andy Walls
On Wed, 2010-01-06 at 14:20 +1100, Robert Lowery wrote: On Mon, 2010-01-04 at 21:27 -0500, Andy Walls wrote: On Mon, 2010-01-04 at 15:27 +1100, Robert Lowery wrote: Mauro, I've split the revert2.diff that I sent you previously to fix the tuning regression on my DViCO Dual

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-01-06 Thread Robert Lowery
On Wed, 2010-01-06 at 14:20 +1100, Robert Lowery wrote: On Mon, 2010-01-04 at 21:27 -0500, Andy Walls wrote: On Mon, 2010-01-04 at 15:27 +1100, Robert Lowery wrote: Mauro, I've split the revert2.diff that I sent you previously to fix the tuning regression on my DViCO Dual

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-01-05 Thread Robert Lowery
On Mon, 2010-01-04 at 21:27 -0500, Andy Walls wrote: On Mon, 2010-01-04 at 15:27 +1100, Robert Lowery wrote: Mauro, I've split the revert2.diff that I sent you previously to fix the tuning regression on my DViCO Dual Digital 4 (rev 1) into three separate patches that will

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-01-04 Thread Andy Walls
On Mon, 2010-01-04 at 15:27 +1100, Robert Lowery wrote: Mauro, I've split the revert2.diff that I sent you previously to fix the tuning regression on my DViCO Dual Digital 4 (rev 1) into three separate patches that will hopefully allow you to review more easily. The first two patches

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-01-04 Thread Andy Walls
On Mon, 2010-01-04 at 21:27 -0500, Andy Walls wrote: On Mon, 2010-01-04 at 15:27 +1100, Robert Lowery wrote: Mauro, I've split the revert2.diff that I sent you previously to fix the tuning regression on my DViCO Dual Digital 4 (rev 1) into three separate patches that will hopefully

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-01-04 Thread Andy Walls
On Mon, 2010-01-04 at 22:13 -0500, Devin Heitmueller wrote: Hey Andy, On Mon, Jan 4, 2010 at 9:27 PM, Andy Walls awa...@radix.net wrote: The changes in question (mostly authored by me) are based on documentation on what offsets are to be used with the firmware for various DVB bandwidths

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2010-01-03 Thread Robert Lowery
Mauro, I've split the revert2.diff that I sent you previously to fix the tuning regression on my DViCO Dual Digital 4 (rev 1) into three separate patches that will hopefully allow you to review more easily. The first two patches revert their respective changesets and nothing else, fixing

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2009-12-15 Thread Robert Lowery
Mauro, I've split the revert2.diff that I sent you previously to fix the tuning regression on my DViCO Dual Digital 4 (rev 1) into three separate patches that will hopefully allow you to review more easily. The first two patches revert their respective changesets and nothing else, fixing the

Re: [RESEND] Re: DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1) tuning regression

2009-12-08 Thread Vincent McIntyre
Mauro, Resend of my proposed patch attached that reverts tuning regressions with my DViCO card, whilst still fixing the original 6Mhz tuning issue. Please merge or let me know how else I should proceed to get this merged. Thanks -Rob perhaps the attached notes will help Rob's case here.