Re: [RFC/PATCH 02/10] media: Media device

2010-07-19 Thread Laurent Pinchart
Hi Murali, On Sunday 18 July 2010 17:32:24 Muralidharan Karicheri wrote: > Hi Laurent, > > > +++ b/Documentation/media-framework.txt > > @@ -0,0 +1,68 @@ > > +Linux kernel media framework > > + > > + > > > > I felt more details needed in this media-framework.txt for

Re: [RFC/PATCH 02/10] media: Media device

2010-07-18 Thread Muralidharan Karicheri
Hi Laurent, > +++ b/Documentation/media-framework.txt > @@ -0,0 +1,68 @@ > +Linux kernel media framework > + > + I felt more details needed in this media-framework.txt for information such as which driver call this register() /unregister() function, details on link ma

RE: [RFC/PATCH 02/10] media: Media device

2010-07-16 Thread Aguirre, Sergio
> -Original Message- > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] > Sent: Friday, July 16, 2010 3:53 AM > To: Aguirre, Sergio > Cc: linux-media@vger.kernel.org; sakari.ai...@maxwell.research.nokia.com > Subject: Re: [RFC/PATCH 02/10] media: Me

RE: [RFC/PATCH 02/10] media: Media device

2010-07-16 Thread Aguirre, Sergio
Hi Laurent, > -Original Message- > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] > Sent: Friday, July 16, 2010 3:56 AM > To: Aguirre, Sergio > Cc: linux-media@vger.kernel.org; sakari.ai...@maxwell.research.nokia.com > Subject: Re: [RFC/PATCH 02/10] m

Re: [RFC/PATCH 02/10] media: Media device

2010-07-16 Thread Laurent Pinchart
Hi Sergio, On Thursday 15 July 2010 16:22:06 Aguirre, Sergio wrote: > > On Wednesday 14 July 2010 08:30:00 Laurent Pinchart wrote: > > diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c > > new file mode 100644 > > index 000..a4d3db5 > > --- /dev/null > > +++ b/drivers

Re: [RFC/PATCH 02/10] media: Media device

2010-07-16 Thread Laurent Pinchart
Hi Sergio, Thanks for the review. On Thursday 15 July 2010 16:16:44 Aguirre, Sergio wrote: > > On Wednesday 14 July 2010 08:30:00 Laurent Pinchart wrote: > > diff --git a/include/media/media-device.h b/include/media/media-device.h > > new file mode 100644 > > index 000..6c1fc4a > > --- /de

RE: [RFC/PATCH 02/10] media: Media device

2010-07-15 Thread Aguirre, Sergio
Hi Laurent, Other comment I missed to mention... > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Laurent Pinchart > Sent: Wednesday, July 14, 2010 8:30 AM > To: linux-media@vger.kernel.org > Cc: sakari.ai...@maxwell

RE: [RFC/PATCH 02/10] media: Media device

2010-07-15 Thread Aguirre, Sergio
Hi Laurent, Very minor comment below. > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Laurent Pinchart > Sent: Wednesday, July 14, 2010 8:30 AM > To: linux-media@vger.kernel.org > Cc: sakari.ai...@maxwell.research.n