Re: [V1, 1/2] media: dt-bindings: media: i2c: Add bindings for ov8856

2019-09-08 Thread Dongchun Zhu
Hi Sakari,

On Thu, 2019-08-08 at 19:54 +0300, Sakari Ailus wrote:
> Hi Dongchun,
> 
> (Cc'ing Ben, too.)
> 
> On Thu, Aug 08, 2019 at 05:22:14PM +0800, dongchun@mediatek.com wrote:
> > From: Dongchun Zhu 
> > 
> > Add device tree binding documentation for the ov8856 camera sensor.
> > 
> > Signed-off-by: Dongchun Zhu 
> > ---
> >  .../devicetree/bindings/media/i2c/ov8856.txt   | 41 
> > ++
> >  MAINTAINERS|  1 +
> >  2 files changed, 42 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8856.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.txt 
> > b/Documentation/devicetree/bindings/media/i2c/ov8856.txt
> > new file mode 100644
> > index 000..96b10e0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.txt
> > @@ -0,0 +1,41 @@
> > +* Omnivision OV8856 MIPI CSI-2 sensor
> > +
> > +Required Properties:
> > +- compatible: shall be "ovti,ov8856"
> > +- clocks: reference to the xvclk input clock
> > +- clock-names: shall be "xvclk"
> 
> Could you add "clock-frequency" property here, please, and specify the
> upper and lower limits?
> 

Sorry, this frequency of the external clock to the sensor and
link-frequencies would be added in DT in next release.

> > +- avdd-supply: Analog voltage supply, 2.8 volts
> > +- dovdd-supply: Digital I/O voltage supply, 1.8 volts
> > +- dvdd-supply: Digital core voltage supply, 1.2 volts
> > +- reset-gpios: Low active reset gpio
> > +
> > +The device node shall contain one 'port' child node with an
> > +'endpoint' subnode for its digital output video port,
> > +in accordance with the video interface bindings defined in
> > +Documentation/devicetree/bindings/media/video-interfaces.txt.
> > +The endpoint optional property 'data-lanes' shall be "<0 1 3 4>".
> 
> If you don't support lane reordering, then monotonically incrementing lane
> numbers from 1 onwards are recommended.
> 
> Please also make the property mandatory.
> 

data-lanes would be required property on endpoint in next release.

> > +
> > +Example:
> > +&i2c7 {
> > +   ov8856: camera-sensor@10 {
> > +   compatible = "ovti,ov8856";
> > +   reg = <0x10>;
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <&clk_24m_cam>;
> > +
> > +   clocks = <&cru SCLK_TESTCLKOUT1>;
> > +   clock-names = "xvclk";
> > +
> > +   avdd-supply = <&mt6358_vcama2_reg>;
> > +   dvdd-supply = <&mt6358_vcamd_reg>;
> > +   dovdd-supply = <&mt6358_vcamio_reg>;
> > +   reset-gpios = <&gpio2 3 GPIO_ACTIVE_LOW>;
> > +
> > +   port {
> > +   wcam_out: endpoint {
> > +   remote-endpoint = <&mipi_in_wcam>;
> > +   data-lanes = <0 1 3 4>;
> > +   };
> > +   };
> > +   };
> > +};
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 783569e..7746c6b 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -11889,6 +11889,7 @@ L:  linux-media@vger.kernel.org
> >  T: git git://linuxtv.org/media_tree.git
> >  S: Maintained
> >  F: drivers/media/i2c/ov8856.c
> > +F: Documentation/devicetree/bindings/media/i2c/ov8856.txt
> >  
> >  OMNIVISION OV9650 SENSOR DRIVER
> >  M: Sakari Ailus 
> 




Re: [V1, 1/2] media: dt-bindings: media: i2c: Add bindings for ov8856

2019-08-13 Thread Sakari Ailus
On Thu, Aug 08, 2019 at 07:54:16PM +0300, Sakari Ailus wrote:
> Hi Dongchun,
> 
> (Cc'ing Ben, too.)
> 
> On Thu, Aug 08, 2019 at 05:22:14PM +0800, dongchun@mediatek.com wrote:
> > From: Dongchun Zhu 
> > 
> > Add device tree binding documentation for the ov8856 camera sensor.
> > 
> > Signed-off-by: Dongchun Zhu 
> > ---
> >  .../devicetree/bindings/media/i2c/ov8856.txt   | 41 
> > ++
> >  MAINTAINERS|  1 +
> >  2 files changed, 42 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8856.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.txt 
> > b/Documentation/devicetree/bindings/media/i2c/ov8856.txt
> > new file mode 100644
> > index 000..96b10e0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.txt
> > @@ -0,0 +1,41 @@
> > +* Omnivision OV8856 MIPI CSI-2 sensor
> > +
> > +Required Properties:
> > +- compatible: shall be "ovti,ov8856"
> > +- clocks: reference to the xvclk input clock
> > +- clock-names: shall be "xvclk"
> 
> Could you add "clock-frequency" property here, please, and specify the
> upper and lower limits?

Can you also add the link-frequencies property, please?

-- 
Sakari Ailus
sakari.ai...@linux.intel.com


Re: [V1, 1/2] media: dt-bindings: media: i2c: Add bindings for ov8856

2019-08-08 Thread Sakari Ailus
Hi Dongchun,

(Cc'ing Ben, too.)

On Thu, Aug 08, 2019 at 05:22:14PM +0800, dongchun@mediatek.com wrote:
> From: Dongchun Zhu 
> 
> Add device tree binding documentation for the ov8856 camera sensor.
> 
> Signed-off-by: Dongchun Zhu 
> ---
>  .../devicetree/bindings/media/i2c/ov8856.txt   | 41 
> ++
>  MAINTAINERS|  1 +
>  2 files changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8856.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.txt 
> b/Documentation/devicetree/bindings/media/i2c/ov8856.txt
> new file mode 100644
> index 000..96b10e0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.txt
> @@ -0,0 +1,41 @@
> +* Omnivision OV8856 MIPI CSI-2 sensor
> +
> +Required Properties:
> +- compatible: shall be "ovti,ov8856"
> +- clocks: reference to the xvclk input clock
> +- clock-names: shall be "xvclk"

Could you add "clock-frequency" property here, please, and specify the
upper and lower limits?

> +- avdd-supply: Analog voltage supply, 2.8 volts
> +- dovdd-supply: Digital I/O voltage supply, 1.8 volts
> +- dvdd-supply: Digital core voltage supply, 1.2 volts
> +- reset-gpios: Low active reset gpio
> +
> +The device node shall contain one 'port' child node with an
> +'endpoint' subnode for its digital output video port,
> +in accordance with the video interface bindings defined in
> +Documentation/devicetree/bindings/media/video-interfaces.txt.
> +The endpoint optional property 'data-lanes' shall be "<0 1 3 4>".

If you don't support lane reordering, then monotonically incrementing lane
numbers from 1 onwards are recommended.

Please also make the property mandatory.

> +
> +Example:
> +&i2c7 {
> + ov8856: camera-sensor@10 {
> + compatible = "ovti,ov8856";
> + reg = <0x10>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&clk_24m_cam>;
> +
> + clocks = <&cru SCLK_TESTCLKOUT1>;
> + clock-names = "xvclk";
> +
> + avdd-supply = <&mt6358_vcama2_reg>;
> + dvdd-supply = <&mt6358_vcamd_reg>;
> + dovdd-supply = <&mt6358_vcamio_reg>;
> + reset-gpios = <&gpio2 3 GPIO_ACTIVE_LOW>;
> +
> + port {
> + wcam_out: endpoint {
> + remote-endpoint = <&mipi_in_wcam>;
> + data-lanes = <0 1 3 4>;
> + };
> + };
> + };
> +};
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 783569e..7746c6b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11889,6 +11889,7 @@ L:linux-media@vger.kernel.org
>  T:   git git://linuxtv.org/media_tree.git
>  S:   Maintained
>  F:   drivers/media/i2c/ov8856.c
> +F:   Documentation/devicetree/bindings/media/i2c/ov8856.txt
>  
>  OMNIVISION OV9650 SENSOR DRIVER
>  M:   Sakari Ailus 

-- 
Regards,

Sakari Ailus
sakari.ai...@linux.intel.com