Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2010-02-20 Thread Hans Verkuil
On Monday 15 February 2010 20:51:07 Hans Verkuil wrote:
 This message is generated daily by a cron job that builds v4l-dvb for
 the kernels and architectures in the list below.

Hmm, my build server seems to have died since this was the last cron job
mail I see. Unfortunately, I won't have physical access to it until next
weekend.

Regards,

Hans

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2010-02-11 Thread hermann pitton
Am Donnerstag, den 11.02.2010, 20:18 +0100 schrieb Hans Verkuil:
 This message is generated daily by a cron job that builds v4l-dvb for
 the kernels and architectures in the list below.
 
 Results of the daily build of v4l-dvb:
 
 date:Thu Feb 11 19:01:22 CET 2010
 path:http://www.linuxtv.org/hg/v4l-dvb
 changeset:   14197:095b1aec2354
 gcc version: i686-linux-gcc (GCC) 4.4.3
 host hardware:x86_64
 host os: 2.6.32.5
 
 linux-2.6.32.6-armv5: OK
 linux-2.6.33-rc5-armv5: OK
 linux-2.6.32.6-armv5-davinci: ERRORS
 linux-2.6.33-rc5-armv5-davinci: ERRORS
 linux-2.6.32.6-armv5-dm365: ERRORS
 linux-2.6.33-rc5-armv5-dm365: ERRORS
 linux-2.6.32.6-armv5-ixp: OK
 linux-2.6.33-rc5-armv5-ixp: OK
 linux-2.6.32.6-armv5-omap2: OK
 linux-2.6.33-rc5-armv5-omap2: OK
 linux-2.6.22.19-i686: ERRORS
 linux-2.6.23.17-i686: ERRORS
 linux-2.6.24.7-i686: ERRORS
 linux-2.6.25.20-i686: ERRORS
 linux-2.6.26.8-i686: ERRORS
 linux-2.6.27.44-i686: ERRORS
 linux-2.6.28.10-i686: ERRORS
 linux-2.6.29.1-i686: ERRORS
 linux-2.6.30.10-i686: ERRORS
 linux-2.6.31.12-i686: WARNINGS
 linux-2.6.32.6-i686: OK
 linux-2.6.33-rc5-i686: OK
 linux-2.6.32.6-m32r: OK
 linux-2.6.33-rc5-m32r: OK
 linux-2.6.32.6-mips: OK
 linux-2.6.33-rc5-mips: OK
 linux-2.6.32.6-powerpc64: OK
 linux-2.6.33-rc5-powerpc64: OK
 linux-2.6.22.19-x86_64: ERRORS
 linux-2.6.23.17-x86_64: ERRORS
 linux-2.6.24.7-x86_64: ERRORS
 linux-2.6.25.20-x86_64: ERRORS
 linux-2.6.26.8-x86_64: ERRORS
 linux-2.6.27.44-x86_64: ERRORS
 linux-2.6.28.10-x86_64: ERRORS
 linux-2.6.29.1-x86_64: ERRORS
 linux-2.6.30.10-x86_64: ERRORS
 linux-2.6.31.12-x86_64: WARNINGS
 linux-2.6.32.6-x86_64: OK
 linux-2.6.33-rc5-x86_64: OK
 spec: OK
 sparse (v4l-dvb-git): ERRORS
 sparse (linux-2.6.33-rc5): ERRORS
 linux-2.6.16.62-i686: ERRORS
 linux-2.6.17.14-i686: ERRORS
 linux-2.6.18.8-i686: ERRORS
 linux-2.6.19.7-i686: ERRORS
 linux-2.6.20.21-i686: ERRORS
 linux-2.6.21.7-i686: ERRORS
 linux-2.6.16.62-x86_64: ERRORS
 linux-2.6.17.14-x86_64: ERRORS
 linux-2.6.18.8-x86_64: ERRORS
 linux-2.6.19.7-x86_64: ERRORS
 linux-2.6.20.21-x86_64: ERRORS
 linux-2.6.21.7-x86_64: ERRORS
 
 Detailed results are available here:
 
 http://www.xs4all.nl/~hverkuil/logs/Thursday.log
 
 Full logs are available here:
 
 http://www.xs4all.nl/~hverkuil/logs/Thursday.tar.bz2
 
 The V4L-DVB specification from this daily build is here:
 
 http://www.xs4all.nl/~hverkuil/spec/media.html



Douglas did fix it on current hg.

Cheers,
Hermann


--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2010-02-02 Thread Németh Márton
Hi,

Hans Verkuil wrote:
 This message is generated daily by a cron job that builds v4l-dvb for
 the kernels and architectures in the list below.
 
 [snip]
 Detailed results are available here:
 
 http://www.xs4all.nl/~hverkuil/logs/Tuesday.log

 linux-2.6.16.62-i686: ERRORS

 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:48:29: error: 
 linux/usb/input.h: No such file or directory
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c: In function 
 'gspca_input_connect':
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:182: warning: implicit 
 declaration of function 'usb_to_input_id'
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:186: error: request for 
 member 'parent' in something not a structure or union
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:192: error: request for 
 member 'parent' in something not a structure or union

 linux-2.6.17.14-i686: ERRORS

 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:48:29: error: 
 linux/usb/input.h: No such file or directory
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c: In function 
 'gspca_input_connect':
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:182: warning: implicit 
 declaration of function 'usb_to_input_id'
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:186: error: request for 
 member 'parent' in something not a structure or union
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:192: error: request for 
 member 'parent' in something not a structure or union

 linux-2.6.18.8-i686: ERRORS

 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c: In function 
 'gspca_input_connect':
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:186: error: request for 
 member 'parent' in something not a structure or union
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:192: error: request for 
 member 'parent' in something not a structure or union

 linux-2.6.19.7-i686: ERRORS

 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c: In function 
 'gspca_input_connect':
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:186: error: 'struct 
 input_dev' has no member named 'dev'
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:192: error: 'struct 
 input_dev' has no member named 'dev'

 linux-2.6.20.21-i686: ERRORS

 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c: In function 
 'gspca_input_connect':
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:186: error: 'struct 
 input_dev' has no member named 'dev'
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:192: error: 'struct 
 input_dev' has no member named 'dev'

 linux-2.6.21.7-i686: ERRORS

 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c: In function 
 'gspca_input_connect':
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:186: error: 'struct 
 input_dev' has no member named 'dev'
 /home/hans/work/build/v4l-dvb-master/v4l/gspca.c:192: error: 'struct 
 input_dev' has no member named 'dev'


It seems that the camera button input support is not compatible with kernel
version 2.6.21.7 and before because of different reasons.

1. Between 2.6.16.62 and 2.6.17.14: there is no linux/usb/input.h .
   The linux/usb/input.h was earlier linux/usb_input.h, see
   
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=history;f=include/linux/usb/input.h;h=0e010b220e85b3f9ea861f2ab009809d17014910;hb=HEAD

2. Between 2.6.16.62 and 2.6.17.14: there is no 'usb_to_input_id'. This was
   introduced with the commit 16a334c0de5a94b1d10a1ac9a33f4dedac89a075, exactly
   in the same place: in linux/usb_input.h .
   
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=16a334c0de5a94b1d10a1ac9a33f4dedac89a075

3. Between 2.6.16.62 and 2.6.18.8: there is no 'parent' field of struct device.
   The struct device is defined in linux/device.h . I couldn't find what exactly
   happened here, yet.
   
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=history;f=include/linux/device.h;h=a62799f2ab0019863d30e4f55f7677c5bd97d124;hb=HEAD

4. Between linux-2.6.19.7 and 2.6.21.7: 'struct input_dev' has no member named 
'dev'.
   The 'dev' member was introduced with commit 
9657d75c5f0f7d0a9cb507521d3ad1436aea28c9
   when a convert was made from class devices to standard devices.
   
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=9657d75c5f0f7d0a9cb507521d3ad1436aea28c9

The main question is that does gspca need to support kernel version 2.6.21.7
and before? If yes, then should the input support disabled in 2.6.21.7 and 
before?

Regards,

Márton Németh
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2010-01-27 Thread Hans Verkuil
On Wednesday 27 January 2010 22:48:24 Hans Verkuil wrote:
 This message is generated daily by a cron job that builds v4l-dvb for
 the kernels and architectures in the list below.

It's up and running again. Note that I upgraded to the latest gcc 4.4.3.
I also updated all the kernels to their latest dot release.

I'm only building the i686 and x86_64 on all kernels from 2.6.16 onwards.
All other architectures are only built for 2.6.32 and 2.6.33. If someone wants
to build one of those for older kernels also, then just let me know.

Regards,

Hans

 
 Results of the daily build of v4l-dvb:
 
 date:Wed Jan 27 21:00:05 CET 2010
 path:http://www.linuxtv.org/hg/v4l-dvb
 changeset:   14064:31eaa9423f98
 gcc version: i686-linux-gcc (GCC) 4.4.3
 host hardware:x86_64
 host os: 2.6.32.5
 
 linux-2.6.32.6-armv5: OK
 linux-2.6.33-rc5-armv5: OK
 linux-2.6.32.6-armv5-davinci: WARNINGS
 linux-2.6.33-rc5-armv5-davinci: WARNINGS
 linux-2.6.32.6-armv5-dm365: ERRORS
 linux-2.6.33-rc5-armv5-dm365: ERRORS
 linux-2.6.32.6-armv5-ixp: WARNINGS
 linux-2.6.33-rc5-armv5-ixp: WARNINGS
 linux-2.6.32.6-armv5-omap2: WARNINGS
 linux-2.6.33-rc5-armv5-omap2: WARNINGS
 linux-2.6.22.19-i686: WARNINGS
 linux-2.6.23.17-i686: WARNINGS
 linux-2.6.24.7-i686: WARNINGS
 linux-2.6.25.20-i686: WARNINGS
 linux-2.6.26.8-i686: WARNINGS
 linux-2.6.27.44-i686: WARNINGS
 linux-2.6.28.10-i686: WARNINGS
 linux-2.6.29.1-i686: WARNINGS
 linux-2.6.30.10-i686: WARNINGS
 linux-2.6.31.12-i686: WARNINGS
 linux-2.6.32.6-i686: WARNINGS
 linux-2.6.33-rc5-i686: WARNINGS
 linux-2.6.32.6-m32r: OK
 linux-2.6.33-rc5-m32r: OK
 linux-2.6.32.6-mips: WARNINGS
 linux-2.6.33-rc5-mips: WARNINGS
 linux-2.6.32.6-powerpc64: ERRORS
 linux-2.6.33-rc5-powerpc64: ERRORS
 linux-2.6.22.19-x86_64: WARNINGS
 linux-2.6.23.17-x86_64: WARNINGS
 linux-2.6.24.7-x86_64: WARNINGS
 linux-2.6.25.20-x86_64: WARNINGS
 linux-2.6.26.8-x86_64: WARNINGS
 linux-2.6.27.44-x86_64: WARNINGS
 linux-2.6.28.10-x86_64: WARNINGS
 linux-2.6.29.1-x86_64: WARNINGS
 linux-2.6.30.10-x86_64: WARNINGS
 linux-2.6.31.12-x86_64: WARNINGS
 linux-2.6.32.6-x86_64: WARNINGS
 linux-2.6.33-rc5-x86_64: WARNINGS
 spec: OK
 sparse (linux-2.6.32.6): ERRORS
 sparse (linux-2.6.33-rc5): ERRORS
 linux-2.6.16.62-i686: ERRORS
 linux-2.6.17.14-i686: ERRORS
 linux-2.6.18.8-i686: ERRORS
 linux-2.6.19.7-i686: OK
 linux-2.6.20.21-i686: WARNINGS
 linux-2.6.21.7-i686: WARNINGS
 linux-2.6.16.62-x86_64: ERRORS
 linux-2.6.17.14-x86_64: ERRORS
 linux-2.6.18.8-x86_64: ERRORS
 linux-2.6.19.7-x86_64: WARNINGS
 linux-2.6.20.21-x86_64: WARNINGS
 linux-2.6.21.7-x86_64: WARNINGS
 
 Detailed results are available here:
 
 http://www.xs4all.nl/~hverkuil/logs/Wednesday.log
 
 Full logs are available here:
 
 http://www.xs4all.nl/~hverkuil/logs/Wednesday.tar.bz2
 
 The V4L-DVB specification from this daily build is here:
 
 http://www.xs4all.nl/~hverkuil/spec/media.html
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2010-01-27 Thread Németh Márton
Hans Verkuil wrote:
 On Wednesday 27 January 2010 22:48:24 Hans Verkuil wrote:
 This message is generated daily by a cron job that builds v4l-dvb for
 the kernels and architectures in the list below.
 
 It's up and running again. Note that I upgraded to the latest gcc 4.4.3.
 I also updated all the kernels to their latest dot release.

I'm happy to hear that this regular check is running again. I think this
is an important tool to increase quality of v4l subsystem.

Regards,

Márton Németh
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2010-01-14 Thread Németh Márton
Hans Verkuil wrote:
 Detailed results are available here:
 
 http://www.xs4all.nl/~hverkuil/logs/Thursday.log

 linux-2.6.32-i686: ERRORS

 /marune/build/v4l-dvb-master/v4l/cx23888-ir.c: In function 
 'cx23888_ir_irq_handler':  CC [M]  
 /marune/build/v4l-dvb-master/v4l/cx23885-f300.o

 /marune/build/v4l-dvb-master/v4l/cx23888-ir.c:621: error: implicit 
 declaration of function 'kfifo_in_locked'
 /marune/build/v4l-dvb-master/v4l/cx23888-ir.c: In function 
 'cx23888_ir_rx_read':
 /marune/build/v4l-dvb-master/v4l/cx23888-ir.c:688: error: implicit 
 declaration of function 'kfifo_out_locked'
 /marune/build/v4l-dvb-master/v4l/cx23888-ir.c: In function 'cx23888_ir_probe':
 /marune/build/v4l-dvb-master/v4l/cx23888-ir.c:1243: warning: passing argument 
 1 of 'kfifo_alloc' makes integer from pointer without a cast
 include/linux/kfifo.h:37: note: expected 'unsigned int' but argument is of 
 type 'struct kfifo *'
 /marune/build/v4l-dvb-master/v4l/cx23888-ir.c:1243: warning: passing argument 
 3 of 'kfifo_alloc' makes pointer from integer without a cast
 include/linux/kfifo.h:37: note: expected 'struct spinlock_t *' but argument 
 is of type 'unsigned int'
 make[3]: *** [/marune/build/v4l-dvb-master/v4l/cx23888-ir.o] Error 1
 make[3]: *** Waiting for unfinished jobs
 make[2]: *** [_module_/marune/build/v4l-dvb-master/v4l] Error 2
 make[2]: Leaving directory `/marune/build/trees/i686/linux-2.6.32'
 make[1]: *** [default] Error 2
 make[1]: Leaving directory `/marune/build/v4l-dvb-master/v4l'
 make: *** [all] Error 2

As I can see in the include/linux/kfifo.h ( 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=history;f=include/linux/kfifo.h
 )
there is renaming of
 - kfifo_put into kfifo_in_locked
 - kfifo_get into kfifo_out_locked

Possible solutions would be:

 a) disable the compiling of cx23888-ir.c before 2.6.33

 b) adding something like this to v4l/compat.h:

#if LINUX_VERSION_CODE  KERNEL_VERSION(2, 6, 33)
#define kfifo_in_locked kfifo_put
#define kfifo_out_locked kfifo_get
#endif

What do you think the best way would be?

Regards,

Márton Németh
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2010-01-14 Thread Laurent Pinchart
Hi Németh,

On Thursday 14 January 2010 21:22:44 Németh Márton wrote:
 Hans Verkuil wrote:
  Detailed results are available here:
 
  http://www.xs4all.nl/~hverkuil/logs/Thursday.log
 
  linux-2.6.32-i686: ERRORS
 
  /marune/build/v4l-dvb-master/v4l/cx23888-ir.c: In function
  'cx23888_ir_irq_handler':  CC [M] 
  /marune/build/v4l-dvb-master/v4l/cx23885-f300.o
 
  /marune/build/v4l-dvb-master/v4l/cx23888-ir.c:621: error: implicit
  declaration of function 'kfifo_in_locked'
  /marune/build/v4l-dvb-master/v4l/cx23888-ir.c: In function
  'cx23888_ir_rx_read': /marune/build/v4l-dvb-master/v4l/cx23888-ir.c:688:
  error: implicit declaration of function 'kfifo_out_locked'
  /marune/build/v4l-dvb-master/v4l/cx23888-ir.c: In function
  'cx23888_ir_probe': /marune/build/v4l-dvb-master/v4l/cx23888-ir.c:1243:
  warning: passing argument 1 of 'kfifo_alloc' makes integer from pointer
  without a cast include/linux/kfifo.h:37: note: expected 'unsigned int'
  but argument is of type 'struct kfifo *'
  /marune/build/v4l-dvb-master/v4l/cx23888-ir.c:1243: warning: passing
  argument 3 of 'kfifo_alloc' makes pointer from integer without a cast
  include/linux/kfifo.h:37: note: expected 'struct spinlock_t *' but
  argument is of type 'unsigned int' make[3]: ***
  [/marune/build/v4l-dvb-master/v4l/cx23888-ir.o] Error 1 make[3]: ***
  Waiting for unfinished jobs
  make[2]: *** [_module_/marune/build/v4l-dvb-master/v4l] Error 2
  make[2]: Leaving directory `/marune/build/trees/i686/linux-2.6.32'
  make[1]: *** [default] Error 2
  make[1]: Leaving directory `/marune/build/v4l-dvb-master/v4l'
  make: *** [all] Error 2
 
 As I can see in the include/linux/kfifo.h (
  http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=history
 ;f=include/linux/kfifo.h ) there is renaming of
  - kfifo_put into kfifo_in_locked
  - kfifo_get into kfifo_out_locked
 
 Possible solutions would be:
 
  a) disable the compiling of cx23888-ir.c before 2.6.33
 
  b) adding something like this to v4l/compat.h:
 
 #if LINUX_VERSION_CODE  KERNEL_VERSION(2, 6, 33)
 #define kfifo_in_locked kfifo_put
 #define kfifo_out_locked kfifo_get
 #endif

I don't think that would be enough. The kfifo API has changed quite a lot in 
2.6.33. It will be difficult to handle that solely through compat.h. 
Conditional compilation based on the kernel version would probably be needed 
in the cx23888 driver itself.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-12-14 Thread Jean-Francois Moine
On Sun, 13 Dec 2009 21:46:28 +0100
Németh Márton nm...@freemail.hu wrote:

 It seems that kernels before 2.6.24 (inclusively) do not have
 __devinitconst, so  conex.c and etoms.c can only build with 2.6.25
 and later. Should USB_GSPCA_CONEX and USB_GSPCA_ETOMS be added to
 v4l/versions.txt?

The fix is not the right one. Some other gspca subdrivers use
__devinitconst (pac7302, pac7311, sonixb and spca506). The fix is to
define the macro for kernels  2.6.25:

diff -r 174ad3097f17 linux/drivers/media/video/gspca/gspca.h
--- a/linux/drivers/media/video/gspca/gspca.h   Sun Dec 13 18:11:07
2009 +0100
+++ b/linux/drivers/media/video/gspca/gspca.h   Mon Dec 14 09:28:51
2009 +0100 @@ -11,6 +11,10 @@ /* compilation option */
 #define GSPCA_DEBUG 1
 
+#if LINUX_VERSION_CODE  KERNEL_VERSION(2, 6, 25)
+#define __devinitconst __section(.devinit.rodata)
+#endif
+
 #ifdef GSPCA_DEBUG
 /* GSPCA our debug messages */
 extern int gspca_debug;

I will ask to upload the changeset (actually in my test repository) as
soon as it is validated (i.e. if it works with hal).

-- 
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef |   http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-12-14 Thread Mauro Carvalho Chehab
Jean-Francois Moine wrote:
 On Sun, 13 Dec 2009 21:46:28 +0100
 Németh Márton nm...@freemail.hu wrote:
 
 It seems that kernels before 2.6.24 (inclusively) do not have
 __devinitconst, so  conex.c and etoms.c can only build with 2.6.25
 and later. Should USB_GSPCA_CONEX and USB_GSPCA_ETOMS be added to
 v4l/versions.txt?
 
 The fix is not the right one. Some other gspca subdrivers use
 __devinitconst (pac7302, pac7311, sonixb and spca506). The fix is to
 define the macro for kernels  2.6.25:
 
 diff -r 174ad3097f17 linux/drivers/media/video/gspca/gspca.h
 --- a/linux/drivers/media/video/gspca/gspca.h   Sun Dec 13 18:11:07
 2009 +0100
 +++ b/linux/drivers/media/video/gspca/gspca.h   Mon Dec 14 09:28:51
 2009 +0100 @@ -11,6 +11,10 @@ /* compilation option */
  #define GSPCA_DEBUG 1
  
 +#if LINUX_VERSION_CODE  KERNEL_VERSION(2, 6, 25)
 +#define __devinitconst __section(.devinit.rodata)
 +#endif
 +

Better to add it at v4l/compat.h, to avoid polluting the drivers with
compat code.

Cheers
Mauro
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-12-13 Thread Németh Márton
Hans Verkuil wrote:
 Detailed results are available here:
 
 http://www.xs4all.nl/~hverkuil/logs/Sunday.log
 linux-2.6.24.7-i686: ERRORS

 /marune/build/v4l-dvb-master/v4l/conex.c:1049: error: expected '=', ',', 
 ';', 'asm' or '__attribute__' before '__devinitconst'
 /marune/build/v4l-dvb-master/v4l/conex.c:1065: error: 'device_table' 
 undeclared here (not in a function)
 make[3]: *** [/marune/build/v4l-dvb-master/v4l/conex.o] Error 1
 make[3]: *** Waiting for unfinished jobs
 /marune/build/v4l-dvb-master/v4l/etoms.c:873: error: expected '=', ',', ';', 
 'asm' or '__attribute__' before '__devinitconst'
 /marune/build/v4l-dvb-master/v4l/etoms.c:893: error: 'device_table' 
 undeclared here (not in a function)
 make[3]: *** [/marune/build/v4l-dvb-master/v4l/etoms.o] Error 1
 make[2]: *** [_module_/marune/build/v4l-dvb-master/v4l] Error 2
 make[2]: Leaving directory `/marune/build/trees/i686/linux-2.6.24.7'
 make[1]: *** [default] Error 2
 make[1]: Leaving directory `/marune/build/v4l-dvb-master/v4l'
 make: *** [all] Error 2
 Sun Dec 13 19:13:59 CET 2009

It seems that kernels before 2.6.24 (inclusively) do not have __devinitconst, 
so  conex.c
and etoms.c can only build with 2.6.25 and later. Should USB_GSPCA_CONEX and 
USB_GSPCA_ETOMS
be added to v4l/versions.txt?

---
From: Márton Németh nm...@freemail.hu

The conex and etoms drivers only build with kernel version 2.6.25 and later.

Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r e2f13778b5dc v4l/versions.txt
--- a/v4l/versions.txt  Sat Dec 12 17:25:43 2009 +0100
+++ b/v4l/versions.txt  Sun Dec 13 21:40:58 2009 +0100
@@ -54,6 +54,11 @@
 RADIO_SI4713
 I2C_SI4713

+[2.6.25]
+# The drivers uses __devinitconst
+USB_GSPCA_CONEX
+USB_GSPCA_ETOMS
+
 [2.6.24]
 # Some freezer routines
 USB_GSPCA_SN9C20X_EVDEV

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-11-22 Thread Németh Márton
Hans Verkuil worte:
 linux-2.6.22.19-armv5: WARNINGS

/marune/build/v4l-dvb-master/v4l/videobuf-core.c: In function 
'videobuf_reqbufs':
/marune/build/v4l-dvb-master/v4l/videobuf-core.c:434: warning: format '%d' 
expects type 'int', but argument 4 has type 'long unsigned int'

I think this can be solved by explicit casting the result.

---
Subject: [PATCH] explicitly cast page count
From: Márton Németh nm...@freemail.hu

Explicitly cast page count in the debug message.

Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r bc16afd1e7a4 linux/drivers/media/video/videobuf-core.c
--- a/linux/drivers/media/video/videobuf-core.c Sat Nov 21 12:01:36 2009 +0100
+++ b/linux/drivers/media/video/videobuf-core.c Sun Nov 22 21:56:20 2009 +0100
@@ -431,8 +431,9 @@
count = VIDEO_MAX_FRAME;
size = 0;
q-ops-buf_setup(q, count, size);
-   dprintk(1, reqbufs: bufs=%d, size=0x%x [%d pages total]\n,
-   count, size, (count*PAGE_ALIGN(size))PAGE_SHIFT);
+   dprintk(1, reqbufs: bufs=%d, size=0x%x [%u pages total]\n,
+   count, size,
+   (unsigned int)((count*PAGE_ALIGN(size))PAGE_SHIFT) );

retval = __videobuf_mmap_setup(q, count, size, req-memory);
if (retval  0) {
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-08-21 Thread Hans Verkuil
On Friday 21 August 2009 20:17:18 Hans Verkuil wrote:
 This message is generated daily by a cron job that builds v4l-dvb for
 the kernels and architectures in the list below.

Guys, I'm providing this service for a reason: please take a look at the 
detailed log when you see errors or warnings.

This time round we have a compat error with DIV_ROUND_CLOSEST:

v4l/stb6100.c: In function 'stb6100_set_frequency':
v4l/stb6100.c:377: error: implicit declaration of 
function 'DIV_ROUND_CLOSEST'

Should be simple to fix. This macro appeared in 2.6.29 and so should be made 
available in compat.h.

I also get a large amount of errors on smssdio.c for kernels pre-2.6.24:

v4l/smssdio.c:39:33: error: linux/mmc/sdio_func.h: No such file or directory
v4l/smssdio.c:51: error: array type has incomplete element type
v4l/smssdio.c:52: warning: implicit declaration of function 'SDIO_DEVICE'
v4l/smssdio.c:53: error: field name not in record or union initializer
v4l/smssdio.c:53: error: (near initialization for 'smssdio_ids')

This header appeared in 2.6.24 for the first time, so this driver shouldn't 
be build on older kernel versions.

There is also a warning here:

v4l/smssdio.c: In function 'smssdio_sendrequest':
v4l/smssdio.c:81: warning: 'ret' may be used uninitialized in this function

The bttv driver has been broken for a lng time for kernels = 2.6.19:

v4l/bttv-driver.c:4635: warning: implicit declaration of 
function 'PCI_VDEVICE'
v4l/bttv-driver.c:4635: error: 'BROOKTREE' undeclared here (not in a 
function)

I don't care about anything pre-2.6.22, but since some people wanted it I've 
kept compiling against these old kernels. But if nobody fixes this soon, 
then I'm going to kill that off since I have better uses for those CPU 
cycles.

Bottom line: if you know that a change of yours was merged in v4l-dvb, and 
you see errors or warnings appearing in the daily build, then take a look 
if your change caused it, and if so, then please fix it asap.

Regards,

Hans


 Results of the daily build of v4l-dvb:

 date:Fri Aug 21 19:00:07 CEST 2009
 path:http://www.linuxtv.org/hg/v4l-dvb
 changeset:   12492:d0ec20a376fe
 gcc version: gcc (GCC) 4.3.1
 hardware:x86_64
 host os: 2.6.26

 linux-2.6.22.19-armv5: OK
 linux-2.6.23.12-armv5: OK
 linux-2.6.24.7-armv5: OK
 linux-2.6.25.11-armv5: OK
 linux-2.6.26-armv5: OK
 linux-2.6.27-armv5: OK
 linux-2.6.28-armv5: OK
 linux-2.6.29.1-armv5: OK
 linux-2.6.30-armv5: OK
 linux-2.6.31-rc5-armv5: OK
 linux-2.6.27-armv5-ixp: ERRORS
 linux-2.6.28-armv5-ixp: ERRORS
 linux-2.6.29.1-armv5-ixp: OK
 linux-2.6.30-armv5-ixp: OK
 linux-2.6.31-rc5-armv5-ixp: OK
 linux-2.6.28-armv5-omap2: ERRORS
 linux-2.6.29.1-armv5-omap2: OK
 linux-2.6.30-armv5-omap2: OK
 linux-2.6.31-rc5-armv5-omap2: OK
 linux-2.6.22.19-i686: ERRORS
 linux-2.6.23.12-i686: ERRORS
 linux-2.6.24.7-i686: ERRORS
 linux-2.6.25.11-i686: ERRORS
 linux-2.6.26-i686: ERRORS
 linux-2.6.27-i686: ERRORS
 linux-2.6.28-i686: ERRORS
 linux-2.6.29.1-i686: WARNINGS
 linux-2.6.30-i686: WARNINGS
 linux-2.6.31-rc5-i686: OK
 linux-2.6.23.12-m32r: ERRORS
 linux-2.6.24.7-m32r: OK
 linux-2.6.25.11-m32r: OK
 linux-2.6.26-m32r: OK
 linux-2.6.27-m32r: OK
 linux-2.6.28-m32r: OK
 linux-2.6.29.1-m32r: OK
 linux-2.6.30-m32r: OK
 linux-2.6.31-rc5-m32r: OK
 linux-2.6.30-mips: WARNINGS
 linux-2.6.31-rc5-mips: OK
 linux-2.6.27-powerpc64: ERRORS
 linux-2.6.28-powerpc64: ERRORS
 linux-2.6.29.1-powerpc64: WARNINGS
 linux-2.6.30-powerpc64: WARNINGS
 linux-2.6.31-rc5-powerpc64: OK
 linux-2.6.22.19-x86_64: ERRORS
 linux-2.6.23.12-x86_64: ERRORS
 linux-2.6.24.7-x86_64: ERRORS
 linux-2.6.25.11-x86_64: ERRORS
 linux-2.6.26-x86_64: ERRORS
 linux-2.6.27-x86_64: ERRORS
 linux-2.6.28-x86_64: ERRORS
 linux-2.6.29.1-x86_64: WARNINGS
 linux-2.6.30-x86_64: WARNINGS
 linux-2.6.31-rc5-x86_64: OK
 sparse (linux-2.6.30): OK
 sparse (linux-2.6.31-rc5): OK
 linux-2.6.16.61-i686: ERRORS
 linux-2.6.17.14-i686: ERRORS
 linux-2.6.18.8-i686: ERRORS
 linux-2.6.19.5-i686: ERRORS
 linux-2.6.20.21-i686: ERRORS
 linux-2.6.21.7-i686: ERRORS
 linux-2.6.16.61-x86_64: ERRORS
 linux-2.6.17.14-x86_64: ERRORS
 linux-2.6.18.8-x86_64: ERRORS
 linux-2.6.19.5-x86_64: ERRORS
 linux-2.6.20.21-x86_64: ERRORS
 linux-2.6.21.7-x86_64: ERRORS

 Detailed results are available here:

 http://www.xs4all.nl/~hverkuil/logs/Friday.log

 Full logs are available here:

 http://www.xs4all.nl/~hverkuil/logs/Friday.tar.bz2

 The V4L2 specification from this daily build is here:

 http://www.xs4all.nl/~hverkuil/spec/v4l2.html

 The DVB API specification from this daily build is here:

 http://www.xs4all.nl/~hverkuil/spec/dvbapi.pdf

 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to 

Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-08-21 Thread Andy Walls
On Fri, 2009-08-21 at 22:45 +0200, Hans Verkuil wrote:
 On Friday 21 August 2009 20:17:18 Hans Verkuil wrote:
  This message is generated daily by a cron job that builds v4l-dvb for
  the kernels and architectures in the list below.
 
 Guys, I'm providing this service for a reason: please take a look at the 
 detailed log when you see errors or warnings.
 
 This time round we have a compat error with DIV_ROUND_CLOSEST:
 
 v4l/stb6100.c: In function 'stb6100_set_frequency':
 v4l/stb6100.c:377: error: implicit declaration of 
 function 'DIV_ROUND_CLOSEST'
 
 Should be simple to fix. This macro appeared in 2.6.29 and so should be made 
 available in compat.h.

A patch for this one was submitted to the list earlier today:

http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/9142

(though not because I saw it in the logs).

I do usually scan the logs for cx18, ivtv, and cx25840 problems.  Maybe
I should expand my scope a little.

Regards,
Andy

 I also get a large amount of errors on smssdio.c for kernels pre-2.6.24:
 
 v4l/smssdio.c:39:33: error: linux/mmc/sdio_func.h: No such file or directory
 v4l/smssdio.c:51: error: array type has incomplete element type
 v4l/smssdio.c:52: warning: implicit declaration of function 'SDIO_DEVICE'
 v4l/smssdio.c:53: error: field name not in record or union initializer
 v4l/smssdio.c:53: error: (near initialization for 'smssdio_ids')
 
 This header appeared in 2.6.24 for the first time, so this driver shouldn't 
 be build on older kernel versions.
 
 There is also a warning here:
 
 v4l/smssdio.c: In function 'smssdio_sendrequest':
 v4l/smssdio.c:81: warning: 'ret' may be used uninitialized in this function
 
 The bttv driver has been broken for a lng time for kernels = 2.6.19:
 
 v4l/bttv-driver.c:4635: warning: implicit declaration of 
 function 'PCI_VDEVICE'
 v4l/bttv-driver.c:4635: error: 'BROOKTREE' undeclared here (not in a 
 function)
 
 I don't care about anything pre-2.6.22, but since some people wanted it I've 
 kept compiling against these old kernels. But if nobody fixes this soon, 
 then I'm going to kill that off since I have better uses for those CPU 
 cycles.
 
 Bottom line: if you know that a change of yours was merged in v4l-dvb, and 
 you see errors or warnings appearing in the daily build, then take a look 
 if your change caused it, and if so, then please fix it asap.
 
 Regards,
 
   Hans
 
 
  Results of the daily build of v4l-dvb:
 
  date:Fri Aug 21 19:00:07 CEST 2009
  path:http://www.linuxtv.org/hg/v4l-dvb
  changeset:   12492:d0ec20a376fe
  gcc version: gcc (GCC) 4.3.1
  hardware:x86_64
  host os: 2.6.26
 
  linux-2.6.22.19-armv5: OK
  linux-2.6.23.12-armv5: OK
  linux-2.6.24.7-armv5: OK
  linux-2.6.25.11-armv5: OK
  linux-2.6.26-armv5: OK
  linux-2.6.27-armv5: OK
  linux-2.6.28-armv5: OK
  linux-2.6.29.1-armv5: OK
  linux-2.6.30-armv5: OK
  linux-2.6.31-rc5-armv5: OK
  linux-2.6.27-armv5-ixp: ERRORS
  linux-2.6.28-armv5-ixp: ERRORS
  linux-2.6.29.1-armv5-ixp: OK
  linux-2.6.30-armv5-ixp: OK
  linux-2.6.31-rc5-armv5-ixp: OK
  linux-2.6.28-armv5-omap2: ERRORS
  linux-2.6.29.1-armv5-omap2: OK
  linux-2.6.30-armv5-omap2: OK
  linux-2.6.31-rc5-armv5-omap2: OK
  linux-2.6.22.19-i686: ERRORS
  linux-2.6.23.12-i686: ERRORS
  linux-2.6.24.7-i686: ERRORS
  linux-2.6.25.11-i686: ERRORS
  linux-2.6.26-i686: ERRORS
  linux-2.6.27-i686: ERRORS
  linux-2.6.28-i686: ERRORS
  linux-2.6.29.1-i686: WARNINGS
  linux-2.6.30-i686: WARNINGS
  linux-2.6.31-rc5-i686: OK
  linux-2.6.23.12-m32r: ERRORS
  linux-2.6.24.7-m32r: OK
  linux-2.6.25.11-m32r: OK
  linux-2.6.26-m32r: OK
  linux-2.6.27-m32r: OK
  linux-2.6.28-m32r: OK
  linux-2.6.29.1-m32r: OK
  linux-2.6.30-m32r: OK
  linux-2.6.31-rc5-m32r: OK
  linux-2.6.30-mips: WARNINGS
  linux-2.6.31-rc5-mips: OK
  linux-2.6.27-powerpc64: ERRORS
  linux-2.6.28-powerpc64: ERRORS
  linux-2.6.29.1-powerpc64: WARNINGS
  linux-2.6.30-powerpc64: WARNINGS
  linux-2.6.31-rc5-powerpc64: OK
  linux-2.6.22.19-x86_64: ERRORS
  linux-2.6.23.12-x86_64: ERRORS
  linux-2.6.24.7-x86_64: ERRORS
  linux-2.6.25.11-x86_64: ERRORS
  linux-2.6.26-x86_64: ERRORS
  linux-2.6.27-x86_64: ERRORS
  linux-2.6.28-x86_64: ERRORS
  linux-2.6.29.1-x86_64: WARNINGS
  linux-2.6.30-x86_64: WARNINGS
  linux-2.6.31-rc5-x86_64: OK
  sparse (linux-2.6.30): OK
  sparse (linux-2.6.31-rc5): OK
  linux-2.6.16.61-i686: ERRORS
  linux-2.6.17.14-i686: ERRORS
  linux-2.6.18.8-i686: ERRORS
  linux-2.6.19.5-i686: ERRORS
  linux-2.6.20.21-i686: ERRORS
  linux-2.6.21.7-i686: ERRORS
  linux-2.6.16.61-x86_64: ERRORS
  linux-2.6.17.14-x86_64: ERRORS
  linux-2.6.18.8-x86_64: ERRORS
  linux-2.6.19.5-x86_64: ERRORS
  linux-2.6.20.21-x86_64: ERRORS
  linux-2.6.21.7-x86_64: ERRORS
 
  Detailed results are available here:
 
  http://www.xs4all.nl/~hverkuil/logs/Friday.log
 
  Full logs are available here:
 
  http://www.xs4all.nl/~hverkuil/logs/Friday.tar.bz2
 
  The V4L2 specification from this daily build is here:
 
  

Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-08-21 Thread Mauro Carvalho Chehab
Em Fri, 21 Aug 2009 18:10:45 -0400
Andy Walls awa...@radix.net escreveu:

  Guys, I'm providing this service for a reason: please take a look at the 
  detailed log when you see errors or warnings.
  
  This time round we have a compat error with DIV_ROUND_CLOSEST:
  
  v4l/stb6100.c: In function 'stb6100_set_frequency':
  v4l/stb6100.c:377: error: implicit declaration of 
  function 'DIV_ROUND_CLOSEST'
  
  Should be simple to fix. This macro appeared in 2.6.29 and so should be 
  made 
  available in compat.h.
 
At the days I'm preparing some upstream patches, it is not rare to have some
backport breakage, since lots of patches are merged, including, on some cases,
some upstream patches that need extra backport.

I intend to finish sync -hg and -git this weekend, so, I'll be fixing the 
remaining backport issues.

 A patch for this one was submitted to the list earlier today:
 
 http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/9142
 
 (though not because I saw it in the logs).

I saw that. It will be merged as well.


Cheers,
Mauro
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS (ignore: just a test)

2009-05-03 Thread Amir Bukhari

just a test email to see if I receive it from the mailing list.

I notice that my email I send to linux-media@vger.kernel.org I don't 
received it but I receive others

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-05-01 Thread Mike Isely
On Fri, 1 May 2009, Alexey Klimov wrote:

 Hello,
 
 On Mon, Apr 20, 2009 at 3:59 AM, Mike Isely is...@isely.net wrote:

   [...]

 
  So the kernel already has this; it just needs to be pulled back into
  v4l-dvb.  It's an obvious trivial thing for now and I've acked it there.
  Obviously we're getting had here because you're compiling against a
  kernel snapshot that's been changed but v4l-dvb doesn't have the
  corresponding change in its local copy of the pvrusb2 driver.  Part of
  the fun of synchronizing changes from different trees :-(
 
 Well, good to know that this thing is already fixed.
 I'm very sorry for the mess.

No apology needed.  Really - this mess wasn't caused by you.  If 
anything I should have just immediately pulled that patch into hg and 
not waited for it to trickle back to Mauro.  That would have avoided the 
error.  So, all I can say is that I'm sorry you had to hit this!

  -Mike


-- 

Mike Isely
isely @ isely (dot) net
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8

Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-04-30 Thread Alexey Klimov
Hello,

On Mon, Apr 20, 2009 at 3:59 AM, Mike Isely is...@isely.net wrote:
 On Mon, 20 Apr 2009, Alexey Klimov wrote:

   [...]

 When trying to compile v4l-dvb tree under 2.6.30-rc2 (up-to-date) i
 have such error with pvr2 module:

   CC [M]  /w/new/v4l-dvb/v4l/pvrusb2-hdw.o
 /w/new/v4l-dvb/v4l/pvrusb2-hdw.c: In function 'pvr2_upload_firmware1':
 /w/new/v4l-dvb/v4l/pvrusb2-hdw.c:1474: error: implicit declaration of
 function 'usb_settoggle'
 /w/new/v4l-dvb/v4l/pvrusb2-hdw.c: In function 'pvr2_hdw_load_modules':
 /w/new/v4l-dvb/v4l/pvrusb2-hdw.c:2133: warning: format not a string
 literal and no format arguments
 make[3]: *** [/w/new/v4l-dvb/v4l/pvrusb2-hdw.o] Error 1
 make[2]: *** [_module_/w/new/v4l-dvb/v4l] Error 2

 It's probably due to this git commit:
 http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3444b26afa145148951112534f298bdc554ec789

 I don't have idea how to fix it fast and correctly.

 This might explain things a bit.  The following thread took place on
 linux-usb on 7-April:

Well, looks like it explains everything.

 quote

 On Tue, 7 Apr 2009, Greg KH wrote:

 On Tue, Apr 07, 2009 at 05:31:55PM +, David Vrabel wrote:
  Wireless USB endpoint state has a sequence number and a current
  window and not just a single toggle bit.  So allow HCDs to provide a
  endpoint_reset method and call this or clear the software toggles as
  required (after a clear halt).
 
  usb_settoggle() and friends are then HCD internal and are moved into
  core/hcd.h.

 You remove this api, yet the pvrusb2 driver used it, and you don't seem
 to have resolved the issue where it was calling it:

  diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c 
  b/drivers/media/video/pvrusb2/pvrusb2-hdw.c
  index fa304e5..b86682d 100644
  --- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c
  +++ b/drivers/media/video/pvrusb2/pvrusb2-hdw.c
  @@ -1418,7 +1418,6 @@ static int pvr2_upload_firmware1(struct pvr2_hdw 
  *hdw)
              return ret;
      }
 
  -   usb_settoggle(hdw-usb_dev, 0  0xf, !(0  USB_DIR_IN), 0);
      usb_clear_halt(hdw-usb_dev, usb_sndbulkpipe(hdw-usb_dev, 0  0x7f));
 
      pipe = usb_sndctrlpipe(hdw-usb_dev, 0);

 Should usb_reset_endpoint() be called here instead?


 Speaking as the maintainer of that driver, I'm OK with accepting this
 as-is for now.  This is a sequence that should not interfere with normal
 driver operation.  I will look at this further a little later (not
 likely before the merge window closes) and if this change turns out to
 cause a problem I'll make a follow-up fix upstream.

 Acked-By: Mike Isely is...@pobox.com

  -Mike

 /quote

 So the kernel already has this; it just needs to be pulled back into
 v4l-dvb.  It's an obvious trivial thing for now and I've acked it there.
 Obviously we're getting had here because you're compiling against a
 kernel snapshot that's been changed but v4l-dvb doesn't have the
 corresponding change in its local copy of the pvrusb2 driver.  Part of
 the fun of synchronizing changes from different trees :-(

Well, good to know that this thing is already fixed.
I'm very sorry for the mess.

-- 
Best regards, Klimov Alexey
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-04-19 Thread Alexey Klimov
On Sun, Apr 19, 2009 at 10:18 PM, Hans Verkuil hverk...@xs4all.nl wrote:
 This message is generated daily by a cron job that builds v4l-dvb for
 the kernels and architectures in the list below.

 Results of the daily build of v4l-dvb:

 date:        Sun Apr 19 19:00:03 CEST 2009
 path:        http://www.linuxtv.org/hg/v4l-dvb
 changeset:   11517:cda79523a93c
 gcc version: gcc (GCC) 4.3.1
 hardware:    x86_64
 host os:     2.6.26

 linux-2.6.22.19-armv5: OK
 linux-2.6.23.12-armv5: OK
 linux-2.6.24.7-armv5: OK
 linux-2.6.25.11-armv5: OK
 linux-2.6.26-armv5: OK
 linux-2.6.27-armv5: OK
 linux-2.6.28-armv5: OK
 linux-2.6.29.1-armv5: OK
 linux-2.6.30-rc1-armv5: OK
 linux-2.6.27-armv5-ixp: OK
 linux-2.6.28-armv5-ixp: OK
 linux-2.6.29.1-armv5-ixp: OK
 linux-2.6.30-rc1-armv5-ixp: WARNINGS
 linux-2.6.28-armv5-omap2: OK
 linux-2.6.29.1-armv5-omap2: OK
 linux-2.6.30-rc1-armv5-omap2: WARNINGS
 linux-2.6.22.19-i686: WARNINGS
 linux-2.6.23.12-i686: ERRORS
 linux-2.6.24.7-i686: OK
 linux-2.6.25.11-i686: OK
 linux-2.6.26-i686: OK
 linux-2.6.27-i686: OK
 linux-2.6.28-i686: OK
 linux-2.6.29.1-i686: OK
 linux-2.6.30-rc1-i686: WARNINGS

When trying to compile v4l-dvb tree under 2.6.30-rc2 (up-to-date) i
have such error with pvr2 module:

  CC [M]  /w/new/v4l-dvb/v4l/pvrusb2-hdw.o
/w/new/v4l-dvb/v4l/pvrusb2-hdw.c: In function 'pvr2_upload_firmware1':
/w/new/v4l-dvb/v4l/pvrusb2-hdw.c:1474: error: implicit declaration of
function 'usb_settoggle'
/w/new/v4l-dvb/v4l/pvrusb2-hdw.c: In function 'pvr2_hdw_load_modules':
/w/new/v4l-dvb/v4l/pvrusb2-hdw.c:2133: warning: format not a string
literal and no format arguments
make[3]: *** [/w/new/v4l-dvb/v4l/pvrusb2-hdw.o] Error 1
make[2]: *** [_module_/w/new/v4l-dvb/v4l] Error 2

It's probably due to this git commit:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3444b26afa145148951112534f298bdc554ec789

I don't have idea how to fix it fast and correctly.

-- 
Best regards, Klimov Alexey
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-04-19 Thread hermann pitton
Hi,

Am Montag, den 20.04.2009, 02:42 +0400 schrieb Alexey Klimov:
 On Sun, Apr 19, 2009 at 10:18 PM, Hans Verkuil hverk...@xs4all.nl wrote:
  This message is generated daily by a cron job that builds v4l-dvb for
  the kernels and architectures in the list below.
 
  Results of the daily build of v4l-dvb:
 
  date:Sun Apr 19 19:00:03 CEST 2009
  path:http://www.linuxtv.org/hg/v4l-dvb
  changeset:   11517:cda79523a93c
  gcc version: gcc (GCC) 4.3.1
  hardware:x86_64
  host os: 2.6.26
 
  linux-2.6.22.19-armv5: OK
  linux-2.6.23.12-armv5: OK
  linux-2.6.24.7-armv5: OK
  linux-2.6.25.11-armv5: OK
  linux-2.6.26-armv5: OK
  linux-2.6.27-armv5: OK
  linux-2.6.28-armv5: OK
  linux-2.6.29.1-armv5: OK
  linux-2.6.30-rc1-armv5: OK
  linux-2.6.27-armv5-ixp: OK
  linux-2.6.28-armv5-ixp: OK
  linux-2.6.29.1-armv5-ixp: OK
  linux-2.6.30-rc1-armv5-ixp: WARNINGS
  linux-2.6.28-armv5-omap2: OK
  linux-2.6.29.1-armv5-omap2: OK
  linux-2.6.30-rc1-armv5-omap2: WARNINGS
  linux-2.6.22.19-i686: WARNINGS
  linux-2.6.23.12-i686: ERRORS
  linux-2.6.24.7-i686: OK
  linux-2.6.25.11-i686: OK
  linux-2.6.26-i686: OK
  linux-2.6.27-i686: OK
  linux-2.6.28-i686: OK
  linux-2.6.29.1-i686: OK
  linux-2.6.30-rc1-i686: WARNINGS
 
 When trying to compile v4l-dvb tree under 2.6.30-rc2 (up-to-date) i
 have such error with pvr2 module:
 
   CC [M]  /w/new/v4l-dvb/v4l/pvrusb2-hdw.o
 /w/new/v4l-dvb/v4l/pvrusb2-hdw.c: In function 'pvr2_upload_firmware1':
 /w/new/v4l-dvb/v4l/pvrusb2-hdw.c:1474: error: implicit declaration of
 function 'usb_settoggle'
 /w/new/v4l-dvb/v4l/pvrusb2-hdw.c: In function 'pvr2_hdw_load_modules':
 /w/new/v4l-dvb/v4l/pvrusb2-hdw.c:2133: warning: format not a string
 literal and no format arguments
 make[3]: *** [/w/new/v4l-dvb/v4l/pvrusb2-hdw.o] Error 1
 make[2]: *** [_module_/w/new/v4l-dvb/v4l] Error 2
 
 It's probably due to this git commit:
 http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3444b26afa145148951112534f298bdc554ec789
 
 I don't have idea how to fix it fast and correctly.
 

without looking into further details, did build a 2.6.30-rc2-git4
yesterday evening for an x86_64 and the whole media tree compiled
without warnings and errors including that one.

Was looking for if, the the breakage of some saa7134 cards on 2.6.29
made it into that one too. As far as I can say without graphics card and
wireless support there, but able to record, luckily not.

Maybe give it a try and/or identify related further patches.
Is git5 now.

Cheers,
Hermann




--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-04-19 Thread Mike Isely
On Mon, 20 Apr 2009, Alexey Klimov wrote:

   [...]

 When trying to compile v4l-dvb tree under 2.6.30-rc2 (up-to-date) i
 have such error with pvr2 module:
 
   CC [M]  /w/new/v4l-dvb/v4l/pvrusb2-hdw.o
 /w/new/v4l-dvb/v4l/pvrusb2-hdw.c: In function 'pvr2_upload_firmware1':
 /w/new/v4l-dvb/v4l/pvrusb2-hdw.c:1474: error: implicit declaration of
 function 'usb_settoggle'
 /w/new/v4l-dvb/v4l/pvrusb2-hdw.c: In function 'pvr2_hdw_load_modules':
 /w/new/v4l-dvb/v4l/pvrusb2-hdw.c:2133: warning: format not a string
 literal and no format arguments
 make[3]: *** [/w/new/v4l-dvb/v4l/pvrusb2-hdw.o] Error 1
 make[2]: *** [_module_/w/new/v4l-dvb/v4l] Error 2
 
 It's probably due to this git commit:
 http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3444b26afa145148951112534f298bdc554ec789
 
 I don't have idea how to fix it fast and correctly.

This might explain things a bit.  The following thread took place on 
linux-usb on 7-April:

quote

On Tue, 7 Apr 2009, Greg KH wrote:

 On Tue, Apr 07, 2009 at 05:31:55PM +, David Vrabel wrote:
  Wireless USB endpoint state has a sequence number and a current
  window and not just a single toggle bit.  So allow HCDs to provide a
  endpoint_reset method and call this or clear the software toggles as
  required (after a clear halt).
 
  usb_settoggle() and friends are then HCD internal and are moved into
  core/hcd.h.

 You remove this api, yet the pvrusb2 driver used it, and you don't seem
 to have resolved the issue where it was calling it:

  diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c 
  b/drivers/media/video/pvrusb2/pvrusb2-hdw.c
  index fa304e5..b86682d 100644
  --- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c
  +++ b/drivers/media/video/pvrusb2/pvrusb2-hdw.c
  @@ -1418,7 +1418,6 @@ static int pvr2_upload_firmware1(struct pvr2_hdw *hdw)
  return ret;
  }
 
  -   usb_settoggle(hdw-usb_dev, 0  0xf, !(0  USB_DIR_IN), 0);
  usb_clear_halt(hdw-usb_dev, usb_sndbulkpipe(hdw-usb_dev, 0  0x7f));
 
  pipe = usb_sndctrlpipe(hdw-usb_dev, 0);

 Should usb_reset_endpoint() be called here instead?


Speaking as the maintainer of that driver, I'm OK with accepting this
as-is for now.  This is a sequence that should not interfere with normal
driver operation.  I will look at this further a little later (not
likely before the merge window closes) and if this change turns out to
cause a problem I'll make a follow-up fix upstream.

Acked-By: Mike Isely is...@pobox.com

  -Mike

/quote

So the kernel already has this; it just needs to be pulled back into 
v4l-dvb.  It's an obvious trivial thing for now and I've acked it there.  
Obviously we're getting had here because you're compiling against a 
kernel snapshot that's been changed but v4l-dvb doesn't have the 
corresponding change in its local copy of the pvrusb2 driver.  Part of 
the fun of synchronizing changes from different trees :-(

Mauro:  If you just want to take this as-is (or find the git commit and 
pull it down), I'm fine.  Otherwise I'll set up a repo that you can pull 
from with this single-line change.  The above changeset also has the 
following attributions:

From: David Vrabel david.vra...@csr.com
Signed-off-by: David Vrabel david.vra...@csr.com

  -Mike



-- 

Mike Isely
isely @ pobox (dot) com
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html