Re: CI-Module not working on Technisat Cablestar HD2
Pascal Hahn writes: > Thanks for the feedback already. Do you know which kernel version this > driver is functional in out of the top of your head? > > I tried multiple kernels and had no luck getting it to work so far. If you are talking about the mantis driver in Linus' mainline kernels, then it isn't updated at all since it was merged. No need to try different kernels. They are all the same with respect to this driver. But the mantis driver went through a lot of changes during the very active development before it was merged, and the CA code used to be enabled at some point. But I do not know if it worked. And there were most likely very good reasons to disable it... Google will know. Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: CI-Module not working on Technisat Cablestar HD2
Thanks for the feedback already. Do you know which kernel version this
driver is functional in out of the top of your head?
I tried multiple kernels and had no luck getting it to work so far.
On Thu, Jun 24, 2010 at 2:32 PM, Bjørn Mork wrote:
> Pascal Hahn writes:
>
>> I can't see any of the expected mantis_ca_init but couldn't figure out
>> in the code where that gets called.
>
> I don't think it is. It was at some point, but it seems to be removed.
> Most likely because it wasn't considered ready at the time this driver
> was merged(?)
>
> BTW, there is a potentional null dereference in mantis_irq_handler(),
> which will do
>
> ca = mantis->mantis_ca;
> ..
> if (stat & MANTIS_INT_IRQ0) {
> dprintk(MANTIS_DEBUG, 0, "<%s>", label[1]);
> mantis->gpif_status = rst_stat;
> wake_up(&ca->hif_write_wq);
> schedule_work(&ca->hif_evm_work);
> }
>
> This will blow up if (stat & MANTIS_INT_IRQ0) is true, since
> mantis->mantis_ca never is allocated. But then I guess that the
> hardware should normally prevent (stat & MANTIS_INT_IRQ0) from being
> true as long as the ca system isn't initiated, so this does not pose a
> problem in practice.
>
> Still doesn't look good.
>
>
>
> Bjørn
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: CI-Module not working on Technisat Cablestar HD2
Pascal Hahn writes:
> I can't see any of the expected mantis_ca_init but couldn't figure out
> in the code where that gets called.
I don't think it is. It was at some point, but it seems to be removed.
Most likely because it wasn't considered ready at the time this driver
was merged(?)
BTW, there is a potentional null dereference in mantis_irq_handler(),
which will do
ca = mantis->mantis_ca;
..
if (stat & MANTIS_INT_IRQ0) {
dprintk(MANTIS_DEBUG, 0, "<%s>", label[1]);
mantis->gpif_status = rst_stat;
wake_up(&ca->hif_write_wq);
schedule_work(&ca->hif_evm_work);
}
This will blow up if (stat & MANTIS_INT_IRQ0) is true, since
mantis->mantis_ca never is allocated. But then I guess that the
hardware should normally prevent (stat & MANTIS_INT_IRQ0) from being
true as long as the ca system isn't initiated, so this does not pose a
problem in practice.
Still doesn't look good.
Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
