Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers

2016-01-04 Thread Russell King - ARM Linux
On Mon, Jan 04, 2016 at 08:07:40AM -0800, Joe Perches wrote: > On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote: > > + my $all_barriers = join('|', (@barriers, @smp_barriers)); > > + > > + if ($line =~ /\b($all_barriers)\(/) { > > It would be better to use /\b$all_ba

Re: [PATCH v2 17/32] arm: define __smp_xxx

2016-01-04 Thread Russell King - ARM Linux
On Mon, Jan 04, 2016 at 02:54:20PM +0100, Peter Zijlstra wrote: > On Mon, Jan 04, 2016 at 02:36:58PM +0100, Peter Zijlstra wrote: > > On Sun, Jan 03, 2016 at 11:12:44AM +0200, Michael S. Tsirkin wrote: > > > On Sat, Jan 02, 2016 at 11:24:38AM +0000, Russell King - ARM Linux wrot

Re: [PATCH v2 17/32] arm: define __smp_xxx

2016-01-02 Thread Russell King - ARM Linux
On Thu, Dec 31, 2015 at 09:07:59PM +0200, Michael S. Tsirkin wrote: > This defines __smp_xxx barriers for arm, > for use by virtualization. > > smp_xxx barriers are removed as they are > defined correctly by asm-generic/barriers.h > > This reduces the amount of arch-specific boiler-plate code. >

Re: [PATCH v2 08/32] arm: reuse asm-generic/barrier.h

2016-01-02 Thread Russell King - ARM Linux
On Thu, Dec 31, 2015 at 09:06:46PM +0200, Michael S. Tsirkin wrote: > On arm smp_store_mb, read_barrier_depends, smp_read_barrier_depends, > smp_store_release, smp_load_acquire, smp_mb__before_atomic and > smp_mb__after_atomic match the asm-generic variants exactly. Drop the > local definitions and