Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available
On Tue, Jul 14, 2015 at 01:59:19PM +, dwal...@fifo99.com wrote: On Mon, Jul 13, 2015 at 08:19:45PM -0500, Eric W. Biederman wrote: dwal...@fifo99.com writes: On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote: Hidehiro Kawai hidehiro.kawai...@hitachi.com writes: You can call panic notifiers and kmsg dumpers before kdump by specifying crash_kexec_post_notifiers as a boot parameter. However, it doesn't make sense if kdump is not available. In that case, disable crash_kexec_post_notifiers boot parameter so that you can't change the value of the parameter. Nacked-by: Eric W. Biederman ebied...@xmission.com I think it would make sense if he just replaced kdump with kexec. It would be less insane, however it still makes no sense as without kexec on panic support crash_kexec is a noop. So the value of the seeting makes no difference. Can you explain more, I don't really understand what you mean. Are you suggesting the whole crash_kexec_post_notifiers feature has no value ? If CONFIG_KEXEC=n, then crash_kexec() is a nop. So it does not matter whether crash_kexec() is called before panic notifiers or after. IOW, what do you gain by disabling crash_kexec_post_notifiers, in case of CONFIG_KEXEC=n? Thanks Vivek -- To unsubscribe from this list: send the line unsubscribe linux-metag in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available
On Mon, Jul 13, 2015 at 08:19:45PM -0500, Eric W. Biederman wrote: dwal...@fifo99.com writes: On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote: Hidehiro Kawai hidehiro.kawai...@hitachi.com writes: You can call panic notifiers and kmsg dumpers before kdump by specifying crash_kexec_post_notifiers as a boot parameter. However, it doesn't make sense if kdump is not available. In that case, disable crash_kexec_post_notifiers boot parameter so that you can't change the value of the parameter. Nacked-by: Eric W. Biederman ebied...@xmission.com I think it would make sense if he just replaced kdump with kexec. It would be less insane, however it still makes no sense as without kexec on panic support crash_kexec is a noop. So the value of the seeting makes no difference. Can you explain more, I don't really understand what you mean. Are you suggesting the whole crash_kexec_post_notifiers feature has no value ? Daniel -- To unsubscribe from this list: send the line unsubscribe linux-metag in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available
On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote: Hidehiro Kawai hidehiro.kawai...@hitachi.com writes: You can call panic notifiers and kmsg dumpers before kdump by specifying crash_kexec_post_notifiers as a boot parameter. However, it doesn't make sense if kdump is not available. In that case, disable crash_kexec_post_notifiers boot parameter so that you can't change the value of the parameter. Nacked-by: Eric W. Biederman ebied...@xmission.com I think it would make sense if he just replaced kdump with kexec. Daniel -- To unsubscribe from this list: send the line unsubscribe linux-metag in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available
dwal...@fifo99.com writes: On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote: Hidehiro Kawai hidehiro.kawai...@hitachi.com writes: You can call panic notifiers and kmsg dumpers before kdump by specifying crash_kexec_post_notifiers as a boot parameter. However, it doesn't make sense if kdump is not available. In that case, disable crash_kexec_post_notifiers boot parameter so that you can't change the value of the parameter. Nacked-by: Eric W. Biederman ebied...@xmission.com I think it would make sense if he just replaced kdump with kexec. It would be less insane, however it still makes no sense as without kexec on panic support crash_kexec is a noop. So the value of the seeting makes no difference. Eric -- To unsubscribe from this list: send the line unsubscribe linux-metag in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
