Re: [PATCH 1/2 v2] ARM: shmobile: lager: add gpio/fixed regulator for SDHI

2013-11-18 Thread Kuninori Morimoto
Hi Laurent > > #include > > #include > > #include > > +#include > > I might be mistaken, but is this header really needed ? Unfortunately, the compile will error without it. regulator_xxx / REGULATOR_XXX need it > > +static struct fixed_voltage_config vcc_sdhi##idx##_info = {

RE: [PATCH] mmc: disable UHS on broadcom sdhci

2013-11-18 Thread Stephen Hurd
> SDHCI_QUIRK2_BCM57785_CR: > Bit twiddles some Broadcom-specific registers and supresses an error > about the 64k bar0. > I think this can be done without spending a global SDHCI quirk bit. This > is just a one-time setup that needs to be done, isn't it? It's hard > to tell since there's

RE: [PATCH] mmc: disable UHS on broadcom sdhci

2013-11-18 Thread Stephen Hurd
> > SDHCI_QUIRK2_BCM57785_CR: > > Bit twiddles some Broadcom-specific registers and supresses an error > > about the 64k bar0. > I think this can be done without spending a global SDHCI quirk bit. This > is just a one-time setup that needs to be done, isn't it? It's hard > to tell since th

Re: [PATCH v2] mmc: sdhci-s3c: Use mmc_gpio_request_cd fuction

2013-11-18 Thread Heiko Stübner
Hi Jaehoon, Am Montag, 18. November 2013, 06:15:03 schrieb Jaehoon Chung: > Didn't have Any other comment for this patch? > If don't have any other comment, i want this patch is submitted at > mmc-next. > > We had tested this patch with exynos4 series. > > CC'd Heiko. I don't have access to my

Re: [PATCH] mmc: sdhci: Avoid needless loop while handling SDIO interrupts in sdhci_irq()

2013-11-18 Thread Alexey Neyman
[yet another patch ping] On Tuesday, November 05, 2013 07:40:36 PM Alexey Neyman wrote: > Ignore Card Interrupt bit in the interrupt status if we already know that > mmc_signal_sdio_irq() is going to be called at the end of sdhci_irq(). This > avoids a needless loop in sdhci_irq() repeatedly readi

Re: [PATCH 2/8] mmc: omap: Fix DMA configuration to not rely on device id

2013-11-18 Thread Tony Lindgren
* Tony Lindgren [131113 18:36]: > We are wrongly relying on device id for the DMA configuration > which can lead to wrong DMA channel being selected. > > Fix the issue by using the standard resources like we should. > > Cc: Chris Ball > Cc: linux-mmc@vger.kernel.org > Signed-off-by: Tony Lindgr

Re: [PATCH v3 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-11-18 Thread Balaji T K
On Monday 18 November 2013 05:45 PM, Andreas Fenkart wrote: 2013/11/18 Michael Trimarchi : Hi Andreas On Mon, Nov 18, 2013 at 8:53 AM, Andreas Fenkart wrote: The am335x can't detect pending cirq in PM runtime suspend. This patch reconfigures dat1 as a GPIO before going to suspend. SDIO interr

Re: [PATCH 01/16] gpio: rcar: use postcore_init()

2013-11-18 Thread Laurent Pinchart
Hi Morimoto-san, (CC'ing Linus Walleij) On Thursday 14 November 2013 16:26:53 Kuninori Morimoto wrote: > Hi Laurent > > > > Renesas GPIO is being interlocked with PFC, and GPIO is > > > very basic system for R-Car. > > > GPIO should be initialised in same timing as PFC. > > > The GPIO based syst

Re: [PATCH v3 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-11-18 Thread Andreas Fenkart
2013/11/18 Michael Trimarchi : > Hi Andreas > > On Mon, Nov 18, 2013 at 8:53 AM, Andreas Fenkart wrote: >> The am335x can't detect pending cirq in PM runtime suspend. >> This patch reconfigures dat1 as a GPIO before going to suspend. >> SDIO interrupts are detected with the GPIO, the GPIO will onl

Re: [PATCH 1/2 v2] ARM: shmobile: lager: add gpio/fixed regulator for SDHI

2013-11-18 Thread Laurent Pinchart
Hi Morimoto-san, Thank you for the patch. On Thursday 14 November 2013 17:55:12 Kuninori Morimoto wrote: > Fixed regulator is used for SDHI0/2 Vcc. > We should use da9063 driver for Vccq, > but, it doesn't have regulator support at this point. > This patch uses gpio-regulator for it as quick-hack

RE: [PATCH v2] mmc: fix host release issue after discard operation

2013-11-18 Thread Seungwon Jeon
On Tue, November 05, 2013, Ray Jui wrote: > On 10/26/2013 11:03 AM, Ray Jui wrote: > > Under function mmc_blk_issue_rq, after an MMC discard operation, > > the MMC request data structure may be freed in memory. Later in > > the same function, the check of req->cmd_flags & MMC_REQ_SPECIAL_MASK > > i

Re: [PATCH v3 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-11-18 Thread Michael Trimarchi
Hi Andreas On Mon, Nov 18, 2013 at 8:53 AM, Andreas Fenkart wrote: > The am335x can't detect pending cirq in PM runtime suspend. > This patch reconfigures dat1 as a GPIO before going to suspend. > SDIO interrupts are detected with the GPIO, the GPIO will only wake > the module from suspend, SDIO