Re: IP header alignment

2008-01-15 Thread Vladimir Kondratiev
> > Thus, I believe, for IP stack it is wise to have IP header aligned by > > drivers. I warn once, so it do not flood system log with messages. > > It is wise only on systems that need it, and most can (albeit > expensively) handle the unaligned access, so it is absolutely > not a requirement in t

Re: IP header alignment

2008-01-15 Thread David Miller
From: "Vladimir Kondratiev" <[EMAIL PROTECTED]> Date: Tue, 15 Jan 2008 10:32:12 +0200 > Thus, I believe, for IP stack it is wise to have IP header aligned by > drivers. I warn once, so it do not flood system log with messages. It is wise only on systems that need it, and most can (albeit expensiv

Re: IP header alignment

2008-01-15 Thread Vladimir Kondratiev
> No. There is hardware like Yukon-EC used in mac mini where the cost > of the CPU unaligned access is trivial and the cost of copying every > frame to shut up the stupid warning would be high. This is correct, there are architectures that do support unaligned access in trivial way. But there are

Re: IP header alignment

2008-01-14 Thread Stephen Hemminger
On Mon, 14 Jan 2008 10:33:52 +0200 "Vladimir Kondratiev" <[EMAIL PROTECTED]> wrote: > Following patch made against 2.6.24-rc7 > It warns if IP stack gets frame with IP header not aligned on dword. > Idea is this will help to identify mis-behaving drivers that do not > enforce this alignment. > ---

IP header alignment

2008-01-14 Thread Vladimir Kondratiev
Following patch made against 2.6.24-rc7 It warns if IP stack gets frame with IP header not aligned on dword. Idea is this will help to identify mis-behaving drivers that do not enforce this alignment. - commit d9ff4a47ca7bd902947eb22ed3b01682dce2752f Author: Vladimir Kon