This series fixes potential leak at nilfs_open and removes unnecessary
null checks before calling free().
Ryusuke Konishi
--
Ryusuke Konishi (3):
lib/nilfs.c: fix potential leak at nilfs_open()
nilfs-utils: get rid of my_free()
nilfs-utils: get rid of null checks before calling
Remove my_free wrapper functions used in fstab.c, mount.nilfs2.c and
umount.nilfs2.c. They are just doing an unnecessary null check before
calling free() and eliminable since free(NULL) is just ignored.
Signed-off-by: Ryusuke Konishi
---
sbin/mount/fstab.c | 20
s.
>
> Ryusuke-san, could you replace the tracepoints branch with this
> patchset?
I've just updated the branch.
Thanks,
Ryusuke Konishi
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majord...@vger.kernel.org
Mo
anslate relocatable block addresses to real ones.
This approach, however, is not flexible than the former because the
size of source partition must equal that of destination partition, and
also needs to sync partitions before running garbage collection.
Regards,
Ryusuke Konishi
> Thanks,
>
On Tue, 2 Dec 2014 01:41:45 +0900, Ryusuke Konishi wrote:
> From: Andreas Rohner
>
> This patch removes filemap_write_and_wait_range() from
> nilfs_sync_file(), because it triggers a data segment construction by
> calling nilfs_writepages() with WB_SYNC_ALL. A data segment cons
s_inode_dirty(inode))
> + return 0;
I just noticed that this transformation is not equivalent to the
original one. With this patch, nilfs_flush_device() is not called if
nilfs_inode_dirty() is not true, which looks to be causing another
data integrity issue.
Could you reconsid
needed.
nilfs_fiemap() reads the block layout on the disk, by using
nilfs_bmap_lookup_contig(). This is already protected by bmap->b_sem.
Signed-off-by: Andreas Rohner
Signed-off-by: Ryusuke Konishi
---
fs/nilfs2/file.c | 21 -
1 file changed, 8 insertions(+), 13 deleti
st of i_nlink. This patch also fixes the issue by
removing the test on i_mode that nilfs2 doesn't need.
Signed-off-by: Ryusuke Konishi
---
fs/nilfs2/inode.c | 32
fs/nilfs2/namei.c | 15 ---
2 files changed, 36 insertions(+), 11 deletions(-)
diff
From: Markus Elfring
The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Signed-off-by: Ryusuke Konishi
---
fs/nilfs2
nnecessary NULL check related to iput().
Thanks,
Ryusuke Konishi
--
Andreas Rohner (1):
nilfs2: avoid duplicate segment construction for fsync()
Markus Elfring (1):
nilfs2: Deletion of an unnecessary check before the function call "iput"
Ryusuke Konishi (1):
nilfs2
issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
Applied to nilfs2 git tree. Thanks.
Ryusuke Konishi
> ---
> fs/nilfs2/the_nilfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/nilfs2/the_nilfs.c b/fs/n
On Wed, 05 Nov 2014 18:08:57 +0100, Andreas Rohner wrote:
> On 2014-11-05 01:07, Ryusuke Konishi wrote:
>> On Tue, 04 Nov 2014 16:50:21 +0100, Andreas Rohner wrote:
>>
>> I found filemap_write_and_wait_range() returns error status of
>> already done page I/Os via filem
> nilfs_bmap_lookup_contig(). This is already protected by bmap->b_sem.
Thank you.
I reached the same conclusion that the i_mutex in nilfs_sync_file()
can be deleted. The side effect of removing
filemap_write_and_wait_range() still looks to need some care.
Anyway, I queue
On Tue, 04 Nov 2014 16:50:21 +0100, Andreas Rohner wrote:
> On 2014-11-04 15:34, Ryusuke Konishi wrote:
>> Since each call to nilfs_construct_segment() or
>> nilfs_construct_dsync_segment() implies an IO completion wait, it
>> seems that this doubles the latency of fsync().
you really need to call filemap_write_and_wait_range() in
nilfs_sync_file() ?
Regards,
Ryusuke Konishi
> ---
> fs/nilfs2/file.c | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/fs/nilfs2/file.c b/fs/nilfs2/file.c
> index e9e3325..b12e0ab 100644
On Mon, 13 Oct 2014 23:52:59 +0900 (JST), Ryusuke Konishi wrote:
> Hi,
> On Sun, 12 Oct 2014 12:38:21 +0200, Andreas Rohner wrote:
>> Hi,
>>
>> The algorithm simply makes sure, that after a directory inode there are
>> a certain number of free slots available and th
Having three different implementations looks too overkill to me at
this time. It should be removed unless it will make a significant
difference.
4) nilfs_cpu_to_leul()
Adding this macro is not preferable. It depends on endian.
Did you look for a generic macro which does the
On Sat, 11 Oct 2014 15:40:53 +0900, Mitake Hitoshi wrote:
> On Sat, Oct 11, 2014 at 3:14 PM, Ryusuke Konishi
> wrote:
>> On Sun, 28 Sep 2014 19:22:44 +0900, Mitake Hitoshi wrote:
>>> This patch adds a tracepoint for transaction events of nilfs. With the
>>> tracepoin
s",
__entry->sb,
__entry->ti,
__entry->count,
__entry->flags,
show_transaction_state(__entry->state))
Or, is there a reason that you left space chars around "=" symbol ?
Ryusuke Konishi
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
e picture would be really appreciated.
I rebased diff branches and pushed them out to github:
nilfs-utils git://github.com/konis/nilfs-utils.git (diff-v2 branch)
kernel git://github.com/konis/nilfs2.git (diffapi-v2 branch)
These are still experimental and need disk format change.
R
> + TP_STRUCT__entry(
> + __field(void *, sb)
> + __field(void *, ti)
> + __field(int, count)
> + __field(unsigned int, flags)
> + __field(int, state)
> + ),
> +
> +
race/events/nilfs2.h:58:
+ { TRACE_NILFS2_TRANSACTION_BEGIN, "BEGIN" },^I^I\$
WARNING: please, no space before tabs
#206: FILE: include/trace/events/nilfs2.h:59:
+ { TRACE_NILFS2_TRANSACTION_COMMIT, "COMMIT" }, ^I\$
WARNING: please, no spaces at the start of a line
#206
On Wed, 24 Sep 2014 10:01:05 +0200, Andreas Rohner wrote:
> On 2014-09-23 18:35, Ryusuke Konishi wrote:
>> On Tue, 23 Sep 2014 16:21:33 +0200, Andreas Rohner wrote:
>>> On 2014-09-23 14:47, Ryusuke Konishi wrote:
>>>> By the way, if you are interested
On Tue, 23 Sep 2014 16:21:33 +0200, Andreas Rohner wrote:
> On 2014-09-23 14:47, Ryusuke Konishi wrote:
>> By the way, if you are interested in improving this sort of bad
>> implemetation, please consider improving inode allocator that we can
>> see at nilfs_ifile_create_inod
On Tue, 23 Sep 2014 14:17:05 +0200, Andreas Rohner wrote:
> On 2014-09-23 12:50, Ryusuke Konishi wrote:
>> On Tue, 23 Sep 2014 10:46:58 +0200, Andreas Rohner wrote:
>>> Support for fdatasync() has been implemented in NILFS2 for a long time,
>>> but whenever the corre
eek=50
conv=fdatasync,notrunc,nocreat
# reboot -nfh
We can use dumpseg command to confirm that the datasync segment is
actually made or how recovery has done after mount.
Thanks,
Ryusuke Konishi
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the b
y: Andreas Rohner
Signed-off-by: Ryusuke Konishi
---
fs/nilfs2/inode.c | 13 +++--
fs/nilfs2/nilfs.h | 14 +++---
fs/nilfs2/segment.c |4 ++--
3 files changed, 20 insertions(+), 11 deletions(-)
diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c
index 9e3c525..f276fe1 10064
change of the various timestamps. Andreas Rohner fixed this issue by
discerning these situations properly.
Thanks,
Ryusuke Konishi
--
Andreas Rohner (1):
nilfs2: improve the performance of fdatasync()
fs/nilfs2/inode.c | 13 +++--
fs/nilfs2/nilfs.h | 14 +++---
fs
On Tue, 23 Sep 2014 08:36:38 +0200, Andreas Rohner wrote:
> On 2014-09-23 07:09, Ryusuke Konishi wrote:
>> Hi Andreas,
>> On Mon, 22 Sep 2014 18:20:27 +0200, Andreas Rohner wrote:
>>> Support for fdatasync() has been implemented in NILFS2 for a long time,
>>> but
ed, NILFS_I_INODE_DIRTY flag will be no longer
required. Can you remove it at the same time?
Thanks,
Ryusuke Konishi
> ---
> fs/nilfs2/inode.c | 12 +++-
> fs/nilfs2/nilfs.h | 13 +++--
> fs/nilfs2/segment.c | 3 ++-
> 3 files changed, 20 insertions(+), 8 del
On Thu, 18 Sep 2014 12:17:08 -0700, Andrew Morton wrote:
> On Thu, 18 Sep 2014 23:56:25 +0900 Ryusuke Konishi
> wrote:
>
>> From: Andreas Rohner
>>
>> This bug leads to reproducible silent data loss, despite the use of
>> msync(), sync() and a clean unmount
x27;t base GC startup on no-mtab context
lscp: always show snapshots, even if marked minor
Ryusuke Konishi (3):
lscp: show snapshots, even if marked minor (reverse mode)
mount.nilfs2: invoke cleanerd even if no-mtab option is specified
nilfs-utils: v2.2.2 release
Thank
not perfect and causing reproducible silent data loss issue.
Thanks in advance,
Ryusuke Konishi
--
Andreas Rohner (1):
nilfs2: fix data loss with mmap()
fs/nilfs2/inode.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
--
To unsubscribe from this list: send the line "uns
written to disk.
This patch fixes the problem by also calling nilfs_set_file_dirty() if
the page has no buffers attached to it.
Signed-off-by: Andreas Rohner
Tested-by: Andreas Rohner
Signed-off-by: Ryusuke Konishi
Cc:
---
fs/nilfs2/inode.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
d
On Wed, 17 Sep 2014 21:34:39 +0900 (JST), Ryusuke Konishi wrote:
> On Wed, 17 Sep 2014 10:16:46 +0200, Andreas Rohner wrote:
>> On 2014-09-16 15:57, Ryusuke Konishi wrote:
>>> On Tue, 16 Sep 2014 10:38:29 +0200, Andreas Rohner wrote:
>>>>> I'd appreciate your
fied.
This patch makes a similiar change to the legacy mount.nilfs2, and
updates the manpage of mount.nilfs2 to reflect the change.
Signed-off-by: Ryusuke Konishi
---
man/mount.nilfs2.8|5 +
sbin/mount/mount.nilfs2.c |9 +++--
2 files changed, 4 insertions(+), 10 delet
On Wed, 17 Sep 2014 10:16:46 +0200, Andreas Rohner wrote:
> On 2014-09-16 15:57, Ryusuke Konishi wrote:
>> On Tue, 16 Sep 2014 10:38:29 +0200, Andreas Rohner wrote:
>>>> I'd appreciate your help on testing the patch for some old kernels.
>>>> (And, please
ned. Well maintained trees are the following longterm kernels:
- 3.4.y (backported commit 136e877)
- 3.10.y
- 3.14.y
I think these three kernels are worty to be tested.
> By the way thanks for your continued effort and time investment in
> reviewing my patches.
Thank you too, for
On Tue, 16 Sep 2014 00:24:05 +0200, Andreas Rohner wrote:
> On 2014-09-16 00:01, Ryusuke Konishi wrote:
>> Hi Andreas,
>> On Mon, 15 Sep 2014 21:47:30 +0200, Andreas Rohner wrote:
>>> This bug leads to reproducible silent data loss, despite the use of
>>> msync(),
if (nr_dirty)
> nilfs_set_file_dirty(inode, nr_dirty);
> + } else if (ret) {
> + unsigned nr_dirty = 1 << (PAGE_SHIFT - inode->i_blkbits);
> +
> + nilfs_set_file_dirty(inode, nr_dirty);
> }
> retur
are written and set
whenever the block device is flushed. For convenience the function
nilfs_flush_device() is added, which contains the above logic.
Signed-off-by: Andreas Rohner
Signed-off-by: Ryusuke Konishi
---
fs/nilfs2/file.c |8 +++-
fs/nilfs2/ioctl.c |8 +++-
fs/nil
written. The original cover letter can be seen at:
[1] http://marc.info/?l=linux-nilfs&m=141061909728506
"[PATCH v6 0/1] nilfs2: add missing blkdev_issue_flush() to
nilfs_sync_fs()"
Thanks,
Ryusuke Konishi
--
Andreas Rohner (1):
nilfs2: add missing blkdev_is
able for the nilfs
> community, I'd like to add more tracepoints and prepare analysis
> tools.
Otherwise, I'll keep it in the tracepoints branch for now.
[1] https://github.com/konis/nilfs2.git
Thanks,
Ryusuke Konishi
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
lfs->ns_flushed_device
> is introduced, which is cleared whenever new logs are written and set
> whenever the block device is flushed. For convenience the function
> nilfs_flush_device() is added, which contains the above logic.
>
> Signed-off-by: Andreas Rohner
Applied, thank you
return ret;
> - }
> + ret = nilfs_flush_device(nilfs);
> + if (ret == -EIO)
> + return ret;
One more comment. I think this special treatment of EIO should be
encapsulated in nilfs_flush_device(). nilfs_ioctl_sync() doesn't have
to know it:
if (
se multiple nilfs mount points
> + * @ns_flushed_device: flag indicating if all volatile data was flushed
> * @ns_flags: flags
ns_flushed_device is inserted after ns_flags, so these two comment lines
should be swapped.
> * @ns_bdev: block device
> * @ns_sem: semaphore for shared states
> @@ -103,6 +104,7 @@ enum {
> */
> struct the_nilfs {
> unsigned long ns_flags;
> + int ns_flushed_device;
>
> struct block_device*ns_bdev;
> struct rw_semaphore ns_sem;
> --
> 2.1.0
Regards,
Ryusuke Konishi
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 03 Sep 2014 02:30:57 +0900 (JST), Ryusuke Konishi wrote:
> On Mon, 1 Sep 2014 14:48:46 -0500, Dan McGee wrote:
>> When the average user types `lscp` and doesn't see the snapshot they
>> just tried to make, it can be very confusing. Add an additional check
>> to
Apply the same change as the commit
d04aea7db2281d2f22d1c943dc5791931db8c474 "lscp: always show snapshots,
even if marked minor" for reverse mode.
Cc: Dan McGee
Signed-off-by: Ryusuke Konishi
---
bin/lscp.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/bi
On Tue, 9 Sep 2014 18:35:40 +0200, Andreas Rohner wrote:
> Under normal circumstances nilfs_sync_fs() writes out the super block,
> which causes a flush of the underlying block device. But this depends on
> the THE_NILFS_SB_DIRTY flag, which is only set if the pointer to the
> last segment crosses
On Mon, 08 Sep 2014 21:03:02 +0200, Andreas Rohner wrote:
>
> Hi Ryusuke,
>
> Sorry for the late response I was busy over the weekend.
>
> On 2014-09-07 07:12, Ryusuke Konishi wrote:
>> - clear_nilfs_flushed() seems to be called more than necessary.
>> Incom
Hi Andreas,
On Wed, 03 Sep 2014 14:32:22 +0200, Andreas Rohner wrote:
> On 2014-09-03 02:35, Ryusuke Konishi wrote:
>> On Mon, 01 Sep 2014 21:18:30 +0200, Andreas Rohner wrote:
>> On the other hand, we need explicit barrier operation like
>> smp_mb__after_atomic() if a
tracepoints.
Could you proceed this work from what you think useful ? I will help
sending this work to upstream step by step, and would like to extend
it learning various tracepoint features.
By the way, your mail addresses differ between the author line (from
line) and the sob line. Can you
On Mon, 01 Sep 2014 21:18:30 +0200, Andreas Rohner wrote:
> On 2014-09-01 20:43, Andreas Rohner wrote:
>> Hi Ryusuke,
>> On 2014-09-01 19:59, Ryusuke Konishi wrote:
>>> On Sun, 31 Aug 2014 17:47:13 +0200, Andreas Rohner wrote:
>>>> Under normal circumstances
even-if-marked-minor.patch
WARNING: line over 80 characters
#75: FILE: bin/lscp.c:162:
+ if (show_all || nilfs_cpinfo_snapshot(cpi) ||
!nilfs_cpinfo_minor(cpi)) {
total: 0 errors, 1 warnings, 8 lines checked
Please insert line feeds as follows:
if (show_all || nil
sses `-n` to the mount command.
>
> Signed-off-by: Dan McGee
Applied, thank you!
Ryusuke Konishi
> ---
> sbin/mount/mount_libmount.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/sbin/mount/mount_libmount.c b/sbin/mount/mount_libmount.c
> index c51847
avorable (though it's
logically correct). I will try to send this to upstream as is unless
a comment comes to mind.
Thanks,
Ryusuke Konishi
> ---
> fs/nilfs2/file.c | 3 ++-
> fs/nilfs2/ioctl.c | 3 ++-
> fs/nilfs2/segment.c | 2 ++
> fs/nilfs2/super.c | 8
As we announced previously, we have fully moved the NILFS project site
to nilfs.sourceforge.net. The prior address "www.nilfs.org" will be
unavailable shortly. Please refer to nilfs.sourceforge.net hereafter.
Thanks,
Ryusuke Konishi
--
To unsubscribe from this list: send the line &q
e pointer information is recoverable
with mount time recovery.
nilfs_sync_super() uses both FLUSH/FUA options for writing the primary
super block and the FUA option may be superfluous in that sense.
(we need to understand the precise semantics)
Can you improve the patch considering these view points ?
S data
- bin/*: improve error message on failure of nilfs_open()
* Fix typos in messages, manpages, source files, and ChangeLog file.
Please see the following changelog for details:
http://nilfs.sourceforge.net/download/ChangeLog-utils-v2
Thanks,
Ryusuke Konishi
--
To unsubscribe from this
ff-by: Ryusuke Konishi
---
lib/sb.c | 55 +--
1 file changed, 33 insertions(+), 22 deletions(-)
diff --git a/lib/sb.c b/lib/sb.c
index 94bccaf..44453bb 100644
--- a/lib/sb.c
+++ b/lib/sb.c
@@ -97,10 +97,20 @@ static int nilfs_sb_is_valid(s
): cannot open NILFS
2) Description of errno is not shown in the error message.
This fixes these issues.
Signed-off-by: Ryusuke Konishi
---
bin/chcp.c|3 ++-
bin/dumpseg.c |3 ++-
bin/lscp.c|4 ++--
bin/lssu.c|4 ++--
bin/mkcp.c|3 ++-
bin/rmcp.c|3
he default
value of min_clean_segments is 10 percent and
mc_min_reclaimable_blocks (1%) is applied while the ratio of free
space is below 10 percent.
Cc: Andreas Rohner
Signed-off-by: Ryusuke Konishi
---
man/nilfs_cleanerd.conf.5 |2 +-
sbin/cleanerd/cldconfig.h
e.
Signed-off-by: Ryusuke Konishi
---
sbin/mkfs/mkfs.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sbin/mkfs/mkfs.c b/sbin/mkfs/mkfs.c
index c7e18c6..f5f7dbb 100644
--- a/sbin/mkfs/mkfs.c
+++ b/sbin/mkfs/mkfs.c
@@ -532,12 +532,12 @@ static struct nilfs_segment_
eems that some trials
actually exist according to the result of search, however I don't know
for details.
Regards,
Ryusuke Konishi
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Now set_suinfo ioctl is supported by nilfs2 kernel module in mainline.
This changes nilfs_cleanerd so that it tries to use the feature by
default. If it's not supported by the underlying kernel, the feature
will be disabled automatically.
Cc: Andreas Rohner
Signed-off-by: Ryusuke Ko
option is not specified.
Cc: Andreas Rohner
Signed-off-by: Ryusuke Konishi
---
man/nilfs-clean.8 |1 -
sbin/nilfs-clean/nilfs-clean.c | 16 +---
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/man/nilfs-clean.8 b/man/nilfs-clean.8
index af39b6b..4bca51d
This series remedies an inconvenience of nilfs-clean command related
to min_reclaimable_blocks parameter and enables set_suinfo ioctl use
by default in nilfs_cleanerd.conf.
The first patch changes nilfs-clean so that it doesn't override
min_reclaimable_blocks paramater when -m option is not explic
when nilfs_clean_parse_min_reclaimable() returned an error
status code (-1), it is not sane for
nilfs_clean_parse_min_reclaimable() function itself.
Cc: Andreas Rohner
Signed-off-by: Ryusuke Konishi
---
sbin/nilfs-clean/nilfs-clean.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sbin/nilfs-
Hi lists,
nilfs2 standalone kernel module for CentOS 7.0 is now available.
Source files of the module is obtainable with "git" command:
$ git clone git://github.com/nilfs-dev/nilfs2-kmod-centos7.git
For details on installation, please see README file in the package.
Regards,
Ryusu
On Mon, 30 Jun 2014 12:24:43 +0400, Vyacheslav Dubeyko wrote:
> On Mon, 2014-06-30 at 04:01 +0900, Ryusuke Konishi wrote:
>> On Sun, 29 Jun 2014 18:03:41 +0400, Vyacheslav Dubeyko wrote:
>> > From: Vyacheslav Dubeyko
>> > Subject: [PATCH] nilfs2: suggest to use dump_s
On Mon, 30 Jun 2014 11:14:20 +0400, Vyacheslav Dubeyko wrote:
> On Mon, 2014-06-30 at 03:33 +0900, Ryusuke Konishi wrote:
>> On Sun, 29 Jun 2014 17:36:50 +0400, Vyacheslav Dubeyko wrote:
>> nilfs_mdt_read_block() returns -ENOENT only if nilfs_grab_buffer()
>> didn't
g() for more clear understanding of different type of
> issues. As a result, end-users can report more informative
> descriptions of issues.
>
> Signed-off-by: Vyacheslav Dubeyko
> CC: Vyacheslav Dubeyko
> CC: Ryusuke Konishi
NAK.
This patch makes error/warning routine of nilfs so v
it
actually happens).
Regards,
Ryusuke Konishi
> Signed-off-by: Vyacheslav Dubeyko
> CC: Vyacheslav Dubeyko
> CC: Ryusuke Konishi
> ---
> fs/nilfs2/mdt.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nilfs2/mdt.c b/fs/nilfs2/mdt.c
> inde
(6) volume_name - show volume's name.
>
> Signed-off-by: Vyacheslav Dubeyko
> CC: Vyacheslav Dubeyko
> CC: Ryusuke Konishi
> CC: Michael L. Semon
> ---
> Documentation/ABI/testing/sysfs-fs-nilfs2 | 51 +
> fs/nilfs2/sysfs.c
In reality of course, creating
nilfs3 is unlikely at present, but logically the above namespace
design looks incoherent.
I now feel the namespace should be
fs/nilfs2/
In this case, it doesn't cause the confliction regardless whether
we add nilfs3 or not.
Thanks,
Ryusuke Konishi
-
each device directory. Otherwise, we should use "nilfs2" as for the
fs directory name.
Regards,
Ryusuke Konishi
> It was reported by Michael L. Semon that
> timestamp output in human-readable format should be changed
> from "2014-4-12 14:5:38" to "2014-0
userland tools.
One my question is about the "device" name. Is it guaranteed that
every device has canonical single node name? What will happen for
devices such as /dev/mapper/xxx?
Thanks,
Ryusuke Konishi
> With the best regards,
> Vyacheslav Dubeyko.
> ---
> fs/nilfs2/Ma
Fix typos in man/mount.nilfs2.8 and man/nilfs-resize.8.
Signed-off-by: Ryusuke Konishi
---
man/mount.nilfs2.8 | 4 ++--
man/nilfs-resize.8 | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/man/mount.nilfs2.8 b/man/mount.nilfs2.8
index 37474e9..8f0115e 100644
--- a/man
This series fixes typos in nilfs-utils detected by aspell command.
Thanks,
Ryusuke Konishi
--
Ryusuke Konishi (4):
nilfs-utils: fix typos in ChangeLog file
nilfs-utils: fix typos in manpages
nilfs-utils: fix typos in messages
nilfs-utils: fix typos in source files
Fix typos in source files of mkfs.nilfs2, nilfs_cleanerd,
mount.nilfs2, nilfs-clean, include/nilfs.h, and lib/gc.c.
Signed-off-by: Ryusuke Konishi
---
include/nilfs.h| 4 ++--
lib/gc.c | 2 +-
sbin/cleanerd/cleanerd.c | 8
sbin/mkfs/bitops.c
Fix typos in messages of nilfs-resize command, lssu command, and
libnilfsgc.
Signed-off-by: Ryusuke Konishi
---
bin/lssu.c | 2 +-
lib/gc.c | 2 +-
sbin/nilfs-resize/nilfs-resize.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git
Signed-off-by: Ryusuke Konishi
---
ChangeLog | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index fde4126..e4082dc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -8,12 +8,12 @@ nilfs-utils-2.2.0 Tue Apr 8, 2014 JST
* lib/gc.c: add
On Sat, 19 Apr 2014 21:46:37 +1000, Dmitry Smirnov wrote:
> On Sat, 19 Apr 2014 20:26:20 Ryusuke Konishi wrote:
>> Yes, I agree. nilfs_cleanerd should statically link libnilfs and
>> libnilfsgc. I am searching the way to do that.
>
> So far I was able to do it with corr
On Sat, 19 Apr 2014 21:17:19 +1000, Dmitry Smirnov wrote:
> On Sat, 19 Apr 2014 19:58:16 Ryusuke Konishi wrote:
>> This patch breaks mount program; mount.nilfs2 fails to find cleanerd
>> since it was moved to /usr/sbin:
>>
>> # mount -t nilfs2 /dev/sdb1 /te
Hi,
On Wed, 16 Apr 2014 11:22:48 +1000, Dmitry Smirnov wrote:
> On Mon, 14 Apr 2014 06:36:54 Ryusuke Konishi wrote:
>> fhs.patch introduced the following error:
>>
>> $ ./autogen.sh
>> $ ./configure
>> $ make
>> $ sudo make install
>> ...
>&
rd'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/home/ryusuke/git/nilfs-utils/sbin'
make: *** [install-recursive] Error 1
Can you fix this error ?
Regards,
Ryusuke Konishi
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
of superblock. If feature is compatible with
> previous state of driver then flag can be added for s_feature_compat
> field.
>
> Thanks,
> Vyacheslav Dubeyko.
This is important thing. Please evaluate backward compatibility and
forward compatibility of modifications, and prop
gt;si_segnum = segnum + i;
> + sm->si_importance = imp;
> }
> }
> if (n == 0) {
> @@ -642,7 +652,11 @@ nilfs_cleanerd_select_segments(struct nilfs_cleanerd
> *cleanerd,
>
can try the latest version, I hope it both for avoiding
critical error of yours and for narrowing down cause of the problem.
Regards,
Ryusuke Konishi
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majord...@vger.kernel.org
More maj
Project's web site was moved to nilfs.sourceforge.net from
www.nilfs.org. This updates the site information in
Documentation/filesystems/nilfs2.txt with the new location.
Signed-off-by: Ryusuke Konishi
---
Documentation/filesystems/nilfs2.txt |5 ++---
1 file changed, 2 insertions(
Also, web-page entry is updated according to relocation of project's
web site.
Signed-off-by: Ryusuke Konishi
---
MAINTAINERS |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 971dcb7..c4ef32c 100644
--- a/MAINTAINERS
+++ b/MAINTA
pdate MAINTAINERS file entries" (to make folding it into the
original patch easy).
Thanks,
Ryusuke Konishi
--
Ryusuke Konishi (2):
nilfs2: update MAINTAINERS file entries fix
nilfs2: update project's web site in nilfs2.txt
Documentation/filesystems/nilfs2.txt |5 ++-
We moved nilfs project site to nilfs.sourceforge.net from
www.nilfs.org. This updates the site information written in man
pages.
Signed-off-by: Ryusuke Konishi
---
man/chcp.8 |2 +-
man/dumpseg.8|2 +-
man/lscp.1 |2 +-
man/lssu.1 |2
;Re: [PATCH 3/4] nilfs2: add nilfs_sufile_set_suinfo to update
segment usage"
Thanks in advance,
Ryusuke Konishi
--
Andreas Rohner (2):
nilfs2: add nilfs_sufile_trim_fs to trim clean segs
nilfs2: add FITRIM ioctl support for nilfs2
Ryusuke Konishi (1):
nilfs2: verify metadata sizes re
ss
to metadata or memory access overrun on metadata block buffers due to
overflow in sundry calculations.
Both lower limit and upper limit of metadata sizes are verified to
prevent these issues.
Signed-off-by: Ryusuke Konishi
---
fs/nilfs2/cpfile.c| 12
fs/nilfs2/
From: Andreas Rohner
This patch adds support for the FITRIM ioctl, which enables user space
tools to issue TRIM/DISCARD requests to the underlying device. Every
clean segment within the specified range will be discarded.
Signed-off-by: Andreas Rohner
Signed-off-by: Ryusuke Konishi
---
fs
: Ryusuke Konishi
---
fs/nilfs2/sufile.c | 152
fs/nilfs2/sufile.h |1 +
2 files changed, 153 insertions(+)
diff --git a/fs/nilfs2/sufile.c b/fs/nilfs2/sufile.c
index 5628b99..84e384d 100644
--- a/fs/nilfs2/sufile.c
+++ b/fs/nilfs2/sufile.c
> Best regards,
> Andreas Rohner
>
> ---
> v3->v4 (based on review by Ryusuke Konishi)
> * Fix integer overflow
> * Add comment
> v2->v3 (based on review by Ryusuke Konishi)
> * Fix integer overflow
> * Round range to block boundary instead of sector bounda
please
add a comment to clarify why we do not simplify this as follows:
end_block = min_t(sector_t, max_blocks, start_block + len) - 1;
For example,
/*
* range->len can be very large (actually, it is set to
* ULLONG_MAX by default) - truncate upper end of the ra
;limits.discard_granularity);
I just noticed that this can overflow since range.minlen has __u64 type.
Should it be as follows ?
range.minlen = max_t(u64, range.minlen, q->limits.discard_granularity);
Regards,
Ryusuke Konishi
> +
> + down_read(&nilfs->ns_segctor_sem);
>
101 - 200 of 1034 matches
Mail list logo
