the backward search found a younger checkpoint or
not.
This patch also inserts a dummy nilfs_get_cpinfo() call before
starting the backward search to make successive nilfs_get_cpinfo()
calls much faster.
Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp
---
bin/lscp.c | 96
Simplify nilfs_mdt_bgl_lock() by utilizing bgl_lock_ptr() helper in
linux/blockgroup_lock.h.
Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp
---
fs/nilfs2/mdt.h | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/nilfs2/mdt.h b/fs/nilfs2/mdt.h
index ab172e8
(1ULL 0)
looks to be enough.
Regards,
Ryusuke Konishi
@@ -630,7 +632,7 @@ struct nilfs_segment_usage {
__le32 su_nblocks;
__le32 su_flags;
__le32 su_nlive_blks;
- __le32 su_pad;
+ __le32 su_nsnapshot_blks;
__le64 su_nlive_lastmod;
};
@@ -682,7 +684,7
);
}
Or you can drop the track flag at mount time if
NILFS_FEATURE_COMPAT_SUFILE_EXTENSION flag is not set or
nilfs_sufile_ext_supported(sufile) is false.
Regards,
Ryusuke Konishi
#endif /* _THE_NILFS_H */
diff --git a/include/linux/nilfs2_fs.h b/include/linux/nilfs2_fs.h
index 5d83c55..6ccb2ad
on the extention of
sufile.
-#define NILFS_FEATURE_COMPAT_SUPP0ULL
+#define NILFS_FEATURE_COMPAT_RO_BLOCK_COUNT (1ULL 0)
+
Regards,
Ryusuke Konishi
--
To unsubscribe from this list: send the line unsubscribe linux-nilfs in
the body of a message to majord...@vger.kernel.org
More majordomo
;
@@ -185,6 +187,7 @@ struct nilfs_sc_info {
struct timer_list sc_timer;
struct task_struct *sc_task;
+ struct nilfs_sufile_mod_cache *sc_mc;
};
/* sc_flags */
Again, I really hope you eliminate this changes by hiding the cache in
sufile.
Regards,
Ryusuke Konishi
is confusing. Actual meaning of this
function is reset and add, and that can be replaced with mc_clear
and mc_add. Remove this function to simplify interface.
Regards,
Ryusuke Konishi
+/**
+ * nilfs_sufile_mc_flush - flush modification cache
+ * @sufile: inode of segment usage file
+ * @mc
On Sat, 14 Mar 2015 13:24:25 +0100, Andreas Rohner wrote:
Hi Ryusuke,
Thank you very much for your detailed review and feedback. I agree with
all of your points and I will start working on a rewrite immediately.
On 2015-03-12 13:54, Ryusuke Konishi wrote:
Hi Andreas,
On Tue, 10 Mar
The type of key arguments in block mapping interface varies depending
on function. For instance, nilfs_bmap_lookup_at_level() takes __u64
for its key argument whereas nilfs_bmap_lookup() takes unsigned
long.
This fits them to __u64 to eliminate the variation.
Signed-off-by: Ryusuke Konishi
of the latter uses as part of refactoring of atomic bit
operations on buffer state bitmap.
Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp
Cc: Vyacheslav Dubeyko sl...@dubeyko.com
---
fs/nilfs2/segment.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/nilfs2/segment.c b/fs
Hi Andreas,
On Tue, 10 Mar 2015 21:37:50 +0100, Andreas Rohner wrote:
Hi Ryusuke,
Thanks for your thorough review.
On 2015-03-10 06:21, Ryusuke Konishi wrote:
Hi Andreas,
I looked through whole kernel patches and a part of util patches.
Overall comments are as follows:
[Algorithm
layer to hide these issues,
or a new error code or a new mechanism to make it possible for file
systems to know/handle them.
Regards,
Ryusuke Konishi
--
To unsubscribe from this list: send the line unsubscribe linux-nilfs in
the body of a message to majord...@vger.kernel.org
More majordomo info
not suit for the recent fedora
since nilfs-utils is not yet tuned to systemd environment.
[2] http://nilfs.sourceforge.net/en/man8/mount.nilfs2.8.html
[3] http://nilfs.sourceforge.net/en/man8/nilfs_cleanerd.8.html
Regards,
Ryusuke Konishi
Is there something else that should be included other than
Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp
Cc: Al Viro v...@zeniv.linux.org.uk
Tested-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp
Cc: sta...@vger.kernel.org
---
fs/nilfs2/segment.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/nilfs2/segment.c b
Hi Andrew,
Please send the following bug fix to upstream. It fixes another
deadlock issue of nilfs2 segment constructor, which was recently
reported.
Thanks,
Ryusuke Konishi
--
Ryusuke Konishi (1):
nilfs2: fix deadlock of segment constructor during recovery
fs/nilfs2/segment.c | 7
The type of key arguments in block mapping interface varies depending
on function. For instance, nilfs_bmap_lookup_at_level() takes __u64
for its key argument whereas nilfs_bmap_lookup() takes unsigned
long.
This fits them to __u64 to eliminate the variation.
Signed-off-by: Ryusuke Konishi
- 108 1
real0m0.003s
user0m0.001s
sys 0m0.002s
Thanks,
Ryusuke Konishi
--
Ryusuke Konishi (4):
nilfs2: unify type of key arguments in bmap interface
nilfs2: add bmap function to seek a valid key
nilfs2: add helper to find existent block
1
real0m0.003s
user0m0.001s
sys 0m0.002s
Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp
---
fs/nilfs2/cpfile.c | 58 --
1 file changed, 52 insertions(+), 6 deletions(-)
diff --git a/fs/nilfs2/cpfile.c b/fs/nilfs2
On Fri, 20 Feb 2015 13:58:42 -0800, Andrew Morton wrote:
On Fri, 20 Feb 2015 22:46:35 +0900 Ryusuke Konishi
konishi.ryus...@lab.ntt.co.jp wrote:
Each inode of nilfs2 stores a root node of a b-tree, and it turned out
to have a memory overrun issue:
Each b-tree node of nilfs2 stores a set
is exclusive.
Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp
Cc: sta...@vger.kernel.org
---
fs/nilfs2/btree.c | 2 +-
include/linux/nilfs2_fs.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c
index 059f371..919fd5b
On Sat, 09 May 2015 21:10:21 +0200, Andreas Rohner wrote:
On 2015-05-09 04:41, Ryusuke Konishi wrote:
On Sun, 3 May 2015 12:05:17 +0200, Andreas Rohner wrote:
+static void nilfs_sufile_cache_node_init_once(void *obj)
+{
+ memset(obj, 0, sizeof(struct nilfs_sufile_cache_node
))
return NULL;
Regards,
Ryusuke Konishi
@@ -510,7 +510,7 @@ static struct dentry *nilfs_fh_to_parent(struct
super_block *sb, struct fid *fh,
{
struct nilfs_fid *fid = (struct nilfs_fid *)fh;
- if (fh_len != NILFS_FID_SIZE_CONNECTABLE ||
+ if (fh_len
On Sun, 3 May 2015 12:05:14 +0200, Andreas Rohner wrote:
This patch adds three new attributes to the nilfs object, which contain
a copy of the feature flags from the super block. This can be used, to
efficiently test whether file system feature flags are set or not.
Signed-off-by: Andreas
Hi Andrew,
Please queue the following changes for the next merge window:
Ryusuke Konishi (2):
nilfs2: put out gfp mask manipulation from nilfs_set_inode_flags()
nilfs2: use inode_set_flags() in nilfs_set_inode_flags()
These fix issues related to nilfs_set_inode_flags() function
to commit 5f16f3225b06 (ext4: atomically set
inode-i_flags in ext4_set_inode_flags()).
Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp
Cc: Theodore Ts'o ty...@mit.edu
---
fs/nilfs2/inode.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/fs/nilfs2
cno 0 is useless
because variable cno has an unsigned integer type __u64.
Reported-by: David Binderman dcb...@hotmail.com
Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp
---
fs/nilfs2/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nilfs2/super.c b/fs
On Wed, 20 May 2015 23:43:35 +0900 (JST), Ryusuke Konishi wrote:
On Sun, 3 May 2015 12:05:22 +0200, Andreas Rohner wrote:
It doesn't really matter if the number of reclaimable blocks for a
segment is inaccurate, as long as the overall performance is better than
the simple timestamp algorithm
$ lsblk --version
lsblk from util-linux 2.23.2
$ lscp -V
lscp (nilfs-utils 2.2.3)
$ rpm -q libblkid util-linux
libblkid-2.23.2-22.el7_1.x86_64
util-linux-2.23.2-22.el7_1.x86_64
$ uname -r
4.1.0-rc7
Regards,
Ryusuke Konishi
--
To unsubscribe from this list: send the line unsubscribe linux-nilfs
On Tue, 9 Jun 2015 16:07:42 +0200, Karel Zak k...@redhat.com wrote:
On Tue, Jun 09, 2015 at 10:04:15PM +0900, Ryusuke Konishi wrote:
$ sudo nilfs-resize -y /dev/sdb1 1G
Partition size = 2146435072 bytes.
Shrink the filesystem size from 2146435072 bytes to 1073741824 bytes.
128 segments
Hi,
On 2015/06/09 17:53, Karel Zak wrote:
On Tue, Jun 09, 2015 at 12:31:27AM +0900, Ryusuke Konishi wrote:
It looks like the backup super block should be dropped from candidates
if its device size (sbp-s_dev_size) doesn't match the partition size.
Yeah, fixed:
http://git.kernel.org/cgit
On Fri, 22 May 2015 20:10:05 +0200, Andreas Rohner wrote:
On 2015-05-20 16:43, Ryusuke Konishi wrote:
On Sun, 3 May 2015 12:05:22 +0200, Andreas Rohner wrote:
It doesn't really matter if the number of reclaimable blocks for a
segment is inaccurate, as long as the overall performance is better
On Sun, 31 May 2015 20:13:44 +0200, Andreas Rohner wrote:
On 2015-05-31 18:45, Ryusuke Konishi wrote:
On Fri, 22 May 2015 20:10:05 +0200, Andreas Rohner wrote:
On 2015-05-20 16:43, Ryusuke Konishi wrote:
On Sun, 3 May 2015 12:05:22 +0200, Andreas Rohner wrote:
[...]
3. The ratio
On Sun, 10 May 2015 13:04:18 +0200, Andreas Rohner wrote:
On 2015-05-09 14:17, Ryusuke Konishi wrote:
On Sun, 3 May 2015 12:05:20 +0200, Andreas Rohner wrote:
[...]
Uum. This still looks to have potential for leak of dirty block
collection between DAT and SUFILE since this retry is limited
Hi Andrew,
please queue the following patch for the next merge window. It fixes
an NFSv2 related issue reported in:
[1] http://marc.info/?l=linux-fsdevelm=143104630128997
[PATCH 0/3] make BTRFS, UDF, NILFS2 work with NFSv2.
Thanks,
Ryusuke Konishi
--
NeilBrown (1):
NILFS2: support
.
This series looks non-divisible except the patch of ufs.
Regards,
Ryusuke Konishi
/*
* Return the offset into page `page_nr' of the last valid
* byte in that page, plus one.
--
2.4.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
.
Regards,
Ryusuke Konishi
+ n = nilfs_sufile_segment_usages_in_block(sufile, segnum,
+ nsegs - 1);
+
+ ret = nilfs_sufile_get_segment_usage_block(sufile, segnum,
+0
Hi Andrew,
Please send the following fixes to upstream:
Ryusuke Konishi (2):
nilfs2: fix gcc unused-but-set-variable warnings
nilfs2: fix gcc uninitialized-variable warnings in powerpc build
These prevent reported warnings in powerpc build and minor warnings
during build with &quo
f908a8 segnum = 2
segctord-17800 [002] ...1 10675.073477: nilfs2_segment_usage_allocated:
sufile = 880054f908a8 segnum = 3
Cc: Benixon Dhas <benixon.d...@wdc.com>
Cc: TK Kato <tk.k...@wdc.com>
Signed-off-by: Hitoshi Mitake <mitake.hito...@lab.ntt.co.jp>
Signed
This adds header file "include/trace/events/nilfs2.h" to
maintainer-ship of nilfs2 so that updates to the nilfs2 header file go
to the mailing list of nilfs2.
Signed-off-by: Ryusuke Konishi <konishi.ryus...@lab.ntt.co.jp>
Cc: Hitoshi Mitake <mitake.hito...@lab.ntt.co.jp>
---
work :)
Christian
Please refer to nilfs.sourceforge.net instead.
We no longer hosts nilfs.org.
Ryusuke Konishi
--
To unsubscribe from this list: send the line unsubscribe linux-nilfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
em_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> //
>
> Signed-off-by: Julia Lawall <julia.law...@lip6.fr>
Looks OK. I'll queue this in my tree.
Thanks,
Ryusuke Konishi
>
> ---
> fs/nilfs2/super.c | 12
> 1 file changed, 4 insertions(+), 8
On 2015/09/28 23:33, Yaowei Bai wrote:
> As new_valid_dev always returns 1, so !new_valid_dev check is not
> needed, remove it.
>
> Signed-off-by: Yaowei Bai <bywxiao...@163.com>
Acked-by: Ryusuke Konishi <konishi.ryus...@lab.ntt.co.jp>
> ---
> fs/nilfs2/namei.c
Lawall <julia.law...@lip6.fr>
Signed-off-by: Ryusuke Konishi <konishi.ryus...@lab.ntt.co.jp>
---
fs/nilfs2/super.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c
index f47585b..c69455a 100644
--- a/fs/nilfs2/super
in the successive change on
deallocator of block addresses ("nilfs2: free unused dat file blocks
during garbage collection").
Signed-off-by: Ryusuke Konishi <konishi.ryus...@lab.ntt.co.jp>
---
fs/nilfs2/alloc.c | 50 ++
1 file change
% /test
Signed-off-by: Ryusuke Konishi <konishi.ryus...@lab.ntt.co.jp>
---
fs/nilfs2/alloc.c | 91 ---
fs/nilfs2/alloc.h | 1 +
2 files changed, 75 insertions(+), 17 deletions(-)
diff --git a/fs/nilfs2/alloc.c b/fs/nilfs2/alloc.c
index 2
On Mon, 5 Oct 2015 19:21:43 +0900, Mitake Hitoshi wrote:
> On Sun, Oct 4, 2015 at 10:33 PM, Ryusuke Konishi
> <konishi.ryus...@lab.ntt.co.jp> wrote:
>> On Sun, 4 Oct 2015 01:02:42 +0900, Mitake Hitoshi wrote:
>>> This patch adds tracepoints for analyzing requests
501 - 546 of 546 matches
Mail list logo
