[PATCH 1/2] ndctl: add support to enable latch system shutdown status

2017-12-06 Thread Dave Jiang
Adding the Enable Latch System Shutdown Status (Function Index 10) for DSM v1.6 spec. Signed-off-by: Dave Jiang --- ndctl/lib/Makefile.am |1 + ndctl/lib/intel.c | 38 ++ ndctl/lib/intel.h |7 +++

[PATCH 2/2] ndctl: lss latch unit test

2017-12-06 Thread Dave Jiang
Signed-off-by: Dave Jiang --- 0 files changed diff --git a/test/Makefile.am b/test/Makefile.am index d5ef648..7f70e63 100644 --- a/test/Makefile.am +++ b/test/Makefile.am @@ -17,7 +17,8 @@ TESTS =\ sector-mode.sh \ inject-error.sh \ btt-errors.sh \

Re: [PATCH 2/2] mm: fix dev_pagemap reference counting around get_dev_pagemap

2017-12-06 Thread Dan Williams
On Wed, Dec 6, 2017 at 2:44 PM, Christoph Hellwig wrote: > On Tue, Dec 05, 2017 at 06:43:36PM -0800, Dan Williams wrote: >> I don't think we need this change, but perhaps the reasoning should be >> added to the code as a comment... details below. > > Hmm, looks like we are ok at

[PATCH v2 4/4] ndctl, test: firmware update unit test

2017-12-06 Thread Dave Jiang
Adding a unit test that will use nfit_test kernel module to test the firmware update sequence. Signed-off-by: Dave Jiang --- test/Makefile.am|3 +- test/firmware-update.sh | 74 +++ 2 files changed, 76

[PATCH v2 3/4] ndctl: add firmware update command option for ndctl

2017-12-06 Thread Dave Jiang
Adding option "update-firmware" to ndctl for update firmware support from Intel DSM v1.6. ndctl update-firmware takes an option of -f for a firmware binary and a -d for the DIMM name: ndctl update-firmware -d nmem0 -f new_firmware.bin Signed-off-by: Dave Jiang --- 0 files

[PATCH v2 2/4] ndctl: add firmware download support functions in libndctl

2017-12-06 Thread Dave Jiang
Adding the DSM commands from Intel DSM v1.6 to support firmware update sequence in the libndctl library as additional dimm_ops. Signed-off-by: Dave Jiang --- v2: Sync'd return types per Dan's comment and removed __uN types. 0 files changed diff --git

[PATCH v2 1/4] ndctl: add support to alloc_intel_cmd for variable payload

2017-12-06 Thread Dave Jiang
Certain payloads have variable size. The existing alloc_intel_cmd() does not take into account of that. Adding additional size for allocation. We do waste a little bit of the space because of the smart payload. Signed-off-by: Dave Jiang --- 0 files changed diff --git

Re: [PATCH 2/2] mm: fix dev_pagemap reference counting around get_dev_pagemap

2017-12-06 Thread Christoph Hellwig
On Tue, Dec 05, 2017 at 06:43:36PM -0800, Dan Williams wrote: > I don't think we need this change, but perhaps the reasoning should be > added to the code as a comment... details below. Hmm, looks like we are ok at least. But even if it's not a correctness issue there is no good point in

Re: [xfsprogs PATCH v2 1/3] xfs_io: fix compiler warnings in getfsmap code

2017-12-06 Thread Ross Zwisler
On Wed, Dec 06, 2017 at 12:47:49PM -0800, Darrick J. Wong wrote: > On Wed, Dec 06, 2017 at 01:10:14PM -0700, Ross Zwisler wrote: > > On Wed, Dec 06, 2017 at 11:27:43AM +1100, Dave Chinner wrote: > > > On Tue, Dec 05, 2017 at 04:56:49PM -0700, Ross Zwisler wrote: > > > > I recently upgraded my

Re: [xfsprogs PATCH v2 1/3] xfs_io: fix compiler warnings in getfsmap code

2017-12-06 Thread Darrick J. Wong
On Wed, Dec 06, 2017 at 01:10:14PM -0700, Ross Zwisler wrote: > On Wed, Dec 06, 2017 at 11:27:43AM +1100, Dave Chinner wrote: > > On Tue, Dec 05, 2017 at 04:56:49PM -0700, Ross Zwisler wrote: > > > I recently upgraded my compiler from > > > gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1) > > > to > >

Re: [xfsprogs PATCH v2 1/3] xfs_io: fix compiler warnings in getfsmap code

2017-12-06 Thread Ross Zwisler
On Wed, Dec 06, 2017 at 11:27:43AM +1100, Dave Chinner wrote: > On Tue, Dec 05, 2017 at 04:56:49PM -0700, Ross Zwisler wrote: > > I recently upgraded my compiler from > > gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1) > > to > > gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2) > > and started

[xfsprogs PATCH v3 3/3] xfs_io: add a new 'log_writes' command

2017-12-06 Thread Ross Zwisler
Add a new 'log_writes' command to xfs_io so that we can add dm-log-writes log marks. It's helpful to allow users of xfs_io to adds these marks from within xfs_io instead of waiting until after xfs_io exits because then they are able to replay the dm-log-writes log up to immediately after another

Re: [RFC PATCH v2 2/7] ndctl: nvdimmd: add nvdimmd necessary util functions

2017-12-06 Thread Dan Williams
On Tue, Dec 5, 2017 at 11:14 PM, Qi, Fuli wrote: > On 2017/11/21 6:19, Dan Williams wrote: >> >> On Mon, Nov 13, 2017 at 11:46 PM, QI Fuli wrote: >>> >>> This patch is used to provide helper functions needed for nvdimm daemon. >>> These util

Re: [RFC PATCH 4/4] EDAC, skx_edac: Detect non-volatile DIMMs

2017-12-06 Thread Borislav Petkov
On Tue, Dec 05, 2017 at 02:24:29PM -0800, Luck, Tony wrote: > So this is what that would look like (on top of existing patches, > but would be folded into them for next version): > > diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig > index 5c0c4a358f67..7f0bc4cd5086 100644 > ---

Re: [xfsprogs PATCH v2 1/3] xfs_io: fix compiler warnings in getfsmap code

2017-12-06 Thread Eric Sandeen
On 12/5/17 6:27 PM, Dave Chinner wrote: > FYI, I posted a fix for this weeks ago. I think Eric has already > picked it up, but it hasn't been pushed out into the for-next branch > yet. Yes, sorry for the delay. Will be pushed out soon. > Cheers, > > Dave. >

Re: [fstests PATCH v5 2/2] generic: add test for DAX MAP_SYNC support

2017-12-06 Thread Amir Goldstein
On Wed, Dec 6, 2017 at 2:37 AM, Ross Zwisler wrote: > This test creates a file and writes to it via an mmap(), but never syncs > via fsync/msync. This process is tracked via dm-log-writes, then replayed. > > If MAP_SYNC is working the dm-log-writes replay will show

Re: [fstests PATCH v5 1/2] dm-log-writes: only replay log to marks that exist

2017-12-06 Thread Amir Goldstein
On Wed, Dec 6, 2017 at 2:37 AM, Ross Zwisler wrote: > The 'replay-log' executable will replay the dm-log-writes log until the > given mark, or until the end of the log if the mark isn't found. > > This means that if the mark you're looking for was never inserted in