[PATCH v4 3/4] ndctl: add firmware update command option for ndctl

2018-01-29 Thread Dave Jiang
Adding option "update-firmware" to ndctl for update firmware support from Intel DSM v1.6. ndctl update-firmware takes an option of -f for a firmware binary and a -d for the DIMM name: ndctl update-firmware -d nmem0 -f new_firmware.bin Signed-off-by: Dave Jiang ---

[PATCH v4 4/4] ndctl, test: firmware update unit test

2018-01-29 Thread Dave Jiang
Adding a unit test that will use nfit_test kernel module to test the firmware update sequence. Signed-off-by: Dave Jiang --- test/Makefile.am|3 +- test/firmware-update.sh | 74 +++ 2 files changed, 76

[PATCH v4 2/4] ndctl: add firmware download support functions in libndctl

2018-01-29 Thread Dave Jiang
Adding the DSM commands from Intel DSM v1.6 to support firmware update sequence in the libndctl library as additional dimm_ops. Signed-off-by: Dave Jiang --- ndctl/lib/Makefile.am |1 ndctl/lib/firmware.c | 119 ++ ndctl/lib/intel.c | 262

[PATCH v4 1/4] ndctl: add support to alloc_intel_cmd for variable payload

2018-01-29 Thread Dave Jiang
Certain payloads have variable size. The existing alloc_intel_cmd() does not take into account of that. Adding additional size for allocation. We do waste a little bit of the space because of the smart payload. Signed-off-by: Dave Jiang --- ndctl/lib/intel.c |2 +- 1

[PATCH v4 0/4] ndctl: add DIMM firmware update support

2018-01-29 Thread Dave Jiang
The following series implements support for DIMM firmware update in ndctl. v4: Addressed Vishal's comments - replaced copyright header - changed gettimeofday to clock_gettime - changed return error for verify_fw_size() v3: Addressed Dan's comments - Removed Intel specific bits from update get

Re: [LSF/MM TOPIC] Filesystem-DAX, page-pinning, and RDMA

2018-01-29 Thread Jerome Glisse
On Wed, Jan 24, 2018 at 07:56:02PM -0800, Dan Williams wrote: > The get_user_pages_longterm() api was recently added as a stop-gap > measure to prevent applications from growing dependencies on the > ability to to pin DAX-mapped filesystem blocks for RDMA indefinitely > with no ongoing

Re: [PATCH v3 4/4] ndctl, test: firmware update unit test

2018-01-29 Thread Vishal Verma
On 12/15, Dave Jiang wrote: > Adding a unit test that will use nfit_test kernel module to test the > firmware update sequence. > > Signed-off-by: Dave Jiang > --- > ndctl/update.c | 10 -- This diffstat is missing the new file? But my attention only went to that

Re: [PATCH v3 3/4] ndctl: add firmware update command option for ndctl

2018-01-29 Thread Vishal Verma
On 12/15, Dave Jiang wrote: > Adding option "update-firmware" to ndctl for update firmware support from > Intel DSM v1.6. ndctl update-firmware takes an option of -f for a firmware > binary and a -d for the DIMM name: > ndctl update-firmware -d nmem0 -f new_firmware.bin > > Signed-off-by: Dave

Re: [ndctl PATCH v3 2/2] ndctl: add sector_size to 'ndctl list' output

2018-01-29 Thread Dan Williams
On Mon, Jan 29, 2018 at 1:48 PM, Ross Zwisler wrote: > It used to be that the only PMEM namespaces with a variable sector size > were ones with a BTT, but that has changed. sector_size still doesn't make > sense for device DAX since we don't have a block I/O path. >

[ndctl PATCH v3 2/2] ndctl: add sector_size to 'ndctl list' output

2018-01-29 Thread Ross Zwisler
It used to be that the only PMEM namespaces with a variable sector size were ones with a BTT, but that has changed. sector_size still doesn't make sense for device DAX since we don't have a block I/O path. If we don't have a specified sector size, as happens with namespaces of devtype

Re: [ndctl PATCH] ndctl: fix the default BTT sector size for reconfig

2018-01-29 Thread Dan Williams
On Mon, Jan 29, 2018 at 12:22 PM, Vishal Verma wrote: > reconfig attempted to reuse the 'previous' value for sector-size when > reconfiguring to a BTT mode or blk type namespace, but this may not > always be valid (for example when coming from a memory mode namespace). >

[ndctl PATCH] ndctl: fix the default BTT sector size for reconfig

2018-01-29 Thread Vishal Verma
reconfig attempted to reuse the 'previous' value for sector-size when reconfiguring to a BTT mode or blk type namespace, but this may not always be valid (for example when coming from a memory mode namespace). Instead, when reconfiguring to BTT or blk, always default to 4096 unless a sector size