> -Original Message-
> From: Vishal Verma [mailto:vis...@kernel.org]
> Sent: Friday, July 20, 2018 12:26 PM
> To: Qi, Fuli/斉 福利 ; 'Vishal Verma'
> ; linux-nvdimm@lists.01.org
> Subject: Re: [ndctl PATCH 0/4] misc fixups for ndctl-monitor
>
> On Thu, 2018-07-19 at 23:59 +, Qi, Fuli
On Thu, 2018-07-19 at 23:59 +, Qi, Fuli wrote:
> > -Original Message-
> > From: Vishal Verma [mailto:vishal.l.ve...@intel.com]
> > Sent: Friday, July 20, 2018 8:00 AM
> > To: linux-nvdimm@lists.01.org
> > Cc: Qi, Fuli/斉 福利 ; Vishal Verma
> >
> > Subject: [ndctl PATCH 0/4] misc fixups
On Thu, Jul 19, 2018 at 6:17 PM Vishal Verma wrote:
>
> Reword the description of the fsdax mode in the create-namespace
> documentation to better distinguish when DAX can be used vs. how the raw
> block device will use the page cache.
>
> Link: https://github.com/pmem/issues/issues/915
> Cc: Dan
Reword the description of the fsdax mode in the create-namespace
documentation to better distinguish when DAX can be used vs. how the raw
block device will use the page cache.
Link: https://github.com/pmem/issues/issues/915
Cc: Dan Williams
Signed-off-by: Vishal Verma
---
On 07/19/2018 02:28 PM, Dave Jiang wrote:
>
>
> On 07/19/2018 01:22 AM, David Howells wrote:
>> Dave Jiang wrote:
>>
>>> Ok stupid question David. I'm attempting to use the logon-type key. I
>>> have added this line to the request-key.conf:
>>> create logon nvdimm* *
> -Original Message-
> From: Vishal Verma [mailto:vishal.l.ve...@intel.com]
> Sent: Friday, July 20, 2018 8:00 AM
> To: linux-nvdimm@lists.01.org
> Cc: Qi, Fuli/斉 福利 ; Vishal Verma
>
> Subject: [ndctl PATCH 0/4] misc fixups for ndctl-monitor
>
> Fix a couple of issues reported by static
Static analysis reports we were leaking the 'events' buffer in the above
function. We were also returning a simple '1' for every error case. Take
this chance to return a more meaningful 'errno' in each case, while also
fixing up the resource leak.
Fixes: fdf6b6844ccf ("ndctl, monitor: add a new
Static analysis reports that we leak 'buf' in the above function. Free
that, and refactor some of the error reporting to clean up the flow.
Since the parser loop was modifying 'buf', it wasn't possible to
directly free it. Introduce a 'seek' variable to seek within the buf so
that buf itself
The ndctl monitor man page was missing documentation for the
--config-file option. Add it, explaining that the option overrides the
system default config file.
Fixes: 02ce9c6bab41 ("ndctl, documentation: add man page for monitor")
Cc: QI Fuli
Signed-off-by: Vishal Verma
---
Fix a couple of issues reported by static analysis, improve the error
reporting, and add a missing option to the monitor man page
Vishal Verma (4):
ndctl, monitor: Add a config-file section to the man page
ndctl, monitor: fix memory leak in read_config_file
ndctl, monitor: Fix memory leak
In several places in the ndctl monitor, we were losing useful error
information (from 'errno' for example), and just returning a simple '1'
or '-1'. Fix these to capture and propagate the correct errors
everywhere.
In the case of notify_dimm_event(), don't error out for failures of
On 07/19/2018 01:22 AM, David Howells wrote:
> Dave Jiang wrote:
>
>> Ok stupid question David. I'm attempting to use the logon-type key. I
>> have added this line to the request-key.conf:
>> create logon nvdimm* * /usr/sbin/nvdimm-upcall %k
>
> Can you show me the whole
On 07/18/2018 06:43 PM, Elliott, Robert (Persistent Memory) wrote:
>
>
>> -Original Message-
>> From: Dave Jiang
>> Sent: Wednesday, July 18, 2018 12:41 PM
>> To: Elliott, Robert (Persistent Memory) ; Williams,
>> Dan J
>> Cc: dhowe...@redhat.com; Schofield, Alison
>> ;
On Thu, 19 Jul 2018 23:17:53 +0800 Baoquan He wrote:
> Hi Andrew,
>
> On 07/18/18 at 03:33pm, Andrew Morton wrote:
> > On Wed, 18 Jul 2018 10:49:44 +0800 Baoquan He wrote:
> >
> > > For kexec_file loading, if kexec_buf.top_down is 'true', the memory which
> > > is used to load
Jan has been developing and reviewing filesystem DAX related changes for
quite a while now, and has agreed to help maintain this code going forward.
Thanks, Jan!
Signed-off-by: Ross Zwisler
Cc: Jan Kara
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS
This series updates my preferred email for kernel work to my
zwis...@kernel.org mail address, and adds Jan as a maintainer for
filesystem DAX. Thank you, Jan, for helping to keep filesystem DAX in a
happy state.
We are planning on pushing this up through the libnvdimm tree for the
v4.19 merge
On 07/18/2018 05:05 AM, Michal Hocko wrote:
> On Tue 17-07-18 10:32:32, Dan Williams wrote:
>> On Tue, Jul 17, 2018 at 8:50 AM Michal Hocko wrote:
> [...]
>>> Is there any reason that this work has to target the next merge window?
>>> The changelog is not really specific about that.
>>
>> Same
On Thu, 2018-07-19 at 17:54 +0900, QI Fuli wrote:
> Currently, the monitor still can be started though there is no dimm event
> to be monitored, which is caused by the typo of uses. In this case,
> no smart event message can be logged.
> This patch is used to fix this bug. When user starts the
Ingo,
Is it possible to ack the x86 bits in this patch series? I'm hoping to
get this pulled through the libnvdimm tree for 4.19. Thanks!
On 07/13/2018 09:49 PM, Dan Williams wrote:
> Changes since v5 [1]:
> * Move put_page() before memory_failure() in madvise_inject_error()
> (Naoya)
> * The
On Thu, 19 Jul 2018 15:58:20 +0200
David Hildenbrand wrote:
> On 19.07.2018 14:16, Stefan Hajnoczi wrote:
> > On Thu, Jul 19, 2018 at 01:48:13AM -0400, Pankaj Gupta wrote:
> >>
> >>>
> This patch adds virtio-pmem Qemu device.
>
> This device presents memory address range
On 07/18/18 at 07:37pm, Andy Shevchenko wrote:
> On Wed, Jul 18, 2018 at 7:36 PM, Andy Shevchenko
> wrote:
> > On Wed, Jul 18, 2018 at 5:49 AM, Baoquan He wrote:
> >> reparent_resources() is duplicated in arch/microblaze/pci/pci-common.c
> >> and arch/powerpc/kernel/pci-common.c, so move it to
Hi Andrew,
On 07/18/18 at 03:33pm, Andrew Morton wrote:
> On Wed, 18 Jul 2018 10:49:44 +0800 Baoquan He wrote:
>
> > For kexec_file loading, if kexec_buf.top_down is 'true', the memory which
> > is used to load kernel/initrd/purgatory is supposed to be allocated from
> > top to down. This is
On 19.07.2018 14:16, Stefan Hajnoczi wrote:
> On Thu, Jul 19, 2018 at 01:48:13AM -0400, Pankaj Gupta wrote:
>>
>>>
This patch adds virtio-pmem Qemu device.
This device presents memory address range information to guest
which is backed by file backend type. It acts like
On Thu, 19 Jul 2018 08:48:19 -0400
Luiz Capitulino wrote:
> > It will be necessary to define specific constants for virtio-pmem
> > instead of passing errno from the host to guest.
>
> Yes, defining your own constants work. But I think the only fsync()
> error that will make sense for the
On Thu, 19 Jul 2018 13:16:35 +0100
Stefan Hajnoczi wrote:
> On Thu, Jul 19, 2018 at 01:48:13AM -0400, Pankaj Gupta wrote:
> >
> > >
> > > > This patch adds virtio-pmem Qemu device.
> > > >
> > > > This device presents memory address range information to guest
> > > > which is backed by
On Thu, 19 Jul 2018 01:48:13 -0400 (EDT)
Pankaj Gupta wrote:
> >
> > > This patch adds virtio-pmem Qemu device.
> > >
> > > This device presents memory address range information to guest
> > > which is backed by file backend type. It acts like persistent
> > > memory device for KVM
Currently, the monitor still can be started though there is no dimm event
to be monitored, which is caused by the typo of uses. In this case,
no smart event message can be logged.
This patch is used to fix this bug. When user starts the monitor with
invalid dimm event in [--dimm-event] option, the
27 matches
Mail list logo
