HELLO GOOD FRIEND.

2018-11-27 Thread Funds Advisory Services Ltd
Attention To linux-nvdimm@lists.01.org We found your email linux-nvdimm@lists.01.org in our Investment Database Hence we are contacting you for Investment Purposes. Please pardon me for this unsolicited communique. I do have the trusteeship of a PRIVATE investor with a stormy political

Re: [driver-core PATCH v6 9/9] libnvdimm: Schedule device registration on node local to the device

2018-11-27 Thread Dan Williams
On Tue, Nov 27, 2018 at 1:22 PM Bart Van Assche wrote: > > On Tue, 2018-11-27 at 12:50 -0800, Dan Williams wrote: > > Thanks Bart, so tying this back to Alex's patches, does the ordering > > problem that Alex's patches solve impact the SCSI case? I'm looking > > for something like "SCSI depends

Re: [driver-core PATCH v6 4/9] driver core: Move async_synchronize_full call

2018-11-27 Thread Alexander Duyck
On Tue, 2018-11-27 at 12:35 -0800, Dan Williams wrote: > On Tue, Nov 27, 2018 at 9:38 AM Alexander Duyck > wrote: > > > > On Mon, 2018-11-26 at 18:11 -0800, Dan Williams wrote: > > > On Thu, Nov 8, 2018 at 10:07 AM Alexander Duyck > > > wrote: > > > > > > > > Move the async_synchronize_full

Re: [driver-core PATCH v6 9/9] libnvdimm: Schedule device registration on node local to the device

2018-11-27 Thread Bart Van Assche
On Tue, 2018-11-27 at 12:50 -0800, Dan Williams wrote: > Thanks Bart, so tying this back to Alex's patches, does the ordering > problem that Alex's patches solve impact the SCSI case? I'm looking > for something like "SCSI depends on asynchronous probing and without > 'driver core: Establish clear

[PATCH 2/2] dax: Don't access a freed inode

2018-11-27 Thread Matthew Wilcox
After we drop the i_pages lock, the inode can be freed at any time. The get_unlocked_entry() code has no choice but to reacquire the lock, so it can't be used here. Create a new wait_entry_unlocked() which takes care not to acquire the lock or dereference the address_space in any way. Fixes:

[PATCH 0/2] Two DAX fixes for 4.20

2018-11-27 Thread Matthew Wilcox
These both fix race conditions in dax_lock_mapping_entry(). I've tagged them both for 4.19 backport, which will fail and I'll do the equivalent patch for it. Dan, do you want to take these through your tree? Matthew Wilcox (2): dax: Check page->mapping isn't NULL dax: Don't access a freed

[PATCH 1/2] dax: Check page->mapping isn't NULL

2018-11-27 Thread Matthew Wilcox
If we race with inode destroy, it's possible for page->mapping to be NULL before we even enter this routine, as well as after having slept waiting for the dax entry to become unlocked. Fixes: c2a7d2a11552 ("filesystem-dax: Introduce dax_lock_mapping_entry()") Cc: sta...@vger.kernel.org

Re: [driver-core PATCH v6 9/9] libnvdimm: Schedule device registration on node local to the device

2018-11-27 Thread Dan Williams
On Tue, Nov 27, 2018 at 12:33 PM Bart Van Assche wrote: > > On Tue, 2018-11-27 at 11:34 -0800, Dan Williams wrote: > > On Tue, Nov 27, 2018 at 10:04 AM Alexander Duyck > > wrote: > > > > > > On Mon, 2018-11-26 at 18:21 -0800, Dan Williams wrote: > > > > On Thu, Nov 8, 2018 at 10:07 AM Alexander

Re: [driver-core PATCH v6 4/9] driver core: Move async_synchronize_full call

2018-11-27 Thread Dan Williams
On Tue, Nov 27, 2018 at 9:38 AM Alexander Duyck wrote: > > On Mon, 2018-11-26 at 18:11 -0800, Dan Williams wrote: > > On Thu, Nov 8, 2018 at 10:07 AM Alexander Duyck > > wrote: > > > > > > Move the async_synchronize_full call out of __device_release_driver and > > > into driver_detach. > > > > >

Re: [driver-core PATCH v6 9/9] libnvdimm: Schedule device registration on node local to the device

2018-11-27 Thread Bart Van Assche
On Tue, 2018-11-27 at 11:34 -0800, Dan Williams wrote: > On Tue, Nov 27, 2018 at 10:04 AM Alexander Duyck > wrote: > > > > On Mon, 2018-11-26 at 18:21 -0800, Dan Williams wrote: > > > On Thu, Nov 8, 2018 at 10:07 AM Alexander Duyck > > > wrote: > > > > > > > > Force the device registration for

Re: [PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-27 Thread Dave Jiang
On 11/27/18 1:10 PM, Mimi Zohar wrote: > On Tue, 2018-11-27 at 11:48 -0800, Dan Williams wrote: > >> I was thinking that the generic-length *is* the format. This does not >> work for ecyptfs because it has that: >> >> payload_datalen = sizeof(struct ecryptfs_auth_tok); >> >> ...detail that

Re: [PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-27 Thread Dan Williams
On Tue, Nov 27, 2018 at 11:35 AM Mimi Zohar wrote: > > On Tue, 2018-11-27 at 11:10 -0800, Dan Williams wrote: > > On Tue, Nov 27, 2018 at 10:24 AM Mimi Zohar wrote: > > > > > > On Tue, 2018-11-27 at 09:20 -0700, Dave Jiang wrote: > > > > > > > > On 11/27/18 12:20 AM, Dan Williams wrote: > > > >

Re: [PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-27 Thread Mimi Zohar
On Tue, 2018-11-27 at 11:10 -0800, Dan Williams wrote: > On Tue, Nov 27, 2018 at 10:24 AM Mimi Zohar wrote: > > > > On Tue, 2018-11-27 at 09:20 -0700, Dave Jiang wrote: > > > > > > On 11/27/18 12:20 AM, Dan Williams wrote: > > > > On Fri, Nov 9, 2018 at 2:13 PM Dave Jiang wrote: > > > >> > > >

Re: [driver-core PATCH v6 9/9] libnvdimm: Schedule device registration on node local to the device

2018-11-27 Thread Dan Williams
On Tue, Nov 27, 2018 at 10:04 AM Alexander Duyck wrote: > > On Mon, 2018-11-26 at 18:21 -0800, Dan Williams wrote: > > On Thu, Nov 8, 2018 at 10:07 AM Alexander Duyck > > wrote: > > > > > > Force the device registration for nvdimm devices to be closer to the > > > actual > > > device. This is

Re: [PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-27 Thread Dan Williams
On Tue, Nov 27, 2018 at 10:24 AM Mimi Zohar wrote: > > On Tue, 2018-11-27 at 09:20 -0700, Dave Jiang wrote: > > > > On 11/27/18 12:20 AM, Dan Williams wrote: > > > On Fri, Nov 9, 2018 at 2:13 PM Dave Jiang wrote: > > >> > > >> Adding nvdimm key format type to encrypted keys in order to limit the

Re: dax_lock_mapping_entry was never safe

2018-11-27 Thread Matthew Wilcox
On Mon, Nov 26, 2018 at 12:36:26PM -0800, Dan Williams wrote: > On Mon, Nov 26, 2018 at 9:11 AM Jan Kara wrote: > > The code looks good. Maybe can we call this wait_entry_unlocked() to stress > > that entry is not really usable after this function returns? And comment > > before the function that

Re: [driver-core PATCH v6 6/9] driver core: Probe devices asynchronously instead of the driver

2018-11-27 Thread Dan Williams
On Tue, Nov 27, 2018 at 9:58 AM Alexander Duyck wrote: > > On Mon, 2018-11-26 at 18:48 -0800, Dan Williams wrote: > > On Thu, Nov 8, 2018 at 10:07 AM Alexander Duyck > > wrote: > > > > > > Probe devices asynchronously instead of the driver. This results in us > > > seeing the same behavior if

Re: [PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-27 Thread Mimi Zohar
On Tue, 2018-11-27 at 09:20 -0700, Dave Jiang wrote: > > On 11/27/18 12:20 AM, Dan Williams wrote: > > On Fri, Nov 9, 2018 at 2:13 PM Dave Jiang wrote: > >> > >> Adding nvdimm key format type to encrypted keys in order to limit the size > > > > s/Adding/Add an/ > > > >> of the key to 32-bytes.

Re: [driver-core PATCH v6 6/9] driver core: Probe devices asynchronously instead of the driver

2018-11-27 Thread Alexander Duyck
On Mon, 2018-11-26 at 18:48 -0800, Dan Williams wrote: > On Thu, Nov 8, 2018 at 10:07 AM Alexander Duyck > wrote: > > > > Probe devices asynchronously instead of the driver. This results in us > > seeing the same behavior if the device is registered before the driver or > > after. This way we

Re: [driver-core PATCH v6 9/9] libnvdimm: Schedule device registration on node local to the device

2018-11-27 Thread Alexander Duyck
On Mon, 2018-11-26 at 18:21 -0800, Dan Williams wrote: > On Thu, Nov 8, 2018 at 10:07 AM Alexander Duyck > wrote: > > > > Force the device registration for nvdimm devices to be closer to the actual > > device. This is achieved by using either the NUMA node ID of the region, or > > of the parent.

Re: [driver-core PATCH v6 4/9] driver core: Move async_synchronize_full call

2018-11-27 Thread Alexander Duyck
On Mon, 2018-11-26 at 18:11 -0800, Dan Williams wrote: > On Thu, Nov 8, 2018 at 10:07 AM Alexander Duyck > wrote: > > > > Move the async_synchronize_full call out of __device_release_driver and > > into driver_detach. > > > > The idea behind this is that the async_synchronize_full call will

Re: [driver-core PATCH v5 5/9] driver core: Establish clear order of operations for deferred probe and remove

2018-11-27 Thread Alexander Duyck
On Mon, 2018-11-26 at 18:35 -0800, Dan Williams wrote: > On Mon, Nov 5, 2018 at 1:12 PM Alexander Duyck > wrote: > > > > This patch adds an additional bit to the device struct named async_probe. > > This additional bit allows us to guarantee ordering between probe and > > remove operations. > >

Re: [PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-27 Thread Dave Jiang
On 11/27/18 12:20 AM, Dan Williams wrote: > On Fri, Nov 9, 2018 at 2:13 PM Dave Jiang wrote: >> >> Adding nvdimm key format type to encrypted keys in order to limit the size > > s/Adding/Add an/ > >> of the key to 32-bytes. >> >> Signed-off-by: Dave Jiang >> --- >>

Re: [PATCH 2/4] ndctl/namespace: Check for seed namespaces earlier

2018-11-27 Thread Oliver
On Mon, Nov 26, 2018 at 7:12 AM Dan Williams wrote: > > On Mon, Nov 19, 2018 at 12:11 AM Oliver O'Halloran wrote: > > > > When creating an fsdax or devdax namespace we need to verify that the > > seed namespaces exist. This patch reworks the validation so that it's > > done earlier to simplify

Re: [PATCH v2 3/3] kvm: remove redundant PageReserved() check

2018-11-27 Thread David Hildenbrand
On 14.11.18 22:51, Barret Rhoden wrote: > kvm_is_reserved_pfn() already checks PageReserved(). > > Signed-off-by: Barret Rhoden > --- > virt/kvm/kvm_main.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index