Re: [RFC v4 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-03-20 Thread Knut Omang
Hi Logan, On Wed, 2019-03-20 at 19:07 -0600, Logan Gunthorpe wrote: > Hi, > > On 2019-02-14 2:37 p.m., Brendan Higgins wrote: > > This patch set proposes KUnit, a lightweight unit testing and mocking > > framework for the Linux kernel. > > I haven't followed the entire conversation but I saw

Re: [PATCH 2/2] mm/dax: Don't enable huge dax mapping by default

2019-03-20 Thread Oliver
On Thu, Mar 21, 2019 at 7:57 AM Dan Williams wrote: > > On Wed, Mar 20, 2019 at 8:34 AM Dan Williams wrote: > > > > On Wed, Mar 20, 2019 at 1:09 AM Aneesh Kumar K.V > > wrote: > > > > > > Aneesh Kumar K.V writes: > > > > > > > Dan Williams writes: > > > > > > > >> > > > >>> Now what will be

Re: [ndctl PATCH v2 4/4] ndctl, monitor: support NVDIMM_FAMILY_HYPERV

2019-03-20 Thread Verma, Vishal L
On Wed, 2019-02-20 at 05:11 +, Dexuan Cui wrote: > Currently "ndctl monitor" fails for NVDIMM_FAMILY_HYPERV due to > "no smart support". > > NVDIMM_FAMILY_HYPERV doesn't use ND_CMD_SMART to get the health info. > Instead, it uses ND_CMD_CALL, so the checking here can't apply,and it >

Re: [ndctl PATCH v2 3/4] ndctl, lib: implement ndctl_dimm_get_cmd_family()

2019-03-20 Thread Verma, Vishal L
On Wed, 2019-02-20 at 05:11 +, Dexuan Cui wrote: > Let's export the family info so we can do some family-specific > handling in ndctl/monitor.c for Hyper-V NVDIMM. s/Let's// > > Signed-off-by: Dexuan Cui > --- > ndctl/lib/libndctl.c | 5 + > ndctl/lib/libndctl.sym | 1 + >

Re: [ndctl PATCH v2 2/4] libndctl: NVDIMM_FAMILY_HYPERV: add .smart_get_shutdown_count (Function 2)

2019-03-20 Thread Verma, Vishal L
On Wed, 2019-02-20 at 05:10 +, Dexuan Cui wrote: > With the patch, "ndctl list --dimms --health --idle" can show > "shutdown_count" now, e.g. > > { > "dev":"nmem0", > "id":"04d5-01-1701-", > "handle":0, > "phys_id":0, > "health":{ > "health_state":"ok", >

Re: [ndctl PATCH v2 1/4] libndctl: add support for NVDIMM_FAMILY_HYPERV's _DSM Function 1

2019-03-20 Thread Verma, Vishal L
Hi Dexuan, Thanks for these patches - I had a few comments below. Also on a more general note, the patches in this series don't appear to be correctly threaded. Normally, patch emails in a series are replies to the first patch (either 1/N or the cover letter), and this allows for easier review

Re: [PATCH 2/2] mm/dax: Don't enable huge dax mapping by default

2019-03-20 Thread Dan Williams
On Wed, Mar 20, 2019 at 8:34 AM Dan Williams wrote: > > On Wed, Mar 20, 2019 at 1:09 AM Aneesh Kumar K.V > wrote: > > > > Aneesh Kumar K.V writes: > > > > > Dan Williams writes: > > > > > >> > > >>> Now what will be page size used for mapping vmemmap? > > >> > > >> That's up to the

Re: [PATCH 2/2] mm/dax: Don't enable huge dax mapping by default

2019-03-20 Thread Dan Williams
On Wed, Mar 20, 2019 at 1:09 AM Aneesh Kumar K.V wrote: > > Aneesh Kumar K.V writes: > > > Dan Williams writes: > > > >> > >>> Now what will be page size used for mapping vmemmap? > >> > >> That's up to the architecture's vmemmap_populate() implementation. > >> > >>> Architectures > >>>

Re: [PATCH 2/6] security/keys/encrypted: Clean up request_trusted_key()

2019-03-20 Thread Dan Williams
On Wed, Mar 20, 2019 at 5:07 AM Mimi Zohar wrote: > > On Tue, 2019-03-19 at 22:48 -0700, Dan Williams wrote: > > On Tue, Mar 19, 2019 at 7:36 PM Mimi Zohar wrote: > > > > > > On Tue, 2019-03-19 at 17:20 -0700, Dan Williams wrote: > > > > On Tue, Mar 19, 2019 at 5:07 PM Mimi Zohar wrote: > > > >

Re: [PATCH 2/6] security/keys/encrypted: Clean up request_trusted_key()

2019-03-20 Thread Mimi Zohar
On Tue, 2019-03-19 at 22:48 -0700, Dan Williams wrote: > On Tue, Mar 19, 2019 at 7:36 PM Mimi Zohar wrote: > > > > On Tue, 2019-03-19 at 17:20 -0700, Dan Williams wrote: > > > On Tue, Mar 19, 2019 at 5:07 PM Mimi Zohar wrote: > > > > > > > > On Mon, 2019-03-18 at 23:06 -0700, Dan Williams wrote:

MAIL SYSTEM ERROR - RETURNED MAIL

2019-03-20 Thread Bounced mail
The original message was received at Wed, 20 Mar 2019 18:25:25 +0800 from lists.01.org [178.210.32.99] - The following addresses had permanent fatal errors - - Transcript of session follows - while talking to lists.01.org.: >>> MAIL From:"Bounced mail" <<< 501 "Bounced mail"

Re: [PATCH 2/2] mm/dax: Don't enable huge dax mapping by default

2019-03-20 Thread Aneesh Kumar K.V
Aneesh Kumar K.V writes: > Dan Williams writes: > >> >>> Now what will be page size used for mapping vmemmap? >> >> That's up to the architecture's vmemmap_populate() implementation. >> >>> Architectures >>> possibly will use PMD_SIZE mapping if supported for vmemmap. Now a >>> device-dax with

Re: [PATCH 2/2] mm/dax: Don't enable huge dax mapping by default

2019-03-20 Thread Aneesh Kumar K.V
Dan Williams writes: > >> Now what will be page size used for mapping vmemmap? > > That's up to the architecture's vmemmap_populate() implementation. > >> Architectures >> possibly will use PMD_SIZE mapping if supported for vmemmap. Now a >> device-dax with struct page in the device will have