Re: [PATCH v3 07/10] lib/memregion: Uplevel the pmem "region" ida to a global allocator

2019-08-26 Thread Dan Williams
On Fri, Jun 7, 2019 at 1:23 PM Matthew Wilcox wrote: > > On Fri, Jun 07, 2019 at 12:27:50PM -0700, Dan Williams wrote: > > diff --git a/lib/memregion.c b/lib/memregion.c > > new file mode 100644 > > index ..f6c6a94c7921 > > --- /dev/null > > +++ b/lib/memregion.c > > @@ -0,0 +1,15 @@

Re: create devdax with "-a 1g" failed from 5.3.0-rc1

2019-08-26 Thread Dan Williams
On Mon, Aug 26, 2019 at 8:58 AM Jeff Moyer wrote: > > Dan, we should probably fix this before 5.3 ships. Do you have any > concerns with the patch I attached? If not, I'll submit a proper one. I took a look. No concerns from me. Yeah, send a proper one and I'll get it queued for v5.3.

[PATCH v2 3/3] libnvdimm/security: Consolidate 'security' operations

2019-08-26 Thread Dan Williams
The security operations are exported from libnvdimm/security.c to libnvdimm/dimm_devs.c, and libnvdimm/security.c is optionally compiled based on the CONFIG_NVDIMM_KEYS config symbol. Rather than export the operations across compile objects, just move the __security_store() entry point to live

[PATCH v2 2/3] libnvdimm/security: Tighten scope of nvdimm->busy vs security operations

2019-08-26 Thread Dan Williams
An attempt to freeze DIMMs currently runs afoul of default blocking of all security operations in the entry to the 'store' routine for the 'security' sysfs attribute. The blanket blocking of all security operations while the DIMM is in active use in a region is too restrictive. The only security

[PATCH v2 1/3] libnvdimm/security: Introduce a 'frozen' attribute

2019-08-26 Thread Dan Williams
In the process of debugging a system with an NVDIMM that was failing to unlock it was found that the kernel is reporting 'locked' while the DIMM security interface is 'frozen'. Unfortunately the security state is tracked internally as an enum which prevents it from communicating the difference

[PATCH v2 0/3] libnvdimm/security: Enumerate the frozen state and other cleanups

2019-08-26 Thread Dan Williams
Changes since v1 [1]: - Cleanup patch1, simplify flags return in the overwrite case and consolidate frozen-state cases (Jeff) - Clarify the motivation for patch2 (Jeff) - Collect Dave's Reviewed-by [1]: https://lists.01.org/pipermail/linux-nvdimm/2019-August/023133.html --- Jeff reported a

Re: [PATCH 02/19] dax: Pass dax_dev to dax_writeback_mapping_range()

2019-08-26 Thread Dan Williams
[ add Jan ] On Mon, Aug 26, 2019 at 1:58 PM Vivek Goyal wrote: > > On Mon, Aug 26, 2019 at 04:33:26PM -0400, Vivek Goyal wrote: > > On Mon, Aug 26, 2019 at 04:53:16AM -0700, Christoph Hellwig wrote: > > > On Wed, Aug 21, 2019 at 01:57:03PM -0400, Vivek Goyal wrote: > > > > Right now

Re: [PATCH 02/19] dax: Pass dax_dev to dax_writeback_mapping_range()

2019-08-26 Thread Vivek Goyal
On Mon, Aug 26, 2019 at 04:33:26PM -0400, Vivek Goyal wrote: > On Mon, Aug 26, 2019 at 04:53:16AM -0700, Christoph Hellwig wrote: > > On Wed, Aug 21, 2019 at 01:57:03PM -0400, Vivek Goyal wrote: > > > Right now dax_writeback_mapping_range() is passed a bdev and dax_dev > > > is searched from that

Re: [PATCH 02/19] dax: Pass dax_dev to dax_writeback_mapping_range()

2019-08-26 Thread Vivek Goyal
On Mon, Aug 26, 2019 at 04:53:16AM -0700, Christoph Hellwig wrote: > On Wed, Aug 21, 2019 at 01:57:03PM -0400, Vivek Goyal wrote: > > Right now dax_writeback_mapping_range() is passed a bdev and dax_dev > > is searched from that bdev name. > > > > virtio-fs does not have a bdev. So pass in

Re: create devdax with "-a 1g" failed from 5.3.0-rc1

2019-08-26 Thread Jeff Moyer
Dan, we should probably fix this before 5.3 ships. Do you have any concerns with the patch I attached? If not, I'll submit a proper one. -Jeff Jeff Moyer writes: > Hi, Yi, > > Yi Zhang writes: > >> Hi Dan >> >> As subject, I found it failed from bellow commit[1], steps list here >> [2] and

Re: [PATCH 02/19] dax: Pass dax_dev to dax_writeback_mapping_range()

2019-08-26 Thread Christoph Hellwig
On Wed, Aug 21, 2019 at 01:57:03PM -0400, Vivek Goyal wrote: > Right now dax_writeback_mapping_range() is passed a bdev and dax_dev > is searched from that bdev name. > > virtio-fs does not have a bdev. So pass in dax_dev also to > dax_writeback_mapping_range(). If dax_dev is passed in, bdev is

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-26 Thread Christoph Hellwig
On Wed, Aug 21, 2019 at 01:57:02PM -0400, Vivek Goyal wrote: > From: Stefan Hajnoczi > > Although struct dax_device itself is not tied to a block device, some > DAX code assumes there is a block device. Make block devices optional > by allowing bdev to be NULL in commonly used DAX APIs. > >

Re: [RFC PATCH v2 02/19] fs/locks: Add Exclusive flag to user Layout lease

2019-08-26 Thread Jeff Layton
On Thu, 2019-08-15 at 07:56 +1000, Dave Chinner wrote: > On Wed, Aug 14, 2019 at 10:15:06AM -0400, Jeff Layton wrote: > > On Fri, 2019-08-09 at 15:58 -0700, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > Add an exclusive lease flag which indicates that the layout mechanism > > >