Re: [PATCH] pmem: emulating usable memory as persistent memory

On Wed, Sep 25, 2019 at 8:31 PM Taeho Hwang wrote: > > This patch checks whether the specified memory (memmap) is > userable or not. This patch prevents non-existing memory > from being emulated as persistent memory. > If non-existing memory is specified by memmap without > this patch, struct

[PATCH] pmem: emulating usable memory as persistent memory

This patch checks whether the specified memory (memmap) is userable or not. This patch prevents non-existing memory from being emulated as persistent memory. If non-existing memory is specified by memmap without this patch, struct nd_namespace_io and struct pmem_device will have invalid values.

Периодичность системы вознаграждений

Построение системы оплаты по результату KPI-Мотивация. ДОСАДНО, ЧТО ВАША КОМПАНИЯ НЕ ЗАРАБАТЫВАЕТ ХОРОШУЮ ПРИБЫЛЬ – ТОЛЬКО ПОТОМУ, ЧТО ВАШИ СОТРУДНИКИ НЕ ДОСТАТОЧНО МОТИВИРОВАНЫ и не достаточно эффективны. Тема, которую мы затрагиваем не из простых. Наша тема: Как ПЛАТИТЬ ТОЛЬКО за РЕЗУЛЬТАТ,

Re: Lease semantic proposal

On Tue, Sep 24, 2019 at 08:26:20AM +1000, Dave Chinner wrote: > On Mon, Sep 23, 2019 at 12:08:53PM -0700, Ira Weiny wrote: > > > > Since the last RFC patch set[1] much of the discussion of supporting RDMA > > with > > FS DAX has been around the semantics of the lease mechanism.[2] Within that >

Re: [PATCH V2] bnvdimm/namsepace: Don't set claim_class on error

On Wed, Sep 25, 2019 at 12:36:35PM -0700, Dan Williams wrote: > On Wed, Sep 25, 2019 at 11:49 AM wrote: > > [snip] > > > > --- > > V1->V2 > > Add space after variable declaration... > > Oh, was also hoping this would address s/bnvdimm/libnvdimm/ in the > patch subject. Yea... > >

[PATCH V3] libnvdimm/namsepace: Don't set claim_class on error

From: Ira Weiny Don't leave claim_class set to an invalid value if an error occurs in btt_claim_class(). While we are here change the return type of __holder_class_store() to be clear about the values it is returning. This was found via code inspection. Reported-by: Dan Carpenter

Re: [PATCH V2] bnvdimm/namsepace: Don't set claim_class on error

On Wed, Sep 25, 2019 at 11:49 AM wrote: > > From: Ira Weiny > > Don't leave claim_class set to an invalid value if an error occurs in > btt_claim_class(). > > While we are here change the return type of __holder_class_store() to be > clear about the values it is returning. > > This was found via

Re: [PATCH] bnvdimm/namsepace: Don't set claim_class on error

> > > > Signed-off-by: Ira Weiny > > --- > > drivers/nvdimm/namespace_devs.c | 19 +-- > > 1 file changed, 9 insertions(+), 10 deletions(-) > > One minor nit below, but otherwise it looks good to me: > Reviewed-by: Vishal Verma Thanks... > > > > > diff --git

[PATCH V2] bnvdimm/namsepace: Don't set claim_class on error

From: Ira Weiny Don't leave claim_class set to an invalid value if an error occurs in btt_claim_class(). While we are here change the return type of __holder_class_store() to be clear about the values it is returning. This was found via code inspection. Reviewed-by: Vishal Verma

Re: [PATCH] bnvdimm/namsepace: Don't set claim_class on error

On Wed, 2019-09-25 at 11:10 -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > Don't leave claim_class set to an invalid value if an error occurs in > btt_claim_class(). > > While we are here change the return type of __holder_class_store() to be > clear about the values it is returning. >

Re: [PATCH] libnvdimm/namespace: Fix a signedness bug in __holder_class_store()

On Wed, Sep 25, 2019 at 10:49:08AM -0700, 'Vishal Verma' wrote: > On Wed, 2019-09-25 at 11:25 -0600, Weiny, Ira wrote: > > > On Wed, 2019-09-25 at 14:00 +0300, Dan Carpenter wrote: > > > > The "ndns->claim_class" variable is an enum but in this case GCC will > > > > treat it as an unsigned int so

[PATCH] bnvdimm/namsepace: Don't set claim_class on error

From: Ira Weiny Don't leave claim_class set to an invalid value if an error occurs in btt_claim_class(). While we are here change the return type of __holder_class_store() to be clear about the values it is returning. This was found via code inspection. Signed-off-by: Ira Weiny ---

Re: [PATCH] libnvdimm/namespace: Fix a signedness bug in __holder_class_store()

On Wed, 2019-09-25 at 11:25 -0600, Weiny, Ira wrote: > > On Wed, 2019-09-25 at 14:00 +0300, Dan Carpenter wrote: > > > The "ndns->claim_class" variable is an enum but in this case GCC will > > > treat it as an unsigned int so the error handling is never triggered. > > > > > > Fixes: 14e494542636

Re: [PATCH] libnvdimm/namespace: Fix a signedness bug in __holder_class_store()

On Wed, 2019-09-25 at 14:00 +0300, Dan Carpenter wrote: > The "ndns->claim_class" variable is an enum but in this case GCC will > treat it as an unsigned int so the error handling is never triggered. > > Fixes: 14e494542636 ("libnvdimm, btt: BTT updates for UEFI 2.7 format") > Signed-off-by: Dan

RE: [PATCH] libnvdimm/namespace: Fix a signedness bug in __holder_class_store()

> > On Wed, 2019-09-25 at 14:00 +0300, Dan Carpenter wrote: > > The "ndns->claim_class" variable is an enum but in this case GCC will > > treat it as an unsigned int so the error handling is never triggered. > > > > Fixes: 14e494542636 ("libnvdimm, btt: BTT updates for UEFI 2.7 > > format") > >

[PATCH] libnvdimm/namespace: Fix a signedness bug in __holder_class_store()

The "ndns->claim_class" variable is an enum but in this case GCC will treat it as an unsigned int so the error handling is never triggered. Fixes: 14e494542636 ("libnvdimm, btt: BTT updates for UEFI 2.7 format") Signed-off-by: Dan Carpenter --- drivers/nvdimm/namespace_devs.c | 2 +- 1 file