On Thu, May 31, 2018 at 09:29:15AM -0700, Dan Williams wrote:
> On Thu, May 31, 2018 at 8:07 AM, Ross Zwisler
> wrote:
> > On Thu, May 31, 2018 at 11:27:33AM +0900, Yasunori Goto wrote:
> >> Hello,
> >>
> >>
> >> I would like to know about the Experimental message of Filesystem DAX.
> >> -
ging the return values
> to return a bool where if DAX is supported then return true and no DAX
> support returns false.
>
> Signed-off-by: Dave Jiang
> Signed-off-by: Ross Zwisler
Looks ok, do you want me to pull the first two patches through the xfs
tree?
Reviewed-by: Darrick J
On Fri, May 25, 2018 at 09:42:29AM -0600, Ross Zwisler wrote:
> On Thu, May 24, 2018 at 10:02:18PM -0700, Darrick J. Wong wrote:
> > On Thu, May 24, 2018 at 08:55:12PM -0600, Ross Zwisler wrote:
> > > From: "Darrick J. Wong"
> > >
> >
On Thu, May 24, 2018 at 08:55:12PM -0600, Ross Zwisler wrote:
> From: "Darrick J. Wong"
>
> Remove __bdev_dax_supported and change to bdev_dax_supported that takes a
> bdev parameter. This enables multi-device filesystems like xfs to check
> that a dax device ca
ging the return values
> to return a bool where if DAX is supported then return true and no DAX
> support returns false.
>
> Signed-off-by: Dave Jiang
> Signed-off-by: Ross Zwisler
Looks ok,
Reviewed-by: Darrick J. Wong
--D
> ---
> drivers/dax/super.c | 16
rect-I/O could starve the truncate
> path indefinitely if the lock is dropped.
>
> Cc: Dave Chinner
> Cc: "Darrick J. Wong"
> Cc: Ross Zwisler
> Reported-by: Jan Kara
> Cc: Christoph Hellwig
> Signed-off-by: Dan Williams
I should've acked this explici
On Thu, May 03, 2018 at 04:53:18PM -0700, Dan Williams wrote:
> On Tue, Apr 24, 2018 at 4:33 PM, Dan Williams
> wrote:
> > Changes since v8 [1]:
> > * Rebase on v4.17-rc2
> >
> > * Fix get_user_pages_fast() for ZONE_DEVICE pages to revalidate the pte,
> > pmd, pud after taking references (Jan)
[haaa, I finally found time to read more of these]
On Sat, Mar 10, 2018 at 10:17:47AM -0800, Andiry Xu wrote:
> From: Andiry Xu
>
> These routines are incomplete and currently only support reserved inodes,
> whose addresses are fixed. This is necessary for fill_super to work.
> File/dir operatio
On Tue, Apr 17, 2018 at 11:40:00AM -0600, Andreas Dilger wrote:
> On Apr 17, 2018, at 10:57 AM, Darrick J. Wong wrote:
> >
> > On Tue, Apr 17, 2018 at 09:53:47AM -0700, Dan Williams wrote:
> >> On Tue, Apr 17, 2018 at 9:10 AM, Christoph Hellwig
> >> wrote:
&g
On Tue, Apr 17, 2018 at 09:53:47AM -0700, Dan Williams wrote:
> On Tue, Apr 17, 2018 at 9:10 AM, Christoph Hellwig wrote:
> > On Tue, Apr 17, 2018 at 10:40:59PM +0800, Xiong Zhou wrote:
> >> We got these in v4.17-rc1:
> >> 6e2608d xfs, dax: introduce xfs_dax_aops
> >> fb094c9 ext2, dax: introduce
ll to
> xfs_break_layouts().
>
> Cc: "Darrick J. Wong"
> Cc: Ross Zwisler
> Cc: Dave Chinner
> Suggested-by: Christoph Hellwig
> Signed-off-by: Dan Williams
Looks ok,
Reviewed-by: Darrick J. Wong
--D
> ---
> fs/xfs/xfs_file.c |5 +
> fs/xf
On Mon, Mar 19, 2018 at 10:57:55AM -0700, Dan Williams wrote:
> On Mon, Mar 19, 2018 at 10:33 AM, Darrick J. Wong
> wrote:
> > On Thu, Mar 15, 2018 at 08:52:29AM -0700, Dan Williams wrote:
> >> In preparation for adding coordination between truncate operations and
> &
ent map. While BREAK_WRITE breaks can be satisfied
> be recalling FL_LAYOUT leases, BREAK_TRUNCATE breaks additionally
> require waiting for busy dax-pages to go idle.
>
> Cc: "Darrick J. Wong"
> Cc: Ross Zwisler
> Reported-by: Dave Chinner
> Reported-by: Chr
dapted to take the appropriate mmap locks
too -- definitely the exclusive mmap lock for the destination file
because we anticipate punching out blocks. I'm not sure about the
source file; I think taking the shared mmap lock is fine for that?
--D
>
> Cc: "Darrick J. Wong"
> Cc
On Thu, Mar 15, 2018 at 11:17:54PM -0700, Andiry Xu wrote:
> On Thu, Mar 15, 2018 at 7:59 PM, Theodore Y. Ts'o wrote:
> > On Thu, Mar 15, 2018 at 09:38:29PM +0100, Arnd Bergmann wrote:
> >>
> >> You could also have a resolution of less than a nanosecond. Note
> >> that today, the file time stamps
On Sat, Mar 10, 2018 at 10:17:45AM -0800, Andiry Xu wrote:
> From: Andiry Xu
>
> inode.h defines the non-volatile and volatile NOVA inode data structures.
>
> The non-volatile NOVA inode (nova_inode) is aligned to 128 bytes and contains
> file/directory metadata information. The most important f
On Sat, Mar 10, 2018 at 10:17:44AM -0800, Andiry Xu wrote:
> From: Andiry Xu
>
> This header file defines NOVA persistent and volatile superblock
> data structures.
>
> It also defines NOVA block layout:
>
> Page 0: Superblock
> Page 1: Reserved inodes
> Page 2 - 15: Reserved
> Page 16 - 31: In
needs to be defined, non-zero, if either DAX facility is
> enabled.
>
> Cc: "Theodore Ts'o"
> Cc: Andreas Dilger
> Cc: Alexander Viro
> Cc: "Darrick J. Wong"
> Cc: linux-...@vger.kernel.org
> Cc: Matthew Wilcox
> Cc: Ross Zwisler
> Cc:
> Fi
On Thu, Mar 01, 2018 at 07:54:16PM -0800, Dan Williams wrote:
> In preparation for fixing the broken definition of S_DAX in the
> CONFIG_FS_DAX=n + CONFIG_DEV_DAX=y case, convert all IS_DAX() usages to
> use explicit tests for FSDAX since DAX is ambiguous.
>
> Cc: "Darrick J
needs to be defined, non-zero, if either DAX facility is
> enabled.
>
> Cc: "Theodore Ts'o"
> Cc: Andreas Dilger
> Cc: Alexander Viro
> Cc: "Darrick J. Wong"
> Cc: linux-...@vger.kernel.org
> Cc: Matthew Wilcox
> Cc: Ross Zwisler
> Cc:
> Fi
On Tue, Feb 27, 2018 at 09:46:54AM -0700, Dave Jiang wrote:
>
>
> On 02/20/2018 04:23 PM, Darrick J. Wong wrote:
> > On Wed, Feb 21, 2018 at 10:15:24AM +1100, Dave Chinner wrote:
> >> On Tue, Feb 20, 2018 at 03:01:09PM -0800, Darrick J. Wong wrote:
> >>> On S
On Wed, Feb 21, 2018 at 10:15:24AM +1100, Dave Chinner wrote:
> On Tue, Feb 20, 2018 at 03:01:09PM -0800, Darrick J. Wong wrote:
> > On Sun, Feb 18, 2018 at 11:23:17AM +1100, Dave Chinner wrote:
> > > On Fri, Feb 16, 2018 at 09:22:47AM -0800, Darrick J. Wong wrote:
> > >
On Sun, Feb 18, 2018 at 11:23:17AM +1100, Dave Chinner wrote:
> On Fri, Feb 16, 2018 at 09:22:47AM -0800, Darrick J. Wong wrote:
> > On Fri, Feb 16, 2018 at 10:04:26AM -0700, Dave Jiang wrote:
> > > In a situation where the rt_dev is DAX and data_dev is not DAX, if the
> &g
@@ -961,8 +961,7 @@ static int ext2_fill_super(struct super_block *sb, void
> *data, int silent)
> blocksize = BLOCK_SIZE << le32_to_cpu(sbi->s_es->s_log_block_size);
>
> if (sbi->s_mount_opt & EXT2_MOUNT_DAX) {
> - err = bdev_dax_support
On Fri, Feb 16, 2018 at 10:04:26AM -0700, Dave Jiang wrote:
> In a situation where the rt_dev is DAX and data_dev is not DAX, if the user
> requests to remove the realtime flag via ioctl we can no longer support DAX
> for that file. Dynamic changing of S_DAX on the inode is not supported due
> to v
On Thu, Feb 15, 2018 at 10:58:54AM -0700, Dave Jiang wrote:
> On 02/15/2018 10:52 AM, Christoph Hellwig wrote:
> >> /**
> >> - * __bdev_dax_supported() - Check if the device supports dax for
> >> filesystem
> >> + * bdev_dax_supported() - Check if the device supports dax for filesystem
> >> * @
On Tue, Feb 06, 2018 at 03:32:00PM -0700, Dave Jiang wrote:
> On 02/01/2018 05:43 PM, Darrick J. Wong wrote:
> > On Fri, Feb 02, 2018 at 10:44:13AM +1100, Dave Chinner wrote:
> >> On Thu, Feb 01, 2018 at 01:33:05PM -0700, Dave Jiang wrote:
> >>> When using realtime
On Fri, Feb 02, 2018 at 10:44:13AM +1100, Dave Chinner wrote:
> On Thu, Feb 01, 2018 at 01:33:05PM -0700, Dave Jiang wrote:
> > When using realtime device (rtdev) with xfs where the data device is not
> > DAX capable, two issues arise. One is when data device is not DAX but the
> > realtime device
On Thu, Feb 01, 2018 at 05:08:36PM -0700, Dave Jiang wrote:
>
> On 02/01/2018 04:28 PM, Darrick J. Wong wrote:
> >> [PATCH 2 2/2] xfs: fix rt_dev usage for DAX
> >
> > "[PATCH v2 2/2]" to distinguish the version number from the patch number
> > more e
ce dax status checking for filesystems
Refactor __bdev_dax_supported into a sb_dax_supported helper for
single-bdev filesystems and a regular bdev_dax_supported that takes a
bdev parameter. This enables multi-device filesystems like xfs to check
that a dax device can work for the part
On Thu, Feb 01, 2018 at 01:32:59PM -0700, Dave Jiang wrote:
> This is in preparation to support DAX for realtime device on XFS.
> bdev_dax_supported() will be taking a block_device as input instead of
> a superblock. The only place a super_block is used in this function is
> providing the id for de
On Wed, Jan 31, 2018 at 04:45:36PM -0800, Andiry Xu wrote:
> PMEM/DAX should allow for significant improvements in file system
> performance and enable new programming models that allow direct,
> efficient access to PMEM from userspace. Achieving these gains in
> existing file systems built for bl
On Wed, Jan 31, 2018 at 05:13:20PM -0700, Dave Jiang wrote:
> When using realtime device (rtdev) with xfs where the data device is not
> DAX capable, two issues arise. One is when data device is not DAX but the
> realtime device is DAX capable, we currently disable DAX.
> After passing this check,
On Fri, Jan 12, 2018 at 11:15:00PM +, Kani, Toshi wrote:
> On Sat, 2018-01-13 at 09:27 +1100, Dave Chinner wrote:
> > On Fri, Jan 12, 2018 at 09:38:22PM +, Kani, Toshi wrote:
> > > On Sat, 2018-01-13 at 08:19 +1100, Dave Chinner wrote:
> > > :
> > > > IOWs, what you are seeing is trying to
gers incorrect page cache assumptions and warnings.
>
> Cc: "Darrick J. Wong"
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Dan Williams
> ---
> fs/xfs/xfs_aops.c |2 ++
> fs/xfs/xfs_aops.h |1 +
> fs/xfs/xfs_iops.c |5 -
> 3 files ch
m to go idle
> as is typically the case of iov_iter_get_pages.
>
> dax_flush_dma relies on the fs-provided wait_atomic_t_action_f
> (xfs_wait_dax_page) to handle evaluating the page reference count and
> dropping locks when waiting.
>
> Cc: Jan Kara
> Cc: Dave Chinner
>
> Suggested-by: Dave Chinner
Looks ok,
Reviewed-by: Darrick J. Wong
> ---
> configure.ac | 1 +
> include/builddefs.in | 1 +
> include/linux.h | 8
> io/Makefile | 4
> io/io.h | 1 +
> io/mmap.c
On Thu, Dec 21, 2017 at 10:41:10AM -0700, Ross Zwisler wrote:
> On Thu, Dec 21, 2017 at 09:09:08AM -0800, Darrick J. Wong wrote:
> > On Tue, Dec 05, 2017 at 04:56:50PM -0700, Ross Zwisler wrote:
>
> > > @@ -195,6 +200,13 @@ mmap_f(
> > > case &#x
EVICE_TARGET_MSG)))
> + return ret;
> +
> + if (!dm_task_set_name(dmt, device))
> + goto out;
> +
> + if (!dm_task_set_sector(dmt, 0))
> + goto out;
> +
> + if (!dm_task_set_message(dmt, message))
> + got
On Tue, Dec 05, 2017 at 04:56:50PM -0700, Ross Zwisler wrote:
> Add support for a new -S flag to xfs_io's mmap command. This opens the
> mapping with the (MAP_SYNC | MAP_SHARED_VALIDATE) flags instead of the
> standard MAP_SHARED flag.
>
> Signed-off-by: Ross Zwisler
> Suggested-by: Dave Chinner
s many as 19 characters
> > > (9223372036854775807 is the max value). The format we're using for bbuf
> > > is
> > > "[%lld..%lld]:" which has 2 signed long longs plus 6 other characters
> > > "[..]:\0", which means it's possib
; which has 2 signed long longs plus 6 other characters
> "[..]:\0", which means it's possible we'll print up to 44 characters,
> overflowing our 32 char buffer.
>
> Fix this by bumping all the buffer sizes in dump_map_verbose() to 64
> characters.
>
> Sig
On Fri, Nov 17, 2017 at 01:25:24PM -0700, Ross Zwisler wrote:
> Add a new 'log_writes' command to xfs_io so that we can add dm-log-writes
> log marks via the external 'dmsetup' executable. It's helpful to allow
> users of xfs_io to adds these marks from within xfs_io instead of waiting
> until aft
On Fri, Nov 17, 2017 at 01:25:23PM -0700, Ross Zwisler wrote:
> Add support for a new -S flag to xfs_io's mmap command. This opens the
> mapping with the (MAP_SYNC | MAP_SHARED_VALIDATE) flags instead of the
> standard MAP_SHARED flag.
>
> Signed-off-by: Ross Zwisler
> Suggested-by: Dave Chinner
s for
> applications not using userspace flushing. And applications using
> userspace flushing can avoid calling fsync(2) and thus avoid the
> performance overhead.
>
> [JK: Added VM_SYNC flag handling]
>
> Reviewed-by: Ross Zwisler
> Signed-off-by: Christoph Hellwig
> S
Kara
Looks ok,
Reviewed-by: Darrick J. Wong
> ---
> fs/xfs/xfs_file.c | 29 -
> fs/xfs/xfs_trace.h | 2 --
> 2 files changed, 4 insertions(+), 27 deletions(-)
>
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 7c6b8def6eed..4496b4567
lements the MAP_SYNC policy. This
> otherwise should not change behavior, it just makes it easier to change
> behavior in the future.
Yes, this was what I was looking for on my last read-through. :)
> Cc: Jan Kara
> Cc: Christoph Hellwig
> Cc: Darrick J. Wong
> Cc: Ross Zwisl
On Tue, Sep 26, 2017 at 11:30:57AM -0600, Ross Zwisler wrote:
> On Tue, Sep 26, 2017 at 04:37:43PM +0200, Christoph Hellwig wrote:
> > On Tue, Sep 26, 2017 at 09:09:57PM +1000, Dave Chinner wrote:
> > > Well, quite frankly, I never wanted the mount option for XFS. It was
> > > supposed to be for in
On Tue, Sep 26, 2017 at 11:16:38AM -0600, Ross Zwisler wrote:
> On Tue, Sep 26, 2017 at 08:36:50AM +0200, Christoph Hellwig wrote:
> > On Mon, Sep 25, 2017 at 05:13:59PM -0600, Ross Zwisler wrote:
> > > Currently only the blocksize is checked, but we should really be calling
> > > bdev_dax_supporte
On Wed, Aug 30, 2017 at 12:43:58PM -0700, Dan Williams wrote:
> The ->iomap_begin() operation is a hot path, so cache the
> fs_dax_get_by_host() result at mount time to avoid the incurring the
> hash lookup overhead on a per-i/o basis.
>
> Cc: "Darrick J. Wong"
>
ax_device lookup from iomap-operation time to
> fs-mount time.
>
> Cc: Jan Kara
> Cc: Christoph Hellwig
> Signed-off-by: Dan Williams
Reviewed-by: Darrick J. Wong
> ---
> drivers/dax/super.c | 10 ++
> include/linux/dax.h |6 ++
> 2 files changed, 16
On Sun, Aug 27, 2017 at 08:48:40PM -0700, Dan Williams wrote:
> The ->iomap_begin() operation is a hot path, so cache the
> fs_dax_get_by_host() result at mount time to avoid the incurring the
> hash lookup overhead on a per-i/o basis.
>
> Cc: "Darrick J. Wong"
>
d I'm merely ignorant) but I was wondering why the daxdev isn't
simply attached to the block_device? Is it not a 1:1 mapping?
--D
>
> Cc: "Darrick J. Wong"
> Reported-by: Christoph Hellwig
> Signed-off-by: Dan Williams
> ---
> fs/xfs/xfs_aops.c | 24 +++
On Sun, Aug 13, 2017 at 01:31:45PM -0700, Dan Williams wrote:
> On Sun, Aug 13, 2017 at 2:24 AM, Christoph Hellwig wrote:
> > On Sat, Aug 12, 2017 at 12:19:50PM -0700, Dan Williams wrote:
> >> The application does not need to know the storage address, it needs to
> >> know that the storage address
On Sat, Aug 12, 2017 at 10:30:34AM +1000, Dave Chinner wrote:
> On Fri, Aug 11, 2017 at 04:42:18PM -0700, Dan Williams wrote:
> > On Fri, Aug 11, 2017 at 4:27 PM, Dave Chinner wrote:
> > > On Thu, Aug 10, 2017 at 11:39:28PM -0700, Dan Williams wrote:
> > >> >From falloc.h:
> > >>
> > >> FALLOC
On Sat, Aug 05, 2017 at 09:46:15AM +1000, Dave Chinner wrote:
> On Fri, Aug 04, 2017 at 01:33:12PM -0700, Darrick J. Wong wrote:
> > On Thu, Aug 03, 2017 at 07:28:30PM -0700, Dan Williams wrote:
> > > Add an on-disk inode flag to record the state of the S_IOMAP_IMMUTABLE
> &g
On Fri, Aug 04, 2017 at 01:47:32PM -0700, Dan Williams wrote:
> On Fri, Aug 4, 2017 at 1:14 PM, Darrick J. Wong
> wrote:
> > On Thu, Aug 03, 2017 at 07:28:35PM -0700, Dan Williams wrote:
> >> After validating the state of the file as not having holes, shared
> >> e
ch.
>
> Cc: Jan Kara
> Cc: Jeff Moyer
> Cc: Christoph Hellwig
> Cc: Ross Zwisler
> Suggested-by: Dave Chinner
> Suggested-by: "Darrick J. Wong"
> Signed-off-by: Dan Williams
> ---
> fs/xfs/libxfs/xfs_format.h |5 -
> fs/xfs/xfs_inod
AP_IMMUTABLE to be set on the vfs inode.
>
> Cc: Jan Kara
> Cc: Jeff Moyer
> Cc: Christoph Hellwig
> Cc: Ross Zwisler
> Suggested-by: Dave Chinner
> Suggested-by: "Darrick J. Wong"
> Signed-off-by: Dan Williams
> ---
> fs/xfs/xfs_bmap_util.c | 32 ++
ara
> Cc: Jeff Moyer
> Cc: Christoph Hellwig
> Cc: Ross Zwisler
> Cc: Alexander Viro
> Cc: "Darrick J. Wong"
> Suggested-by: Dave Chinner
> Signed-off-by: Dan Williams
> ---
> fs/open.c | 17 +++
c_file_space and xfs_free_file_space when the flag is set.
>
> Cc: Jan Kara
> Cc: Jeff Moyer
> Cc: Christoph Hellwig
> Cc: Ross Zwisler
> Cc: Alexander Viro
> Suggested-by: Dave Chinner
> Suggested-by: "Darrick J. Wong"
> Signed-off-by: Dan Williams
>
e
> extents and fill all holes in the file. It then holds XFS_ILOCK_EXCL
> while it validates the file is in the proper state and sets
> S_IOMAP_IMMUTABLE.
>
> Cc: Jan Kara
> Cc: Jeff Moyer
> Cc: Christoph Hellwig
> Cc: Ross Zwisler
> Cc: Alexander Viro
> Su
On Mon, Jul 31, 2017 at 01:42:13PM -0400, Colin Walters wrote:
>
>
> On Mon, Jul 31, 2017, at 12:32 PM, Colin Walters wrote:
> > On Mon, Jul 31, 2017, at 12:29 PM, Dan Williams wrote:
> > >
> > > How is S_CONTENTS_IMMUTABLE different than S_IMMUTABLE?
> >
> > We still want the ability to make h
IMMUTABLE since
> fallocate(2) is the path to toggle this flag.
>
> Cc: Jan Kara
> Cc: Jeff Moyer
> Cc: Christoph Hellwig
> Cc: Ross Zwisler
> Cc: Alexander Viro
> Suggested-by: Dave Chinner
> Suggested-by: "Darrick J. Wong"
> Signed-off-by: Dan Williams
>
fill all holes in the file, or otherwise extend the file
> size in the same operation that sets S_IOMAP_IMMUTABLE.
>
> Cc: Jan Kara
> Cc: Jeff Moyer
> Cc: Christoph Hellwig
> Cc: Ross Zwisler
> Cc: Alexander Viro
> Suggested-by: Dave Chinner
> Sugg
Cc: Alexander Viro
> Suggested-by: Dave Chinner
> Suggested-by: "Darrick J. Wong"
> Signed-off-by: Dan Williams
> ---
> fs/attr.c | 10 ++
> fs/namei.c |3 ++-
> fs/open.c |6 ++
> fs/read_write.c|3 +
On Thu, Jun 22, 2017 at 09:37:14AM +1000, Dave Chinner wrote:
> On Mon, Jun 19, 2017 at 10:22:14PM -0700, Darrick J. Wong wrote:
> > [add linux-xfs to the fray]
> >
> > On Fri, Jun 16, 2017 at 06:15:35PM -0700, Dan Williams wrote:
> > > + spin_lock(&dax_lock);
&g
On Tue, Jun 20, 2017 at 09:42:55AM -0600, Ross Zwisler wrote:
> On Mon, Jun 19, 2017 at 10:22:14PM -0700, Darrick J. Wong wrote:
> <>
> > Fourth, the VFS entry points for things like read, write, truncate,
> > utimes, fallocate, etc. all just bail out if S_IOMAP_FROZEN
On Wed, Jun 21, 2017 at 09:53:46AM +1000, Dave Chinner wrote:
> On Tue, Jun 20, 2017 at 09:17:36AM -0700, Dan Williams wrote:
> > On Tue, Jun 20, 2017 at 1:49 AM, Christoph Hellwig wrote:
> > > [stripped giant fullquotes]
> > >
> > > On Mon, Jun 19, 2017 at 10:53:12PM -0700, Andy Lutomirski wrote:
[add linux-xfs to the fray]
On Fri, Jun 16, 2017 at 06:15:35PM -0700, Dan Williams wrote:
> To date, the full promise of byte-addressable access to persistent
> memory has only been half realized via the filesystem-dax interface. The
> current filesystem-dax mechanism allows an application to cons
On Sun, Jun 18, 2017 at 09:51:52AM +0200, Christoph Hellwig wrote:
> On Sat, Jun 17, 2017 at 05:29:23AM -0700, Dan Williams wrote:
> > On Fri, Jun 16, 2017 at 10:22 PM, Christoph Hellwig wrote:
> > > On Fri, Jun 16, 2017 at 06:15:29PM -0700, Dan Williams wrote:
> > >> Refactor the core of generic_
On Thu, May 18, 2017 at 08:26:54AM +0200, Christoph Hellwig wrote:
> Directly use the v1 intepretation of uuid_t instead.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Darrick J. Wong
--D
> ---
> fs/xfs/uuid.c | 25 -
> fs/xfs/uuid.h
On Thu, May 18, 2017 at 08:26:44AM +0200, Christoph Hellwig wrote:
> Use the generic Linux definition to implement our UUID type, this will
> allow using more generic infrastructure in the future.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Darrick J. Wong
--D
> ---
&
On Thu, May 18, 2017 at 08:26:43AM +0200, Christoph Hellwig wrote:
> From: Amir Goldstein
>
> uuid_t definition is about to change.
>
> Signed-off-by: Amir Goldstein
> Signed-off-by: Christoph Hellwig
Reviewed-by: Darrick J. Wong
> ---
> fs/xfs/xfs_inode_item.
ined for
> now, but will hopefully go away soon. The exception to that are the _cmp
> helpers that will be replaced by better primites ASAP and thus don't
I misread that as "better primates ASAP" :)
(Assuming you meant 'primitives'?)
Other than that,
Reviewed-by: Dar
> To: "Darrick J. Wong" , x...@oss.sgi.com
[list moved; cc'ing linux-...@vger.kernel.org]
On Wed, Feb 08, 2017 at 12:11:56PM -0700, Ross Zwisler wrote:
> I hit the following WARN_ON_ONCE() during generic/270 with xfs (passed through
> kasan_symbolize.py):
>
> r
On Wed, Jan 18, 2017 at 03:39:17PM -0500, Jeff Moyer wrote:
> Jan Kara writes:
>
> > On Tue 17-01-17 15:14:21, Vishal Verma wrote:
> >> Your note on the online repair does raise another tangentially related
> >> topic. Currently, if there are badblocks, writes via the bio submission
> >> path wil
On Fri, Jan 13, 2017 at 05:49:10PM -0700, Vishal Verma wrote:
> On 01/14, Slava Dubeyko wrote:
> >
> > Original Message
> > Subject: [LSF/MM TOPIC] Badblocks checking/representation in filesystems
> > Sent: Jan 13, 2017 1:40 PM
> > From: "Verma, Vishal L"
> > To: lsf...@lists.linux-foun
On Mon, Jan 16, 2017 at 03:00:41PM -0500, Jeff Moyer wrote:
> "Darrick J. Wong" writes:
>
> >> - Whenever you mount a filesystem with DAX, it spits out a message that
> >> says
> >> "DAX enabled. Warning: EXPERIMENTAL, use at your own risk"
On Fri, Jan 13, 2017 at 05:20:08PM -0700, Ross Zwisler wrote:
> This past year has seen a lot of new DAX development. We have added support
> for fsync/msync, moved to the new iomap I/O data structure, introduced radix
> tree based locking, re-enabled PMD support (twice!), and have fixed a bunch o
On Mon, Dec 19, 2016 at 05:18:40PM -0800, Dan Williams wrote:
> On Mon, Dec 19, 2016 at 5:09 PM, Darrick J. Wong
> wrote:
> > On Mon, Dec 19, 2016 at 02:11:49PM -0700, Ross Zwisler wrote:
> >> On Fri, Sep 16, 2016 at 03:54:05PM +1000, Nicholas Piggin wrote:
> >>
On Mon, Dec 19, 2016 at 02:11:49PM -0700, Ross Zwisler wrote:
> On Fri, Sep 16, 2016 at 03:54:05PM +1000, Nicholas Piggin wrote:
> <>
> > Definitely the first step would be your simple preallocated per
> > inode approach until it is shown to be insufficient.
>
> Reviving this thread a few months l
On Thu, Sep 29, 2016 at 09:03:43PM -0600, Ross Zwisler wrote:
> On Fri, Sep 30, 2016 at 09:43:45AM +1000, Dave Chinner wrote:
> > Finally: none of the patches in your tree have reviewed-by tags.
> > That says to me that none of this code has been reviewed yet.
> > Reviewed-by tags are non-negotiabl
On Wed, Jun 22, 2016 at 05:27:15PM +0200, Christoph Hellwig wrote:
> So far the DAX code overloaded the direct I/O code path. There is very little
> in common between the two, and untangling them allows to clean up both
> variants.
>
> As a Ń•ide effect we also get separate trace points for both
On Thu, Sep 15, 2016 at 10:01:03AM -0700, Dan Williams wrote:
> On Thu, Sep 15, 2016 at 1:26 AM, Christoph Hellwig wrote:
> > On Wed, Sep 14, 2016 at 11:54:38PM -0700, Dan Williams wrote:
> >> The DAX property, page cache bypass, of a VMA is only detectable via the
> >> vma_is_dax() helper to chec
On Mon, Sep 12, 2016 at 11:40:35AM +1000, Dave Chinner wrote:
> On Thu, Sep 08, 2016 at 04:56:36PM -0600, Ross Zwisler wrote:
> > On Wed, Sep 07, 2016 at 09:32:36PM -0700, Dan Williams wrote:
> > > My understanding is that it is looking for the VM_MIXEDMAP flag which
> > > is already ambiguous for
On Thu, Sep 15, 2016 at 07:12:29AM +0200, Christoph Hellwig wrote:
> On Wed, Sep 14, 2016 at 11:07:59AM -0600, Ross Zwisler wrote:
> > I'll bite - why do you think adding a space before labels is a "fairly
> > horrible style"? Adding them gives a tangible benefit for unified diffs and
> > patches
On Wed, Sep 14, 2016 at 12:01:29PM +0200, Christoph Hellwig wrote:
> Another users of buffer_heads bytes the dust.
Yay!
Babbling below. :)
> Signed-off-by: Christoph Hellwig
> ---
> fs/xfs/xfs_file.c | 61
> +++---
> fs/xfs/xfs_iomap.c | 11 +++
On Tue, Aug 30, 2016 at 09:25:45AM -0700, Dan Williams wrote:
> On Tue, Aug 30, 2016 at 7:53 AM, Dan Williams
> wrote:
> > On Mon, Aug 29, 2016 at 7:37 PM, Darrick J. Wong
> > wrote:
> >> On Mon, Aug 29, 2016 at 06:50:05PM -0700, Dan Williams wrote:
> >>>
On Mon, Aug 29, 2016 at 06:50:05PM -0700, Dan Williams wrote:
> [ Adding Darrick on the off chance that this triggers an "aha, of
> course it does!" ]
Aha! Of course it does!!! :)
> Darrick these corruption tests you added to xfstests last year all
> fail the same way with DAX enabled. They spe
On Mon, Jun 20, 2016 at 12:48:27PM -0600, Vishal Verma wrote:
> On 06/16, Vishal Verma wrote:
> > These are early/RFC patches to add badblock support in xfs.
> >
> > Patch 1 should be relatively straightforward - it adds a notifier chain
> > to badblocks that filesystems can register with.
> >
>
On Fri, Jun 17, 2016 at 01:26:47PM -0600, Vishal Verma wrote:
> On 06/16, Darrick J. Wong wrote:
> > On Thu, Jun 16, 2016 at 07:03:39PM -0600, Vishal Verma wrote:
> > > RFC/WIP commit.
> > >
> > > This adds the foollowing:
> > > 1. In xfs_mountfs(),
a new 'badblocks' bit to both
the file extent records and the rmap records to signify that something's
wrong with the extent. I'll let him write about that.
> 2. Before doing file IO, refer the rmap/badblocks to error out early if
> the IO will attempt wo read a bad sector
>
On Thu, Jun 16, 2016 at 07:03:37PM -0600, Vishal Verma wrote:
> These are early/RFC patches to add badblock support in xfs.
>
> Patch 1 should be relatively straightforward - it adds a notifier chain
> to badblocks that filesystems can register with.
>
> Patch 2 is the beginnings of xfs support.
101 - 194 of 194 matches
Mail list logo
